kadet1090 / nucleus

Component/Subscription/SubscriptionManager.php

Doc Comments +4 added lines, -1 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * Sends subscription removal request presence to server.
      *
-     * @param Jid|string $jid
+     * @param Jid $jid
      * @return \React\Promise\ExtendedPromiseInterface
      */
     public function unsubscribe(Jid $jid)
@@ -74,6 +74,9 @@ 
         return $this->_client->send($this->presence('unsubscribed', $jid));
     }
 
+    /**
+     * @param string $type
+     */
     private function presence($type, $jid)
     {
         $jid = $jid instanceof Jid ? $jid : new Jid($jid);

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
     private function handleSubscriptionRequest(Presence $presence)
     {
-        $this->emit('request', [ $presence ]);
+        $this->emit('request', [$presence]);
     }
 
     /**

Component/TlsEnabler.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use Kadet\Xmpp\Stream\Features;
 use Kadet\Xmpp\Utils\filter as with;
 use Kadet\Xmpp\Xml\XmlElement;
-use Kadet\Xmpp\XmppClient;
 
 class TlsEnabler extends Component
 {

Spacing +2 added lines, -2 removed lines

@@ -26,11 +26,11 @@
 {
     public function init()
     {
-        $this->_client->on('features', function (Features $features) {
+        $this->_client->on('features', function(Features $features) {
             return !$this->startTls($features);
         }, null, 10);
 
-        $this->_client->on('element', function (XmlElement $element) {
+        $this->_client->on('element', function(XmlElement $element) {
             return $this->handleTls($element);
         }, with\element\xmlns(Features\StartTls::XMLNS));
     }

Stanza/Presence.php

Spacing +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function setShow(string $show = 'available')
     {
-        if(!in_array($show, self::POSSIBLE_SHOW)) {
+        if (!in_array($show, self::POSSIBLE_SHOW)) {
             throw new InvalidArgumentException(format('$show must be one of: {possible}. {show} given.', [
                 'possible' => implode(',', self::POSSIBLE_SHOW),
                 'show'     => $show
@@ -77,7 +77,7 @@ 
         }
 
         $predicate = filter\element('show', 'jabber:client');
-        if(in_array($show, ['available', 'unavailable'])) {
+        if (in_array($show, ['available', 'unavailable'])) {
             $this->remove($predicate);
             $this->type = $show;
             return;
@@ -99,7 +99,7 @@ 
     public function setStatus(string $status = null)
     {
         $predicate = filter\element('status', 'jabber:client');
-        if($status === null) {
+        if ($status === null) {
             $this->remove($predicate);
             return;
         }
@@ -115,7 +115,7 @@ 
     public function setPriority(int $priority = null)
     {
         $predicate = filter\element('status', 'jabber:client');
-        if(!$priority) {
+        if (!$priority) {
             $this->remove($predicate);
         }
 

Utils/filter.php

Spacing +19 added lines, -19 removed lines

@@ -34,7 +34,7 @@ 
  */
 function equals($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument == $value;
     };
 }
@@ -55,7 +55,7 @@ 
  */
 function same($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument === $value;
     };
 }
@@ -77,7 +77,7 @@ 
  */
 function instance($expected) : \Closure
 {
-    return function ($object) use ($expected) {
+    return function($object) use ($expected) {
         return $expected instanceof \Closure ? $expected(get_class($object)) : $object instanceof $expected;
     };
 }
@@ -103,7 +103,7 @@ 
  */
 function matches($regex, ...$options) : \Closure
 {
-    return function ($value) use ($regex, $options) {
+    return function($value) use ($regex, $options) {
         return preg_match($regex, $value, $null, ...$options) > 0;
     };
 }
@@ -122,7 +122,7 @@ 
  * @return \Closure
  */
 function in(...$options) {
-    return function ($value) use ($options) {
+    return function($value) use ($options) {
         return in_array($value, $options);
     };
 }
@@ -142,10 +142,10 @@ 
  */
 function contains($value)
 {
-    if($value instanceof \Closure) {
-        return function (array $array) use ($value) {
+    if ($value instanceof \Closure) {
+        return function(array $array) use ($value) {
             foreach ($array as $item) {
-                if($value($item)) {
+                if ($value($item)) {
                     return true;
                 }
             }
@@ -154,7 +154,7 @@ 
         };
     }
 
-    return function (array $array) use ($value) {
+    return function(array $array) use ($value) {
         return array_search($value, $array) !== false;
     };
 }
@@ -174,7 +174,7 @@ 
  */
 function has($key)
 {
-    return function (array $array) use ($key) {
+    return function(array $array) use ($key) {
         return (contains($key))(array_keys($array));
     };
 }
@@ -248,7 +248,7 @@ 
  */
 function all(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if (!$function(...$args)) {
                 return false;
@@ -277,7 +277,7 @@ 
  */
 function any(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if ($function(...$args)) {
                 return true;
@@ -322,7 +322,7 @@ 
 function not($predicate) : \Closure
 {
     $predicate = predicate($predicate);
-    return function (...$arguments) use ($predicate) {
+    return function(...$arguments) use ($predicate) {
         return !$predicate(...$arguments);
     };
 }
@@ -350,13 +350,13 @@ 
  */
 function argument(int $offset, callable $predicate, $length = true) : \Closure
 {
-    if($length === true) {
+    if ($length === true) {
         $length = 1;
-    } elseif($length === false) {
+    } elseif ($length === false) {
         $length = null;
     }
 
-    return function (...$arguments) use ($predicate, $offset, $length) {
+    return function(...$arguments) use ($predicate, $offset, $length) {
         return $predicate(...array_slice($arguments, $offset, $length, false));
     };
 }
@@ -379,9 +379,9 @@ 
  */
 function consecutive(callable ...$predicates)
 {
-    return function (...$arguments) use ($predicates) {
+    return function(...$arguments) use ($predicates) {
         foreach ($arguments as $index => $value) {
-            if(!$predicates[$index]($value)) {
+            if (!$predicates[$index]($value)) {
                 return false;
             }
         }
@@ -393,7 +393,7 @@ 
 function property($name, $value) {
     $predicate = $value instanceof \Closure ? $value : \Kadet\Xmpp\Utils\filter\equals($value);
 
-    return function ($element) use ($name, $predicate) {
+    return function($element) use ($name, $predicate) {
         return $predicate($element->$name);
     };
 }

Utils/helper.php

Spacing +8 added lines, -8 removed lines

@@ -26,9 +26,9 @@ 
 function typeof($value) : string
 {
     if (is_object($value)) {
-        return "object of type ".get_class($value);
+        return "object of type " . get_class($value);
     } elseif (is_resource($value)) {
-        return get_resource_type($value).' resource';
+        return get_resource_type($value) . ' resource';
     }
 
     return gettype($value);
@@ -36,10 +36,10 @@ 
 
 function partial(callable $callable, $argument, int $position = 0) : callable
 {
-    return function (...$arguments) use ($callable, $argument, $position) {
+    return function(...$arguments) use ($callable, $argument, $position) {
         $arguments = array_merge(
             array_slice($arguments, 0, $position),
-            [ $argument ],
+            [$argument],
             array_slice($arguments, $position)
         );
 
@@ -49,7 +49,7 @@ 
 
 function dump($value)
 {
-    echo Dumper::get()->dump($value).PHP_EOL.PHP_EOL;
+    echo Dumper::get()->dump($value) . PHP_EOL . PHP_EOL;
 }
 
 function dd($value)
@@ -60,7 +60,7 @@ 
 
 function format($string, array $arguments = [])
 {
-    return str_replace(array_map(function ($e) { return "{{$e}}"; }, array_keys($arguments)), $arguments, $string);
+    return str_replace(array_map(function($e) { return "{{$e}}"; }, array_keys($arguments)), $arguments, $string);
 }
 
 function rearrange(array $array, array $keys) : array
@@ -75,9 +75,9 @@ 
 function copy(array $array)
 {
     return array_map(function($element) {
-        if(is_array($element)) {
+        if (is_array($element)) {
             return copy($element);
-        } elseif(is_object($element)) {
+        } elseif (is_object($element)) {
             return clone $element;
         }
 

Component/Roster.php

Spacing +6 added lines, -6 removed lines

@@ -47,7 +47,7 @@ 
 
     public function setClient(XmppClient $client)
     {
-        if($this->_client !== null) {
+        if ($this->_client !== null) {
             throw new BadMethodCallException("You cannot change rosters XmppClient instance.");
         }
 
@@ -72,7 +72,7 @@ 
     private function handleSet(Iq\Query\Roster $query)
     {
         foreach ($query->items as $item) {
-            if($item->subscription == 'remove') {
+            if ($item->subscription == 'remove') {
                 $this->removeItem($item->jid);
             } else {
                 $this->setItem($item);
@@ -169,7 +169,7 @@ 
 
         $iq = new Iq('remove', ['query' => new Iq\Query\Roster()]);
         /** @var Iq\Query\Roster\Item $item */
-        foreach($remove as $item) {
+        foreach ($remove as $item) {
             $iq->query->append(new Iq\Query\Roster\Item($item->jid, ['subscription' => 'remove']));
         }
 
@@ -186,7 +186,7 @@ 
     public function update(Iq\Query\Roster\Item $item)
     {
         $iq = new Iq('set', ['query' => new Iq\Query\Roster([
-            'items' => [ $item ]
+            'items' => [$item]
         ])]);
 
         return $this->_client->send($iq);
@@ -274,7 +274,7 @@ 
 
     private function setItem(Iq\Query\Roster\Item $item)
     {
-        $this->emit('item', [ $item ]);
+        $this->emit('item', [$item]);
         $this->_items[(string)$item->jid] = $item;
     }
 
@@ -287,7 +287,7 @@ 
             return;
         }
 
-        $this->emit('remove', [ $this->_items[(string)$jid] ]);
+        $this->emit('remove', [$this->_items[(string)$jid]]);
         unset($this->_items[(string)$jid]);
     }
 }

Component/PingKeepAlive.php

Spacing +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
      */
     public function enable()
     {
-        if($this->_interval) {
+        if ($this->_interval) {
             $this->_timer = $this->_client->connector->getLoop()->addPeriodicTimer($this->_interval, function() {
                 $this->keepAlive();
             });
@@ -67,7 +67,7 @@ 
      */
     public function disable()
     {
-        if($this->_timer) {
+        if ($this->_timer) {
             $this->_timer->cancel();
         }