kadet1090 / nucleus

Xml/XmlElementFactory.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
         }
 
         foreach ($lookup['<predicate>'] as list($class, $predicate)) {
-            if($predicate($tag, $namespace)) {
+            if ($predicate($tag, $namespace)) {
                 return $class;
             }
         }
@@ -64,7 +64,7 @@ 
     {
         $result = ['<predicate>' => []];
         foreach ($dictionary as $element) {
-            if($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
+            if ($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
                 $result['<predicate>'][] = [$element[0], \Kadet\Xmpp\Utils\filter\consecutive(
                     \Kadet\Xmpp\Utils\filter\predicate($element['name']),
                     \Kadet\Xmpp\Utils\filter\predicate($element['uri'])

Stanza/Iq.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
 
     protected function appendChild($element)
     {
-        if(count($this->children) > 0) {
+        if (count($this->children) > 0) {
             throw new \RuntimeException('Iq stanzas cannot have more than one child.');
         }
 
@@ -77,7 +77,7 @@ 
     public static function getXmlCollocations() : array
     {
         return array_merge(
-            [[ Query::class, 'name' => pass(), 'uri' => pass() ]],
+            [[Query::class, 'name' => pass(), 'uri' => pass()]],
             parent::getXmlCollocations()
         );
     }

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 use Kadet\Xmpp\Jid;
 use Kadet\Xmpp\Stanza\Iq\Query;
 use function Kadet\Xmpp\Utils\filter\pass;
-use Kadet\Xmpp\Xml\XmlElement;
 
 /**
  * Represents IQ Stanza

Component/Roster.php

Doc Comments -1 removed lines

@@ -184,7 +184,6 @@
     }
 
     /**
-     * @param callable(Item $item) $mapper
      * @return array
      */
     public function map(callable $mapper)

Spacing +6 added lines, -6 removed lines

@@ -47,7 +47,7 @@ 
 
     public function setClient(XmppClient $client)
     {
-        if($this->_client !== null) {
+        if ($this->_client !== null) {
             throw new BadMethodCallException("You cannot change rosters XmppClient instance.");
         }
 
@@ -72,7 +72,7 @@ 
     private function handleSet(Iq\Query\Roster $query)
     {
         foreach ($query->items as $item) {
-            if($item->subscription == 'remove') {
+            if ($item->subscription == 'remove') {
                 $this->removeItem($item->jid);
             } else {
                 $this->setItem($item);
@@ -169,7 +169,7 @@ 
 
         $iq = new Iq('remove', ['query' => new Iq\Query\Roster()]);
         /** @var Iq\Query\Roster\Item $item */
-        foreach($remove as $item) {
+        foreach ($remove as $item) {
             $iq->query->append(new Iq\Query\Roster\Item($item->jid, ['subscription' => 'remove']));
         }
 
@@ -186,7 +186,7 @@ 
     public function update(Iq\Query\Roster\Item $item)
     {
         $iq = new Iq('set', ['query' => new Iq\Query\Roster([
-            'items' => [ $item ]
+            'items' => [$item]
         ])]);
 
         return $this->_client->send($iq);
@@ -274,7 +274,7 @@ 
 
     private function setItem(Iq\Query\Roster\Item $item)
     {
-        $this->emit('item', [ $item ]);
+        $this->emit('item', [$item]);
         $this->_items[(string)$item->jid] = $item;
     }
 
@@ -287,7 +287,7 @@ 
             return;
         }
 
-        $this->emit('remove', [ $this->_items[(string)$jid] ]);
+        $this->emit('remove', [$this->_items[(string)$jid]]);
         unset($this->_items[(string)$jid]);
     }
 }

Stanza/Iq/Query/Roster.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
 
     protected function appendChild($element)
     {
-        if(!$element instanceof Item) {
+        if (!$element instanceof Item) {
             throw new InvalidArgumentException(format('Only instances of roster item ({expected}) can be added into roster, tried to add {actual}', [
                 'expected' => Item::class,
                 'actual'   => get_class($element)
@@ -99,7 +99,7 @@ 
     public static function getXmlCollocations() : array
     {
         return [
-            [ Item::class, 'name' => 'item', 'uri' => 'jabber:iq:roster' ]
+            [Item::class, 'name' => 'item', 'uri' => 'jabber:iq:roster']
         ];
     }
 }

XmppClient.php

Spacing +11 added lines, -11 removed lines

@@ -148,17 +148,17 @@ 
 
         $this->applyOptions($options);
 
-        $this->on('element', function (Features $element) {
+        $this->on('element', function(Features $element) {
             $this->_features = $element;
             $this->emit('features', [$element]);
         }, Features::class);
 
-        $this->on('element', function (Stanza $stanza) {
-            $this->emit('stanza', [ $stanza ]);
-            $this->emit($stanza->localName, [ $stanza ]);
+        $this->on('element', function(Stanza $stanza) {
+            $this->emit('stanza', [$stanza]);
+            $this->emit($stanza->localName, [$stanza]);
         }, Stanza::class);
 
-        $this->on('close', function () {
+        $this->on('close', function() {
             $this->state = 'disconnected';
         });
     }
@@ -211,7 +211,7 @@ 
         $this->state = 'bound';
 
         $queue = new \SplQueue();
-        $this->emit('init', [ $queue ]);
+        $this->emit('init', [$queue]);
 
         \React\Promise\all(iterator_to_array($queue))->then(function() {
             $this->state = 'ready';
@@ -235,10 +235,10 @@ 
 
         if ($alias === true) {
             $this->_addToContainer($module, array_merge(class_implements($module), array_slice(class_parents($module), 1)));
-        } elseif(is_array($alias)) {
+        } elseif (is_array($alias)) {
             $this->_addToContainer($module, $alias);
         } else {
-            $this->_addToContainer($module, [ $alias === false ? get_class($module) : $alias ]);
+            $this->_addToContainer($module, [$alias === false ? get_class($module) : $alias]);
         }
     }
 
@@ -261,7 +261,7 @@ 
         $deferred = new Deferred();
 
         $this->once('element', function(Stanza $stanza) use ($deferred) {
-            if($stanza->type === "error") {
+            if ($stanza->type === "error") {
                 $deferred->reject($stanza);
             } else {
                 $deferred->resolve($stanza);
@@ -297,7 +297,7 @@ 
     //region Parser
     public function setParser(XmlParser $parser)
     {
-        if($this->state !== "disconnected") {
+        if ($this->state !== "disconnected") {
             throw new \BadMethodCallException('Parser can be changed only when client is disconnected.');
         }
 
@@ -325,7 +325,7 @@ 
             ));
         }
 
-        $this->_connector->on('connect', function ($stream) {
+        $this->_connector->on('connect', function($stream) {
             return $this->handleConnect($stream);
         });
     }

Sasl/DigestMD5.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function createResponse($challenge = null)
     {
-        if(strpos($challenge, 'rspauth=') !== false) {
+        if (strpos($challenge, 'rspauth=') !== false) {
             return '';
         }
 

Utils/filter/element.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
 {
     $predicate = $uri instanceof \Closure ? $uri : \Kadet\Xmpp\Utils\filter\same($uri);
 
-    return function ($element) use ($predicate) {
+    return function($element) use ($predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }
@@ -74,7 +74,7 @@ 
 {
     $predicate = $name instanceof \Closure ? $name : \Kadet\Xmpp\Utils\filter\same($name);
 
-    return function ($element) use ($predicate) {
+    return function($element) use ($predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }
@@ -108,7 +108,7 @@ 
 {
     $predicate = $value instanceof \Closure ? $value : \Kadet\Xmpp\Utils\filter\equals($value);
 
-    return function ($element) use ($name, $predicate) {
+    return function($element) use ($name, $predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }

Utils/DnsResolver.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
                 continue;
             }
 
-            $this->_results = array_merge($this->_results, array_map(function ($record) use($type) {
+            $this->_results = array_merge($this->_results, array_map(function($record) use($type) {
                 return $type === DNS_SRV
                     ? [$record['target'], $record['port']]
                     : [$record['ip'], $this->_port];

Component/Subscription/SubscriptionManager.php

Doc Comments +4 added lines, -1 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * Sends subscription removal request presence to server.
      *
-     * @param Jid|string $jid
+     * @param Jid $jid
      * @return \React\Promise\ExtendedPromiseInterface
      */
     public function unsubscribe(Jid $jid)
@@ -74,6 +74,9 @@ 
         return $this->_client->send($this->presence('unsubscribed', $jid));
     }
 
+    /**
+     * @param string $type
+     */
     private function presence($type, $jid)
     {
         $jid = $jid instanceof Jid ? $jid : new Jid($jid);

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
     private function handleSubscriptionRequest(Presence $presence)
     {
-        $this->emit('request', [ $presence ]);
+        $this->emit('request', [$presence]);
     }
 
     /**