Completed
Pull Request — master (#16)
by Tuomas
04:38
created
src/Extension/AddFullElementNameExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
             return;
48 48
         }
49 49
         if ($type === PhpDomainBuilder::SECTION_BEFORE_DESCRIPTION) {
50
-            if($element instanceof Class_) {
50
+            if ($element instanceof Class_) {
51 51
                 $modifiers = $element->isAbstract() ? 'abstract' : '';
52 52
                 $modifiers = $element->isFinal() ? ' final' : $modifiers;
53 53
                 $builder->addLine(':php:`' . $modifiers . ' class ' . RstBuilder::escape($builder->getElement()->getName()) . ' {}`');
Please login to merge, or discard this patch.
src/Extension/TocExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
                 /** @var Interface_ $interface */
53 53
                 $interface = $builder->getElement();
54 54
 
55
-                if(count($interface->getMethods()) > 0) {
55
+                if (count($interface->getMethods()) > 0) {
56 56
                     $builder->addH3('Methods');
57 57
                     foreach ($interface->getMethods() as $method) {
58 58
                         $args = '';
Please login to merge, or discard this patch.
src/GenerateDocumentationCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,17 +71,17 @@
 block discarded – undo
71 71
             $apiDocBuilder->setVerboseOutput(true);
72 72
             $apiDocBuilder->setDebugOutput(true);
73 73
         }
74
-        if($input->getOption('public-only')) {
74
+        if ($input->getOption('public-only')) {
75 75
             $apiDocBuilder->addExtension(PublicOnlyExtension::class);
76 76
         }
77
-        if(!$input->getOption('show-private')) {
77
+        if (!$input->getOption('show-private')) {
78 78
             $apiDocBuilder->addExtension(NoPrivateExtension::class);
79 79
         }
80
-        if($input->getOption('element-toc')) {
80
+        if ($input->getOption('element-toc')) {
81 81
             $apiDocBuilder->addExtension(TocExtension::class);
82 82
         }
83 83
 
84
-        if($input->getOption('repo-github') && $input->getOption('repo-base')) {
84
+        if ($input->getOption('repo-github') && $input->getOption('repo-base')) {
85 85
             $apiDocBuilder->addExtension(GithubLocationExtension::class, [
86 86
                 $input->getOption('repo-base'),
87 87
                 $input->getOption('repo-github')
Please login to merge, or discard this patch.
src/ApiDocBuilder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      * @param string $class name of the extension class
203 203
      * @throws \Exception
204 204
      */
205
-    public function addExtension($class, $arguments=[]) {
205
+    public function addExtension($class, $arguments = []) {
206 206
         $this->extensionNames[] = $class;
207 207
         $this->extensionArguments[$class] = $arguments;
208 208
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
         $this->log('Build indexes.');
303 303
         $namespaces = $this->project->getNamespaces();
304 304
         $namespaces['\\'] = $this->project->getRootNamespace();
305
-        usort($namespaces, function (Namespace_ $a, Namespace_ $b) {
305
+        usort($namespaces, function(Namespace_ $a, Namespace_ $b) {
306 306
             return strcmp($a->getFqsen(), $b->getFqsen());
307 307
         });
308 308
         /** @var Namespace_ $namespace */
Please login to merge, or discard this patch.
src/Extension/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /** @var array */
38 38
     protected $arguments;
39 39
 
40
-    public function __construct(Project $project, $arguments=[]) {
40
+    public function __construct(Project $project, $arguments = []) {
41 41
         $this->project = $project;
42 42
         $this->arguments = $arguments;
43 43
     }
Please login to merge, or discard this patch.
src/Builder/PhpDomainBuilder.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      * @return mixed
71 71
      */
72 72
     public static function getNamespace(Element $element) {
73
-        return substr($element->getFqsen(), 0, strlen($element->getFqsen())-strlen('\\'. $element->getName()));
73
+        return substr($element->getFqsen(), 0, strlen($element->getFqsen()) - strlen('\\' . $element->getName()));
74 74
         //return str_replace('\\' . $element->getName(), '', $element->getFqsen());
75 75
     }
76 76
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      * @param Property $property
165 165
      */
166 166
     private function addProperty(Property $property) {
167
-        $modifiers = $property->isStatic() ? '' : ' static' ;
167
+        $modifiers = $property->isStatic() ? '' : ' static';
168 168
         $this->beginPhpDomain('attr', $property->getVisibility() . $modifiers . ' ' . $property->getName());
169 169
         $docBlock = $property->getDocBlock();
170 170
         $this->addDocBlockDescription($property);
@@ -239,10 +239,10 @@  discard block
 block discarded – undo
239 239
                 $args .= self::escape($type) . '|';
240 240
             }
241 241
             $args = substr($args, 0, -1) . ' ';
242
-            if($argument->isVariadic()) {
242
+            if ($argument->isVariadic()) {
243 243
                 $args .= '...';
244 244
             }
245
-            if($argument->isByReference()) {
245
+            if ($argument->isByReference()) {
246 246
                 $args .= '&';
247 247
             }
248 248
             $args .= '$' . $argument->getName();
@@ -292,8 +292,8 @@  discard block
 block discarded – undo
292 292
      * @param $fqsen string
293 293
      * @return string
294 294
      */
295
-    public static function getLink($type, $fqsen, $description='') {
296
-        if($description !== '') {
295
+    public static function getLink($type, $fqsen, $description = '') {
296
+        if ($description !== '') {
297 297
             return ':php:' . $type . ':`' . RstBuilder::escape($description) . '<' . RstBuilder::escape(substr($fqsen, 1)) . '>`';
298 298
         }
299 299
         return ':php:' . $type . ':`' . RstBuilder::escape(substr($fqsen, 1)) . '`';
Please login to merge, or discard this patch.
Braces   +24 added lines, -9 removed lines patch added patch discarded remove patch
@@ -350,44 +350,58 @@  discard block
 block discarded – undo
350 350
         $tags = $docBlock->getTagsByName($tagName);
351 351
         switch ($tagName) {
352 352
             case 'return':
353
-                if (count($tags) === 0) continue;
353
+                if (count($tags) === 0) {
354
+                    continue;
355
+                }
354 356
                 /** @var Return_ $return */
355 357
                 $return = $tags[0];
356 358
                 $this->addMultiline(':Returns: ' . self::typesToRst($return->getType()) . ' ' . RstBuilder::escape($return->getDescription()), true);
357 359
                 break;
358 360
             case 'var':
359
-                if (count($tags) === 0) continue;
361
+                if (count($tags) === 0) {
362
+                    continue;
363
+                }
360 364
                 /** @var DocBlock\Tags\Var_ $return */
361 365
                 $return = $tags[0];
362 366
                 $this->addMultiline(':Type: ' . self::typesToRst($return->getType()) . ' ' . RstBuilder::escape($return->getDescription()), true);
363 367
                 break;
364 368
             case 'throws':
365
-                if (count($tags) === 0) continue;
369
+                if (count($tags) === 0) {
370
+                    continue;
371
+                }
366 372
                 /** @var Throws $tag */
367 373
                 foreach ($tags as $tag) {
368 374
                     $this->addMultiline(':Throws: ' . self::typesToRst($tag->getType()) . ' ' . RstBuilder::escape($tag->getDescription()), true);
369 375
                 }
370 376
                 break;
371 377
             case 'since':
372
-                if (count($tags) === 0) continue;
378
+                if (count($tags) === 0) {
379
+                    continue;
380
+                }
373 381
                 /** @var Since $return */
374 382
                 $return = $tags[0];
375 383
                 $this->addMultiline(':Since: ' . $return->getVersion() . ' ' . RstBuilder::escape($return->getDescription()), true);
376 384
                 break;
377 385
             case 'deprecated':
378
-                if (count($tags) === 0) continue;
386
+                if (count($tags) === 0) {
387
+                    continue;
388
+                }
379 389
                 /** @var Deprecated $return */
380 390
                 $return = $tags[0];
381 391
                 $this->addMultiline(':Deprecated: ' . $return->getVersion() . ' ' . RstBuilder::escape($return->getDescription()), true);
382 392
                 break;
383 393
             case 'see':
384
-                if (count($tags) === 0) continue;
394
+                if (count($tags) === 0) {
395
+                    continue;
396
+                }
385 397
                 /** @var See $return */
386 398
                 $return = $tags[0];
387 399
                 $this->addMultiline(':See: ' . self::typesToRst($return->getReference()) . ' ' . RstBuilder::escape($return->getDescription()), true);
388 400
                 break;
389 401
             case 'license':
390
-                if (count($tags) === 0) continue;
402
+                if (count($tags) === 0) {
403
+                    continue;
404
+                }
391 405
                 /** @var DocBlock\Tags\BaseTag $return */
392 406
                 $return = $tags[0];
393 407
                 $this->addMultiline(':License: ' . RstBuilder::escape($return->getDescription()), true);
@@ -421,8 +435,9 @@  discard block
 block discarded – undo
421 435
                 $result .= $typeFull . ' | ';
422 436
                 continue;
423 437
             }
424
-            if (0 === strpos($type, '\\'))
425
-                $type = substr($type, 1);
438
+            if (0 === strpos($type, '\\')) {
439
+                            $type = substr($type, 1);
440
+            }
426 441
             $result .= ':any:`' . RstBuilder::escape($typeFull) . ' <' . RstBuilder::escape($type) . '>` | ';
427 442
         }
428 443
         return substr($result, 0, -3);
Please login to merge, or discard this patch.
src/Extension/GithubLocationExtension.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,12 +71,12 @@
 block discarded – undo
71 71
             $filePath = preg_replace('/^' . preg_quote($this->basePath, '/') . '/', '', $filePath);
72 72
             $lineNumber = $element->getLocation()->getLineNumber();
73 73
             $url = $this->getGithubLink($filePath, $lineNumber, $this->branch);
74
-            $builder->addFieldList('Source', '`' . $filePath. '#' . $lineNumber . ' <'.$url.'>`_');
74
+            $builder->addFieldList('Source', '`' . $filePath . '#' . $lineNumber . ' <' . $url . '>`_');
75 75
         }
76 76
     }
77 77
 
78
-    private function getGithubLink($file, $line=1, $branch='master') {
79
-        return $this->githubRepo . '/blob/'.$branch.'/'.$file.'#L' . $line;
78
+    private function getGithubLink($file, $line = 1, $branch = 'master') {
79
+        return $this->githubRepo . '/blob/' . $branch . '/' . $file . '#L' . $line;
80 80
     }
81 81
 
82 82
 }
83 83
\ No newline at end of file
Please login to merge, or discard this patch.
src/Builder/RstBuilder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
     private $indentLevel = 0;
37 37
     /** @var string */
38
-    protected $content = '.. rst-class:: phpdoctorst' . PHP_EOL . PHP_EOL ;
38
+    protected $content = '.. rst-class:: phpdoctorst' . PHP_EOL . PHP_EOL;
39 39
 
40 40
     public function getContent() {
41 41
         return $this->content;
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     }
60 60
 
61 61
     public function addFieldList($key, $value) {
62
-        $this->addLine(':'.self::escape($key).':');
62
+        $this->addLine(':' . self::escape($key) . ':');
63 63
         $this->indent()->addMultiline($value, false)->unindent();
64 64
         return $this;
65 65
     }
Please login to merge, or discard this patch.