Completed
Push — master ( deb9d0...9a5284 )
by Julius
9s
created
lib/Service/CardService.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
         return $this->cardMapper->find($cardId);
46 46
     }
47 47
 
48
+    /**
49
+     * @param integer $order
50
+     */
48 51
     public function create($title, $stackId, $type, $order, $owner) {
49 52
         $this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
50 53
         $card = new Card();
Please login to merge, or discard this patch.
Indentation   +114 added lines, -114 removed lines patch added patch discarded remove patch
@@ -32,118 +32,118 @@
 block discarded – undo
32 32
 
33 33
 class CardService {
34 34
 
35
-    private $cardMapper;
36
-
37
-    public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService) {
38
-        $this->cardMapper = $cardMapper;
39
-        $this->stackMapper = $stackMapper;
40
-        $this->permissionService = $permissionService;
41
-    }
42
-
43
-    public function find($cardId) {
44
-        $this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_READ);
45
-        return $this->cardMapper->find($cardId);
46
-    }
47
-
48
-    public function create($title, $stackId, $type, $order, $owner) {
49
-        $this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
50
-        $card = new Card();
51
-        $card->setTitle($title);
52
-        $card->setStackId($stackId);
53
-        $card->setType($type);
54
-        $card->setOrder($order);
55
-        $card->setOwner($owner);
56
-        return $this->cardMapper->insert($card);
57
-
58
-    }
59
-
60
-    public function delete($id) {
61
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
62
-        return $this->cardMapper->delete($this->cardMapper->find($id));
63
-    }
64
-
65
-    public function update($id, $title, $stackId, $type, $order, $description, $owner) {
66
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
67
-        $card = $this->cardMapper->find($id);
68
-        if ($card->getArchived()) {
69
-            throw new CardArchivedException();
70
-        }
71
-        $card->setTitle($title);
72
-        $card->setStackId($stackId);
73
-        $card->setType($type);
74
-        $card->setOrder($order);
75
-        $card->setOwner($owner);
76
-        $card->setDescription($description);
77
-        return $this->cardMapper->update($card);
78
-    }
79
-
80
-    public function rename($id, $title) {
81
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
82
-        $card = $this->cardMapper->find($id);
83
-        if ($card->getArchived()) {
84
-            throw new CardArchivedException();
85
-        }
86
-        $card->setTitle($title);
87
-        return $this->cardMapper->update($card);
88
-    }
89
-
90
-    public function reorder($id, $stackId, $order) {
91
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
92
-        $cards = $this->cardMapper->findAll($stackId);
93
-        $result = [];
94
-        $i = 0;
95
-        foreach ($cards as $card) {
96
-            if ($card->getArchived()) {
97
-                throw new CardArchivedException();
98
-            }
99
-            if ($card->id === $id) {
100
-                $card->setOrder($order);
101
-                $card->setLastModified(time());
102
-            }
103
-
104
-            if ($i === $order) {
105
-                            $i++;
106
-            }
107
-
108
-            if ($card->id !== $id) {
109
-                $card->setOrder($i++);
110
-            }
111
-            $this->cardMapper->update($card);
112
-            $result[$card->getOrder()] = $card;
113
-        }
114
-
115
-        return $result;
116
-    }
117
-
118
-    public function archive($id) {
119
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
120
-        $card = $this->cardMapper->find($id);
121
-        $card->setArchived(true);
122
-        return $this->cardMapper->update($card);
123
-    }
124
-
125
-    public function unarchive($id) {
126
-        $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
127
-        $card = $this->cardMapper->find($id);
128
-        $card->setArchived(false);
129
-        return $this->cardMapper->update($card);
130
-    }
131
-
132
-    public function assignLabel($cardId, $labelId) {
133
-        $this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
134
-        $card = $this->cardMapper->find($cardId);
135
-        if ($card->getArchived()) {
136
-            throw new CardArchivedException();
137
-        }
138
-        $this->cardMapper->assignLabel($cardId, $labelId);
139
-    }
140
-
141
-    public function removeLabel($cardId, $labelId) {
142
-        $this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
143
-        $card = $this->cardMapper->find($cardId);
144
-        if ($card->getArchived()) {
145
-            throw new CardArchivedException();
146
-        }
147
-        $this->cardMapper->removeLabel($cardId, $labelId);
148
-    }
35
+	private $cardMapper;
36
+
37
+	public function __construct(CardMapper $cardMapper, StackMapper $stackMapper, PermissionService $permissionService) {
38
+		$this->cardMapper = $cardMapper;
39
+		$this->stackMapper = $stackMapper;
40
+		$this->permissionService = $permissionService;
41
+	}
42
+
43
+	public function find($cardId) {
44
+		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_READ);
45
+		return $this->cardMapper->find($cardId);
46
+	}
47
+
48
+	public function create($title, $stackId, $type, $order, $owner) {
49
+		$this->permissionService->checkPermission($this->stackMapper, $stackId, Acl::PERMISSION_EDIT);
50
+		$card = new Card();
51
+		$card->setTitle($title);
52
+		$card->setStackId($stackId);
53
+		$card->setType($type);
54
+		$card->setOrder($order);
55
+		$card->setOwner($owner);
56
+		return $this->cardMapper->insert($card);
57
+
58
+	}
59
+
60
+	public function delete($id) {
61
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
62
+		return $this->cardMapper->delete($this->cardMapper->find($id));
63
+	}
64
+
65
+	public function update($id, $title, $stackId, $type, $order, $description, $owner) {
66
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
67
+		$card = $this->cardMapper->find($id);
68
+		if ($card->getArchived()) {
69
+			throw new CardArchivedException();
70
+		}
71
+		$card->setTitle($title);
72
+		$card->setStackId($stackId);
73
+		$card->setType($type);
74
+		$card->setOrder($order);
75
+		$card->setOwner($owner);
76
+		$card->setDescription($description);
77
+		return $this->cardMapper->update($card);
78
+	}
79
+
80
+	public function rename($id, $title) {
81
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
82
+		$card = $this->cardMapper->find($id);
83
+		if ($card->getArchived()) {
84
+			throw new CardArchivedException();
85
+		}
86
+		$card->setTitle($title);
87
+		return $this->cardMapper->update($card);
88
+	}
89
+
90
+	public function reorder($id, $stackId, $order) {
91
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
92
+		$cards = $this->cardMapper->findAll($stackId);
93
+		$result = [];
94
+		$i = 0;
95
+		foreach ($cards as $card) {
96
+			if ($card->getArchived()) {
97
+				throw new CardArchivedException();
98
+			}
99
+			if ($card->id === $id) {
100
+				$card->setOrder($order);
101
+				$card->setLastModified(time());
102
+			}
103
+
104
+			if ($i === $order) {
105
+							$i++;
106
+			}
107
+
108
+			if ($card->id !== $id) {
109
+				$card->setOrder($i++);
110
+			}
111
+			$this->cardMapper->update($card);
112
+			$result[$card->getOrder()] = $card;
113
+		}
114
+
115
+		return $result;
116
+	}
117
+
118
+	public function archive($id) {
119
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
120
+		$card = $this->cardMapper->find($id);
121
+		$card->setArchived(true);
122
+		return $this->cardMapper->update($card);
123
+	}
124
+
125
+	public function unarchive($id) {
126
+		$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
127
+		$card = $this->cardMapper->find($id);
128
+		$card->setArchived(false);
129
+		return $this->cardMapper->update($card);
130
+	}
131
+
132
+	public function assignLabel($cardId, $labelId) {
133
+		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
134
+		$card = $this->cardMapper->find($cardId);
135
+		if ($card->getArchived()) {
136
+			throw new CardArchivedException();
137
+		}
138
+		$this->cardMapper->assignLabel($cardId, $labelId);
139
+	}
140
+
141
+	public function removeLabel($cardId, $labelId) {
142
+		$this->permissionService->checkPermission($this->cardMapper, $cardId, Acl::PERMISSION_EDIT);
143
+		$card = $this->cardMapper->find($cardId);
144
+		if ($card->getArchived()) {
145
+			throw new CardArchivedException();
146
+		}
147
+		$this->cardMapper->removeLabel($cardId, $labelId);
148
+	}
149 149
 }
150 150
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Service/BoardService.php 1 patch
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 
40 40
 	private $boardMapper;
41 41
 	private $labelMapper;
42
-    private $aclMapper;
42
+	private $aclMapper;
43 43
 	private $l10n;
44 44
 	private $permissionService;
45 45
 
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
 	}
60 60
 
61 61
 	public function find($boardId) {
62
-	    $this->permissionService->checkPermission($this->boardMapper, $boardId, Acl::PERMISSION_READ);
62
+		$this->permissionService->checkPermission($this->boardMapper, $boardId, Acl::PERMISSION_READ);
63 63
 		return $this->boardMapper->find($boardId, true, true);
64 64
 	}
65 65
 
@@ -72,11 +72,11 @@  discard block
 block discarded – undo
72 72
 
73 73
 		// create new labels
74 74
 		$default_labels = [
75
-		    '31CC7C' => $this->l10n->t('Finished'),
76
-            '317CCC' => $this->l10n->t('To review'),
75
+			'31CC7C' => $this->l10n->t('Finished'),
76
+			'317CCC' => $this->l10n->t('To review'),
77 77
 			'FF7A66' => $this->l10n->t('Action needed'),
78 78
 			'F1DB50' => $this->l10n->t('Later')
79
-        ];
79
+		];
80 80
 		$labels = [];
81 81
 		foreach ($default_labels as $color => $title) {
82 82
 			$label = new Label();
@@ -91,12 +91,12 @@  discard block
 block discarded – undo
91 91
 	}
92 92
 
93 93
 	public function delete($id) {
94
-        $this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_READ);
94
+		$this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_READ);
95 95
 		return $this->boardMapper->delete($this->find($id));
96 96
 	}
97 97
 
98 98
 	public function update($id, $title, $color) {
99
-        $this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_MANAGE);
99
+		$this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_MANAGE);
100 100
 		$board = $this->find($id);
101 101
 		$board->setTitle($title);
102 102
 		$board->setColor($color);
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
 
107 107
 	public function addAcl($boardId, $type, $participant, $edit, $share, $manage) {
108
-        $this->permissionService->checkPermission($this->boardMapper, $boardId, Acl::PERMISSION_SHARE);
108
+		$this->permissionService->checkPermission($this->boardMapper, $boardId, Acl::PERMISSION_SHARE);
109 109
 		$acl = new Acl();
110 110
 		$acl->setBoardId($boardId);
111 111
 		$acl->setType($type);
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 	}
118 118
 
119 119
 	public function updateAcl($id, $edit, $share, $manage) {
120
-        $this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_SHARE);
120
+		$this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_SHARE);
121 121
 		$acl = $this->aclMapper->find($id);
122 122
 		$acl->setPermissionEdit($edit);
123 123
 		$acl->setPermissionShare($share);
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	}
127 127
 
128 128
 	public function deleteAcl($id) {
129
-        $this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_SHARE);
129
+		$this->permissionService->checkPermission($this->boardMapper, $id, Acl::PERMISSION_SHARE);
130 130
 		$acl = $this->aclMapper->find($id);
131 131
 		return $this->aclMapper->delete($acl);
132 132
 	}
Please login to merge, or discard this patch.
lib/Db/Stack.php 1 patch
Indentation   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -28,37 +28,37 @@
 block discarded – undo
28 28
 
29 29
 class Stack extends Entity implements JsonSerializable {
30 30
 
31
-    public $id;
32
-    protected $title;
33
-    protected $boardId;
34
-    protected $cards = array();
35
-    protected $order;
31
+	public $id;
32
+	protected $title;
33
+	protected $boardId;
34
+	protected $cards = array();
35
+	protected $order;
36 36
 
37
-    public function __construct() {
38
-        $this->addType('id', 'integer');
39
-        $this->addType('boardId', 'integer');
40
-        $this->addType('order', 'integer');
41
-    }
37
+	public function __construct() {
38
+		$this->addType('id', 'integer');
39
+		$this->addType('boardId', 'integer');
40
+		$this->addType('order', 'integer');
41
+	}
42 42
 
43
-    public function setCards($cards) {
44
-        $this->cards = $cards;
45
-    }
43
+	public function setCards($cards) {
44
+		$this->cards = $cards;
45
+	}
46 46
 
47
-    public function jsonSerialize() {
48
-        if (!empty($this->cards)) {
49
-            return [
50
-                'id' => $this->id,
51
-                'title' => $this->title,
52
-                'order' => $this->order,
53
-                'boardId' => $this->boardId,
54
-                'cards' => $this->cards
55
-            ];
56
-        }
57
-        return [
58
-            'id' => $this->id,
59
-            'title' => $this->title,
60
-            'order' => $this->order,
61
-            'boardId' => $this->boardId
62
-        ];
63
-    }
47
+	public function jsonSerialize() {
48
+		if (!empty($this->cards)) {
49
+			return [
50
+				'id' => $this->id,
51
+				'title' => $this->title,
52
+				'order' => $this->order,
53
+				'boardId' => $this->boardId,
54
+				'cards' => $this->cards
55
+			];
56
+		}
57
+		return [
58
+			'id' => $this->id,
59
+			'title' => $this->title,
60
+			'order' => $this->order,
61
+			'boardId' => $this->boardId
62
+		];
63
+	}
64 64
 }
65 65
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Controller/BoardController.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,10 +49,10 @@
 block discarded – undo
49 49
 		$this->userInfo = $this->getBoardPrerequisites();
50 50
 	}
51 51
 
52
-    /**
53
-     * TODO: move to boardservice
54
-     * @return array
55
-     */
52
+	/**
53
+	 * TODO: move to boardservice
54
+	 * @return array
55
+	 */
56 56
 	private function getBoardPrerequisites() {
57 57
 		$groups = $this->groupManager->getUserGroupIds(
58 58
 			$this->userManager->get($this->userId)
Please login to merge, or discard this patch.
appinfo/routes.php 1 patch
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -22,46 +22,46 @@
 block discarded – undo
22 22
  */
23 23
 
24 24
 return [
25
-    'routes' => [
26
-        ['name' => 'page#index', 'url' => '/', 'verb' => 'GET'],
25
+	'routes' => [
26
+		['name' => 'page#index', 'url' => '/', 'verb' => 'GET'],
27 27
 
28
-        // share
29
-        ['name' => 'share#searchUser', 'url' => '/share/search/{search}', 'verb' => 'GET'],
28
+		// share
29
+		['name' => 'share#searchUser', 'url' => '/share/search/{search}', 'verb' => 'GET'],
30 30
 
31
-        // boards
32
-        ['name' => 'board#index', 'url' => '/boards', 'verb' => 'GET'],
33
-        ['name' => 'board#create', 'url' => '/boards', 'verb' => 'POST'],
34
-        ['name' => 'board#read', 'url' => '/boards/{boardId}', 'verb' => 'GET'],
35
-        ['name' => 'board#update', 'url' => '/boards/{boardId}', 'verb' => 'PUT'],
36
-        ['name' => 'board#delete', 'url' => '/boards/{boardId}', 'verb' => 'DELETE'],
31
+		// boards
32
+		['name' => 'board#index', 'url' => '/boards', 'verb' => 'GET'],
33
+		['name' => 'board#create', 'url' => '/boards', 'verb' => 'POST'],
34
+		['name' => 'board#read', 'url' => '/boards/{boardId}', 'verb' => 'GET'],
35
+		['name' => 'board#update', 'url' => '/boards/{boardId}', 'verb' => 'PUT'],
36
+		['name' => 'board#delete', 'url' => '/boards/{boardId}', 'verb' => 'DELETE'],
37 37
 		['name' => 'board#getUserPermissions', 'url' => '/boards/{boardId}/permissions', 'verb' => 'GET'],
38
-        ['name' => 'board#addAcl', 'url' => '/boards/{boardId}/acl', 'verb' => 'POST'],
39
-        ['name' => 'board#updateAcl', 'url' => '/boards/{boardId}/acl', 'verb' => 'PUT'],
40
-        ['name' => 'board#deleteAcl', 'url' => '/boards/{boardId}/acl/{aclId}', 'verb' => 'DELETE'],
38
+		['name' => 'board#addAcl', 'url' => '/boards/{boardId}/acl', 'verb' => 'POST'],
39
+		['name' => 'board#updateAcl', 'url' => '/boards/{boardId}/acl', 'verb' => 'PUT'],
40
+		['name' => 'board#deleteAcl', 'url' => '/boards/{boardId}/acl/{aclId}', 'verb' => 'DELETE'],
41 41
 
42
-        // stacks
43
-        ['name' => 'stack#index', 'url' => '/stacks/{boardId}', 'verb' => 'GET'],
44
-        ['name' => 'stack#create', 'url' => '/stacks', 'verb' => 'POST'],
45
-        ['name' => 'stack#update', 'url' => '/stacks/{stackId}', 'verb' => 'PUT'],
46
-        ['name' => 'stack#delete', 'url' => '/stacks/{stackId}', 'verb' => 'DELETE'],
47
-        ['name' => 'stack#archived', 'url' => '/stacks/{boardId}/archived', 'verb' => 'GET'],
42
+		// stacks
43
+		['name' => 'stack#index', 'url' => '/stacks/{boardId}', 'verb' => 'GET'],
44
+		['name' => 'stack#create', 'url' => '/stacks', 'verb' => 'POST'],
45
+		['name' => 'stack#update', 'url' => '/stacks/{stackId}', 'verb' => 'PUT'],
46
+		['name' => 'stack#delete', 'url' => '/stacks/{stackId}', 'verb' => 'DELETE'],
47
+		['name' => 'stack#archived', 'url' => '/stacks/{boardId}/archived', 'verb' => 'GET'],
48 48
 
49
-        // cards
50
-        ['name' => 'card#read', 'url' => '/cards/{cardId}', 'verb' => 'GET'],
51
-        ['name' => 'card#create', 'url' => '/cards', 'verb' => 'POST'],
52
-        ['name' => 'card#update', 'url' => '/cards/{cardId}', 'verb' => 'PUT'],
53
-        ['name' => 'card#delete', 'url' => '/cards/{cardId}', 'verb' => 'DELETE'],
54
-        ['name' => 'card#rename', 'url' => '/cards/{cardId}/rename', 'verb' => 'PUT'],
55
-        ['name' => 'card#reorder', 'url' => '/cards/{cardId}/reorder', 'verb' => 'PUT'],
56
-        ['name' => 'card#archive', 'url' => '/cards/{cardId}/archive', 'verb' => 'PUT'],
57
-        ['name' => 'card#unarchive', 'url' => '/cards/{cardId}/unarchive', 'verb' => 'PUT'],
58
-        ['name' => 'card#assignLabel', 'url' => '/cards/{cardId}/label/{labelId}', 'verb' => 'POST'],
59
-        ['name' => 'card#removeLabel', 'url' => '/cards/{cardId}/label/{labelId}', 'verb' => 'DELETE'],
49
+		// cards
50
+		['name' => 'card#read', 'url' => '/cards/{cardId}', 'verb' => 'GET'],
51
+		['name' => 'card#create', 'url' => '/cards', 'verb' => 'POST'],
52
+		['name' => 'card#update', 'url' => '/cards/{cardId}', 'verb' => 'PUT'],
53
+		['name' => 'card#delete', 'url' => '/cards/{cardId}', 'verb' => 'DELETE'],
54
+		['name' => 'card#rename', 'url' => '/cards/{cardId}/rename', 'verb' => 'PUT'],
55
+		['name' => 'card#reorder', 'url' => '/cards/{cardId}/reorder', 'verb' => 'PUT'],
56
+		['name' => 'card#archive', 'url' => '/cards/{cardId}/archive', 'verb' => 'PUT'],
57
+		['name' => 'card#unarchive', 'url' => '/cards/{cardId}/unarchive', 'verb' => 'PUT'],
58
+		['name' => 'card#assignLabel', 'url' => '/cards/{cardId}/label/{labelId}', 'verb' => 'POST'],
59
+		['name' => 'card#removeLabel', 'url' => '/cards/{cardId}/label/{labelId}', 'verb' => 'DELETE'],
60 60
 
61
-        // labels
62
-        ['name' => 'label#create', 'url' => '/labels', 'verb' => 'POST'],
63
-        ['name' => 'label#update', 'url' => '/labels/{labelId}', 'verb' => 'PUT'],
64
-        ['name' => 'label#delete', 'url' => '/labels/{labelId}', 'verb' => 'DELETE'],
61
+		// labels
62
+		['name' => 'label#create', 'url' => '/labels', 'verb' => 'POST'],
63
+		['name' => 'label#update', 'url' => '/labels/{labelId}', 'verb' => 'PUT'],
64
+		['name' => 'label#delete', 'url' => '/labels/{labelId}', 'verb' => 'DELETE'],
65 65
 
66
-    ]
66
+	]
67 67
 ];
Please login to merge, or discard this patch.
lib/Service/PermissionService.php 1 patch
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -75,35 +75,35 @@  discard block
 block discarded – undo
75 75
 	 * @return bool
76 76
 	 * @throws NoPermissionException
77 77
 	 */
78
-    public function checkPermission($mapper, $id, $permission) {
79
-        try {
80
-            if ($mapper instanceof IPermissionMapper) {
81
-                $boardId = $mapper->findBoardId($id);
82
-            } else {
83
-                $boardId = $id;
84
-            }
85
-            if ($boardId === null) {
86
-                // Throw NoPermission to not leak information about existing entries
87
-                throw new NoPermissionException('Permission denied');
88
-            }
78
+	public function checkPermission($mapper, $id, $permission) {
79
+		try {
80
+			if ($mapper instanceof IPermissionMapper) {
81
+				$boardId = $mapper->findBoardId($id);
82
+			} else {
83
+				$boardId = $id;
84
+			}
85
+			if ($boardId === null) {
86
+				// Throw NoPermission to not leak information about existing entries
87
+				throw new NoPermissionException('Permission denied');
88
+			}
89 89
 
90
-            if ($this->userIsBoardOwner($boardId)) {
91
-                return true;
92
-            }
93
-            $acls = $this->aclMapper->findAll($boardId);
94
-            $result = $this->userCan($acls, $permission);
95
-            if ($result) {
96
-                return true;
97
-            }
90
+			if ($this->userIsBoardOwner($boardId)) {
91
+				return true;
92
+			}
93
+			$acls = $this->aclMapper->findAll($boardId);
94
+			$result = $this->userCan($acls, $permission);
95
+			if ($result) {
96
+				return true;
97
+			}
98 98
 
99
-        } catch (DoesNotExistException $exception) {
100
-            // Throw NoPermission to not leak information about existing entries
101
-            throw new NoPermissionException('Permission denied');
102
-        }
99
+		} catch (DoesNotExistException $exception) {
100
+			// Throw NoPermission to not leak information about existing entries
101
+			throw new NoPermissionException('Permission denied');
102
+		}
103 103
 
104
-        throw new NoPermissionException('Permission denied.');
104
+		throw new NoPermissionException('Permission denied.');
105 105
 
106
-    }
106
+	}
107 107
 
108 108
 	/**
109 109
 	 * @param $boardId
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 		if ($board && $this->userId === $board->getOwner()) {
115 115
 			return true;
116 116
 		}
117
-        return false;
117
+		return false;
118 118
 	}
119 119
 
120 120
 	/**
Please login to merge, or discard this patch.
lib/Service/LabelService.php 1 patch
Indentation   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -30,38 +30,38 @@
 block discarded – undo
30 30
 
31 31
 class LabelService {
32 32
 
33
-    private $labelMapper;
33
+	private $labelMapper;
34 34
 
35
-    public function __construct(LabelMapper $labelMapper, PermissionService $permissionService) {
36
-        $this->labelMapper = $labelMapper;
37
-        $this->permissionService = $permissionService;
38
-    }
35
+	public function __construct(LabelMapper $labelMapper, PermissionService $permissionService) {
36
+		$this->labelMapper = $labelMapper;
37
+		$this->permissionService = $permissionService;
38
+	}
39 39
 
40
-    public function find($labelId) {
41
-        $this->permissionService->checkPermission($this->labelMapper, $labelId, Acl::PERMISSION_READ);
42
-        return $this->labelMapper->find($labelId);
43
-    }
40
+	public function find($labelId) {
41
+		$this->permissionService->checkPermission($this->labelMapper, $labelId, Acl::PERMISSION_READ);
42
+		return $this->labelMapper->find($labelId);
43
+	}
44 44
 
45
-    public function create($title, $color, $boardId) {
46
-        $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
47
-        $label = new Label();
48
-        $label->setTitle($title);
49
-        $label->setColor($color);
50
-        $label->setBoardId($boardId);
51
-        return $this->labelMapper->insert($label);
52
-    }
45
+	public function create($title, $color, $boardId) {
46
+		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
47
+		$label = new Label();
48
+		$label->setTitle($title);
49
+		$label->setColor($color);
50
+		$label->setBoardId($boardId);
51
+		return $this->labelMapper->insert($label);
52
+	}
53 53
 
54
-    public function delete($id) {
55
-        $this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
56
-        return $this->labelMapper->delete($this->find($id));
57
-    }
54
+	public function delete($id) {
55
+		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
56
+		return $this->labelMapper->delete($this->find($id));
57
+	}
58 58
 
59
-    public function update($id, $title, $color) {
60
-        $this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
61
-        $label = $this->find($id);
62
-        $label->setTitle($title);
63
-        $label->setColor($color);
64
-        return $this->labelMapper->update($label);
65
-    }
59
+	public function update($id, $title, $color) {
60
+		$this->permissionService->checkPermission($this->labelMapper, $id, Acl::PERMISSION_MANAGE);
61
+		$label = $this->find($id);
62
+		$label->setTitle($title);
63
+		$label->setColor($color);
64
+		return $this->labelMapper->update($label);
65
+	}
66 66
 
67 67
 }
68 68
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Service/StackService.php 1 patch
Indentation   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -35,71 +35,71 @@
 block discarded – undo
35 35
 
36 36
 class StackService {
37 37
 
38
-    private $stackMapper;
39
-    private $cardMapper;
40
-    private $labelMapper;
41
-    private $permissionService;
38
+	private $stackMapper;
39
+	private $cardMapper;
40
+	private $labelMapper;
41
+	private $permissionService;
42 42
 
43
-    public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, PermissionService $permissionService) {
44
-        $this->stackMapper = $stackMapper;
45
-        $this->cardMapper = $cardMapper;
46
-        $this->labelMapper = $labelMapper;
47
-        $this->permissionService = $permissionService;
48
-    }
43
+	public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, PermissionService $permissionService) {
44
+		$this->stackMapper = $stackMapper;
45
+		$this->cardMapper = $cardMapper;
46
+		$this->labelMapper = $labelMapper;
47
+		$this->permissionService = $permissionService;
48
+	}
49 49
 
50
-    public function findAll($boardId) {
51
-        $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_READ);
52
-        $stacks = $this->stackMapper->findAll($boardId);
53
-        $labels = $this->labelMapper->getAssignedLabelsForBoard($boardId);
54
-        foreach ($stacks as $stackIndex => $stack) {
55
-            $cards = $this->cardMapper->findAll($stack->id);
56
-            foreach ($cards as $cardIndex => $card) {
57
-            	if (array_key_exists($card->id, $labels)) {
58
-                	$cards[$cardIndex]->setLabels($labels[$card->id]);
50
+	public function findAll($boardId) {
51
+		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_READ);
52
+		$stacks = $this->stackMapper->findAll($boardId);
53
+		$labels = $this->labelMapper->getAssignedLabelsForBoard($boardId);
54
+		foreach ($stacks as $stackIndex => $stack) {
55
+			$cards = $this->cardMapper->findAll($stack->id);
56
+			foreach ($cards as $cardIndex => $card) {
57
+				if (array_key_exists($card->id, $labels)) {
58
+					$cards[$cardIndex]->setLabels($labels[$card->id]);
59 59
 				}
60
-            }
61
-            $stacks[$stackIndex]->setCards($cards);
62
-        }
63
-        return $stacks;
64
-    }
60
+			}
61
+			$stacks[$stackIndex]->setCards($cards);
62
+		}
63
+		return $stacks;
64
+	}
65 65
 
66
-    public function findAllArchived($boardId) {
67
-        $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_READ);
68
-        $stacks = $this->stackMapper->findAll($boardId);
69
-        $labels = $this->labelMapper->getAssignedLabelsForBoard($boardId);
70
-        foreach ($stacks as $stackIndex => $stack) {
71
-            $cards = $this->cardMapper->findAllArchived($stack->id);
72
-            foreach ($cards as $cardIndex => $card) {
73
-            	if (array_key_exists($card->id, $labels)) {
66
+	public function findAllArchived($boardId) {
67
+		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_READ);
68
+		$stacks = $this->stackMapper->findAll($boardId);
69
+		$labels = $this->labelMapper->getAssignedLabelsForBoard($boardId);
70
+		foreach ($stacks as $stackIndex => $stack) {
71
+			$cards = $this->cardMapper->findAllArchived($stack->id);
72
+			foreach ($cards as $cardIndex => $card) {
73
+				if (array_key_exists($card->id, $labels)) {
74 74
 					$cards[$cardIndex]->setLabels($labels[$card->id]);
75 75
 				}
76
-            }
77
-            $stacks[$stackIndex]->setCards($cards);
78
-        }
79
-        return $stacks;
80
-    }
76
+			}
77
+			$stacks[$stackIndex]->setCards($cards);
78
+		}
79
+		return $stacks;
80
+	}
81 81
 
82
-    public function create($title, $boardId, $order) {
83
-        $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
84
-        $stack = new Stack();
85
-        $stack->setTitle($title);
86
-        $stack->setBoardId($boardId);
87
-        $stack->setOrder($order);
88
-        return $this->stackMapper->insert($stack);
82
+	public function create($title, $boardId, $order) {
83
+		$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
84
+		$stack = new Stack();
85
+		$stack->setTitle($title);
86
+		$stack->setBoardId($boardId);
87
+		$stack->setOrder($order);
88
+		return $this->stackMapper->insert($stack);
89 89
 
90
-    }
90
+	}
91 91
 
92
-    public function delete($id) {
93
-        $this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
94
-        return $this->stackMapper->delete($this->stackMapper->find($id));
95
-    }
92
+	public function delete($id) {
93
+		$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
94
+		return $this->stackMapper->delete($this->stackMapper->find($id));
95
+	}
96 96
 
97
-    public function update($id, $title, $boardId, $order) {
98
-        $this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
99
-        $stack = $this->stackMapper->find($id);
100
-        $stack->setTitle($title);
101
-        $stack->setBoardId($boardId);
102
-        $stack->setOrder($order);
103
-        return $this->stackMapper->update($stack);
104
-    }
97
+	public function update($id, $title, $boardId, $order) {
98
+		$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
99
+		$stack = $this->stackMapper->find($id);
100
+		$stack->setTitle($title);
101
+		$stack->setBoardId($boardId);
102
+		$stack->setOrder($order);
103
+		return $this->stackMapper->update($stack);
104
+	}
105 105
 }
106 106
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Db/Label.php 1 patch
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,21 +28,21 @@
 block discarded – undo
28 28
 
29 29
 class Label extends Entity implements JsonSerializable {
30 30
 
31
-    public $id;
32
-    protected $title;
33
-    protected $color;
34
-    protected $boardId;
35
-    protected $cardId;
36
-    public function __construct() {
37
-        $this->addType('id', 'integer');
38
-    }
39
-    public function jsonSerialize() {
40
-        return [
41
-            'id' => $this->id,
42
-            'title' => $this->title,
43
-            'boardId' => $this->boardId,
44
-            'cardId' => $this->cardId,
45
-            'color' => $this->color,
46
-        ];
47
-    }
31
+	public $id;
32
+	protected $title;
33
+	protected $color;
34
+	protected $boardId;
35
+	protected $cardId;
36
+	public function __construct() {
37
+		$this->addType('id', 'integer');
38
+	}
39
+	public function jsonSerialize() {
40
+		return [
41
+			'id' => $this->id,
42
+			'title' => $this->title,
43
+			'boardId' => $this->boardId,
44
+			'cardId' => $this->cardId,
45
+			'color' => $this->color,
46
+		];
47
+	}
48 48
 }
49 49
\ No newline at end of file
Please login to merge, or discard this patch.