View GitHub Repository fermi

Schedule Inspection
Subscribe
Passed
Branch — master (718883)
by Justin
03:35
created
Category
Toggle Patches
core/Framework.php 2 patches
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -16,7 +16,7 @@  discard block
 
 block discarded – undo
16 16 
      * Note: If you want to use a different PSR-7 implementation this would be
17 17 
      * the proper place to replace the stock implementation of zend\diactoros.
18 18 
      *
19 
-     * @return Psr\Http\Message\RequestInterface
19 
+     * @return \Zend\Diactoros\ServerRequest
20 20 
      */
21 21 
     public static function requestFromGlobals()
22 22 
     {
 
@@ -52,7 +52,7 @@  discard block
 
 block discarded – undo
52 52 
      * class passed to it and then call __invoke() with middleware arguments.
53 53 
      *
54 54 
      * @param  string $className fully qualified name of a class
55 
-     * @return callable
55 
+     * @return \Closure
56 56 
      */
57 57 
     public static function lazy($className)
58 58 
     {
 
@@ -99,6 +99,7 @@  discard block
 
 block discarded – undo
99 99 
     /**
100 100 
      * Load a given configuration file or array.
101 101 
      *
102 
+     * @param string $name
102 103 
      * @return array
103 104 
      */
104 105 
     public static function config($name, $dir = null)
 
@@ -120,7 +121,7 @@  discard block
 
 block discarded – undo
120 121 
      *
121 122 
      * @param  string $view our view data.
122 123 
      * @param  array  $data data to pass through to our template
123 
-     * @return array
124 
+     * @return string
124 125 
      */
125 126 
     public static function render($view, $data)
126 127 
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
      */
42 42 
     public static function middleware(array $stack)
43 43 
     {
44 
-        return array_map(function ($callable) {
44 
+        return array_map(function($callable) {
45 45 
             $callable = is_string($callable) ? static::lazy($callable) : $callable;
46 46 
             return $callable;
47 47 
         }, $stack);
 
@@ -56,7 +56,7 @@  discard block
 
 block discarded – undo
56 56 
      */
57 57 
     public static function lazy($className)
58 58 
     {
59 
-        return function (RequestInterface $request, callable $next) use ($className) {
59 
+        return function(RequestInterface $request, callable $next) use ($className) {
60 60 
             $class = new $className();
61 61 
             return $class($request, $next);
62 62 
         };
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
     public static function router(RequestInterface $request, $path = null)
71 71 
     {
72 72 
         $path = $path ?: __DIR__ . "/../app/routes.php";
73 
-        $dispatcher = \FastRoute\simpleDispatcher(function (RouteCollector $r) use ($path) {
73 
+        $dispatcher = \FastRoute\simpleDispatcher(function(RouteCollector $r) use ($path) {
74 74 
             include $path;
75 75 
         });
76 76 
         $match = $dispatcher->dispatch($request->getMethod(), $request->getUri()->getPath());
Please login to merge, or discard this patch.
core/Response.php 1 patch
Doc Comments   +8 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -13,7 +13,7 @@  discard block
 
 block discarded – undo
13 13 
      *
14 14 
      * @param  string $view name of the view to load
15 15 
      * @param  array  $data data to expose to the view
16 
-     * @return Psr\Http\Message\ResponseInterface
16 
+     * @return HtmlResponse
17 17 
      */
18 18 
     public static function view($view, $data)
19 19 
     {
 
@@ -23,9 +23,8 @@  discard block
 
 block discarded – undo
23 23 
     /**
24 24 
      * Returns a response with a particular view loaded.
25 25 
      *
26 
-     * @param  string $view name of the view to load
27 26 
      * @param  array  $data data to expose to the view
28 
-     * @return Psr\Http\Message\ResponseInterface
27 
+     * @return HtmlResponse
29 28 
      */
30 29 
     public static function json($data, $flags = 79)
31 30 
     {
 
@@ -35,8 +34,7 @@  discard block
 
 block discarded – undo
35 34 
     /**
36 35 
      * Create a new basic string response.
37 36 
      *
38 
-     * @param  string $name name of the view to load
39 
-     * @return Psr\Http\Message\ResponseInterface
37 
+     * @return TextResponse
40 38 
      */
41 39 
     public static function string($string)
42 40 
     {
 
@@ -46,7 +44,7 @@  discard block
 
 block discarded – undo
46 44 
     /**
47 45 
      * Respond with a 400 bad request error json message.
48 46 
      *
49 
-     * @return Psr\Http\Message\ResponseInterface
47 
+     * @return \Zend\Diactoros\Response
50 48 
      */
51 49 
     public static function error400(RequestInterface $request)
52 50 
     {
 
@@ -56,7 +54,7 @@  discard block
 
 block discarded – undo
56 54 
     /**
57 55 
      * Respond with a 402 error message.
58 56 
      *
59 
-     * @return Psr\Http\Message\ResponseInterface
57 
+     * @return \Zend\Diactoros\Response
60 58 
      */
61 59 
     public static function error402(RequestInterface $request)
62 60 
     {
 
@@ -66,7 +64,7 @@  discard block
 
 block discarded – undo
66 64 
     /**
67 65 
      * Respond with a 403 error message.
68 66 
      *
69 
-     * @return Psr\Http\Message\ResponseInterface
67 
+     * @return \Zend\Diactoros\Response
70 68 
      */
71 69 
     public static function error403(RequestInterface $request)
72 70 
     {
 
@@ -76,7 +74,7 @@  discard block
 
 block discarded – undo
76 74 
     /**
77 75 
      * Respond with a 404 error message.
78 76 
      *
79 
-     * @return Psr\Http\Message\ResponseInterface
77 
+     * @return \Zend\Diactoros\Response
80 78 
      */
81 79 
     public static function error404(RequestInterface $request)
82 80 
     {
 
@@ -86,7 +84,7 @@  discard block
 
 block discarded – undo
86 84 
     /**
87 85 
      * Respond with a 405 error message.
88 86 
      *
89 
-     * @return Psr\Http\Message\ResponseInterface
87 
+     * @return \Zend\Diactoros\Response
90 88 
      */
91 89 
     public static function error405(RequestInterface $request)
92 90 
     {
Please login to merge, or discard this patch.