View GitHub Repository fermi

Schedule Inspection
Subscribe
Passed
Pull Request — master (#4)
by Justin
03:07
created
Status
Category
Toggle Patches
core/Framework.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@  discard block
 
 block discarded – undo
44 44 
      */
45 45 
     public static function middleware(array $stack): array
46 46 
     {
47 
-        return array_map(function ($callable) {
47 
+        return array_map(function($callable) {
48 48 
             $callable = is_string($callable) ? static::lazy($callable) : $callable;
49 49 
             return $callable;
50 50 
         }, $stack);
 
@@ -59,7 +59,7 @@  discard block
 
 block discarded – undo
59 59 
      */
60 60 
     public static function lazy(string $className): callable
61 61 
     {
62 
-        return function (ServerRequestInterface $request, RequestHandlerInterface $handler) use ($className): ResponseInterface {
62 
+        return function(ServerRequestInterface $request, RequestHandlerInterface $handler) use ($className): ResponseInterface {
63 63 
             $class = new $className();
64 64 
             if ($class instanceof MiddlewareInterface) {
65 65 
                 return $class->process($request, $handler);
 
@@ -79,7 +79,7 @@  discard block
 
 block discarded – undo
79 79 
     public static function router(ServerRequestInterface $request, string $path = null): ResponseInterface
80 80 
     {
81 81 
         $path = $path ?: __DIR__ . "/../app/routes.php";
82 
-        $dispatcher = \FastRoute\simpleDispatcher(function (RouteCollector $r) use ($path) {
82 
+        $dispatcher = \FastRoute\simpleDispatcher(function(RouteCollector $r) use ($path) {
83 83 
             include $path;
84 84 
         });
85 85 
         $match = $dispatcher->dispatch($request->getMethod(), $request->getUri()->getPath());
Please login to merge, or discard this patch.
core/Response.php 1 patch
Doc Comments   +9 added lines, -10 removed lines patch added patch discarded remove patch 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
      * @param  string $view name of the view to load
18 18 
      * @param  array  $data data to expose to the view
19 19 
      * @param  Engine $engine alternative rendering engine
20 
-     * @return Psr\Http\Message\ResponseInterface
20 
+     * @return ResponseInterface
21 21 
      */
22 22 
     public static function view(string $view, array $data, Engine $engine = null): ResponseInterface
23 23 
     {
 
@@ -27,9 +27,8 @@  discard block
 
 block discarded – undo
27 27 
     /**
28 28 
      * Returns a response with a particular view loaded.
29 29 
      *
30 
-     * @param  mixed $json  JSON serializable data
31 30 
      * @param  int   $flags JSON flags
32 
-     * @return Psr\Http\Message\ResponseInterface
31 
+     * @return ResponseInterface
33 32 
      */
34 33 
     public static function json($data, int $flags = 79): ResponseInterface
35 34 
     {
 
@@ -41,10 +40,10 @@  discard block
 
 block discarded – undo
41 40 
      *
42 41 
 <<<<<<< Updated upstream
43 42 
      * @param  string $string string to respond
44 
-     * @return Psr\Http\Message\ResponseInterface
43 
+     * @return ResponseInterface
45 44 
 =======
46 45 
      * @param  string $string name of the view to load
47 
-     * @return \Psr\Http\Message\ResponseInterface
46 
+     * @return ResponseInterface
48 47 
 >>>>>>> Stashed changes
49 48 
      */
50 49 
     public static function string(string $string): ResponseInterface
 
@@ -55,7 +54,7 @@  discard block
 
 block discarded – undo
55 54 
     /**
56 55 
      * Respond with a 400 bad request error json message.
57 56 
      *
58 
-     * @return Psr\Http\Message\ResponseInterface
57 
+     * @return ResponseInterface
59 58 
      */
60 59 
     public static function error400(ServerRequestInterface $request): ResponseInterface
61 60 
     {
 
@@ -65,7 +64,7 @@  discard block
 
 block discarded – undo
65 64 
     /**
66 65 
      * Respond with a 403 error message.
67 66 
      *
68 
-     * @return Psr\Http\Message\ResponseInterface
67 
+     * @return ResponseInterface
69 68 
      */
70 69 
     public static function error403(ServerRequestInterface $request): ResponseInterface
71 70 
     {
 
@@ -75,7 +74,7 @@  discard block
 
 block discarded – undo
75 74 
     /**
76 75 
      * Respond with a 404 error message.
77 76 
      *
78 
-     * @return Psr\Http\Message\ResponseInterface
77 
+     * @return ResponseInterface
79 78 
      */
80 79 
     public static function error404(ServerRequestInterface $request): ResponseInterface
81 80 
     {
 
@@ -85,7 +84,7 @@  discard block
 
 block discarded – undo
85 84 
     /**
86 85 
      * Respond with a 405 error message.
87 86 
      *
88 
-     * @return Psr\Http\Message\ResponseInterface
87 
+     * @return ResponseInterface
89 88 
      */
90 89 
     public static function error405(ServerRequestInterface $request): ResponseInterface
91 90 
     {
 
@@ -95,7 +94,7 @@  discard block
 
 block discarded – undo
95 94 
     /**
96 95 
      * Respond with a 429 error message.
97 96 
      *
98 
-     * @return Psr\Http\Message\ResponseInterface
97 
+     * @return ResponseInterface
99 98 
      */
100 99 
     public static function error429(ServerRequestInterface $request): ResponseInterface
101 100 
     {
Please login to merge, or discard this patch.
public/index.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -2,7 +2,6 @@
 
 block discarded – undo
2 2
3 3 
 use Relay\Relay;
4 4 
 use Fermi\Framework;
5 
-use Zend\Diactoros\ServerRequestFactory;
6 5
7 6 
 /**
8 7 
  * Fermi - A nuclear sized PSR-7 and PSR-15 compliant PHP framework.
Please login to merge, or discard this patch.