Inspection of "No longer need cache support with counter tables" - joomla/statistics-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9af6b2...4eed4e )

by Michael

created 2018-04-14 02:36 UTC

Status

Doc Comments +35 added lines, -35 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@  discard block
 block discarded – undo
 	/**
 	 * Registers the service provider with a DI container.
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  void
 	 */
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Analytics class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  Analytics
 	 */
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the CLI application service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  CliApplication
+	 * @return  \Joomla\StatsServer\CliApplication
 	 */
 	public function getCliApplicationService(Container $container) : CliApplication
 	{
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the CliInput class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  JoomlaApplication\Cli\CliInput
 	 */
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the CliOutput class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  JoomlaApplication\Cli\CliOutput
 	 */
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the ColorProcessor class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  JoomlaApplication\Cli\Output\Processor\ColorProcessor
 	 */
@@ -186,9 +186,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the console service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  Console
+	 * @return  \Joomla\StatsServer\Console
 	 */
 	public function getConsoleService(Container $container) : Console
 	{
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Database\MigrateCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\Database\MigrateCommand
 	 */
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Database\StatusCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\Database\StatusCommand
 	 */
@@ -236,9 +236,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the DisplayControllerCreate class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  DisplayControllerCreate
+	 * @return  \Joomla\StatsServer\Controllers\DisplayControllerCreate
 	 */
 	public function getDisplayControllerCreateService(Container $container) : DisplayControllerCreate
 	{
@@ -253,9 +253,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the DisplayControllerGet class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  DisplayControllerGet
+	 * @return  \Joomla\StatsServer\Controllers\DisplayControllerGet
 	 */
 	public function getDisplayControllerGetService(Container $container) : DisplayControllerGet
 	{
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the HelpCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\HelpCommand
 	 */
@@ -289,9 +289,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Input\Cli class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  Cli
+	 * @return  \Joomla\Input\Cli
 	 */
 	public function getInputCliService(Container $container) : Cli
 	{
@@ -301,9 +301,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Input class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  Input
+	 * @return  \Joomla\Input\Input
 	 */
 	public function getInputService(Container $container) : Input
 	{
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the InstallCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\InstallCommand
 	 */
@@ -330,9 +330,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the router service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  Router
+	 * @return  \Joomla\StatsServer\Router
 	 */
 	public function getRouterService(Container $container) : Router
 	{
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the SnapshotCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\SnapshotCommand
 	 */
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the StatsJsonView class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  StatsJsonView
 	 */
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the StatsModel class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  StatsModel
 	 */
@@ -395,9 +395,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the SubmitControllerCreate class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  SubmitControllerCreate
+	 * @return  \Joomla\StatsServer\Controllers\SubmitControllerCreate
 	 */
 	public function getSubmitControllerCreateService(Container $container) : SubmitControllerCreate
 	{
@@ -414,9 +414,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the SubmitControllerGet class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  SubmitControllerGet
+	 * @return  \Joomla\StatsServer\Controllers\SubmitControllerGet
 	 */
 	public function getSubmitControllerGetService(Container $container) : SubmitControllerGet
 	{
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Tags\JoomlaCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\Tags\JoomlaCommand
 	 */
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the Tags\PhpCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\Tags\PhpCommand
 	 */
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
 	/**
 	 * Get the UpdateCommand class service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
 	 * @return  AppCommands\UpdateCommand
 	 */
@@ -482,9 +482,9 @@  discard block
 block discarded – undo
 	/**
 	 * Get the web application service
 	 *
-	 * @param   Container  $container  The DI container.
+	 * @param   \Joomla\DI\Container  $container  The DI container.
 	 *
-	 * @return  WebApplication
+	 * @return  \Joomla\StatsServer\WebApplication
 	 */
 	public function getWebApplicationService(Container $container) : WebApplication
 	{

Please login to merge, or discard this patch.

www/index.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -6,7 +6,7 @@  discard block
 block discarded – undo
  * @license    http://www.gnu.org/licenses/gpl-2.0.txt GNU General Public License Version 2 or Later
  */
 
-require dirname(__DIR__) . '/boot.php';
+require dirname(__DIR__).'/boot.php';
 
 use Joomla\Application\{
 	AbstractApplication, AbstractWebApplication
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 
 $container = (new Container)
 	->registerServiceProvider(new ApplicationServiceProvider)
-	->registerServiceProvider(new ConfigServiceProvider(APPROOT . '/etc/config.json'))
+	->registerServiceProvider(new ConfigServiceProvider(APPROOT.'/etc/config.json'))
 	->registerServiceProvider(new DatabaseServiceProvider)
 	->registerServiceProvider(new GitHubServiceProvider)
 	->registerServiceProvider(new MonologServiceProvider);
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
 
 	$response = [
 		'error' => true,
-		'message' => 'An error occurred while executing the application: ' . $e->getMessage()
+		'message' => 'An error occurred while executing the application: '.$e->getMessage()
 	];
 
 	echo json_encode($response);

Please login to merge, or discard this patch.

		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	/**
39	39	* Registers the service provider with a DI container.
40	40	*
41		- * @param Container $container The DI container.
	41	+ * @param \Joomla\DI\Container $container The DI container.
42	42	*
43	43	* @return void
44	44	*/
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	/**
103	103	* Get the Analytics class service
104	104	*
105		- * @param Container $container The DI container.
	105	+ * @param \Joomla\DI\Container $container The DI container.
106	106	*
107	107	* @return Analytics
108	108	*/
		@@ -114,9 +114,9 @@ discard block
		block discarded – undo
114	114	/**
115	115	* Get the CLI application service
116	116	*
117		- * @param Container $container The DI container.
	117	+ * @param \Joomla\DI\Container $container The DI container.
118	118	*
119		- * @return CliApplication
	119	+ * @return \Joomla\StatsServer\CliApplication
120	120	*/
121	121	public function getCliApplicationService(Container $container) : CliApplication
122	122	{
		@@ -137,7 +137,7 @@ discard block
		block discarded – undo
137	137	/**
138	138	* Get the CliInput class service
139	139	*
140		- * @param Container $container The DI container.
	140	+ * @param \Joomla\DI\Container $container The DI container.
141	141	*
142	142	* @return JoomlaApplication\Cli\CliInput
143	143	*/
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	/**
150	150	* Get the CliOutput class service
151	151	*
152		- * @param Container $container The DI container.
	152	+ * @param \Joomla\DI\Container $container The DI container.
153	153	*
154	154	* @return JoomlaApplication\Cli\CliOutput
155	155	*/
		@@ -161,7 +161,7 @@ discard block
		block discarded – undo
161	161	/**
162	162	* Get the ColorProcessor class service
163	163	*
164		- * @param Container $container The DI container.
	164	+ * @param \Joomla\DI\Container $container The DI container.
165	165	*
166	166	* @return JoomlaApplication\Cli\Output\Processor\ColorProcessor
167	167	*/
		@@ -186,9 +186,9 @@ discard block
		block discarded – undo
186	186	/**
187	187	* Get the console service
188	188	*
189		- * @param Container $container The DI container.
	189	+ * @param \Joomla\DI\Container $container The DI container.
190	190	*
191		- * @return Console
	191	+ * @return \Joomla\StatsServer\Console
192	192	*/
193	193	public function getConsoleService(Container $container) : Console
194	194	{
		@@ -201,7 +201,7 @@ discard block
		block discarded – undo
201	201	/**
202	202	* Get the Database\MigrateCommand class service
203	203	*
204		- * @param Container $container The DI container.
	204	+ * @param \Joomla\DI\Container $container The DI container.
205	205	*
206	206	* @return AppCommands\Database\MigrateCommand
207	207	*/
		@@ -219,7 +219,7 @@ discard block
		block discarded – undo
219	219	/**
220	220	* Get the Database\StatusCommand class service
221	221	*
222		- * @param Container $container The DI container.
	222	+ * @param \Joomla\DI\Container $container The DI container.
223	223	*
224	224	* @return AppCommands\Database\StatusCommand
225	225	*/
		@@ -236,9 +236,9 @@ discard block
		block discarded – undo
236	236	/**
237	237	* Get the DisplayControllerCreate class service
238	238	*
239		- * @param Container $container The DI container.
	239	+ * @param \Joomla\DI\Container $container The DI container.
240	240	*
241		- * @return DisplayControllerCreate
	241	+ * @return \Joomla\StatsServer\Controllers\DisplayControllerCreate
242	242	*/
243	243	public function getDisplayControllerCreateService(Container $container) : DisplayControllerCreate
244	244	{
		@@ -253,9 +253,9 @@ discard block
		block discarded – undo
253	253	/**
254	254	* Get the DisplayControllerGet class service
255	255	*
256		- * @param Container $container The DI container.
	256	+ * @param \Joomla\DI\Container $container The DI container.
257	257	*
258		- * @return DisplayControllerGet
	258	+ * @return \Joomla\StatsServer\Controllers\DisplayControllerGet
259	259	*/
260	260	public function getDisplayControllerGetService(Container $container) : DisplayControllerGet
261	261	{
		@@ -272,7 +272,7 @@ discard block
		block discarded – undo
272	272	/**
273	273	* Get the HelpCommand class service
274	274	*
275		- * @param Container $container The DI container.
	275	+ * @param \Joomla\DI\Container $container The DI container.
276	276	*
277	277	* @return AppCommands\HelpCommand
278	278	*/
		@@ -289,9 +289,9 @@ discard block
		block discarded – undo
289	289	/**
290	290	* Get the Input\Cli class service
291	291	*
292		- * @param Container $container The DI container.
	292	+ * @param \Joomla\DI\Container $container The DI container.
293	293	*
294		- * @return Cli
	294	+ * @return \Joomla\Input\Cli
295	295	*/
296	296	public function getInputCliService(Container $container) : Cli
297	297	{
		@@ -301,9 +301,9 @@ discard block
		block discarded – undo
301	301	/**
302	302	* Get the Input class service
303	303	*
304		- * @param Container $container The DI container.
	304	+ * @param \Joomla\DI\Container $container The DI container.
305	305	*
306		- * @return Input
	306	+ * @return \Joomla\Input\Input
307	307	*/
308	308	public function getInputService(Container $container) : Input
309	309	{
		@@ -313,7 +313,7 @@ discard block
		block discarded – undo
313	313	/**
314	314	* Get the InstallCommand class service
315	315	*
316		- * @param Container $container The DI container.
	316	+ * @param \Joomla\DI\Container $container The DI container.
317	317	*
318	318	* @return AppCommands\InstallCommand
319	319	*/
		@@ -330,9 +330,9 @@ discard block
		block discarded – undo
330	330	/**
331	331	* Get the router service
332	332	*
333		- * @param Container $container The DI container.
	333	+ * @param \Joomla\DI\Container $container The DI container.
334	334	*
335		- * @return Router
	335	+ * @return \Joomla\StatsServer\Router
336	336	*/
337	337	public function getRouterService(Container $container) : Router
338	338	{
		@@ -350,7 +350,7 @@ discard block
		block discarded – undo
350	350	/**
351	351	* Get the SnapshotCommand class service
352	352	*
353		- * @param Container $container The DI container.
	353	+ * @param \Joomla\DI\Container $container The DI container.
354	354	*
355	355	* @return AppCommands\SnapshotCommand
356	356	*/
		@@ -367,7 +367,7 @@ discard block
		block discarded – undo
367	367	/**
368	368	* Get the StatsJsonView class service
369	369	*
370		- * @param Container $container The DI container.
	370	+ * @param \Joomla\DI\Container $container The DI container.
371	371	*
372	372	* @return StatsJsonView
373	373	*/
		@@ -381,7 +381,7 @@ discard block
		block discarded – undo
381	381	/**
382	382	* Get the StatsModel class service
383	383	*
384		- * @param Container $container The DI container.
	384	+ * @param \Joomla\DI\Container $container The DI container.
385	385	*
386	386	* @return StatsModel
387	387	*/
		@@ -395,9 +395,9 @@ discard block
		block discarded – undo
395	395	/**
396	396	* Get the SubmitControllerCreate class service
397	397	*
398		- * @param Container $container The DI container.
	398	+ * @param \Joomla\DI\Container $container The DI container.
399	399	*
400		- * @return SubmitControllerCreate
	400	+ * @return \Joomla\StatsServer\Controllers\SubmitControllerCreate
401	401	*/
402	402	public function getSubmitControllerCreateService(Container $container) : SubmitControllerCreate
403	403	{
		@@ -414,9 +414,9 @@ discard block
		block discarded – undo
414	414	/**
415	415	* Get the SubmitControllerGet class service
416	416	*
417		- * @param Container $container The DI container.
	417	+ * @param \Joomla\DI\Container $container The DI container.
418	418	*
419		- * @return SubmitControllerGet
	419	+ * @return \Joomla\StatsServer\Controllers\SubmitControllerGet
420	420	*/
421	421	public function getSubmitControllerGetService(Container $container) : SubmitControllerGet
422	422	{
		@@ -431,7 +431,7 @@ discard block
		block discarded – undo
431	431	/**
432	432	* Get the Tags\JoomlaCommand class service
433	433	*
434		- * @param Container $container The DI container.
	434	+ * @param \Joomla\DI\Container $container The DI container.
435	435	*
436	436	* @return AppCommands\Tags\JoomlaCommand
437	437	*/
		@@ -448,7 +448,7 @@ discard block
		block discarded – undo
448	448	/**
449	449	* Get the Tags\PhpCommand class service
450	450	*
451		- * @param Container $container The DI container.
	451	+ * @param \Joomla\DI\Container $container The DI container.
452	452	*
453	453	* @return AppCommands\Tags\PhpCommand
454	454	*/
		@@ -465,7 +465,7 @@ discard block
		block discarded – undo
465	465	/**
466	466	* Get the UpdateCommand class service
467	467	*
468		- * @param Container $container The DI container.
	468	+ * @param \Joomla\DI\Container $container The DI container.
469	469	*
470	470	* @return AppCommands\UpdateCommand
471	471	*/
		@@ -482,9 +482,9 @@ discard block
		block discarded – undo
482	482	/**
483	483	* Get the web application service
484	484	*
485		- * @param Container $container The DI container.
	485	+ * @param \Joomla\DI\Container $container The DI container.
486	486	*
487		- * @return WebApplication
	487	+ * @return \Joomla\StatsServer\WebApplication
488	488	*/
489	489	public function getWebApplicationService(Container $container) : WebApplication
490	490	{

		@@ -6,7 +6,7 @@ discard block
		block discarded – undo
6	6	* @license http://www.gnu.org/licenses/gpl-2.0.txt GNU General Public License Version 2 or Later
7	7	*/
8	8
9		-require dirname(__DIR__) . '/boot.php';
	9	+require dirname(__DIR__).'/boot.php';
10	10
11	11	use Joomla\Application\{
12	12	AbstractApplication, AbstractWebApplication
		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23
24	24	$container = (new Container)
25	25	->registerServiceProvider(new ApplicationServiceProvider)
26		- ->registerServiceProvider(new ConfigServiceProvider(APPROOT . '/etc/config.json'))
	26	+ ->registerServiceProvider(new ConfigServiceProvider(APPROOT.'/etc/config.json'))
27	27	->registerServiceProvider(new DatabaseServiceProvider)
28	28	->registerServiceProvider(new GitHubServiceProvider)
29	29	->registerServiceProvider(new MonologServiceProvider);
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58
59	59	$response = [
60	60	'error' => true,
61		- 'message' => 'An error occurred while executing the application: ' . $e->getMessage()
	61	+ 'message' => 'An error occurred while executing the application: '.$e->getMessage()
62	62	];
63	63
64	64	echo json_encode($response);

joomla / statistics-server

Push — master ( 9af6b2...4eed4e )

Status

Category

Doc Comments +35 added lines, -35 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch