jonathanmaron / ctw-middleware-pagecache

src/PageCacheMiddleware.php

<?php
declare(strict_types=1);

namespace Ctw\Middleware\PageCacheMiddleware;

use Laminas\Diactoros\Response\ArraySerializer as ResponseSerializer;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface;

class PageCacheMiddleware extends AbstractPageCacheMiddleware
{
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        if (!$this->shouldCache($request)) {
            return $handler->handle($request);
        }

        $idGenerator = $this->getIdGenerator();
        $cache       = $this->getStorageAdapter();

        $cacheId    = $idGenerator->generate($request);
        $serialized = $cache->getItem($cacheId, $success, $casToken);

        if (!$success) {
            $cacheStatus = self::STATUS_MISS;
            $response    = $handler->handle($request);
            $serialized  = ResponseSerializer::toArray($response);
            $cache->setItem($cacheId, $serialized);
        } else {
            $cacheStatus = self::STATUS_HIT;
            assert(is_array($serialized));
            $response    = ResponseSerializer::fromArray($serialized);
        }

        return $response->withHeader('X-Page-Cache', $cacheStatus);

The expression return $response->withHeader('X-Page-Cache', $cacheStatus) could return the type Psr\Http\Message\MessageInterface which includes types incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }
}