Ctw\Middleware\PageCacheMiddleware\PageCacheMiddleware::process()

Complexity

Conditions	3
Paths	3

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	7.8273

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        if (!$this->shouldCache($request)) {
            return $handler->handle($request);
        }

        $idGenerator = $this->getIdGenerator();
        $cache       = $this->getStorageAdapter();

        $cacheId    = $idGenerator->generate($request);
        $serialized = $cache->getItem($cacheId, $success, $casToken);

        if (!$success) {
            $cacheStatus = self::STATUS_MISS;
            $response    = $handler->handle($request);
            $serialized  = ResponseSerializer::toArray($response);
            $cache->setItem($cacheId, $serialized);
        } else {
            $cacheStatus = self::STATUS_HIT;
            assert(is_array($serialized));
            $response    = ResponseSerializer::fromArray($serialized);
        }

        return $response->withHeader('X-Page-Cache', $cacheStatus);

The expression return $response->withHeader('X-Page-Cache', $cacheStatus) could return the type Psr\Http\Message\MessageInterface which includes types incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }