PokerSquaresCreateObjectTest::testTraitDeckReturnDeck() - Code Metrics - Inspection of "Reducerat komplexiteten för metoder till godtagbar..." - joki20/dbwebb-mvc-proj - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Push — master ( ac9ff0...806846 )

by Johan

created 2021-05-18 18:18 UTC

testTraitDeckReturnDeck() A

↳ Parent: PokerSquaresCreateObjectTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

// php artisan test
namespace Tests\Unit;

use PHPUnit\Framework\TestCase;
use Joki20\Http\Controllers\PokerSquares;
use Joki20\Http\Controllers\Setup;
/**
 * Test cases for class Guess.
 */
class PokerSquaresCreateObjectTest extends TestCase
{
    // /**
    //  * Construct object and verify that the object is instance of class
    //  */
    public function testCreateObjectPokerSquares()
    {
        $pokersquares = new PokerSquares();
        $this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);
    }

    // /**
    //  * Test empty $_POST array
    //  */
    public function testEmptyPost()
    {
        $pokersquares = new PokerSquares();
        $this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);

        $exp = $pokersquares->game();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertEquals($exp, null);
    }

    public function testTraitDeckName()
    {
        $pokersquares = new PokerSquares();

        $exp = strlen($pokersquares->name());
        $this->assertEquals($exp, 265);
    }

    public function testTraitDeckDeckSize()

    {
        $pokersquares = new PokerSquares();

        $exp = $pokersquares->deckSize(['<div class="card rank08C">8 <br/> &clubs;</div>','<div class="card rank09C">9 <br/> &clubs;</div>',]);
        $this->assertEquals($exp, 2);
    }

    public function testTraitSetupName()
    {
        $pokersquares = new PokerSquares();

        $exp = strlen($pokersquares->name());
        $this->assertEquals($exp, 265);
    }

    // public function testTraitSetupShuffleDeck()
    // {
    //     $pokersquares = new PokerSquares();
    //
    //     $pokersquares->shuffleDeck();

        // $exp = 52;
        // $res = count(session('deck'));
        //
        // $this->assertEquals($exp, 52);
    //
    // }

}


1		<?php
2
3		// php artisan test
4		namespace Tests\Unit;
5
6		use PHPUnit\Framework\TestCase;
7		use Joki20\Http\Controllers\PokerSquares;
8		use Joki20\Http\Controllers\Setup;
9		/**
10		* Test cases for class Guess.
11		*/
12		class PokerSquaresCreateObjectTest extends TestCase
13		{
14		// /**
15		// * Construct object and verify that the object is instance of class
16		// */
17		public function testCreateObjectPokerSquares()
18		{
19		$pokersquares = new PokerSquares();
20		$this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);
21		}
22
23		// /**
24		// * Test empty $_POST array
25		// */
26		public function testEmptyPost()
27		{
28		$pokersquares = new PokerSquares();
29		$this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);
30
31		$exp = $pokersquares->game();
		0 ignored issues – show Bug introduced 2021-05-17 05:24 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$exp` is correct as `$pokersquares->game()` (which targets `Joki20\Http\Controllers\PokerSquares::game()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
32		$this->assertEquals($exp, null);
33		}
34
35		public function testTraitDeckName()
36		{
37		$pokersquares = new PokerSquares();
38
39		$exp = strlen($pokersquares->name());
40		$this->assertEquals($exp, 265);
41		}
42
43	View Code Duplication	public function testTraitDeckDeckSize()
		0 ignored issues – show Duplication introduced 2021-05-18 18:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$pokersquares = new PokerSquares();
46
47		$exp = $pokersquares->deckSize(['<div class="card rank08C">8 <br/> &clubs;</div>','<div class="card rank09C">9 <br/> &clubs;</div>',]);
48		$this->assertEquals($exp, 2);
49		}
50
51		public function testTraitSetupName()
52		{
53		$pokersquares = new PokerSquares();
54
55		$exp = strlen($pokersquares->name());
56		$this->assertEquals($exp, 265);
57		}
58
59		// public function testTraitSetupShuffleDeck()
60		// {
61		// $pokersquares = new PokerSquares();
62		//
63		// $pokersquares->shuffleDeck();
64
65		// $exp = 52;
66		// $res = count(session('deck'));
67		//
68		// $this->assertEquals($exp, 52);
69		//
70		// }
71
72		}
73

joki20 / dbwebb-mvc-proj

Push — master ( ac9ff0...806846 )

testTraitDeckReturnDeck() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like