Test Failed
Push — master ( ac9ff0...806846 )
by Johan
03:01
created

PokerSquaresCreateObjectTest   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 61
Duplicated Lines 11.48 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 5
lcom 1
cbo 2
dl 7
loc 61
rs 10
c 0
b 0
f 0

5 Methods

Rating   Name   Duplication   Size   Complexity  
A testCreateObjectPokerSquares() 0 5 1
A testEmptyPost() 0 8 1
A testTraitDeckName() 0 7 1
A testTraitDeckDeckSize() 7 7 1
A testTraitSetupName() 0 7 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
// php artisan test
4
namespace Tests\Unit;
5
6
use PHPUnit\Framework\TestCase;
7
use Joki20\Http\Controllers\PokerSquares;
8
use Joki20\Http\Controllers\Setup;
9
/**
10
 * Test cases for class Guess.
11
 */
12
class PokerSquaresCreateObjectTest extends TestCase
13
{
14
    // /**
15
    //  * Construct object and verify that the object is instance of class
16
    //  */
17
    public function testCreateObjectPokerSquares()
18
    {
19
        $pokersquares = new PokerSquares();
20
        $this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);
21
    }
22
23
    // /**
24
    //  * Test empty $_POST array
25
    //  */
26
    public function testEmptyPost()
27
    {
28
        $pokersquares = new PokerSquares();
29
        $this->assertInstanceOf("\Joki20\Http\Controllers\PokerSquares", $pokersquares);
30
31
        $exp = $pokersquares->game();
0 ignored issues
show
Bug introduced by
Are you sure the assignment to $exp is correct as $pokersquares->game() (which targets Joki20\Http\Controllers\PokerSquares::game()) seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
32
        $this->assertEquals($exp, null);
33
    }
34
35
    public function testTraitDeckName()
36
    {
37
        $pokersquares = new PokerSquares();
38
39
        $exp = strlen($pokersquares->name());
40
        $this->assertEquals($exp, 265);
41
    }
42
43 View Code Duplication
    public function testTraitDeckDeckSize()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
44
    {
45
        $pokersquares = new PokerSquares();
46
47
        $exp = $pokersquares->deckSize(['<div class="card rank08C">8 <br/> &clubs;</div>','<div class="card rank09C">9 <br/> &clubs;</div>',]);
48
        $this->assertEquals($exp, 2);
49
    }
50
51
    public function testTraitSetupName()
52
    {
53
        $pokersquares = new PokerSquares();
54
55
        $exp = strlen($pokersquares->name());
56
        $this->assertEquals($exp, 265);
57
    }
58
59
    // public function testTraitSetupShuffleDeck()
60
    // {
61
    //     $pokersquares = new PokerSquares();
62
    //
63
    //     $pokersquares->shuffleDeck();
64
65
        // $exp = 52;
66
        // $res = count(session('deck'));
67
        //
68
        // $this->assertEquals($exp, 52);
69
    //
70
    // }
71
72
}
73