johnvandeweghe / LunixREST

src/APIRequest/RequestData/JSONRequestData.php

Doc Comments +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
 
     /**
      * JSONRequestData constructor.
-     * @param $body
+     * @param string $body
      * @throws InvalidRequestDataException
      */
     public function __construct($body)
@@ -48,7 +48,7 @@ 
     /**
      * Attempts to find a specific key in the parsed data. Returns true if found else false
      * @param string $key
-     * @return mixed
+     * @return boolean
      */
     public function has(string $key): bool
     {

src/AccessControl/PublicAccessControl.php

Braces +3 added lines, -6 removed lines

@@ -8,14 +8,12 @@ 
  * Class PublicAccessControl
  * @package LunixREST\AccessControl
  */
-class PublicAccessControl implements AccessControl
-{
+class PublicAccessControl implements AccessControl {
     /**
      * @param \LunixREST\APIRequest\APIRequest $request
      * @return bool
      */
-    public function validateAccess(APIRequest $request)
-    {
+    public function validateAccess(APIRequest $request) {
         return true;
     }
 
@@ -23,8 +21,7 @@ 
      * @param $apiKey
      * @return bool
      */
-    public function validateKey($apiKey)
-    {
+    public function validateKey($apiKey) {
         return true;
     }
 }

src/AccessControl/OneKeyAccessControl.php

Braces +4 added lines, -8 removed lines

@@ -8,8 +8,7 @@ 
  * Class OneKeyAccessControl
  * @package LunixREST\AccessControl
  */
-class OneKeyAccessControl implements AccessControl
-{
+class OneKeyAccessControl implements AccessControl {
     /**
      * @var string
      */
@@ -18,8 +17,7 @@ 
     /**
      * @param string $key
      */
-    public function __construct($key)
-    {
+    public function __construct($key) {
         $this->key = $key;
     }
 
@@ -27,8 +25,7 @@ 
      * @param \LunixREST\APIRequest\APIRequest $request
      * @return bool true if key is valid
      */
-    public function validateAccess(APIRequest $request)
-    {
+    public function validateAccess(APIRequest $request) {
         return $this->validateKey($request->getApiKey());
     }
 
@@ -36,8 +33,7 @@ 
      * @param $apiKey
      * @return bool true if key is the key specified in the constructor
      */
-    public function validateKey($apiKey)
-    {
+    public function validateKey($apiKey) {
         return $apiKey === $this->key;
     }
 }

src/AccessControl/MultiAndAccessControl.php

Braces +3 added lines, -6 removed lines

@@ -8,14 +8,12 @@ 
  * Class MultiAccessControl
  * @package LunixREST\AccessControl
  */
-class MultiAndAccessControl extends MultiAccessControl
-{
+class MultiAndAccessControl extends MultiAccessControl {
     /**
      * @param \LunixREST\APIRequest\APIRequest $request
      * @return bool true if all of the $accessControls' validate access methods returned true for the given request
      */
-    public function validateAccess(APIRequest $request)
-    {
+    public function validateAccess(APIRequest $request) {
         foreach ($this->accessControls as $accessControl) {
             if (!$accessControl->validateAccess($request)) {
                 return false;
@@ -28,8 +26,7 @@ 
      * @param $apiKey
      * @return bool true if all of the $accessControls' validate key methods returned true for the given request
      */
-    public function validateKey($apiKey)
-    {
+    public function validateKey($apiKey) {
         foreach ($this->accessControls as $accessControl) {
             if (!$accessControl->validateKey($apiKey)) {
                 return false;

src/AccessControl/AllAccessConfigurationListAccessControl.php

Braces +4 added lines, -8 removed lines

@@ -9,8 +9,7 @@ 
  * Class AllAccessListAccessControl
  * @package LunixREST\AccessControl
  */
-class AllAccessConfigurationListAccessControl implements AccessControl
-{
+class AllAccessConfigurationListAccessControl implements AccessControl {
     /**
      * @var Configuration
      */
@@ -25,8 +24,7 @@ 
      * @param Configuration $config a config that has a list of valid keys in the stored $configKey
      * @param string $configKey key to use when accessing the list of valid keys from the $config
      */
-    public function __construct(Configuration $config, $configKey = 'keys')
-    {
+    public function __construct(Configuration $config, $configKey = 'keys') {
         $this->config = $config;
         $this->configKey = $configKey;
     }
@@ -35,8 +33,7 @@ 
      * @param \LunixREST\APIRequest\APIRequest $request
      * @return bool true if this key is valid
      */
-    public function validateAccess(APIRequest $request)
-    {
+    public function validateAccess(APIRequest $request) {
         return $this->validateKey($request->getApiKey());
     }
 
@@ -44,8 +41,7 @@ 
      * @param $apiKey
      * @return bool true if the key is found inside of the array returned by the config when $config->get is called with the key from the constructor
      */
-    public function validateKey($apiKey)
-    {
+    public function validateKey($apiKey) {
         return in_array($apiKey, $this->config->get($this->configKey));
     }
 }

src/AccessControl/AllAccessListAccessControl.php

Braces +4 added lines, -8 removed lines

@@ -9,8 +9,7 @@ 
  * Class AllAccessListAccessControl
  * @package LunixREST\AccessControl
  */
-class AllAccessListAccessControl implements AccessControl
-{
+class AllAccessListAccessControl implements AccessControl {
     /**
      * @var array
      */
@@ -19,8 +18,7 @@ 
     /**
      * @param array $keys
      */
-    public function __construct(Array $keys)
-    {
+    public function __construct(Array $keys) {
         $this->keys = $keys;
     }
 
@@ -28,8 +26,7 @@ 
      * @param \LunixREST\APIRequest\APIRequest $request
      * @return bool true if key is valid
      */
-    public function validateAccess(APIRequest $request)
-    {
+    public function validateAccess(APIRequest $request) {
         return $this->validateKey($request->getApiKey());
     }
 
@@ -37,8 +34,7 @@ 
      * @param $apiKey
      * @return bool true if key is in the array passed to this object in it's construction
      */
-    public function validateKey($apiKey)
-    {
+    public function validateKey($apiKey) {
         return in_array($apiKey, $this->keys);
     }
 }

src/Throttle/NoThrottle.php

Braces +2 added lines, -4 removed lines

@@ -3,8 +3,7 @@ 
 
 use LunixREST\APIRequest\APIRequest;
 
-class NoThrottle implements Throttle
-{
+class NoThrottle implements Throttle {
     /**
      * Never throttle
      * @param \LunixREST\APIRequest\APIRequest $request
@@ -19,8 +18,7 @@ 
      * Log that a request took place
      * @param \LunixREST\APIRequest\APIRequest $request
      */
-    public function logRequest(APIRequest $request)
-    {
+    public function logRequest(APIRequest $request) {
         //Do nothing
     }
 }

src/APIRequest/APIRequest.php

Spacing +3 added lines, -3 removed lines

@@ -55,10 +55,10 @@
     public function __construct(
         string $method,
         string $endpoint,
-        ?string $element,
+        ? string $element,
         array $acceptableMIMETypes,
-        ?string $version,
-        ?string $apiKey,
+        ? string $version,
+        ? string $apiKey,
         array $queryData,
         $data
     ) {

Braces +5 added lines, -10 removed lines

@@ -6,8 +6,7 @@ 
  * Class APIRequest
  * @package LunixREST\Request
  */
-class APIRequest
-{
+class APIRequest {
     /**
      * @var string
      */
@@ -91,8 +90,7 @@ 
     /**
      * @return null|string
      */
-    public function getElement()
-    {
+    public function getElement() {
         return $this->element;
     }
 
@@ -107,16 +105,14 @@ 
     /**
      * @return null|string
      */
-    public function getVersion()
-    {
+    public function getVersion() {
         return $this->version;
     }
 
     /**
      * @return null|string
      */
-    public function getApiKey()
-    {
+    public function getApiKey() {
         return $this->apiKey;
     }
 
@@ -131,8 +127,7 @@ 
     /**
      * @return array|null|object
      */
-    public function getData()
-    {
+    public function getData() {
         return $this->data;
     }
 }

src/APIRequest/RequestFactory/GenericRequestFactory.php

Spacing +2 added lines, -2 removed lines

@@ -47,13 +47,13 @@
         $parsedHeaders = $this->headerParser->parse($serverRequest->getHeaders());
 
         $urlQueryData = [];
-        if($urlQueryString = $parsedURL->getQueryString())
+        if ($urlQueryString = $parsedURL->getQueryString())
         {
             parse_str($parsedURL->getQueryString(), $urlQueryData);
         }
 
         $apiKey = $parsedURL->getAPIKey();
-        if($apiKey === null)
+        if ($apiKey === null)
         {
             $apiKey = $parsedHeaders->getAPIKey();
         }

Braces +3 added lines, -6 removed lines

@@ -28,8 +28,7 @@ 
      * @param URLParser $URLParser
      * @param HeaderParser $headerParser
      */
-    public function __construct(URLParser $URLParser, HeaderParser $headerParser)
-    {
+    public function __construct(URLParser $URLParser, HeaderParser $headerParser) {
         $this->URLParser = $URLParser;
         $this->headerParser = $headerParser;
     }
@@ -47,14 +46,12 @@ 
         $parsedHeaders = $this->headerParser->parse($serverRequest->getHeaders());
 
         $urlQueryData = [];
-        if($urlQueryString = $parsedURL->getQueryString())
-        {
+        if($urlQueryString = $parsedURL->getQueryString()) {
             parse_str($parsedURL->getQueryString(), $urlQueryData);
         }
 
         $apiKey = $parsedURL->getAPIKey();
-        if($apiKey === null)
-        {
+        if($apiKey === null) {
             $apiKey = $parsedHeaders->getAPIKey();
         }