TableController::initAction() - Code Metrics - johannaand/CHTMLTable - Measure and Improve Code Quality continuously with Scrutinizer

TableController::initAction() A
last analyzed 2016-02-20 21:03 UTC

↳ Parent: TableController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace Jovis\HTMLTable;
 
/**
 * A controller for creating a html table from a movie model.
 *
 */
class TableController implements \Anax\DI\IInjectionAware
{
    use \Anax\DI\TInjectable;
    
    private $model;
      
   /**
   * Lists all instances of the model, (databasetable) except for noListing.
   *
   * @param $noListing params not to be listed
   * @param $model model object to list (create an html table from) 
   *
   * @return void
   */
  public function listAction($noListing = NULL, $model)
  {

      $this->model = $model;
      $this->model->setDI($this->di);
   
      $all = $this->model->findAll();
      
      $aContent = array();
      
      //gör om arrayen av objekt till en array av arrayer
      foreach ($all as $key1=>$value) {

        foreach ($value as $key2=>$v){
          if (!in_array($key2, $noListing)) { //$noListing, parametrar som inte ska vara med
              $aContent[$key1][$key2] = $v;
          }
        }
      }
     
      
      $aHeading = [];
      //hittar objektens parametrar/tabellens kolumnnamn och skapar
      //en ny array av rubriker
      foreach ($all as $key1=>$value) {

        foreach ($value as $key2=>$v){
          if (!in_array($key2, $noListing)) { //$noListing, parametrar som inte ska vara med
              $aHeading[] = $key2;
          }
        }
        break;  
      }
      
      $chtml = new \Jovis\HTMLTable\CHTMLTable($aHeading, $aContent);
      
      $htmltable = $chtml->getTable();
      $source = $this->model->getSource();
      
   
      $this->theme->setTitle("Visa alla användare");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
      $this->views->add('table/list-all', [
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
          'title' => $source,
          'htmltable' => $htmltable,
      ]);
  }
  
   public function initAction($model){ //används för att befolka databasen, bara för att testa
    $model->setDI($this->di);
    $model->init();
  }
}


1		<?php
2
3		namespace Jovis\HTMLTable;
4
5		/**
6		* A controller for creating a html table from a movie model.
7		*
8		*/
9		class TableController implements \Anax\DI\IInjectionAware
10		{
11		use \Anax\DI\TInjectable;
12
13		private $model;
14
15		/**
16		* Lists all instances of the model, (databasetable) except for noListing.
17		*
18		* @param $noListing params not to be listed
19		* @param $model model object to list (create an html table from)
20		*
21		* @return void
22		*/
23		public function listAction($noListing = NULL, $model)
24		{
25
26		$this->model = $model;
27		$this->model->setDI($this->di);
28
29		$all = $this->model->findAll();
30
31		$aContent = array();
32
33		//gör om arrayen av objekt till en array av arrayer
34	View Code Duplication	foreach ($all as $key1=>$value) {
		0 ignored issues – show Duplication introduced 2016-02-16 12:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		foreach ($value as $key2=>$v){
36		if (!in_array($key2, $noListing)) { //$noListing, parametrar som inte ska vara med
37		$aContent[$key1][$key2] = $v;
38		}
39		}
40		}
41
42
43		$aHeading = [];
44		//hittar objektens parametrar/tabellens kolumnnamn och skapar
45		//en ny array av rubriker
46	View Code Duplication	foreach ($all as $key1=>$value) {
		0 ignored issues – show Duplication introduced 2016-02-16 12:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		foreach ($value as $key2=>$v){
48		if (!in_array($key2, $noListing)) { //$noListing, parametrar som inte ska vara med
49		$aHeading[] = $key2;
50		}
51		}
52		break;
53		}
54
55		$chtml = new \Jovis\HTMLTable\CHTMLTable($aHeading, $aContent);
56
57		$htmltable = $chtml->getTable();
58		$source = $this->model->getSource();
59
60
61		$this->theme->setTitle("Visa alla användare");
		0 ignored issues – show Documentation introduced 2016-02-16 12:46 UTC by Report Bug Copy Issue Report The property `theme` does not exist on `object<Jovis\HTMLTable\TableController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62		$this->views->add('table/list-all', [
		0 ignored issues – show Documentation introduced 2016-02-16 12:46 UTC by Report Bug Copy Issue Report The property `views` does not exist on `object<Jovis\HTMLTable\TableController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
63		'title' => $source,
64		'htmltable' => $htmltable,
65		]);
66		}
67
68		public function initAction($model){ //används för att befolka databasen, bara för att testa
69		$model->setDI($this->di);
70		$model->init();
71		}
72		}
73

johannaand / CHTMLTable

TableController::initAction() A last analyzed 2016-02-20 21:03 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

TableController::initAction() A
last analyzed 2016-02-20 21:03 UTC