Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class TableController implements \Anax\DI\IInjectionAware |
||
10 | { |
||
11 | use \Anax\DI\TInjectable; |
||
12 | |||
13 | private $model; |
||
14 | |||
15 | /** |
||
16 | * Lists all instances of the model, (databasetable) except for noListing. |
||
17 | * |
||
18 | * @param $noListing params not to be listed |
||
19 | * @param $model model object to list (create an html table from) |
||
20 | * |
||
21 | * @return void |
||
22 | */ |
||
23 | public function listAction($noListing = NULL, $model) |
||
67 | |||
68 | public function initAction($model){ //används för att befolka databasen, bara för att testa |
||
72 | } |
||
73 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.