Completed
Push — master ( 441e4c...7a0697 )
by Joe Nilson
16s queued 14s
created
Mod/SalesFooterMod.php 1 patch
Spacing   +20 added lines, -25 removed lines patch added patch discarded remove patch
@@ -29,19 +29,19 @@  discard block
 block discarded – undo
29 29
 
30 30
 class SalesFooterMod implements SalesModInterface
31 31
 {
32
-    public function apply(SalesDocument &$model, array $formData, User $user)
32
+    public function apply(SalesDocument & $model, array $formData, User $user)
33 33
     {
34 34
     }
35 35
 
36
-    public function applyBefore(SalesDocument &$model, array $formData, User $user)
36
+    public function applyBefore(SalesDocument & $model, array $formData, User $user)
37 37
     {
38 38
         if ($model->modelClassName() === 'FacturaCliente') {
39
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
40
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
41
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
42
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
43
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
44
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
39
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
40
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
41
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
42
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
43
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
44
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
45 45
         }
46 46
     }
47 47
 
@@ -119,18 +119,16 @@  discard block
 block discarded – undo
119 119
         $options = ['<option value="">------</option>'];
120 120
         foreach ($tipoComprobante as $row) {
121 121
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
122
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
123
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
122
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
124 123
         }
125 124
 
126 125
         $attributes = ($model->editable || $model->numeroncf === '') ?
127
-            'id="tipocomprobante" name="tipocomprobante" required="" onChange="verificarCorrelativoNCF(this.value,\'Ventas\')"' :
128
-            'disabled=""';
126
+            'id="tipocomprobante" name="tipocomprobante" required="" onChange="verificarCorrelativoNCF(this.value,\'Ventas\')"' : 'disabled=""';
129 127
 
130 128
         return '<div class="col-sm-3">'
131 129
             . '<div class="form-group">'
132 130
             . $i18n->trans('tipocomprobante')
133
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
131
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
134 132
             . '</div>'
135 133
             . '</div>';
136 134
     }
@@ -154,15 +152,14 @@  discard block
 block discarded – undo
154 152
         $options = ['<option value="">------</option>'];
155 153
         foreach ($tipoPago as $row) {
156 154
             $options[] = ($row->codigo === $invoiceTipoPago) ?
157
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
158
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
155
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
159 156
         }
160 157
 
161 158
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
162 159
         return '<div class="col-sm-2">'
163 160
             . '<div class="form-group">'
164 161
             . $i18n->trans('ncf-payment-type')
165
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
162
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
166 163
             . '</div>'
167 164
             . '</div>';
168 165
     }
@@ -180,15 +177,14 @@  discard block
 block discarded – undo
180 177
         $options = ['<option value="">------</option>'];
181 178
         foreach ($tipoMovimiento as $row) {
182 179
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
183
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
184
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
180
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
185 181
         }
186 182
 
187 183
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
188 184
         return '<div class="col-sm-3">'
189 185
             . '<div class="form-group">'
190 186
             . $i18n->trans('ncf-movement-type')
191
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
187
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
192 188
             . '</div>'
193 189
             . '</div>';
194 190
     }
@@ -206,15 +202,14 @@  discard block
 block discarded – undo
206 202
         $options = ['<option value="">------</option>'];
207 203
         foreach ($tipoAnulacion as $row) {
208 204
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
209
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
210
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
205
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
211 206
         }
212 207
 
213 208
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'disabled=""';
214 209
         return '<div class="col-sm-2">'
215 210
             . '<div class="form-group">'
216 211
             . $i18n->trans('ncf-cancellation-type')
217
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
212
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
218 213
             . '</div>'
219 214
             . '</div>';
220 215
     }
@@ -226,8 +221,8 @@  discard block
 block discarded – undo
226 221
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
227 222
             : '';
228 223
         return '<div class="col-sm-2">'
229
-            . '<div class="form-group">' . $i18n->trans('due-date')
230
-            . '<input type="date" ' . $attributes . ' value="' . $ncfFechaVencimiento . '" class="form-control"/>'
224
+            . '<div class="form-group">'.$i18n->trans('due-date')
225
+            . '<input type="date" '.$attributes.' value="'.$ncfFechaVencimiento.'" class="form-control"/>'
231 226
             . '</div>'
232 227
             . '</div>';
233 228
     }
@@ -238,7 +233,7 @@  discard block
 block discarded – undo
238 233
         return empty($model->codcliente) ? '' : '<div class="col-sm">'
239 234
             . '<div class="form-group">'
240 235
             . $i18n->trans('desc-numeroncf-sales')
241
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
236
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
242 237
             . '</div>'
243 238
             . '</div>';
244 239
     }
Please login to merge, or discard this patch.
Mod/PurchasesFooterMod.php 1 patch
Spacing   +22 added lines, -26 removed lines patch added patch discarded remove patch
@@ -29,19 +29,19 @@  discard block
 block discarded – undo
29 29
 
30 30
 class PurchasesFooterMod implements PurchasesModInterface
31 31
 {
32
-    public function apply(PurchaseDocument &$model, array $formData, User $user)
32
+    public function apply(PurchaseDocument & $model, array $formData, User $user)
33 33
     {
34 34
     }
35 35
 
36
-    public function applyBefore(PurchaseDocument &$model, array $formData, User $user)
36
+    public function applyBefore(PurchaseDocument & $model, array $formData, User $user)
37 37
     {
38 38
         if ($model->modelClassName() === 'FacturaProveedor') {
39
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
40
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
41
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
42
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
43
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
44
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
39
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
40
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
41
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
42
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
43
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
44
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
45 45
         }
46 46
     }
47 47
 
@@ -109,15 +109,14 @@  discard block
 block discarded – undo
109 109
         $options = ['<option value="">------</option>'];
110 110
         foreach ($tipoComprobante as $row) {
111 111
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
112
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
113
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
112
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
114 113
         }
115 114
 
116 115
         $attributes = ($model->editable || $model->numeroncf === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
117 116
         return '<div class="col-sm-3">'
118 117
             . '<div class="form-group">'
119 118
             . $i18n->trans('tipocomprobante')
120
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
119
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
121 120
             . '</div>'
122 121
             . '</div>';
123 122
     }
@@ -141,15 +140,14 @@  discard block
 block discarded – undo
141 140
         $options = ['<option value="">------</option>'];
142 141
         foreach ($tipoPago as $row) {
143 142
             $options[] = ($row->codigo === $invoiceTipoPago) ?
144
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
145
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
143
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
146 144
         }
147 145
 
148 146
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
149 147
         return '<div class="col-sm-2">'
150 148
             . '<div class="form-group">'
151 149
             . $i18n->trans('ncf-payment-type')
152
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
150
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
153 151
             . '</div>'
154 152
             . '</div>';
155 153
     }
@@ -167,15 +165,14 @@  discard block
 block discarded – undo
167 165
         $options = ['<option value="">------</option>'];
168 166
         foreach ($tipoMovimiento as $row) {
169 167
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
170
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
171
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
168
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
172 169
         }
173 170
 
174 171
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
175 172
         return '<div class="col-sm-3">'
176 173
             . '<div class="form-group">'
177 174
             . $i18n->trans('ncf-movement-type')
178
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
175
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
179 176
             . '</div>'
180 177
             . '</div>';
181 178
     }
@@ -193,15 +190,14 @@  discard block
 block discarded – undo
193 190
         $options = ['<option value="">------</option>'];
194 191
         foreach ($tipoAnulacion as $row) {
195 192
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
196
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
197
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
193
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
198 194
         }
199 195
 
200 196
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'name="ncftipoanulacion" readonly=""';
201 197
         return '<div class="col-sm-2">'
202 198
             . '<div class="form-group">'
203 199
             . $i18n->trans('ncf-cancellation-type')
204
-            . '<select ' . $attributes . ' class="form-control">' . implode('', $options) . '</select>'
200
+            . '<select '.$attributes.' class="form-control">'.implode('', $options).'</select>'
205 201
             . '</div>'
206 202
             . '</div>';
207 203
     }
@@ -213,9 +209,9 @@  discard block
 block discarded – undo
213 209
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
214 210
             : '';
215 211
         return '<div class="col-sm-2">'
216
-            . '<div class="form-group">' . $i18n->trans('due-date')
217
-            . '<input type="date" ' . $attributes . ' value="'
218
-            . $ncfFechaVencimiento . '" class="form-control"/>'
212
+            . '<div class="form-group">'.$i18n->trans('due-date')
213
+            . '<input type="date" '.$attributes.' value="'
214
+            . $ncfFechaVencimiento.'" class="form-control"/>'
219 215
             . '</div>'
220 216
             . '</div>';
221 217
     }
@@ -228,11 +224,11 @@  discard block
 block discarded – undo
228 224
             . '<div class="form-group">'
229 225
             . $i18n->trans('desc-numeroncf-purchases')
230 226
             . '<div class="input-group">'
231
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
227
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
232 228
             . '<div class="input-group-append">'
233
-            . '<button class="btn ' . $btnColor . ' btn-spin-action" id="btnVerifyNCF"'
229
+            . '<button class="btn '.$btnColor.' btn-spin-action" id="btnVerifyNCF"'
234 230
             . 'onclick="purchasesNCFVerify()" '
235
-            . 'title="' . $i18n->trans('verify-numproveedor')
231
+            . 'title="'.$i18n->trans('verify-numproveedor')
236 232
             . '" type="button">'
237 233
             . '<i id="iconBtnVerify" class="fas fa-search fa-fw"></i>'
238 234
             . '</button>'
Please login to merge, or discard this patch.
Translation/updater.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
 $files = [];
9 9
 $langs = 'ca_ES,cs_CZ,de_DE,en_EN,es_AR,es_CL,es_CO,es_CR,es_DO,es_EC,es_ES,es_GT,es_MX,es_PA,es_PE,es_UY,eu_ES,fr_FR,gl_ES,it_IT,pl_PL,pt_BR,pt_PT,va_ES';
10 10
 foreach (explode(',', $langs) as $lang) {
11
-    $files[] = $lang . '.json';
11
+    $files[] = $lang.'.json';
12 12
 }
13 13
 foreach (scandir(__DIR__, SCANDIR_SORT_ASCENDING) as $filename) {
14 14
     if (is_file($filename) && substr($filename, -5) === '.json' && false === in_array($filename, $files)) {
@@ -18,25 +18,25 @@  discard block
 block discarded – undo
18 18
 
19 19
 // download json from facturascripts.com
20 20
 foreach ($files as $filename) {
21
-    $url = "https://facturascripts.com/EditLanguage?action=json&idproject=176&code=" . substr($filename, 0, -5);
21
+    $url = "https://facturascripts.com/EditLanguage?action=json&idproject=176&code=".substr($filename, 0, -5);
22 22
     $newContent = file_get_contents($url);
23 23
     if (empty($newContent)) {
24 24
         if (file_exists($filename)) {
25 25
             unlink($filename);
26
-            echo "Remove " . $filename . "\n";
26
+            echo "Remove ".$filename."\n";
27 27
             continue;
28 28
         }
29 29
 
30
-        echo "Empty " . $filename . "\n";
30
+        echo "Empty ".$filename."\n";
31 31
         continue;
32 32
     }
33 33
 
34 34
     $oldContent = file_exists($filename) ? file_get_contents($filename) : '';
35 35
     if (strlen($newContent) > 10 && $newContent !== $oldContent) {
36
-        echo "Download " . $filename . "\n";
36
+        echo "Download ".$filename."\n";
37 37
         file_put_contents($filename, $newContent);
38 38
         continue;
39 39
     }
40 40
 
41
-    echo "Skip " . $filename . "\n";
41
+    echo "Skip ".$filename."\n";
42 42
 }
43 43
\ No newline at end of file
Please login to merge, or discard this patch.