Passed
Push — master ( 64fa2f...070c80 )
by Joe Nilson
01:41
created
Mod/PurchasesFooterMod.php 1 patch
Spacing   +28 added lines, -32 removed lines patch added patch discarded remove patch
@@ -31,21 +31,21 @@  discard block
 block discarded – undo
31 31
 
32 32
 class PurchasesFooterMod implements PurchasesModInterface
33 33
 {
34
-    public function apply(PurchaseDocument &$model, array $formData): void
34
+    public function apply(PurchaseDocument & $model, array $formData): void
35 35
     {
36 36
     }
37 37
 
38
-    public function applyBefore(PurchaseDocument &$model, array $formData): void
38
+    public function applyBefore(PurchaseDocument & $model, array $formData): void
39 39
     {
40 40
         if ($model->modelClassName() === 'FacturaProveedor') {
41
-            $model->numeroncf = isset($formData['numeroncf']) ? (string)$formData['numeroncf'] : $model->numeroncf;
42
-            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string)$formData['tipocomprobante'] : $model->tipocomprobante;
43
-            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string)$formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
-            $model->ncftipopago = isset($formData['ncftipopago']) ? (string)$formData['ncftipopago'] : $model->ncftipopago;
45
-            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string)$formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
-            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string)$formData['ncftipoanulacion'] : $model->ncftipoanulacion;
47
-            $model->ecf_fecha_firma = isset($formData['ecf_fecha_firma']) ? (string)$formData['ecf_fecha_firma'] : $model->ecf_fecha_firma;
48
-            $model->ecf_codigo_seguridad = isset($formData['ecf_codigo_seguridad']) ? (string)$formData['ecf_codigo_seguridad'] : $model->ecf_codigo_seguridad;
41
+            $model->numeroncf = isset($formData['numeroncf']) ? (string) $formData['numeroncf'] : $model->numeroncf;
42
+            $model->tipocomprobante = isset($formData['tipocomprobante']) ? (string) $formData['tipocomprobante'] : $model->tipocomprobante;
43
+            $model->ncffechavencimiento = isset($formData['ncffechavencimiento']) ? (string) $formData['ncffechavencimiento'] : $model->ncffechavencimiento;
44
+            $model->ncftipopago = isset($formData['ncftipopago']) ? (string) $formData['ncftipopago'] : $model->ncftipopago;
45
+            $model->ncftipomovimiento = isset($formData['ncftipomovimiento']) ? (string) $formData['ncftipomovimiento'] : $model->ncftipomovimiento;
46
+            $model->ncftipoanulacion = isset($formData['ncftipoanulacion']) ? (string) $formData['ncftipoanulacion'] : $model->ncftipoanulacion;
47
+            $model->ecf_fecha_firma = isset($formData['ecf_fecha_firma']) ? (string) $formData['ecf_fecha_firma'] : $model->ecf_fecha_firma;
48
+            $model->ecf_codigo_seguridad = isset($formData['ecf_codigo_seguridad']) ? (string) $formData['ecf_codigo_seguridad'] : $model->ecf_codigo_seguridad;
49 49
         }
50 50
     }
51 51
 
@@ -55,12 +55,12 @@  discard block
 block discarded – undo
55 55
 
56 56
     public function newBtnFields(): array
57 57
     {
58
-        return ['btnLoadXmlEcf','btnLoadXmlAck','btnLoadPdfEcf'];
58
+        return ['btnLoadXmlEcf', 'btnLoadXmlAck', 'btnLoadPdfEcf'];
59 59
     }
60 60
 
61 61
     public function newFields(): array
62 62
     {
63
-        return ['numeroncf', 'tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion', 'ecf_xml_firmado','ecf_fecha_firma','ecf_codigo_seguridad'];
63
+        return ['numeroncf', 'tipocomprobante', 'ncffechavencimiento', 'ncftipopago', 'ncftipomovimiento', 'ncftipoanulacion', 'ecf_xml_firmado', 'ecf_fecha_firma', 'ecf_codigo_seguridad'];
64 64
     }
65 65
 
66 66
     public function newModalFields(): array
@@ -143,15 +143,14 @@  discard block
 block discarded – undo
143 143
         $options = ['<option value="">------</option>'];
144 144
         foreach ($tipoComprobante as $row) {
145 145
             $options[] = ($row->tipocomprobante === $invoiceTipoComprobante) ?
146
-                '<option value="' . $row->tipocomprobante . '" selected="">' . $row->descripcion . '</option>' :
147
-                '<option value="' . $row->tipocomprobante . '">' . $row->descripcion . '</option>';
146
+                '<option value="'.$row->tipocomprobante.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->tipocomprobante.'">'.$row->descripcion.'</option>';
148 147
         }
149 148
 
150 149
         $attributes = ($model->editable || $model->numeroncf === '') ? 'name="tipocomprobante" required=""' : 'disabled=""';
151 150
         return '<div class="col-sm-3">'
152 151
             . '<div class="mb-3">'
153 152
             . $i18n->trans('tipocomprobante')
154
-            . '<select ' . $attributes . ' class="form-select">' . implode('', $options) . '</select>'
153
+            . '<select '.$attributes.' class="form-select">'.implode('', $options).'</select>'
155 154
             . '</div>'
156 155
             . '</div>';
157 156
     }
@@ -175,15 +174,14 @@  discard block
 block discarded – undo
175 174
         $options = ['<option value="">------</option>'];
176 175
         foreach ($tipoPago as $row) {
177 176
             $options[] = ($row->codigo === $invoiceTipoPago) ?
178
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
179
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
177
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
180 178
         }
181 179
 
182 180
         $attributes = $model->editable ? 'name="ncftipopago" required=""' : 'disabled=""';
183 181
         return '<div class="col-sm-2">'
184 182
             . '<div class="mb-3">'
185 183
             . $i18n->trans('ncf-payment-type')
186
-            . '<select ' . $attributes . ' class="form-select">' . implode('', $options) . '</select>'
184
+            . '<select '.$attributes.' class="form-select">'.implode('', $options).'</select>'
187 185
             . '</div>'
188 186
             . '</div>';
189 187
     }
@@ -201,15 +199,14 @@  discard block
 block discarded – undo
201 199
         $options = ['<option value="">------</option>'];
202 200
         foreach ($tipoMovimiento as $row) {
203 201
             $options[] = ($row->codigo === $invoiceTipoMovimiento) ?
204
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
205
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
202
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
206 203
         }
207 204
 
208 205
         $attributes = $model->editable ? 'name="ncftipomovimiento" required=""' : 'disabled=""';
209 206
         return '<div class="col-sm-3">'
210 207
             . '<div class="mb-3">'
211 208
             . $i18n->trans('ncf-movement-type')
212
-            . '<select ' . $attributes . ' class="form-select">' . implode('', $options) . '</select>'
209
+            . '<select '.$attributes.' class="form-select">'.implode('', $options).'</select>'
213 210
             . '</div>'
214 211
             . '</div>';
215 212
     }
@@ -227,15 +224,14 @@  discard block
 block discarded – undo
227 224
         $options = ['<option value="">------</option>'];
228 225
         foreach ($tipoAnulacion as $row) {
229 226
             $options[] = ($row->codigo === $invoiceTipoAnulacion) ?
230
-                '<option value="' . $row->codigo . '" selected="">' . $row->descripcion . '</option>' :
231
-                '<option value="' . $row->codigo . '">' . $row->descripcion . '</option>';
227
+                '<option value="'.$row->codigo.'" selected="">'.$row->descripcion.'</option>' : '<option value="'.$row->codigo.'">'.$row->descripcion.'</option>';
232 228
         }
233 229
 
234 230
         $attributes = $model->editable ? 'name="ncftipoanulacion"' : 'name="ncftipoanulacion" readonly=""';
235 231
         return '<div class="col-sm-2">'
236 232
             . '<div class="mb-3">'
237 233
             . $i18n->trans('ncf-cancellation-type')
238
-            . '<select ' . $attributes . ' class="form-select">' . implode('', $options) . '</select>'
234
+            . '<select '.$attributes.' class="form-select">'.implode('', $options).'</select>'
239 235
             . '</div>'
240 236
             . '</div>';
241 237
     }
@@ -247,9 +243,9 @@  discard block
 block discarded – undo
247 243
             ? date('Y-m-d', strtotime($model->ncffechavencimiento))
248 244
             : '';
249 245
         return '<div class="col-sm-2">'
250
-            . '<div class="mb-3">' . $i18n->trans('due-date')
251
-            . '<input type="date" ' . $attributes . ' value="'
252
-            . $ncfFechaVencimiento . '" class="form-control"/>'
246
+            . '<div class="mb-3">'.$i18n->trans('due-date')
247
+            . '<input type="date" '.$attributes.' value="'
248
+            . $ncfFechaVencimiento.'" class="form-control"/>'
253 249
             . '</div>'
254 250
             . '</div>';
255 251
     }
@@ -262,10 +258,10 @@  discard block
 block discarded – undo
262 258
             . '<div class="mb-3">'
263 259
             . $i18n->trans('desc-numeroncf-purchases')
264 260
             . '<div class="input-group">'
265
-            . '<input type="text" ' . $attributes . ' value="' . $model->numeroncf . '" class="form-control"/>'
266
-            . '<button class="btn ' . $btnColor . ' btn-spin-action" id="btnVerifyNCF"'
261
+            . '<input type="text" '.$attributes.' value="'.$model->numeroncf.'" class="form-control"/>'
262
+            . '<button class="btn '.$btnColor.' btn-spin-action" id="btnVerifyNCF"'
267 263
             . 'onclick="purchasesNCFVerify()" '
268
-            . 'title="' . $i18n->trans('verify-numproveedor')
264
+            . 'title="'.$i18n->trans('verify-numproveedor')
269 265
             . '" type="button">'
270 266
             . '<i id="iconBtnVerify" class="fa-solid fa-search fa-fw"></i>'
271 267
             . '</button>'
@@ -282,7 +278,7 @@  discard block
 block discarded – undo
282 278
             . '<div class="mb-4">'
283 279
             . $i18n->trans('desc-ecf_fecha_firma')
284 280
             . '<div class="input-group">'
285
-            . '<input type="datetime-local" ' . $attributes . ' value="' . $model->ecf_fecha_firma . '" class="form-control"/>'
281
+            . '<input type="datetime-local" '.$attributes.' value="'.$model->ecf_fecha_firma.'" class="form-control"/>'
286 282
             . '</div>'
287 283
             . '</div>'
288 284
             . '</div>';
@@ -296,7 +292,7 @@  discard block
 block discarded – undo
296 292
             . '<div class="mb-4">'
297 293
             . $i18n->trans('desc-ecf_codigo_seguridad')
298 294
             . '<div class="input-group">'
299
-            . '<input type="text" ' . $attributes . ' value="' . $model->ecf_codigo_seguridad . '" class="form-control"/>'
295
+            . '<input type="text" '.$attributes.' value="'.$model->ecf_codigo_seguridad.'" class="form-control"/>'
300 296
             . '</div>'
301 297
             . '</div>'
302 298
             . '</div>';
Please login to merge, or discard this patch.