MergeManager::setStrategy() - Code Metrics - Inspection of "Develop" - jobtech-dev/laravel-chunky - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#24)

by Filippo

created 2020-09-28 15:10 UTC

MergeManager::setStrategy() A

↳ Parent: MergeManager

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
nc	3
nop	1
dl	0
loc	9
rs	10
c	1
b	0
f	0

<?php

namespace Jobtech\LaravelChunky;

use Illuminate\Container\Container;
use Jobtech\LaravelChunky\Contracts\MergeManager as MergeManagerContract;
use Jobtech\LaravelChunky\Handlers\MergeHandler;
filter:
    dependency_paths: ["lib/*"]
use Jobtech\LaravelChunky\Strategies\Contracts\MergeStrategy;
use Jobtech\LaravelChunky\Support\MergeFilesystem;

class MergeManager implements MergeManagerContract
{
    /** @var ?MergeManager */
    private static $instance;

    /** @var \Jobtech\LaravelChunky\ChunkySettings */
    private ChunkySettings $settings;

    /** @var \Jobtech\LaravelChunky\Support\MergeFilesystem */
    private $mergeFilesystem;

    /**
     * @var \Jobtech\LaravelChunky\Handlers\MergeHandler|null
     */
    private ?MergeHandler $handler;


    public function __construct(ChunkySettings $settings)
    {
        $this->settings = $settings;
        $this->mergeFilesystem = MergeFilesystem::instance([
            'disk' => $settings->mergeDisk(),
            'folder' => $settings->mergeFolder(),
        ]);
    }

    private function defaultMergeStrategy()
    {
        return $this->settings->defaultMergeStrategy();
    }

    public function setStrategy($strategy = null): MergeManager
    {
        if ($strategy instanceof MergeStrategy) {
            $this->strategy = $strategy;

        } elseif ($strategy === null) {
            $this->defaultMergeStrategy();
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function mergeFilesystem(): MergeFilesystem
    {
        return $this->mergeFilesystem;
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeDisk(): ?string
    {
        return $this->settings
            ->mergeDisk();
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeFolder(): string
    {
        return $this->settings
            ->mergeFolder();
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeOptions(): array
    {
        return array_merge([
            'disk' => $this->getMergeDisk(),
        ], $this->settings->additionalMergeOptions());
    }

    /**
     * {@inheritdoc}
     */
    public function store(string $destination, $origin, $options = [])
    {
        return $this->mergeFilesystem->store($destination, $origin, $options);
    }

    /**
     * {@inheritdoc}
     */
    public function destinationPath(string $path): string
    {
        return $this->mergeFilesystem()->destinationPath($path);
    }

    public static function getInstance(): MergeManager
    {
        if (static::$instance === null) {

            static::$instance = Container::getInstance()->make(MergeManagerContract::class);
        }

        return static::$instance;

    }
}


1			<?php
2
3			namespace Jobtech\LaravelChunky;
4
5			use Illuminate\Container\Container;
6			use Jobtech\LaravelChunky\Contracts\MergeManager as MergeManagerContract;
7			use Jobtech\LaravelChunky\Handlers\MergeHandler;
			0 ignored issues – show Bug introduced 2020-09-28 15:23 UTC by Report Bug Copy Issue Report The type `Jobtech\LaravelChunky\Handlers\MergeHandler` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use Jobtech\LaravelChunky\Strategies\Contracts\MergeStrategy;
9			use Jobtech\LaravelChunky\Support\MergeFilesystem;
10
11			class MergeManager implements MergeManagerContract
12			{
13			/** @var ?MergeManager */
14			private static $instance;
15
16			/** @var \Jobtech\LaravelChunky\ChunkySettings */
17			private ChunkySettings $settings;
18
19			/** @var \Jobtech\LaravelChunky\Support\MergeFilesystem */
20			private $mergeFilesystem;
21
22			/**
23			* @var \Jobtech\LaravelChunky\Handlers\MergeHandler\|null
24			*/
25			private ?MergeHandler $handler;
			0 ignored issues – show introduced 2020-09-28 15:23 UTC by Report Bug Copy Issue Report The private property `$handler` is not used, and could be removed. Loading history...
26
27			public function __construct(ChunkySettings $settings)
28			{
29			$this->settings = $settings;
30			$this->mergeFilesystem = MergeFilesystem::instance([
31			'disk' => $settings->mergeDisk(),
32			'folder' => $settings->mergeFolder(),
33			]);
34			}
35
36			private function defaultMergeStrategy()
37			{
38			return $this->settings->defaultMergeStrategy();
39			}
40
41			public function setStrategy($strategy = null): MergeManager
42			{
43			if ($strategy instanceof MergeStrategy) {
44			$this->strategy = $strategy;
			0 ignored issues – show Bug Best Practice introduced 2020-09-28 15:23 UTC by Report Bug Copy Issue Report The property `strategy` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
45			} elseif ($strategy === null) {
46			$this->defaultMergeStrategy();
47			}
48
49			return $this;
50			}
51
52			/**
53			* {@inheritdoc}
54			*/
55			public function mergeFilesystem(): MergeFilesystem
56			{
57			return $this->mergeFilesystem;
58			}
59
60			/**
61			* {@inheritdoc}
62			*/
63			public function getMergeDisk(): ?string
64			{
65			return $this->settings
66			->mergeDisk();
67			}
68
69			/**
70			* {@inheritdoc}
71			*/
72			public function getMergeFolder(): string
73			{
74			return $this->settings
75			->mergeFolder();
76			}
77
78			/**
79			* {@inheritdoc}
80			*/
81			public function getMergeOptions(): array
82			{
83			return array_merge([
84			'disk' => $this->getMergeDisk(),
85			], $this->settings->additionalMergeOptions());
86			}
87
88			/**
89			* {@inheritdoc}
90			*/
91			public function store(string $destination, $origin, $options = [])
92			{
93			return $this->mergeFilesystem->store($destination, $origin, $options);
94			}
95
96			/**
97			* {@inheritdoc}
98			*/
99			public function destinationPath(string $path): string
100			{
101			return $this->mergeFilesystem()->destinationPath($path);
102			}
103
104			public static function getInstance(): MergeManager
105			{
106			if (static::$instance === null) {
			0 ignored issues – show Bug introduced 2020-09-28 15:23 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; you can either use `self`, or increase the visibility of `$instance` to at least protected. Loading history...
107			static::$instance = Container::getInstance()->make(MergeManagerContract::class);
108			}
109
110			return static::$instance;
			0 ignored issues – show Bug Best Practice introduced 2020-09-28 15:23 UTC by Report Bug Copy Issue Report The expression `return static::instance` could return the type `Jobtech\LaravelChunky\Contracts\MergeManager` which includes types incompatible with the type-hinted return `Jobtech\LaravelChunky\MergeManager`. Consider adding an additional type-check to rule them out. Loading history...
111			}
112			}
113

jobtech-dev / laravel-chunky

Pull Request — master (#24)

MergeManager::setStrategy() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like