Jobtech\LaravelChunky\MergeManager

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	7	2
A	getMergeFolder()	0	4	1
A	mergeFilesystem()	0	3	1
A	store()	0	3	1
A	__construct()	0	6	1
A	destinationPath()	0	3	1
A	defaultMergeStrategy()	0	3	1
A	setStrategy()	0	9	3
A	getMergeOptions()	0	5	1
A	getMergeDisk()	0	4	1

<?php

namespace Jobtech\LaravelChunky;

use Illuminate\Container\Container;
use Jobtech\LaravelChunky\Contracts\MergeManager as MergeManagerContract;
use Jobtech\LaravelChunky\Handlers\MergeHandler;

The type Jobtech\LaravelChunky\Handlers\MergeHandler was not found. Maybe you did not declare it correctly or list all dependencies?

use Jobtech\LaravelChunky\Strategies\Contracts\MergeStrategy;
use Jobtech\LaravelChunky\Support\MergeFilesystem;

class MergeManager implements MergeManagerContract
{
    /** @var ?MergeManager */
    private static $instance;

    /** @var \Jobtech\LaravelChunky\ChunkySettings */
    private ChunkySettings $settings;

    /** @var \Jobtech\LaravelChunky\Support\MergeFilesystem */
    private $mergeFilesystem;

    /**
     * @var \Jobtech\LaravelChunky\Handlers\MergeHandler|null
     */
    private ?MergeHandler $handler;

The private property $handler is not used, and could be removed.

    public function __construct(ChunkySettings $settings)
    {
        $this->settings = $settings;
        $this->mergeFilesystem = MergeFilesystem::instance([
            'disk' => $settings->mergeDisk(),
            'folder' => $settings->mergeFolder(),
        ]);
    }

    private function defaultMergeStrategy()
    {
        return $this->settings->defaultMergeStrategy();
    }

    public function setStrategy($strategy = null): MergeManager
    {
        if ($strategy instanceof MergeStrategy) {
            $this->strategy = $strategy;

The property strategy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        } elseif ($strategy === null) {
            $this->defaultMergeStrategy();
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function mergeFilesystem(): MergeFilesystem
    {
        return $this->mergeFilesystem;
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeDisk(): ?string
    {
        return $this->settings
            ->mergeDisk();
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeFolder(): string
    {
        return $this->settings
            ->mergeFolder();
    }

    /**
     * {@inheritdoc}
     */
    public function getMergeOptions(): array
    {
        return array_merge([
            'disk' => $this->getMergeDisk(),
        ], $this->settings->additionalMergeOptions());
    }

    /**
     * {@inheritdoc}
     */
    public function store(string $destination, $origin, $options = [])
    {
        return $this->mergeFilesystem->store($destination, $origin, $options);
    }

    /**
     * {@inheritdoc}
     */
    public function destinationPath(string $path): string
    {
        return $this->mergeFilesystem()->destinationPath($path);
    }

    public static function getInstance(): MergeManager
    {
        if (static::$instance === null) {

Since $instance is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $instance to at least protected.

            static::$instance = Container::getInstance()->make(MergeManagerContract::class);
        }

        return static::$instance;

The expression return static::instance could return the type Jobtech\LaravelChunky\Contracts\MergeManager which includes types incompatible with the type-hinted return Jobtech\LaravelChunky\MergeManager. Consider adding an additional type-check to rule them out.

    }
}