JMGQ\AStar\Benchmark\TerrainGenerator::generate()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function generate($rows, $columns, $seed = null)
    {
        $this->validatePositiveInteger($rows);
        $this->validatePositiveInteger($columns);
        $this->validateOptionalInteger($seed);

        mt_srand($seed);

It seems like $seed can also be of type null; however, parameter $seed of mt_srand() does only seem to accept integer, maybe add an additional type check?

        $terrainCost = array();

        foreach (range(0, $rows - 1) as $row) {
            foreach (range(0, $columns - 1) as $column) {
                $terrainCost[$row][$column] = mt_rand(1, 10);
            }
        }

        return new TerrainCost($terrainCost);
    }