JMGQ\AStar\Benchmark\TerrainGenerator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	validateOptionalInteger()	0	6	3
A	validatePositiveInteger()	0	6	2
A	generate()	0	17	3

<?php

namespace JMGQ\AStar\Benchmark;

use JMGQ\AStar\Example\Terrain\TerrainCost;

class TerrainGenerator
{
    /**
     * @param int $rows
     * @param int $columns
     * @param int | null $seed
     * @return TerrainCost
     */
    public function generate($rows, $columns, $seed = null)
    {
        $this->validatePositiveInteger($rows);
        $this->validatePositiveInteger($columns);
        $this->validateOptionalInteger($seed);

        mt_srand($seed);

It seems like $seed can also be of type null; however, parameter $seed of mt_srand() does only seem to accept integer, maybe add an additional type check?

        $terrainCost = array();

        foreach (range(0, $rows - 1) as $row) {
            foreach (range(0, $columns - 1) as $column) {
                $terrainCost[$row][$column] = mt_rand(1, 10);
            }
        }

        return new TerrainCost($terrainCost);
    }

    private function validatePositiveInteger($number)
    {
        $positiveInteger = filter_var($number, FILTER_VALIDATE_INT, array('options' => array('min_range' => 1)));

        if ($positiveInteger === false) {
            throw new \InvalidArgumentException('Invalid positive integer: ' . print_r($number, true));

Are you sure print_r($number, true) of type string|true can be used in concatenation?

        }
    }

    private function validateOptionalInteger($number)
    {
        $integer = filter_var($number, FILTER_VALIDATE_INT);

        if ($integer === false && $number !== null) {
            throw new \InvalidArgumentException('Invalid integer: ' . print_r($number, true));

Are you sure print_r($number, true) of type string|true can be used in concatenation?

        }
    }
}