Completed
Pull Request — master (#20)
by Jan
02:51
created
src/File.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 	/**
77 77
 	 * Moves file to new location / rename
78 78
 	 * @param string $destination path
79
-	 * @return bool
79
+	 * @return boolean|null
80 80
 	 * @throws Exception
81 81
 	 */
82 82
 	function move($destination)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 		// $readable = is_readable($file); // does not always return correct value for directories
67 67
 
68 68
 		$fp = @fopen($this->path, "r"); // must be file and must be readable
69
-		if($fp) {
69
+		if ($fp) {
70 70
 			fclose($fp);
71 71
 			return true;
72 72
 		}
Please login to merge, or discard this patch.
examples/example-deprecated.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 require '../vendor/autoload.php';
4
-echo $f = BigFileTools::fromPath(__FILE__)->getSize()." bytes";
5 4
\ No newline at end of file
5
+echo $f = BigFileTools::fromPath(__FILE__)->getSize() . " bytes";
6 6
\ No newline at end of file
Please login to merge, or discard this patch.
src/Driver/ComDriver.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,8 +22,9 @@
 block discarded – undo
22 22
 	{
23 23
 		// Use the Windows COM interface
24 24
 		$fsobj = new \COM('Scripting.FileSystemObject');
25
-		if (dirname($path) == '.')
26
-			$this->path = ((substr(getcwd(), -1) == DIRECTORY_SEPARATOR) ? getcwd() . basename($path) : getcwd() . DIRECTORY_SEPARATOR . basename($path));
25
+		if (dirname($path) == '.') {
26
+					$this->path = ((substr(getcwd(), -1) == DIRECTORY_SEPARATOR) ? getcwd() . basename($path) : getcwd() . DIRECTORY_SEPARATOR . basename($path));
27
+		}
27 28
 		$f = $fsobj->GetFile($path);
28 29
 		return BigInteger::of($f->Size);
29 30
 	}
Please login to merge, or discard this patch.
src/Driver/NativeSeekDriver.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,15 +32,15 @@
 block discarded – undo
32 32
 		// TODO: There is *hope* that ftell() or fseek() fails when file is over 4GB
33 33
 		// TODO: This really needs tests, any ideas how to test this in CI? (please let me know)
34 34
 
35
-		if($flockResult === false) {
35
+		if ($flockResult === false) {
36 36
 			throw new Exception("Couldn't get file lock. Operation abandoned.");
37 37
 		}
38 38
 
39
-		if($seekResult !== 0) {
39
+		if ($seekResult !== 0) {
40 40
 			throw new Exception("Seeking to end of file failed");
41 41
 		}
42 42
 
43
-		if($position === false) {
43
+		if ($position === false) {
44 44
 			throw new Exception("Cannot determine position in file. ftell() failed.");
45 45
 		}
46 46
 
Please login to merge, or discard this patch.
src/Utils.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 	{
27 27
 
28 28
 		$path = realpath($path);
29
-		if(!$path) {
29
+		if (!$path) {
30 30
 			// TODO: use hack like http://stackoverflow.com/questions/4049856/replace-phps-realpath or http://www.php.net/manual/en/function.realpath.php#84012
31 31
 			//       probably as optional feature that can be turned on when you know, what are you doing
32 32
 
Please login to merge, or discard this patch.
src/Driver/SizeDriverAggregator.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	 */
32 32
 	public function __construct(array $drivers)
33 33
 	{
34
-		foreach($drivers as $driver) {
34
+		foreach ($drivers as $driver) {
35 35
 			$this->addDriver($driver);
36 36
 		}
37 37
 	}
@@ -60,8 +60,8 @@  discard block
 block discarded – undo
60 60
 	public function getFileSize($path)
61 61
 	{
62 62
 		$this->lastExceptions = [];
63
-		foreach($this->drivers as $driver) {
64
-			try{
63
+		foreach ($this->drivers as $driver) {
64
+			try {
65 65
 				$result = $driver->getFileSize($path);
66 66
 				$this->lastUsedDriver = $driver;
67 67
 				return $result;
Please login to merge, or discard this patch.
src/Driver/SizeDriverFactory.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,12 +19,12 @@
 block discarded – undo
19 19
 	 */
20 20
 	public function __construct(array $drivers)
21 21
 	{
22
-		foreach($drivers as $driver) {
23
-			try{
24
-				if(is_callable($driver)) {
22
+		foreach ($drivers as $driver) {
23
+			try {
24
+				if (is_callable($driver)) {
25 25
 					$this->addDriver($driver());
26 26
 
27
-				} else if(class_exists($driver)) {
27
+				} else if (class_exists($driver)) {
28 28
 					$this->addDriver(new $driver());
29 29
 
30 30
 				} else {
Please login to merge, or discard this patch.
src/Exception.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Created by PhpStorm.
4
- * User: jkuchar1
5
- * Date: 1.2.2016
6
- * Time: 10:46
7
- */
3
+	 * Created by PhpStorm.
4
+	 * User: jkuchar1
5
+	 * Date: 1.2.2016
6
+	 * Time: 10:46
7
+	 */
8 8
 
9 9
 namespace BigFileTools;
10 10
 
Please login to merge, or discard this patch.
src/Driver/ExecDriver.php 2 patches
Doc Comments   +10 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 	 * Convert string into integer
47 47
 	 * Must be precise number, otherwise you will see and exception.
48 48
 	 *
49
-	 * @param $valueAsString
49
+	 * @param string $valueAsString
50 50
 	 * @return BigInteger
51 51
 	 * @throws Exception
52 52
 	 */
@@ -65,6 +65,9 @@  discard block
 block discarded – undo
65 65
 
66 66
 	}
67 67
 
68
+	/**
69
+	 * @param string $path
70
+	 */
68 71
 	private function getFileSizeWindows($path)
69 72
 	{
70 73
 		$escapedPath = escapeshellarg($path);
@@ -73,6 +76,9 @@  discard block
 block discarded – undo
73 76
 		);
74 77
 	}
75 78
 
79
+	/**
80
+	 * @param string $path
81
+	 */
76 82
 	private function getFileSizeLinux($path)
77 83
 	{
78 84
 		$escapedPath = escapeshellarg($path);
@@ -81,6 +87,9 @@  discard block
 block discarded – undo
81 87
 		);
82 88
 	}
83 89
 
90
+	/**
91
+	 * @param string $path
92
+	 */
84 93
 	private function getFileSizeMac($path)
85 94
 	{
86 95
 		$escapedPath = escapeshellarg($path);
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 			throw new PrerequisiteException("Exec function is disabled");
18 18
 		}
19 19
 
20
-		if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
20
+		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
21 21
 			$this->os = self::OS_WINDOWS;
22 22
 		} elseif (strtoupper(PHP_OS) == "DARWIN") {
23 23
 			$this->os = self::OS_MAC;
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 */
35 35
 	public function getFileSize($path)
36 36
 	{
37
-		switch($this->os) {
37
+		switch ($this->os) {
38 38
 			case self::OS_WINDOWS: return $this->getFileSizeWindows($path); break;
39 39
 			case self::OS_LINUX:   return $this->getFileSizeLinux($path); break;
40 40
 			case self::OS_MAC:     return $this->getFileSizeMac($path); break;
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 	 * @throws Exception
52 52
 	 */
53 53
 	private function convertToInteger($valueAsString) {
54
-		if(!is_string($valueAsString)) {
55
-			throw new Exception("Cannot convert to integer. Expected string, but got " . gettype($valueAsString). ".");
54
+		if (!is_string($valueAsString)) {
55
+			throw new Exception("Cannot convert to integer. Expected string, but got " . gettype($valueAsString) . ".");
56 56
 		}
57 57
 		$trimmedInput = trim($valueAsString);
58 58
 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 			return BigInteger::of($trimmedInput);
61 61
 
62 62
 		} catch (ArithmeticException $e) {
63
-			throw new Exception("Returned value cannot be converted to an integer.",0, $e);
63
+			throw new Exception("Returned value cannot be converted to an integer.", 0, $e);
64 64
 		}
65 65
 
66 66
 	}
Please login to merge, or discard this patch.