Completed
Pull Request — master (#157)
by
unknown
01:46
created
src/Drupal/Component/Utility/DriverNameMatcher.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
   /**
176 176
    * Matches an identifer against a machine name exactly.
177 177
    *
178
-   * @param string $identifer
178
+   * @param string $identifier
179 179
    *   The human-friendly name of the target.
180 180
    * @param string $machineName
181 181
    *   The machine name of the candidate.
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
   /**
194 194
    * Matches an identifer against a label exactly.
195 195
    *
196
-   * @param string $identifer
196
+   * @param string $identifier
197 197
    *   The human-friendly name of the target.
198 198
    * @param string $machineName
199 199
    *   The machine name of the candidate.
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
   /**
212 212
    * Matches an identifer against a machine name removing the prefix.
213 213
    *
214
-   * @param string $identifer
214
+   * @param string $identifier
215 215
    *   The human-friendly name of the target.
216 216
    * @param string $machineName
217 217
    *   The machine name of the candidate.
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
   /**
233 233
    * Matches an identifer against a machine name removing underscores from it.
234 234
    *
235
-   * @param string $identifer
235
+   * @param string $identifier
236 236
    *   The human-friendly name of the target.
237 237
    * @param string $machineName
238 238
    *   The machine name of the candidate.
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
   /**
252 252
    * Matches an identifer against a machine name, removing prefix & underscores.
253 253
    *
254
-   * @param string $identifer
254
+   * @param string $identifier
255 255
    *   The human-friendly name of the target.
256 256
    * @param string $machineName
257 257
    *   The machine name of the candidate.
Please login to merge, or discard this patch.
src/Drupal/Driver/Plugin/DriverEntityPluginDrupal8Base.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,11 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Drupal\Driver\Plugin;
4 4
 
5
-use Drupal\Component\Plugin\PluginBase;
6 5
 use Drupal\Driver\Exception\Exception;
7 6
 use Drupal\Driver\Wrapper\Field\DriverFieldInterface;
8
-use Symfony\Component\DependencyInjection\ContainerInterface;
9
-use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
10 7
 use Drupal\Core\Entity\EntityInterface;
11 8
 use Drupal\Driver\Wrapper\Field\DriverFieldDrupal8;
12 9
 use Drupal\Driver\Wrapper\Entity\DriverEntityInterface;
Please login to merge, or discard this patch.
src/Drupal/Driver/Wrapper/Entity/DriverEntityBase.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -496,6 +496,7 @@
 block discarded – undo
496 496
    * Sets the provisional entity plugin.
497 497
    *
498 498
    * @param \Drupal\Driver\Plugin\DriverEntityPluginInterface
499
+   * @param DriverEntityPluginInterface $plugin
499 500
    */
500 501
     protected function setProvisionalPlugin($plugin)
501 502
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use Drupal\Driver\Plugin\DriverEntityPluginManager;
8 8
 use Drupal\Driver\Plugin\DriverPluginManagerInterface;
9 9
 use Drupal\Driver\Wrapper\Field\DriverFieldInterface;
10
-use Drupal\Driver\Wrapper\Field\DriverFieldDrupal8;
11 10
 use Drupal\Component\Utility\DriverNameMatcher;
12 11
 
13 12
 /**
Please login to merge, or discard this patch.
src/Drupal/Driver/Wrapper/Entity/DriverEntityDrupal8.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Drupal\Driver\Wrapper\Entity;
4 4
 
5
-use Drupal\Driver\Wrapper\Field\DriverFieldDrupal8;
6 5
 use Drupal\Driver\Plugin\DriverPluginManagerInterface;
7 6
 use Drupal\Component\Utility\DriverNameMatcher;
8 7
 
Please login to merge, or discard this patch.
src/Drupal/Driver/Wrapper/Entity/DriverEntityWrapperInterface.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
   /**
64 64
    * Sets the entity bundle.
65 65
    *
66
-   * @param string $identifier
66
+   * @param string $identifer
67 67
    *   A string identifying the entity bundle.
68 68
    *
69 69
    * @return $this
@@ -88,6 +88,7 @@  discard block
 block discarded – undo
88 88
    *
89 89
    * @param \Drupal\Driver\Plugin\DriverEntityPluginInterface $plugin
90 90
    *   An instantiated driver entity plugin matching this entity.
91
+   * @return DriverEntityBase
91 92
    */
92 93
     public function setFinalPlugin($plugin);
93 94
 }
Please login to merge, or discard this patch.
src/Drupal/Driver/Wrapper/Field/DriverFieldBase.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -74,8 +74,6 @@
 block discarded – undo
74 74
    * @param mixed
75 75
    *   Raw values for the field. Typically an array, one for each value of a
76 76
    *   multivalue field, but can be single. Values are typically string.
77
-   * @param string $fieldName
78
-   *   The machine name of the field.
79 77
    * @param string $entityType
80 78
    *   The machine name of the entity type the field is attached to.
81 79
    * @param string $bundle
Please login to merge, or discard this patch.
src/Drupal/Driver/Wrapper/Field/DriverFieldDrupal8.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Drupal\Driver\Wrapper\Field;
4 4
 
5
-use Drupal\Driver\Plugin\DriverPluginManagerInterface;
6 5
 use Drupal\Core\Config\Entity\ConfigEntityInterface;
7 6
 use Drupal\Component\Utility\DriverNameMatcher;
8 7
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -49,6 +49,10 @@
 block discarded – undo
49 49
    */
50 50
     protected $version = 8;
51 51
 
52
+    /**
53
+     * @param string $entityType
54
+     * @param string $projectPluginRoot
55
+     */
52 56
     public function __construct(
53 57
         $rawValues,
54 58
         $fieldName,
Please login to merge, or discard this patch.
tests/Drupal/Tests/Driver/DriverPluginManagersTest.php 2 patches
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -190,10 +190,6 @@
 block discarded – undo
190 190
    *
191 191
    * @param array $target
192 192
    *   The properties to find a matching plugin for.
193
-   * @param array $mockFilters
194
-   *   The possible filters for the mocked plugin manager.
195
-   * @param array $mockCriteria
196
-   *   The specificity criteria for the mocked plugin manager.
197 193
    * @param array $mockDefinitions
198 194
    *   The plugins to be discovered by the mocked plugin manager.
199 195
    * @param array $expectedIds
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Drupal\Tests\Driver;
4 4
 
5
-use Drupal\Driver\Wrapper\Field\DriverFieldDrupal8;
6
-
7 5
 /**
8 6
  * Tests the Driver's plugin managers.
9 7
  */
Please login to merge, or discard this patch.
tests/Drupal/Tests/Driver/Kernel/Drupal8/Entity/DriverEntityTest.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -123,6 +123,8 @@
 block discarded – undo
123 123
 
124 124
   /**
125 125
    * Assert that an entity is created & wrapped with a specified name.
126
+   * @param string $fieldName
127
+   * @param DriverEntityDrupal8 $entity
126 128
    */
127 129
     protected function assertEntityWithName($value, $fieldName, $entity)
128 130
     {
Please login to merge, or discard this patch.