jfederico / moodle-mod_bigbluebuttonbn

classes/privacy/provider.php

Doc Comments +2 added lines

@@ -54,6 +54,7 @@ 
          * Get the list of users who have data within a context.
          *
          * @param   userlist $userlist The userlist containing the list of users who have data in this context/plugin combination.
+         * @return void
          */
         public static function get_users_in_context(userlist $userlist);
 
@@ -61,6 +62,7 @@ 
          * Delete multiple users within a single context.
          *
          * @param   approved_userlist       $userlist The approved context and user information to delete information for.
+         * @return void
          */
         public static function delete_data_for_users(approved_userlist $userlist);
     }

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /*
  * This part is to be eliminated as soon as possible but allows the phpunit test to pass Ok on MOODLE_33 and below WHILST allowing

locallib.php

Doc Comments +14 added lines, -14 removed lines

@@ -317,7 +317,7 @@ 
  * Helper function to retrieve imported recordings from the Moodle database.
  * The references are stored as events in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -345,7 +345,7 @@ 
 /**
  * Helper function to retrive the default config.xml file.
  *
- * @return string
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_get_default_config_xml() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
@@ -427,7 +427,7 @@ 
  * @param object $a
  * @param object $b
  *
- * @return array
+ * @return integer
  */
 function bigbluebuttonbn_recording_build_sorter($a, $b) {
     global $CFG;
@@ -541,7 +541,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     if (extension_loaded('curl')) {
@@ -582,7 +582,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return string
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
@@ -977,7 +977,7 @@ 
  * @param integer $instance
  * @param integer $voicebridge
  *
- * @return string
+ * @return boolean
  */
 function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) {
     global $DB;
@@ -1325,7 +1325,7 @@ 
  * @param string $meetingid
  * @param string $configxml
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
     $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
@@ -1379,7 +1379,7 @@ 
  * @param array $recording
  * @param array $tools
  *
- * @return array
+ * @return null|stdClass
  */
 function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) {
     if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) {
@@ -2016,7 +2016,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recording
- * @param object $rowdata
+ * @param stdClass $rowdata
  *
  * @return object
  */
@@ -2211,7 +2211,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recordings
- * @param array $tools
+ * @param string[] $tools
  *
  * @return array
  */
@@ -2292,7 +2292,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to deleted activities.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2316,7 +2316,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to imported recordings.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2339,7 +2339,7 @@ 
 /**
  * Helper function to get recordings and imported recordings together.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted
@@ -2357,7 +2357,7 @@ 
  * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events
  * in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted

Spacing +80 added lines, -80 removed lines

@@ -32,7 +32,7 @@ 
 
 global $CFG;
 
-require_once(__DIR__ . '/lib.php');
+require_once(__DIR__.'/lib.php');
 
 /** @var BIGBLUEBUTTONBN_UPDATE_CACHE boolean set to true indicates that cache has to be updated */
 const BIGBLUEBUTTONBN_UPDATE_CACHE = true;
@@ -145,8 +145,8 @@ 
     $data = null;
     if (!is_null($pname) && !is_null($purl)) {
         $method = 'POST';
-        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
-            $purl . "' /></module></modules>";
+        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
+            $purl."' /></module></modules>";
     }
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $data);
     if ($xml) {
@@ -242,8 +242,8 @@ 
             || defined('BEHAT_UTIL')) {
         // Just return the fake recording.
         global $CFG;
-        require_once($CFG->libdir . '/testing/generator/lib.php');
-        require_once(__DIR__ . '/tests/generator/lib.php');
+        require_once($CFG->libdir.'/testing/generator/lib.php');
+        require_once(__DIR__.'/tests/generator/lib.php');
         return mod_bigbluebuttonbn_generator::bigbluebuttonbn_get_recordings_array_fetch($meetingidsarray);
     }
     $recordings = array();
@@ -416,7 +416,7 @@ 
         if (is_object($value)) {
             $value = '';
         }
-        $metadataarray['meta_' . $key] = $value;
+        $metadataarray['meta_'.$key] = $value;
     }
     return $metadataarray;
 }
@@ -556,7 +556,7 @@ 
             return $xml;
         } catch (Exception $e) {
             libxml_use_internal_errors($previous);
-            $error = 'Caught exception: ' . $e->getMessage();
+            $error = 'Caught exception: '.$e->getMessage();
             debugging($error, DEBUG_DEVELOPER);
             return null;
         }
@@ -567,7 +567,7 @@ 
         $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS);
         return $response;
     } catch (Exception $e) {
-        $error = 'Caught exception: ' . $e->getMessage();
+        $error = 'Caught exception: '.$e->getMessage();
         debugging($error, DEBUG_DEVELOPER);
         libxml_use_internal_errors($previous);
         return null;
@@ -586,7 +586,7 @@ 
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
-    require_once($CFG->libdir . '/filelib.php');
+    require_once($CFG->libdir.'/filelib.php');
     $c = new curl();
     $c->setopt(array('SSL_VERIFYPEER' => true));
     if ($method == 'POST') {
@@ -595,8 +595,8 @@ 
         }
         $options = array();
         $options['CURLOPT_HTTPHEADER'] = array(
-            'Content-Type: ' . $contenttype,
-            'Content-Length: ' . strlen($data),
+            'Content-Type: '.$contenttype,
+            'Content-Length: '.strlen($data),
             'Content-Language: en-US',
         );
 
@@ -617,7 +617,7 @@ 
  * @return void
  */
 function bigbluebuttonbn_end_meeting_if_running($bigbluebuttonbn) {
-    $meetingid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
+    $meetingid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
     if (bigbluebuttonbn_is_meeting_running($meetingid)) {
         bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass);
     }
@@ -637,9 +637,9 @@ 
     if ($userroles) {
         $where = '';
         foreach ($userroles as $userrole) {
-            $where .= (empty($where) ? ' WHERE' : ' OR') . ' id=' . $userrole->roleid;
+            $where .= (empty($where) ? ' WHERE' : ' OR').' id='.$userrole->roleid;
         }
-        $userroles = $DB->get_records_sql('SELECT * FROM {role}' . $where);
+        $userroles = $DB->get_records_sql('SELECT * FROM {role}'.$where);
     }
     return $userroles;
 }
@@ -984,9 +984,9 @@ 
     if ($voicebridge == 0) {
         return true;
     }
-    $select = 'voicebridge = ' . $voicebridge;
+    $select = 'voicebridge = '.$voicebridge;
     if ($instance != 0) {
-        $select .= ' AND id <>' . $instance;
+        $select .= ' AND id <>'.$instance;
     }
     if (!$DB->get_records_select('bigbluebuttonbn', $select)) {
         return true;
@@ -1122,7 +1122,7 @@ 
 function bigbluebuttonbn_generate_nonce() {
     $mt = microtime();
     $rand = mt_rand();
-    return md5($mt . $rand);
+    return md5($mt.$rand);
 }
 
 /**
@@ -1170,7 +1170,7 @@ 
         $params['other'] = $options['other'];
     }
     $event = call_user_func_array(
-        '\mod_bigbluebuttonbn\event\\' . $type . '::create',
+        '\mod_bigbluebuttonbn\event\\'.$type.'::create',
         array($params)
     );
     $event->add_record_snapshot('course_modules', $cm);
@@ -1328,7 +1328,7 @@ 
  * @return object
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
-    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
+    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url').'api/setConfigXML?';
     $configxmlparams = bigbluebuttonbn_set_config_xml_params($meetingid, $configxml);
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         $urldefaultconfig,
@@ -1348,9 +1348,9 @@ 
  * @return string
  */
 function bigbluebuttonbn_set_config_xml_params($meetingid, $configxml) {
-    $params = 'configXML=' . urlencode($configxml) . '&meetingID=' . urlencode($meetingid);
+    $params = 'configXML='.urlencode($configxml).'&meetingID='.urlencode($meetingid);
     $sharedsecret = \mod_bigbluebuttonbn\locallib\config::get('shared_secret');
-    $configxmlparams = $params . '&checksum=' . sha1('setConfigXML' . $params . $sharedsecret);
+    $configxmlparams = $params.'&checksum='.sha1('setConfigXML'.$params.$sharedsecret);
     return $configxmlparams;
 }
 
@@ -1456,7 +1456,7 @@ 
     global $USER;
     $starttime = $starttime - ($starttime % 1000);
     // Set formatted date.
-    $dateformat = get_string('strftimerecentfull', 'langconfig') . ' %Z';
+    $dateformat = get_string('strftimerecentfull', 'langconfig').' %Z';
     return userdate($starttime / 1000, $dateformat, usertimezone($USER->timezone));
 }
 
@@ -1504,11 +1504,11 @@ 
         $actionbar .= bigbluebuttonbn_actionbar_render_button($recording, $buttonpayload);
     }
     $head = html_writer::start_tag('div', array(
-        'id' => 'recording-actionbar-' . $recording['recordID'],
+        'id' => 'recording-actionbar-'.$recording['recordID'],
         'data-recordingid' => $recording['recordID'],
         'data-meetingid' => $recording['meetingID']));
     $tail = html_writer::end_tag('div');
-    return $head . $actionbar . $tail;
+    return $head.$actionbar.$tail;
 }
 
 /**
@@ -1572,7 +1572,7 @@ 
  * @return string
  */
 function bigbluebuttonbn_get_recording_data_row_preview($recording) {
-    $options = array('id' => 'preview-' . $recording['recordID']);
+    $options = array('id' => 'preview-'.$recording['recordID']);
     if ($recording['published'] === 'false') {
         $options['hidden'] = 'hidden';
     }
@@ -1604,7 +1604,7 @@ 
         $recordingpreview .= html_writer::start_tag('div', array('class' => ''));
         $recordingpreview .= html_writer::empty_tag(
             'img',
-            array('src' => trim($image['url']) . '?' . time(), 'class' => 'recording-thumbnail pull-left')
+            array('src' => trim($image['url']).'?'.time(), 'class' => 'recording-thumbnail pull-left')
         );
         $recordingpreview .= html_writer::end_tag('div');
     }
@@ -1639,7 +1639,7 @@ 
     if ($recording['published'] === 'false') {
         $visibility = 'hidden ';
     }
-    $id = 'playbacks-' . $recording['recordID'];
+    $id = 'playbacks-'.$recording['recordID'];
     $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported,
         'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
         'title' => $title, $visibility => $visibility));
@@ -1665,13 +1665,13 @@ 
         return '';
     }
     $text = bigbluebuttonbn_get_recording_type_text($playback['type']);
-    $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id .
-        '&mid=' . $recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
+    $href = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=play&bn='.$bbbsession['bigbluebuttonbn']->id.
+        '&mid='.$recording['meetingID'].'&rid='.$recording['recordID'].'&rtype='.$playback['type'];
     if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') {
-        $href .= '&href=' . urlencode(trim($playback['url']));
+        $href .= '&href='.urlencode(trim($playback['url']));
     }
     $linkattributes = array(
-        'id' => 'recording-play-' . $playback['type'] . '-' . $recording['recordID'],
+        'id' => 'recording-play-'.$playback['type'].'-'.$recording['recordID'],
         'class' => 'btn btn-sm btn-default',
         'onclick' => 'M.mod_bigbluebuttonbn.recordings.recordingPlay(this);',
         'data-action' => 'play',
@@ -1683,7 +1683,7 @@ 
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');
         unset($linkattributes['data-href']);
     }
-    return $OUTPUT->action_link('#', $text, null, $linkattributes) . '&#32;';
+    return $OUTPUT->action_link('#', $text, null, $linkattributes).'&#32;';
 }
 
 /**
@@ -1696,7 +1696,7 @@ 
 function bigbluebuttonbn_get_recording_type_text($playbacktype) {
     // Check first if string exists, and if it does'nt just default to the capitalised version of the string.
     $text = ucwords($playbacktype);
-    $typestringid = 'view_recording_format_' . $playbacktype;
+    $typestringid = 'view_recording_format_'.$playbacktype;
     if (get_string_manager()->string_exists($typestringid, 'bigbluebuttonbn')) {
         $text = get_string($typestringid, 'bigbluebuttonbn');
     }
@@ -1726,7 +1726,7 @@ 
     $validatedurls[$urlhost] = true;
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($url, 'HEAD');
     if (!isset($curlinfo['http_code']) || $curlinfo['http_code'] != 200) {
-        $error = "Resources hosted by " . $urlhost . " are unreachable. Server responded with code " . $curlinfo['http_code'];
+        $error = "Resources hosted by ".$urlhost." are unreachable. Server responded with code ".$curlinfo['http_code'];
         debugging($error, DEBUG_DEVELOPER);
         $validatedurls[$urlhost] = false;
     }
@@ -1817,12 +1817,12 @@ 
  * @return string
  */
 function bigbluebuttonbn_get_recording_data_row_text($recording, $text, $source, $data) {
-    $htmltext = '<span>' . htmlentities($text) . '</span>';
+    $htmltext = '<span>'.htmlentities($text).'</span>';
     if (empty($data)) {
         return $htmltext;
     }
-    $target = $data['action'] . '-' . $data['target'];
-    $id = 'recording-' . $target . '-' . $data['recordingid'];
+    $target = $data['action'].'-'.$data['target'];
+    $id = 'recording-'.$target.'-'.$data['recordingid'];
     $attributes = array('id' => $id, 'class' => 'quickeditlink col-md-20',
         'data-recordingid' => $data['recordingid'], 'data-meetingid' => $data['meetingid'],
         'data-target' => $data['target'], 'data-source' => $source);
@@ -1830,7 +1830,7 @@ 
     $tail = html_writer::end_tag('div');
     $payload = array('action' => $data['action'], 'tag' => $data['tag'], 'target' => $data['target']);
     $htmllink = bigbluebuttonbn_actionbar_render_button($recording, $payload);
-    return $head . $htmltext . $htmllink . $tail;
+    return $head.$htmltext.$htmllink.$tail;
 }
 
 /**
@@ -1848,10 +1848,10 @@ 
     }
     $target = $data['action'];
     if (isset($data['target'])) {
-        $target .= '-' . $data['target'];
+        $target .= '-'.$data['target'];
     }
-    $id = 'recording-' . $target . '-' . $recording['recordID'];
-    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this);';
+    $id = 'recording-'.$target.'-'.$recording['recordID'];
+    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording'.ucfirst($data['action']).'(this);';
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
         // With icon for $manageaction.
         $iconattributes = array('id' => $id, 'class' => 'iconsmall');
@@ -1866,13 +1866,13 @@ 
             );
         }
         if (isset($data['disabled'])) {
-            $iconattributes['class'] .= ' fa-' . $data['disabled'];
+            $iconattributes['class'] .= ' fa-'.$data['disabled'];
             $linkattributes['class'] = 'disabled';
             unset($linkattributes['onclick']);
         }
         $icon = new pix_icon(
-            'i/' . $data['tag'],
-            get_string('view_recording_list_actionbar_' . $data['action'], 'bigbluebuttonbn'),
+            'i/'.$data['tag'],
+            get_string('view_recording_list_actionbar_'.$data['action'], 'bigbluebuttonbn'),
             'moodle',
             $iconattributes
         );
@@ -1967,7 +1967,7 @@ 
     if ($bbbsession['managerecordings']) {
         $table->head[] = get_string('view_recording_actionbar', 'bigbluebuttonbn');
         $table->align[] = 'left';
-        $table->size[] = (count($tools) * 40) . 'px';
+        $table->size[] = (count($tools) * 40).'px';
     }
     // Get the groups of the user.
     $usergroups = groups_get_all_groups($bbbsession['course']->id, $bbbsession['userID']);
@@ -2022,7 +2022,7 @@ 
  */
 function bigbluebuttonbn_get_recording_table_row($bbbsession, $recording, $rowdata) {
     $row = new html_table_row();
-    $row->id = 'recording-tr-' . $recording['recordID'];
+    $row->id = 'recording-tr-'.$recording['recordID'];
     $row->attributes['data-imported'] = 'false';
     $texthead = '';
     $texttail = '';
@@ -2034,13 +2034,13 @@ 
     }
     $rowdata->date_formatted = str_replace(' ', '&nbsp;', $rowdata->date_formatted);
     $row->cells = array();
-    $row->cells[] = $texthead . $rowdata->playback . $texttail;
-    $row->cells[] = $texthead . $rowdata->recording . $texttail;
-    $row->cells[] = $texthead . $rowdata->description . $texttail;
+    $row->cells[] = $texthead.$rowdata->playback.$texttail;
+    $row->cells[] = $texthead.$rowdata->recording.$texttail;
+    $row->cells[] = $texthead.$rowdata->description.$texttail;
     if (bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession)) {
         $row->cells[] = $rowdata->preview;
     }
-    $row->cells[] = $texthead . $rowdata->date_formatted . $texttail;
+    $row->cells[] = $texthead.$rowdata->date_formatted.$texttail;
     $row->cells[] = $rowdata->duration_formatted;
     if ($bbbsession['managerecordings']) {
         $row->cells[] = $rowdata->actionbar;
@@ -2131,7 +2131,7 @@ 
         // Enqueue it.
         \core\task\manager::queue_adhoc_task($task);
     } catch (Exception $e) {
-        mtrace("Error while enqueuing completion_update_state task. " . (string) $e);
+        mtrace("Error while enqueuing completion_update_state task. ".(string) $e);
     }
 }
 
@@ -2299,17 +2299,17 @@ 
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
  */
 function bigbluebuttonbn_get_recordings_deleted_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_DELETE . "' AND meta like '%has_recordings%' AND meta like '%true%'";
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_DELETE."' AND meta like '%has_recordings%' AND meta like '%true%'";
     if (empty($courseid)) {
         $courseid = 0;
     }
     if (empty($bigbluebuttonbnid)) {
-        return $sql . " AND courseid = {$courseid}";
+        return $sql." AND courseid = {$courseid}";
     }
     if ($subset) {
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
     }
-    return $sql . " AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
+    return $sql." AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
 }
 
 /**
@@ -2323,17 +2323,17 @@ 
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
  */
 function bigbluebuttonbn_get_recordings_imported_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_IMPORT . "'";
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_IMPORT."'";
     if (empty($courseid)) {
         $courseid = 0;
     }
     if (empty($bigbluebuttonbnid)) {
-        return $sql . " AND courseid = '{$courseid}'";
+        return $sql." AND courseid = '{$courseid}'";
     }
     if ($subset) {
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
     }
-    return $sql . " AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
+    return $sql." AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
 }
 
 /**
@@ -2392,7 +2392,7 @@ 
     }
     // Prepare select for loading records based on existent bigbluebuttonbns.
     $sql = 'SELECT DISTINCT meetingid, bigbluebuttonbnid FROM {bigbluebuttonbn_logs} WHERE ';
-    $sql .= '(bigbluebuttonbnid=' . implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)) . ')';
+    $sql .= '(bigbluebuttonbnid='.implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)).')';
     // Include only Create events and exclude those with record not true.
     $sql .= ' AND log = ? AND meta LIKE ? AND meta LIKE ?';
     // Execute select for loading records based on existent bigbluebuttonbns.
@@ -2577,8 +2577,8 @@ 
     require_once($CFG->dirroot.'/calendar/lib.php');
     $activitytime = '';
     if ($time) {
-        $activitytime = calendar_day_representation($time) . ' ' .
-        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn') . ' ' .
+        $activitytime = calendar_day_representation($time).' '.
+        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
         calendar_time_representation($time);
     }
     return $activitytime;
@@ -3127,16 +3127,16 @@ 
         return $output;
     }
     $output .= $OUTPUT->box_start(
-        'box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
+        'box boxalignleft adminerror alert alert-'.$type.' alert-block fade in',
         'bigbluebuttonbn_view_general_warning'
-    ) . "\n";
-    $output .= '    ' . $message . "\n";
-    $output .= '  <div class="singlebutton pull-right">' . "\n";
+    )."\n";
+    $output .= '    '.$message."\n";
+    $output .= '  <div class="singlebutton pull-right">'."\n";
     if (!empty($href)) {
         $output .= bigbluebuttonbn_render_warning_button($href, $text, $class);
     }
-    $output .= '  </div>' . "\n";
-    $output .= $OUTPUT->box_end() . "\n";
+    $output .= '  </div>'."\n";
+    $output .= $OUTPUT->box_end()."\n";
     return $output;
 }
 
@@ -3160,11 +3160,11 @@ 
     if ($class == '') {
         $class = 'btn btn-secondary';
     }
-    $output = '  <form method="post" action="' . $href . '" class="form-inline">' . "\n";
-    $output .= '      <button type="submit" class="' . $class . '"' . "\n";
-    $output .= '          title="' . $title . '"' . "\n";
-    $output .= '          >' . $text . '</button>' . "\n";
-    $output .= '  </form>' . "\n";
+    $output = '  <form method="post" action="'.$href.'" class="form-inline">'."\n";
+    $output .= '      <button type="submit" class="'.$class.'"'."\n";
+    $output .= '          title="'.$title.'"'."\n";
+    $output .= '          >'.$text.'</button>'."\n";
+    $output .= '  </form>'."\n";
     return $output;
 }
 
@@ -3228,7 +3228,7 @@ 
 function bigbluebuttonbn_user_can_join_meeting($bigbluebuttonbn, $mid = null, $userid = null) {
     // By default, use a meetingid without groups.
     if (empty($mid)) {
-        $mid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
+        $mid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
     }
     // When meeting is running, all authorized users can join right in.
     if (bigbluebuttonbn_is_meeting_running($mid)) {
@@ -3297,7 +3297,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_has_html5_client() {
-    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root() . "html5client/check";
+    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root()."html5client/check";
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($checkurl, 'HEAD');
     return (isset($curlinfo['http_code']) && $curlinfo['http_code'] == 200);
 }
@@ -3325,7 +3325,7 @@ 
     $bbbsession['modPW'] = $bbbsession['bigbluebuttonbn']->moderatorpass;
     $bbbsession['viewerPW'] = $bbbsession['bigbluebuttonbn']->viewerpass;
     // Database info related to the activity.
-    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid . '-' . $bbbsession['course']->id . '-' .
+    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'.
     $bbbsession['bigbluebuttonbn']->id;
     $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name;
     $bbbsession['meetingdescription'] = $bbbsession['bigbluebuttonbn']->intro;
@@ -3357,12 +3357,12 @@ 
     if ($bbbsession['bigbluebuttonbn']->record) {
         // Check if is enable record all from start.
         if ($bbbsession['recordallfromstart']) {
-            $bbbsession['welcome'] .= '<br><br>' . get_string(
+            $bbbsession['welcome'] .= '<br><br>'.get_string(
                 'bbbrecordallfromstartwarning',
                 'bigbluebuttonbn'
             );
         } else {
-            $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
+            $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
         }
     }
     $bbbsession['openingtime'] = $bbbsession['bigbluebuttonbn']->openingtime;
@@ -3377,7 +3377,7 @@ 
     $bbbsession['originServerName'] = $parsedurl['host'];
     $bbbsession['originServerUrl'] = $CFG->wwwroot;
     $bbbsession['originServerCommonName'] = '';
-    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
+    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
     $bbbsession['bnserver'] = bigbluebuttonbn_is_bn_server();
     // Setting for clienttype, assign flash if not enabled, or default if not editable.
     $bbbsession['clienttype'] = BIGBLUEBUTTON_CLIENTTYPE_FLASH;
@@ -3484,7 +3484,7 @@ 
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
         $metadata["bn-recording-status"] = json_encode(
             array(
-                'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'),
+                'email' => array('"'.fullname($USER).'" <'.$USER->email.'>'),
                 'context' => $bbbsession['bigbluebuttonbnURL'],
             )
         );

lib.php

Indentation +4 added lines, -4 removed lines

@@ -356,7 +356,7 @@ 
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
     $result = $DB->count_records_sql($sql, array($course->id, $bigbluebuttonbn->id, $user->id,
-                                              BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
+                                                BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
     return $result;
 }
 
@@ -589,12 +589,12 @@ 
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
     $str .= '  </div>'."\n";
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
         '</div>'."\n";
     $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-      .'</div>'."\n";
+        .'</div>'."\n";
     $str .= '</div>'."\n";
     return $str;
 }
@@ -836,7 +836,7 @@ 
             'bigbluebuttonbn',
             $bigbluebuttonbn->id,
             $bigbluebuttonbn->completionexpected
-          );
+            );
     }
 }
 

mod_form.php

Spacing +11 added lines, -11 removed lines

@@ -99,8 +99,8 @@ 
         $PAGE->requires->strings_for_js(array_keys(bigbluebuttonbn_get_strings_for_js()), 'bigbluebuttonbn');
         $jsvars['participantData'] = bigbluebuttonbn_get_participant_data($context, $bigbluebuttonbn);
         $jsvars['participantList'] = $participantlist;
-        $jsvars['iconsEnabled'] = (boolean)$cfg['recording_icons_enabled'];
-        $jsvars['pixIconDelete'] = (string)$OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle');
+        $jsvars['iconsEnabled'] = (boolean) $cfg['recording_icons_enabled'];
+        $jsvars['pixIconDelete'] = (string) $OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle');
         $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-modform',
             'M.mod_bigbluebuttonbn.modform.init', array($jsvars));
     }
@@ -171,7 +171,7 @@ 
      */
     public function add_completion_rules() {
         $mform = $this->_form;
-        if (!bigbluebuttonbn_is_bn_server() || !(boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
+        if (!bigbluebuttonbn_is_bn_server() || !(boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
             return [];
         }
 
@@ -179,7 +179,7 @@ 
         $attendance['grouplabel'] = get_string('completionattendancegroup', 'bigbluebuttonbn');
         $attendance['rulelabel'] = get_string('completionattendance', 'bigbluebuttonbn');
         $attendance['group'] = [
-            $mform->createElement('checkbox', 'completionattendanceenabled', '', $attendance['rulelabel'] . ' '),
+            $mform->createElement('checkbox', 'completionattendanceenabled', '', $attendance['rulelabel'].' '),
             $mform->createElement('text', 'completionattendance', '', ['size' => 3]),
             $mform->createElement('static', 'completionattendanceunit', ' ', get_string('minutes', 'bigbluebuttonbn'))
         ];
@@ -197,11 +197,11 @@ 
         $engagement['pollvotes'] = get_string('completionengagementpollvotes', 'bigbluebuttonbn');
         $engagement['emojis'] = get_string('completionengagementemojis', 'bigbluebuttonbn');
         $engagement['group'] = [
-            $mform->createElement('checkbox', 'completionengagementchats', '', $engagement['chatlabel'] . '  '),
-            $mform->createElement('checkbox', 'completionengagementtalks', '', $engagement['talklabel'] . '  '),
-            $mform->createElement('checkbox', 'completionengagementraisehand', '', $engagement['raisehand'] . '  '),
-            $mform->createElement('checkbox', 'completionengagementpollvotes', '', $engagement['pollvotes'] . '  '),
-            $mform->createElement('checkbox', 'completionengagementemojis', '', $engagement['emojis'] . '  '),
+            $mform->createElement('checkbox', 'completionengagementchats', '', $engagement['chatlabel'].'  '),
+            $mform->createElement('checkbox', 'completionengagementtalks', '', $engagement['talklabel'].'  '),
+            $mform->createElement('checkbox', 'completionengagementraisehand', '', $engagement['raisehand'].'  '),
+            $mform->createElement('checkbox', 'completionengagementpollvotes', '', $engagement['pollvotes'].'  '),
+            $mform->createElement('checkbox', 'completionengagementemojis', '', $engagement['emojis'].'  '),
         ];
         $mform->addGroup($engagement['group'], 'completionengagementgroup', $engagement['grouplabel'], [' '], false);
         $mform->addHelpButton('completionengagementgroup', 'completionengagementgroup', 'bigbluebuttonbn');
@@ -248,7 +248,7 @@ 
      * @return void
      */
     private function bigbluebuttonbn_mform_add_block_profiles(&$mform, $profiles) {
-        if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
+        if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
             $mform->addElement('select', 'type', get_string('mod_form_field_instanceprofiles', 'bigbluebuttonbn'),
                 bigbluebuttonbn_get_instance_profiles_array($profiles),
                 array('onchange' => 'M.mod_bigbluebuttonbn.modform.updateInstanceTypeProfile(this);'));
@@ -487,7 +487,7 @@ 
             'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;'
           ));
         $htmladdparticipant = html_writer::tag('div',
-            $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null);
+            $htmlselectiontype.'  '.$htmlselectionoptions.'  '.$htmlselectioninput, null);
         $mform->addElement('html', "\n\n");
         $mform->addElement('static', 'static_add_participant',
             get_string('mod_form_field_participant_add', 'bigbluebuttonbn'), $htmladdparticipant);