|  | @@ -99,8 +99,8 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 99 | 99 |          $PAGE->requires->strings_for_js(array_keys(bigbluebuttonbn_get_strings_for_js()), 'bigbluebuttonbn'); | 
                                                                                                            
                                                            | 100 | 100 |          $jsvars['participantData'] = bigbluebuttonbn_get_participant_data($context, $bigbluebuttonbn); | 
                                                                                                            
                                                            | 101 | 101 |          $jsvars['participantList'] = $participantlist; | 
                                                                                                            
                                                            | 102 |  | -        $jsvars['iconsEnabled'] = (boolean)$cfg['recording_icons_enabled']; | 
                                                                                                            
                                                            | 103 |  | -        $jsvars['pixIconDelete'] = (string)$OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle'); | 
                                                                                                            
                                                            |  | 102 | +        $jsvars['iconsEnabled'] = (boolean) $cfg['recording_icons_enabled']; | 
                                                                                                            
                                                            |  | 103 | +        $jsvars['pixIconDelete'] = (string) $OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle'); | 
                                                                                                            
                                                            | 104 | 104 |          $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-modform', | 
                                                                                                            
                                                            | 105 | 105 |              'M.mod_bigbluebuttonbn.modform.init', array($jsvars)); | 
                                                                                                            
                                                            | 106 | 106 |      } | 
                                                                                                                                                        
                                                        |  | @@ -171,7 +171,7 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 171 | 171 |       */ | 
                                                                                                            
                                                            | 172 | 172 |      public function add_completion_rules() { | 
                                                                                                            
                                                            | 173 | 173 |          $mform = $this->_form; | 
                                                                                                            
                                                            | 174 |  | -        if (!(boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) { | 
                                                                                                            
                                                            |  | 174 | +        if (!(boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) { | 
                                                                                                            
                                                            | 175 | 175 |              return []; | 
                                                                                                            
                                                            | 176 | 176 |          } | 
                                                                                                            
                                                            | 177 | 177 |   | 
                                                                                                                                                        
                                                        |  | @@ -179,7 +179,7 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 179 | 179 |          $attendance['grouplabel'] = get_string('completionattendancegroup', 'bigbluebuttonbn'); | 
                                                                                                            
                                                            | 180 | 180 |          $attendance['rulelabel'] = get_string('completionattendance', 'bigbluebuttonbn'); | 
                                                                                                            
                                                            | 181 | 181 |          $attendance['group'] = [ | 
                                                                                                            
                                                            | 182 |  | -            $mform->createElement('advcheckbox', 'completionattendanceenabled', '', $attendance['rulelabel'] . ' '), | 
                                                                                                            
                                                            |  | 182 | +            $mform->createElement('advcheckbox', 'completionattendanceenabled', '', $attendance['rulelabel'].' '), | 
                                                                                                            
                                                            | 183 | 183 |              $mform->createElement('text', 'completionattendance', '', ['size' => 3]), | 
                                                                                                            
                                                            | 184 | 184 |              $mform->createElement('static', 'completionattendanceunit', ' ', get_string('minutes', 'bigbluebuttonbn')) | 
                                                                                                            
                                                            | 185 | 185 |          ]; | 
                                                                                                                                                        
                                                        |  | @@ -197,11 +197,11 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 197 | 197 |          $engagement['pollvotes'] = get_string('completionengagementpollvotes', 'bigbluebuttonbn'); | 
                                                                                                            
                                                            | 198 | 198 |          $engagement['emojis'] = get_string('completionengagementemojis', 'bigbluebuttonbn'); | 
                                                                                                            
                                                            | 199 | 199 |          $engagement['group'] = [ | 
                                                                                                            
                                                            | 200 |  | -            $mform->createElement('advcheckbox', 'completionengagementchats', '', $engagement['chatlabel'] . '  '), | 
                                                                                                            
                                                            | 201 |  | -            $mform->createElement('advcheckbox', 'completionengagementtalks', '', $engagement['talklabel'] . '  '), | 
                                                                                                            
                                                            | 202 |  | -            $mform->createElement('advcheckbox', 'completionengagementraisehand', '', $engagement['raisehand'] . '  '), | 
                                                                                                            
                                                            | 203 |  | -            $mform->createElement('advcheckbox', 'completionengagementpollvotes', '', $engagement['pollvotes'] . '  '), | 
                                                                                                            
                                                            | 204 |  | -            $mform->createElement('advcheckbox', 'completionengagementemojis', '', $engagement['emojis'] . '  '), | 
                                                                                                            
                                                            |  | 200 | +            $mform->createElement('advcheckbox', 'completionengagementchats', '', $engagement['chatlabel'].'  '), | 
                                                                                                            
                                                            |  | 201 | +            $mform->createElement('advcheckbox', 'completionengagementtalks', '', $engagement['talklabel'].'  '), | 
                                                                                                            
                                                            |  | 202 | +            $mform->createElement('advcheckbox', 'completionengagementraisehand', '', $engagement['raisehand'].'  '), | 
                                                                                                            
                                                            |  | 203 | +            $mform->createElement('advcheckbox', 'completionengagementpollvotes', '', $engagement['pollvotes'].'  '), | 
                                                                                                            
                                                            |  | 204 | +            $mform->createElement('advcheckbox', 'completionengagementemojis', '', $engagement['emojis'].'  '), | 
                                                                                                            
                                                            | 205 | 205 |          ]; | 
                                                                                                            
                                                            | 206 | 206 |          $mform->addGroup($engagement['group'], 'completionengagementgroup', $engagement['grouplabel'], [' '], false); | 
                                                                                                            
                                                            | 207 | 207 |          $mform->addHelpButton('completionengagementgroup', 'completionengagementgroup', 'bigbluebuttonbn'); | 
                                                                                                                                                        
                                                        |  | @@ -248,7 +248,7 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 248 | 248 |       * @return void | 
                                                                                                            
                                                            | 249 | 249 |       */ | 
                                                                                                            
                                                            | 250 | 250 |      private function bigbluebuttonbn_mform_add_block_profiles(&$mform, $profiles) { | 
                                                                                                            
                                                            | 251 |  | -        if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled()) { | 
                                                                                                            
                                                            |  | 251 | +        if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled()) { | 
                                                                                                            
                                                            | 252 | 252 |              $mform->addElement('select', 'type', get_string('mod_form_field_instanceprofiles', 'bigbluebuttonbn'), | 
                                                                                                            
                                                            | 253 | 253 |                  bigbluebuttonbn_get_instance_profiles_array($profiles), | 
                                                                                                            
                                                            | 254 | 254 |                  array('onchange' => 'M.mod_bigbluebuttonbn.modform.updateInstanceTypeProfile(this);')); | 
                                                                                                                                                        
                                                        |  | @@ -487,7 +487,7 @@  discard block | 
                                                    
                                                        |  |  |  block discarded – undo | 
                                                                                                                                                                                                                    
                                                            | 487 | 487 |              'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;' | 
                                                                                                            
                                                            | 488 | 488 |            )); | 
                                                                                                            
                                                            | 489 | 489 |          $htmladdparticipant = html_writer::tag('div', | 
                                                                                                            
                                                            | 490 |  | -            $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null); | 
                                                                                                            
                                                            |  | 490 | +            $htmlselectiontype.'  '.$htmlselectionoptions.'  '.$htmlselectioninput, null); | 
                                                                                                            
                                                            | 491 | 491 |          $mform->addElement('html', "\n\n"); | 
                                                                                                            
                                                            | 492 | 492 |          $mform->addElement('static', 'static_add_participant', | 
                                                                                                            
                                                            | 493 | 493 |              get_string('mod_form_field_participant_add', 'bigbluebuttonbn'), $htmladdparticipant); |