Completed
Branch scrutinizer (9d9d33)
by Jesus
01:59
created
classes/locallib/notifier.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 
28 28
 defined('MOODLE_INTERNAL') || die();
29 29
 
30
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
30
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
31 31
 
32 32
 /**
33 33
  * Helper class for sending notifications.
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
117 117
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
118
-            ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
118
+            ' &quot;'.$bigbluebuttonbn->name.'&quot; '.
119 119
             get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
120 120
     }
121 121
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
                     // Enqueue it.
159 159
                     \core\task\manager::queue_adhoc_task($task);
160 160
                 } catch (\Exception $e) {
161
-                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string) $e);
161
+                    mtrace("Error while enqueuing completion_uopdate_state task. ".(string) $e);
162 162
                 }
163 163
             }
164 164
         }
Please login to merge, or discard this patch.
bbb_broker.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
 // The endpoints for recording_ready and meeting_events callbacks must be moved to services (CONTRIB-7440).
44 44
 // But in order to support the transition, requests other than the callbacks are redirected to bbb_ajax.php.
45 45
 if ($params['action'] != 'recording_ready' && $params['action'] != 'meeting_events') {
46
-    $url = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_ajax.php?' . http_build_query($params, '', '&');
47
-    header("Location: " . $url);
46
+    $url = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_ajax.php?'.http_build_query($params, '', '&');
47
+    header("Location: ".$url);
48 48
     exit;
49 49
 }
50 50
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         bigbluebuttonbn_broker_meeting_events($bigbluebuttonbn);
72 72
         return;
73 73
     }
74
-    header('HTTP/1.0 400 Bad request. The action '. $a . ' doesn\'t exist');
74
+    header('HTTP/1.0 400 Bad request. The action '.$a.' doesn\'t exist');
75 75
 } catch (\Exception $e) {
76 76
     header('HTTP/1.0 500 Internal Server Error. '.$e->getMessage());
77 77
 }
Please login to merge, or discard this patch.
locallib.php 1 patch
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 global $CFG;
34 34
 
35
-require_once(__DIR__ . '/lib.php');
35
+require_once(__DIR__.'/lib.php');
36 36
 
37 37
 /** @var BIGBLUEBUTTONBN_UPDATE_CACHE boolean set to true indicates that cache has to be updated */
38 38
 const BIGBLUEBUTTONBN_UPDATE_CACHE = true;
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
145 145
     $data = null;
146 146
     if (!is_null($pname) && !is_null($purl)) {
147 147
         $method = 'POST';
148
-        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
149
-            $purl . "' /></module></modules>";
148
+        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
149
+            $purl."' /></module></modules>";
150 150
     }
151 151
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $data);
152 152
     if ($xml) {
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
         if (is_object($value)) {
407 407
             $value = '';
408 408
         }
409
-        $metadataarray['meta_' . $key] = $value;
409
+        $metadataarray['meta_'.$key] = $value;
410 410
     }
411 411
     return $metadataarray;
412 412
 }
@@ -546,7 +546,7 @@  discard block
 block discarded – undo
546 546
             return $xml;
547 547
         } catch (\Exception $e) {
548 548
             libxml_use_internal_errors($previous);
549
-            $error = 'Caught exception: ' . $e->getMessage();
549
+            $error = 'Caught exception: '.$e->getMessage();
550 550
             debugging($error, DEBUG_DEVELOPER);
551 551
             return null;
552 552
         }
@@ -557,7 +557,7 @@  discard block
 block discarded – undo
557 557
         $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS);
558 558
         return $response;
559 559
     } catch (\Exception $e) {
560
-        $error = 'Caught exception: ' . $e->getMessage();
560
+        $error = 'Caught exception: '.$e->getMessage();
561 561
         debugging($error, DEBUG_DEVELOPER);
562 562
         libxml_use_internal_errors($previous);
563 563
         return null;
@@ -583,8 +583,8 @@  discard block
 block discarded – undo
583 583
         }
584 584
         $options = array();
585 585
         $options['CURLOPT_HTTPHEADER'] = array(
586
-            'Content-Type: ' . $contenttype,
587
-            'Content-Length: ' . strlen($data),
586
+            'Content-Type: '.$contenttype,
587
+            'Content-Length: '.strlen($data),
588 588
             'Content-Language: en-US',
589 589
         );
590 590
 
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
  * @return void
606 606
  */
607 607
 function bigbluebuttonbn_end_meeting_if_running($bigbluebuttonbn) {
608
-    $meetingid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
608
+    $meetingid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
609 609
     if (bigbluebuttonbn_is_meeting_running($meetingid)) {
610 610
         bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass);
611 611
     }
@@ -625,9 +625,9 @@  discard block
 block discarded – undo
625 625
     if ($userroles) {
626 626
         $where = '';
627 627
         foreach ($userroles as $userrole) {
628
-            $where .= (empty($where) ? ' WHERE' : ' OR') . ' id=' . $userrole->roleid;
628
+            $where .= (empty($where) ? ' WHERE' : ' OR').' id='.$userrole->roleid;
629 629
         }
630
-        $userroles = $DB->get_records_sql('SELECT * FROM {role}' . $where);
630
+        $userroles = $DB->get_records_sql('SELECT * FROM {role}'.$where);
631 631
     }
632 632
     return $userroles;
633 633
 }
@@ -952,9 +952,9 @@  discard block
 block discarded – undo
952 952
     if ($voicebridge == 0) {
953 953
         return true;
954 954
     }
955
-    $select = 'voicebridge = ' . $voicebridge;
955
+    $select = 'voicebridge = '.$voicebridge;
956 956
     if ($instance != 0) {
957
-        $select .= ' AND id <>' . $instance;
957
+        $select .= ' AND id <>'.$instance;
958 958
     }
959 959
     if (!$DB->get_records_select('bigbluebuttonbn', $select)) {
960 960
         return true;
@@ -1090,7 +1090,7 @@  discard block
 block discarded – undo
1090 1090
 function bigbluebuttonbn_generate_nonce() {
1091 1091
     $mt = microtime();
1092 1092
     $rand = mt_rand();
1093
-    return md5($mt . $rand);
1093
+    return md5($mt.$rand);
1094 1094
 }
1095 1095
 
1096 1096
 /**
@@ -1138,7 +1138,7 @@  discard block
 block discarded – undo
1138 1138
         $params['other'] = $options['other'];
1139 1139
     }
1140 1140
     $event = call_user_func_array(
1141
-        '\mod_bigbluebuttonbn\event\\' . $type . '::create',
1141
+        '\mod_bigbluebuttonbn\event\\'.$type.'::create',
1142 1142
         array($params)
1143 1143
     );
1144 1144
     $event->add_record_snapshot('course_modules', $cm);
@@ -1296,7 +1296,7 @@  discard block
 block discarded – undo
1296 1296
  * @return object
1297 1297
  */
1298 1298
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
1299
-    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
1299
+    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url').'api/setConfigXML?';
1300 1300
     $configxmlparams = bigbluebuttonbn_set_config_xml_params($meetingid, $configxml);
1301 1301
     $xml = bigbluebuttonbn_wrap_xml_load_file(
1302 1302
         $urldefaultconfig,
@@ -1316,9 +1316,9 @@  discard block
 block discarded – undo
1316 1316
  * @return string
1317 1317
  */
1318 1318
 function bigbluebuttonbn_set_config_xml_params($meetingid, $configxml) {
1319
-    $params = 'configXML=' . urlencode($configxml) . '&meetingID=' . urlencode($meetingid);
1319
+    $params = 'configXML='.urlencode($configxml).'&meetingID='.urlencode($meetingid);
1320 1320
     $sharedsecret = \mod_bigbluebuttonbn\locallib\config::get('shared_secret');
1321
-    $configxmlparams = $params . '&checksum=' . sha1('setConfigXML' . $params . $sharedsecret);
1321
+    $configxmlparams = $params.'&checksum='.sha1('setConfigXML'.$params.$sharedsecret);
1322 1322
     return $configxmlparams;
1323 1323
 }
1324 1324
 
@@ -1426,7 +1426,7 @@  discard block
 block discarded – undo
1426 1426
     global $USER;
1427 1427
     $starttime = $starttime - ($starttime % 1000);
1428 1428
     // Set formatted date.
1429
-    $dateformat = get_string('strftimerecentfull', 'langconfig') . ' %Z';
1429
+    $dateformat = get_string('strftimerecentfull', 'langconfig').' %Z';
1430 1430
     return userdate($starttime / 1000, $dateformat, usertimezone($USER->timezone));
1431 1431
 }
1432 1432
 
@@ -1474,11 +1474,11 @@  discard block
 block discarded – undo
1474 1474
         $actionbar .= bigbluebuttonbn_actionbar_render_button($recording, $buttonpayload);
1475 1475
     }
1476 1476
     $head = html_writer::start_tag('div', array(
1477
-        'id' => 'recording-actionbar-' . $recording['recordID'],
1477
+        'id' => 'recording-actionbar-'.$recording['recordID'],
1478 1478
         'data-recordingid' => $recording['recordID'],
1479 1479
         'data-meetingid' => $recording['meetingID']));
1480 1480
     $tail = html_writer::end_tag('div');
1481
-    return $head . $actionbar . $tail;
1481
+    return $head.$actionbar.$tail;
1482 1482
 }
1483 1483
 
1484 1484
 /**
@@ -1542,7 +1542,7 @@  discard block
 block discarded – undo
1542 1542
  * @return string
1543 1543
  */
1544 1544
 function bigbluebuttonbn_get_recording_data_row_preview($recording) {
1545
-    $options = array('id' => 'preview-' . $recording['recordID']);
1545
+    $options = array('id' => 'preview-'.$recording['recordID']);
1546 1546
     if ($recording['published'] === 'false') {
1547 1547
         $options['hidden'] = 'hidden';
1548 1548
     }
@@ -1574,7 +1574,7 @@  discard block
 block discarded – undo
1574 1574
         $recordingpreview .= html_writer::start_tag('div', array('class' => ''));
1575 1575
         $recordingpreview .= html_writer::empty_tag(
1576 1576
             'img',
1577
-            array('src' => trim($image['url']) . '?' . time(), 'class' => 'recording-thumbnail pull-left')
1577
+            array('src' => trim($image['url']).'?'.time(), 'class' => 'recording-thumbnail pull-left')
1578 1578
         );
1579 1579
         $recordingpreview .= html_writer::end_tag('div');
1580 1580
     }
@@ -1609,7 +1609,7 @@  discard block
 block discarded – undo
1609 1609
     if ($recording['published'] === 'false') {
1610 1610
         $visibility = 'hidden ';
1611 1611
     }
1612
-    $id = 'playbacks-' . $recording['recordID'];
1612
+    $id = 'playbacks-'.$recording['recordID'];
1613 1613
     $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported,
1614 1614
         'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
1615 1615
         'title' => $title, $visibility => $visibility));
@@ -1634,14 +1634,14 @@  discard block
 block discarded – undo
1634 1634
     if (!bigbluebuttonbn_include_recording_data_row_type($recording, $bbbsession, $playback)) {
1635 1635
         return '';
1636 1636
     }
1637
-    $text = get_string('view_recording_format_' . $playback['type'], 'bigbluebuttonbn');
1638
-    $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id .
1639
-        '&mid=' . $recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
1637
+    $text = get_string('view_recording_format_'.$playback['type'], 'bigbluebuttonbn');
1638
+    $href = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=play&bn='.$bbbsession['bigbluebuttonbn']->id.
1639
+        '&mid='.$recording['meetingID'].'&rid='.$recording['recordID'].'&rtype='.$playback['type'];
1640 1640
     if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') {
1641
-        $href .= '&href=' . urlencode(trim($playback['url']));
1641
+        $href .= '&href='.urlencode(trim($playback['url']));
1642 1642
     }
1643 1643
     $linkattributes = array(
1644
-        'id' => 'recording-play-' . $playback['type'] . '-' . $recording['recordID'],
1644
+        'id' => 'recording-play-'.$playback['type'].'-'.$recording['recordID'],
1645 1645
         'class' => 'btn btn-sm btn-default',
1646 1646
         'onclick' => 'M.mod_bigbluebuttonbn.recordings.recordingPlay(this);',
1647 1647
         'data-action' => 'play',
@@ -1653,7 +1653,7 @@  discard block
 block discarded – undo
1653 1653
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');
1654 1654
         unset($linkattributes['data-href']);
1655 1655
     }
1656
-    return $OUTPUT->action_link('#', $text, null, $linkattributes) . '&#32;';
1656
+    return $OUTPUT->action_link('#', $text, null, $linkattributes).'&#32;';
1657 1657
 }
1658 1658
 
1659 1659
 /**
@@ -1679,7 +1679,7 @@  discard block
 block discarded – undo
1679 1679
     $validatedurls[$urlhost] = true;
1680 1680
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($url, 'HEAD');
1681 1681
     if (!isset($curlinfo['http_code']) || $curlinfo['http_code'] != 200) {
1682
-        $error = "Resources hosted by " . $urlhost . " are unreachable. Server responded with code " . $curlinfo['http_code'];
1682
+        $error = "Resources hosted by ".$urlhost." are unreachable. Server responded with code ".$curlinfo['http_code'];
1683 1683
         debugging($error, DEBUG_DEVELOPER);
1684 1684
         $validatedurls[$urlhost] = false;
1685 1685
     }
@@ -1770,12 +1770,12 @@  discard block
 block discarded – undo
1770 1770
  * @return string
1771 1771
  */
1772 1772
 function bigbluebuttonbn_get_recording_data_row_text($recording, $text, $source, $data) {
1773
-    $htmltext = '<span>' . htmlentities($text) . '</span>';
1773
+    $htmltext = '<span>'.htmlentities($text).'</span>';
1774 1774
     if (empty($data)) {
1775 1775
         return $htmltext;
1776 1776
     }
1777
-    $target = $data['action'] . '-' . $data['target'];
1778
-    $id = 'recording-' . $target . '-' . $data['recordingid'];
1777
+    $target = $data['action'].'-'.$data['target'];
1778
+    $id = 'recording-'.$target.'-'.$data['recordingid'];
1779 1779
     $attributes = array('id' => $id, 'class' => 'quickeditlink col-md-20',
1780 1780
         'data-recordingid' => $data['recordingid'], 'data-meetingid' => $data['meetingid'],
1781 1781
         'data-target' => $data['target'], 'data-source' => $source);
@@ -1783,7 +1783,7 @@  discard block
 block discarded – undo
1783 1783
     $tail = html_writer::end_tag('div');
1784 1784
     $payload = array('action' => $data['action'], 'tag' => $data['tag'], 'target' => $data['target']);
1785 1785
     $htmllink = bigbluebuttonbn_actionbar_render_button($recording, $payload);
1786
-    return $head . $htmltext . $htmllink . $tail;
1786
+    return $head.$htmltext.$htmllink.$tail;
1787 1787
 }
1788 1788
 
1789 1789
 /**
@@ -1801,10 +1801,10 @@  discard block
 block discarded – undo
1801 1801
     }
1802 1802
     $target = $data['action'];
1803 1803
     if (isset($data['target'])) {
1804
-        $target .= '-' . $data['target'];
1804
+        $target .= '-'.$data['target'];
1805 1805
     }
1806
-    $id = 'recording-' . $target . '-' . $recording['recordID'];
1807
-    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this);';
1806
+    $id = 'recording-'.$target.'-'.$recording['recordID'];
1807
+    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording'.ucfirst($data['action']).'(this);';
1808 1808
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
1809 1809
         // With icon for $manageaction.
1810 1810
         $iconattributes = array('id' => $id, 'class' => 'iconsmall');
@@ -1819,13 +1819,13 @@  discard block
 block discarded – undo
1819 1819
             );
1820 1820
         }
1821 1821
         if (isset($data['disabled'])) {
1822
-            $iconattributes['class'] .= ' fa-' . $data['disabled'];
1822
+            $iconattributes['class'] .= ' fa-'.$data['disabled'];
1823 1823
             $linkattributes['class'] = 'disabled';
1824 1824
             unset($linkattributes['onclick']);
1825 1825
         }
1826 1826
         $icon = new pix_icon(
1827
-            'i/' . $data['tag'],
1828
-            get_string('view_recording_list_actionbar_' . $data['action'], 'bigbluebuttonbn'),
1827
+            'i/'.$data['tag'],
1828
+            get_string('view_recording_list_actionbar_'.$data['action'], 'bigbluebuttonbn'),
1829 1829
             'moodle',
1830 1830
             $iconattributes
1831 1831
         );
@@ -1923,7 +1923,7 @@  discard block
 block discarded – undo
1923 1923
     if ($bbbsession['managerecordings']) {
1924 1924
         $table->head[] = get_string('view_recording_actionbar', 'bigbluebuttonbn');
1925 1925
         $table->align[] = 'left';
1926
-        $table->size[] = (count($tools) * 40) . 'px';
1926
+        $table->size[] = (count($tools) * 40).'px';
1927 1927
     }
1928 1928
     // Get the groups of the user.
1929 1929
     $usergroups = groups_get_all_groups($bbbsession['course']->id, $bbbsession['userID']);
@@ -1988,7 +1988,7 @@  discard block
 block discarded – undo
1988 1988
  */
1989 1989
 function bigbluebuttonbn_get_recording_table_row($bbbsession, $recording, $rowdata) {
1990 1990
     $row = new html_table_row();
1991
-    $row->id = 'recording-tr-' . $recording['recordID'];
1991
+    $row->id = 'recording-tr-'.$recording['recordID'];
1992 1992
     $row->attributes['data-imported'] = 'false';
1993 1993
     $texthead = '';
1994 1994
     $texttail = '';
@@ -2000,15 +2000,15 @@  discard block
 block discarded – undo
2000 2000
     }
2001 2001
     $rowdata->date_formatted = str_replace(' ', '&nbsp;', $rowdata->date_formatted);
2002 2002
     $row->cells = array();
2003
-    $row->cells[] = $texthead . $rowdata->recording . $texttail;
2004
-    $row->cells[] = $texthead . $rowdata->meeting . $texttail;
2003
+    $row->cells[] = $texthead.$rowdata->recording.$texttail;
2004
+    $row->cells[] = $texthead.$rowdata->meeting.$texttail;
2005 2005
 
2006
-    $row->cells[] = $texthead . $rowdata->activity . $texttail;
2007
-    $row->cells[] = $texthead . $rowdata->description . $texttail;
2006
+    $row->cells[] = $texthead.$rowdata->activity.$texttail;
2007
+    $row->cells[] = $texthead.$rowdata->description.$texttail;
2008 2008
     if (bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession)) {
2009 2009
         $row->cells[] = $rowdata->preview;
2010 2010
     }
2011
-    $row->cells[] = $texthead . $rowdata->date_formatted . $texttail;
2011
+    $row->cells[] = $texthead.$rowdata->date_formatted.$texttail;
2012 2012
     $row->cells[] = $rowdata->duration_formatted;
2013 2013
     if ($bbbsession['managerecordings']) {
2014 2014
         $row->cells[] = $rowdata->actionbar;
@@ -2099,7 +2099,7 @@  discard block
 block discarded – undo
2099 2099
         // Enqueue it.
2100 2100
         \core\task\manager::queue_adhoc_task($task);
2101 2101
     } catch (\Exception $e) {
2102
-        mtrace("Error while enqueuing completion_update_state task. " . (string) $e);
2102
+        mtrace("Error while enqueuing completion_update_state task. ".(string) $e);
2103 2103
     }
2104 2104
 }
2105 2105
 
@@ -2265,17 +2265,17 @@  discard block
 block discarded – undo
2265 2265
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
2266 2266
  */
2267 2267
 function bigbluebuttonbn_get_recordings_deleted_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
2268
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_DELETE . "' AND meta like '%has_recordings%' AND meta like '%true%'";
2268
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_DELETE."' AND meta like '%has_recordings%' AND meta like '%true%'";
2269 2269
     if (empty($courseid)) {
2270 2270
         $courseid = 0;
2271 2271
     }
2272 2272
     if (empty($bigbluebuttonbnid)) {
2273
-        return $sql . " AND courseid = {$courseid}";
2273
+        return $sql." AND courseid = {$courseid}";
2274 2274
     }
2275 2275
     if ($subset) {
2276
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
2276
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
2277 2277
     }
2278
-    return $sql . " AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
2278
+    return $sql." AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
2279 2279
 }
2280 2280
 
2281 2281
 /**
@@ -2289,17 +2289,17 @@  discard block
 block discarded – undo
2289 2289
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
2290 2290
  */
2291 2291
 function bigbluebuttonbn_get_recordings_imported_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
2292
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_IMPORT . "'";
2292
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_IMPORT."'";
2293 2293
     if (empty($courseid)) {
2294 2294
         $courseid = 0;
2295 2295
     }
2296 2296
     if (empty($bigbluebuttonbnid)) {
2297
-        return $sql . " AND courseid = '{$courseid}'";
2297
+        return $sql." AND courseid = '{$courseid}'";
2298 2298
     }
2299 2299
     if ($subset) {
2300
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
2300
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
2301 2301
     }
2302
-    return $sql . " AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
2302
+    return $sql." AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
2303 2303
 }
2304 2304
 
2305 2305
 /**
@@ -2358,7 +2358,7 @@  discard block
 block discarded – undo
2358 2358
     }
2359 2359
     // Prepare select for loading records based on existent bigbluebuttonbns.
2360 2360
     $sql = 'SELECT DISTINCT meetingid, bigbluebuttonbnid FROM {bigbluebuttonbn_logs} WHERE ';
2361
-    $sql .= '(bigbluebuttonbnid=' . implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)) . ')';
2361
+    $sql .= '(bigbluebuttonbnid='.implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)).')';
2362 2362
     // Include only Create events and exclude those with record not true.
2363 2363
     $sql .= ' AND log = ? AND meta LIKE ? AND meta LIKE ?';
2364 2364
     // Execute select for loading records based on existent bigbluebuttonbns.
@@ -2541,8 +2541,8 @@  discard block
 block discarded – undo
2541 2541
 function bigbluebuttonbn_format_activity_time($time) {
2542 2542
     $activitytime = '';
2543 2543
     if ($time) {
2544
-        $activitytime = calendar_day_representation($time) . ' ' .
2545
-        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn') . ' ' .
2544
+        $activitytime = calendar_day_representation($time).' '.
2545
+        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
2546 2546
         calendar_time_representation($time);
2547 2547
     }
2548 2548
     return $activitytime;
@@ -3091,16 +3091,16 @@  discard block
 block discarded – undo
3091 3091
         return $output;
3092 3092
     }
3093 3093
     $output .= $OUTPUT->box_start(
3094
-        'box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
3094
+        'box boxalignleft adminerror alert alert-'.$type.' alert-block fade in',
3095 3095
         'bigbluebuttonbn_view_general_warning'
3096
-    ) . "\n";
3097
-    $output .= '    ' . $message . "\n";
3098
-    $output .= '  <div class="singlebutton pull-right">' . "\n";
3096
+    )."\n";
3097
+    $output .= '    '.$message."\n";
3098
+    $output .= '  <div class="singlebutton pull-right">'."\n";
3099 3099
     if (!empty($href)) {
3100 3100
         $output .= bigbluebuttonbn_render_warning_button($href, $text, $class);
3101 3101
     }
3102
-    $output .= '  </div>' . "\n";
3103
-    $output .= $OUTPUT->box_end() . "\n";
3102
+    $output .= '  </div>'."\n";
3103
+    $output .= $OUTPUT->box_end()."\n";
3104 3104
     return $output;
3105 3105
 }
3106 3106
 
@@ -3124,11 +3124,11 @@  discard block
 block discarded – undo
3124 3124
     if ($class == '') {
3125 3125
         $class = 'btn btn-secondary';
3126 3126
     }
3127
-    $output = '  <form method="post" action="' . $href . '" class="form-inline">' . "\n";
3128
-    $output .= '      <button type="submit" class="' . $class . '"' . "\n";
3129
-    $output .= '          title="' . $title . '"' . "\n";
3130
-    $output .= '          >' . $text . '</button>' . "\n";
3131
-    $output .= '  </form>' . "\n";
3127
+    $output = '  <form method="post" action="'.$href.'" class="form-inline">'."\n";
3128
+    $output .= '      <button type="submit" class="'.$class.'"'."\n";
3129
+    $output .= '          title="'.$title.'"'."\n";
3130
+    $output .= '          >'.$text.'</button>'."\n";
3131
+    $output .= '  </form>'."\n";
3132 3132
     return $output;
3133 3133
 }
3134 3134
 
@@ -3192,7 +3192,7 @@  discard block
 block discarded – undo
3192 3192
 function bigbluebuttonbn_user_can_join_meeting($bigbluebuttonbn, $mid = null, $userid = null) {
3193 3193
     // By default, use a meetingid without groups.
3194 3194
     if (empty($mid)) {
3195
-        $mid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
3195
+        $mid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
3196 3196
     }
3197 3197
     // When meeting is running, all authorized users can join right in.
3198 3198
     if (bigbluebuttonbn_is_meeting_running($mid)) {
@@ -3261,7 +3261,7 @@  discard block
 block discarded – undo
3261 3261
  * @return boolean
3262 3262
  */
3263 3263
 function bigbluebuttonbn_has_html5_client() {
3264
-    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root() . "html5client/check";
3264
+    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root()."html5client/check";
3265 3265
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($checkurl, 'HEAD');
3266 3266
     return (isset($curlinfo['http_code']) && $curlinfo['http_code'] == 200);
3267 3267
 }
@@ -3289,7 +3289,7 @@  discard block
 block discarded – undo
3289 3289
     $bbbsession['modPW'] = $bbbsession['bigbluebuttonbn']->moderatorpass;
3290 3290
     $bbbsession['viewerPW'] = $bbbsession['bigbluebuttonbn']->viewerpass;
3291 3291
     // Database info related to the activity.
3292
-    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid . '-' . $bbbsession['course']->id . '-' .
3292
+    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'.
3293 3293
     $bbbsession['bigbluebuttonbn']->id;
3294 3294
     $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name;
3295 3295
     $bbbsession['meetingdescription'] = $bbbsession['bigbluebuttonbn']->intro;
@@ -3321,12 +3321,12 @@  discard block
 block discarded – undo
3321 3321
     if ($bbbsession['bigbluebuttonbn']->record) {
3322 3322
         // Check if is enable record all from start.
3323 3323
         if ($bbbsession['recordallfromstart']) {
3324
-            $bbbsession['welcome'] .= '<br><br>' . get_string(
3324
+            $bbbsession['welcome'] .= '<br><br>'.get_string(
3325 3325
                 'bbbrecordallfromstartwarning',
3326 3326
                 'bigbluebuttonbn'
3327 3327
             );
3328 3328
         } else {
3329
-            $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
3329
+            $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
3330 3330
         }
3331 3331
     }
3332 3332
     $bbbsession['openingtime'] = $bbbsession['bigbluebuttonbn']->openingtime;
@@ -3341,7 +3341,7 @@  discard block
 block discarded – undo
3341 3341
     $bbbsession['originServerName'] = $parsedurl['host'];
3342 3342
     $bbbsession['originServerUrl'] = $CFG->wwwroot;
3343 3343
     $bbbsession['originServerCommonName'] = '';
3344
-    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
3344
+    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
3345 3345
     $bbbsession['bnserver'] = bigbluebuttonbn_is_bn_server();
3346 3346
     // Setting for clienttype, assign flash if not enabled, or default if not editable.
3347 3347
     $bbbsession['clienttype'] = BIGBLUEBUTTON_CLIENTTYPE_FLASH;
@@ -3448,7 +3448,7 @@  discard block
 block discarded – undo
3448 3448
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
3449 3449
         $metadata["bn-recording-status"] = json_encode(
3450 3450
             array(
3451
-                'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'),
3451
+                'email' => array('"'.fullname($USER).'" <'.$USER->email.'>'),
3452 3452
                 'context' => $bbbsession['bigbluebuttonbnURL'],
3453 3453
             )
3454 3454
         );
Please login to merge, or discard this patch.
bbb_ajax.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@
 block discarded – undo
126 126
         echo $completionvalidate;
127 127
         return;
128 128
     }
129
-    header('HTTP/1.0 400 Bad request. The action '. $a . ' doesn\'t exist');
129
+    header('HTTP/1.0 400 Bad request. The action '.$a.' doesn\'t exist');
130 130
 } catch (\Exception $e) {
131 131
     header('HTTP/1.0 500 Internal Server Error. '.$e->getMessage());
132 132
 }
Please login to merge, or discard this patch.
brokerlib.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
         // Pull the Bearer from the headers.
654 654
         if (!array_key_exists('Authorization', $headers)) {
655 655
             $msg = 'Authorization failed';
656
-            header('HTTP/1.0 400 Bad Request. ' . $msg);
656
+            header('HTTP/1.0 400 Bad Request. '.$msg);
657 657
             return;
658 658
         }
659 659
         $authorization = explode(" ", $headers['Authorization']);
@@ -671,8 +671,8 @@  discard block
 block discarded – undo
671 671
         // Convert JSON string to a JSON object.
672 672
         $jsonobj = json_decode($jsonstr);
673 673
     } catch (\Exception $e) {
674
-        $msg = 'Caught exception: ' . $e->getMessage();
675
-        header('HTTP/1.0 400 Bad Request. ' . $msg);
674
+        $msg = 'Caught exception: '.$e->getMessage();
675
+        header('HTTP/1.0 400 Bad Request. '.$msg);
676 676
         return;
677 677
     }
678 678
 
@@ -681,7 +681,7 @@  discard block
 block discarded – undo
681 681
     $meetingidelements = explode('-', $meetingidelements[0]);
682 682
     if (!isset($bigbluebuttonbn) || $bigbluebuttonbn->meetingid != $meetingidelements[0]) {
683 683
         $msg = 'The activity may have been deleted';
684
-        header('HTTP/1.0 410 Gone. ' . $msg);
684
+        header('HTTP/1.0 410 Gone. '.$msg);
685 685
         return;
686 686
     }
687 687
 
@@ -694,11 +694,11 @@  discard block
 block discarded – undo
694 694
         // Process the events.
695 695
         bigbluebuttonbn_process_meeting_events($bigbluebuttonbn, $jsonobj);
696 696
         $msg = 'Enqueued.';
697
-        header('HTTP/1.0 202 Accepted. ' . $msg);
697
+        header('HTTP/1.0 202 Accepted. '.$msg);
698 698
         return;
699 699
     }
700 700
     $msg = 'Already processed.';
701
-    header('HTTP/1.0 202 Accepted. ' . $msg);
701
+    header('HTTP/1.0 202 Accepted. '.$msg);
702 702
 }
703 703
 
704 704
 /**
Please login to merge, or discard this patch.