jfederico / moodle-mod_bigbluebuttonbn

backup/moodle2/backup_bigbluebuttonbn_stepslib.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
         $logs = new backup_nested_element('logs');
 
         $log = new backup_nested_element('log', array('id'), array(
-                'courseid', 'bigbluebuttonbnid', 'userid', 'timecreated', 'meetingid', 'log', 'meta', ));
+                'courseid', 'bigbluebuttonbnid', 'userid', 'timecreated', 'meetingid', 'log', 'meta',));
 
         // Build the tree.
         $bigbluebuttonbn->add_child($logs);

import_view.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     print_error('view_error_invalid_session', plugin::COMPONENT);
 }
 
-if (!(boolean)\mod_bigbluebuttonbn\locallib\config::importrecordings_enabled()) {
+if (!(boolean) \mod_bigbluebuttonbn\locallib\config::importrecordings_enabled()) {
     print_error('view_message_importrecordings_disabled', plugin::COMPONENT);
 }
 

mod_form.php

Indentation +11 added lines, -11 removed lines

@@ -309,8 +309,8 @@ 
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6],
                 ['message' => get_string('mod_form_field_voicebridge_format_error', 'bigbluebuttonbn'),
-                 'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
-              );
+                    'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
+                );
         } else {
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6]);
@@ -380,7 +380,7 @@ 
     private function bigbluebuttonbn_mform_add_block_room_recordings(&$mform, $cfg) {
         $recordingsettings = false;
         $field = ['type' => 'hidden', 'name' => 'recordings_html', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_html_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_html';
@@ -389,7 +389,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_html_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_deleted', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_deleted_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_deleted';
@@ -398,7 +398,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_deleted_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_imported', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['importrecordings_enabled'] && $cfg['recordings_imported_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_imported';
@@ -407,7 +407,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_imported_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_preview', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_preview_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_preview';
@@ -484,7 +484,7 @@ 
         $htmlselectiontype = html_writer::select($participantselection['type_options'],
             'bigbluebuttonbn_participant_selection_type', $participantselection['type_selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection_type',
-                  'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
+                    'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
         $htmlselectionoptions = html_writer::select($participantselection['options'], 'bigbluebuttonbn_participant_selection',
             $participantselection['selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection', 'disabled' => 'disabled'));
@@ -492,7 +492,7 @@ 
             'type' => 'button', 'class' => 'btn btn-secondary',
             'value' => get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn'),
             'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;'
-          ));
+            ));
         $htmladdparticipant = html_writer::tag('div',
             $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null);
         $mform->addElement('html', "\n\n");
@@ -534,9 +534,9 @@ 
             $field['type'] = 'select';
             $field['data_type'] = PARAM_TEXT;
             $field['description_key'] = 'mod_form_field_block_clienttype';
-             $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
-                             BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
-             $mform->addElement('header', 'clienttypeselection', get_string('mod_form_block_clienttype', 'bigbluebuttonbn'));
+                $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
+                                BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
+                $mform->addElement('header', 'clienttypeselection', get_string('mod_form_block_clienttype', 'bigbluebuttonbn'));
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                                     $field['description_key'], $cfg['clienttype_default'], $choices);
             return;

Spacing +4 added lines, -4 removed lines

@@ -106,8 +106,8 @@ 
         $PAGE->requires->strings_for_js(array_keys(bigbluebuttonbn_get_strings_for_js()), 'bigbluebuttonbn');
         $jsvars['participantData'] = bigbluebuttonbn_get_participant_data($context, $bigbluebuttonbn);
         $jsvars['participantList'] = $participantlist;
-        $jsvars['iconsEnabled'] = (boolean)$cfg['recording_icons_enabled'];
-        $jsvars['pixIconDelete'] = (string)$OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle');
+        $jsvars['iconsEnabled'] = (boolean) $cfg['recording_icons_enabled'];
+        $jsvars['pixIconDelete'] = (string) $OUTPUT->pix_icon('t/delete', get_string('delete'), 'moodle');
         $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-modform',
             'M.mod_bigbluebuttonbn.modform.init', array($jsvars));
     }
@@ -165,7 +165,7 @@ 
      * @return void
      */
     private function bigbluebuttonbn_mform_add_block_profiles(&$mform, $profiles) {
-        if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
+        if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
             $mform->addElement('select', 'type', get_string('mod_form_field_instanceprofiles', 'bigbluebuttonbn'),
                 bigbluebuttonbn_get_instance_profiles_array($profiles),
                 array('onchange' => 'M.mod_bigbluebuttonbn.modform.updateInstanceTypeProfile(this);'));
@@ -404,7 +404,7 @@ 
             'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;'
           ));
         $htmladdparticipant = html_writer::tag('div',
-            $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null);
+            $htmlselectiontype.'  '.$htmlselectionoptions.'  '.$htmlselectioninput, null);
         $mform->addElement('html', "\n\n");
         $mform->addElement('static', 'static_add_participant',
             get_string('mod_form_field_participant_add', 'bigbluebuttonbn'), $htmladdparticipant);

view.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
 bigbluebuttonbn_view_bbbsession_set($PAGE->context, $bbbsession);
 
 // Validates if the BigBlueButton server is working.
-$serverversion = bigbluebuttonbn_get_server_version();  // In locallib.
+$serverversion = bigbluebuttonbn_get_server_version(); // In locallib.
 if ($serverversion === null) {
     $errmsg = 'view_error_unable_join_student';
     $errurl = '/course/view.php';

db/mobile.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
             'coursebigbluebuttonbn' => array( // Handler unique name (can be anything).
                 'displaydata' => array(
                     'title' => 'pluginname',
-                    'icon' => $CFG->wwwroot . '/mod/bigbluebuttonbn/pix/icon.gif',
+                    'icon' => $CFG->wwwroot.'/mod/bigbluebuttonbn/pix/icon.gif',
                     'class' => '',
                 ),
                 'delegate' => 'CoreCourseModuleDelegate', // Delegate (where to display the link to the add-on).

classes/locallib/notifier.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Helper class for sending notifications.

classes/locallib/config.php

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Handles the global configuration based on config.php.
@@ -128,10 +128,10 @@ 
     public static function get($setting) {
         global $CFG;
         if (isset($CFG->bigbluebuttonbn[$setting])) {
-            return (string)$CFG->bigbluebuttonbn[$setting];
+            return (string) $CFG->bigbluebuttonbn[$setting];
         }
         if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
+            return (string) $CFG->{'bigbluebuttonbn_'.$setting};
         }
         return self::defaultvalue($setting);
     }
@@ -142,7 +142,7 @@ 
      * @return boolean
      */
     public static function recordings_enabled() {
-        return (boolean)self::get('recordings_enabled');
+        return (boolean) self::get('recordings_enabled');
     }
 
     /**
@@ -151,7 +151,7 @@ 
      * @return boolean
      */
     public static function importrecordings_enabled() {
-        return (boolean)self::get('importrecordings_enabled');
+        return (boolean) self::get('importrecordings_enabled');
     }
 
     /**
@@ -160,7 +160,7 @@ 
      * @return boolean
      */
     public static function clienttype_enabled() {
-        return (boolean)self::get('clienttype_enabled');
+        return (boolean) self::get('clienttype_enabled');
     }
 
     /**

Indentation +38 added lines, -38 removed lines

@@ -172,43 +172,43 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recordings_validate_url' => self::get('recordings_validate_url'),
-               'recording_default' => self::get('recording_default'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
-               'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
-               'recording_hide_button_default' => self::get('recording_hide_button_default'),
-               'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-               'clienttype_enabled' => self::get('clienttype_enabled'),
-               'clienttype_editable' => self::get('clienttype_editable'),
-               'clienttype_default' => self::get('clienttype_default'),
-               'muteonstart_editable' => self::get('muteonstart_editable'),
-               'muteonstart_default' => self::get('muteonstart_default'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recordings_validate_url' => self::get('recordings_validate_url'),
+                'recording_default' => self::get('recording_default'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
+                'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
+                'recording_hide_button_default' => self::get('recording_hide_button_default'),
+                'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+                'clienttype_enabled' => self::get('clienttype_enabled'),
+                'clienttype_editable' => self::get('clienttype_editable'),
+                'clienttype_default' => self::get('clienttype_default'),
+                'muteonstart_editable' => self::get('muteonstart_editable'),
+                'muteonstart_default' => self::get('muteonstart_default'),
+            );
     }
 }

classes/privacy/provider.php

Indentation +6 added lines, -6 removed lines

@@ -59,11 +59,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -207,7 +207,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

Doc Comments +2 added lines

@@ -54,6 +54,7 @@ 
          * Get the list of users who have data within a context.
          *
          * @param   userlist $userlist The userlist containing the list of users who have data in this context/plugin combination.
+         * @return void
          */
         public static function get_users_in_context(userlist $userlist);
 
@@ -61,6 +62,7 @@ 
          * Delete multiple users within a single context.
          *
          * @param   approved_userlist       $userlist The approved context and user information to delete information for.
+         * @return void
          */
         public static function delete_data_for_users(approved_userlist $userlist);
     }

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /*
  * This part is to be eliminated as soon as possible but allows the phpunit test to pass Ok on MOODLE_33 and below WHILST allowing

classes/output/import_view.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
             }
             $recordings = bigbluebuttonbn_get_allrecordings(
                 $selected, $bigbluebuttonbnid, false,
-                (boolean)\mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
+                (boolean) \mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
             );
             // Exclude the ones that are already imported.
             if (!empty($recordings)) {