| @@ -307,7 +307,7 @@ discard block | ||
| 307 | 307 | * Helper function to retrieve imported recordings from the Moodle database. | 
| 308 | 308 | * The references are stored as events in bigbluebuttonbn_logs. | 
| 309 | 309 | * | 
| 310 | - * @param string $courseid | |
| 310 | + * @param integer $courseid | |
| 311 | 311 | * @param string $bigbluebuttonbnid | 
| 312 | 312 | * @param bool $subset | 
| 313 | 313 | * | 
| @@ -335,7 +335,7 @@ discard block | ||
| 335 | 335 | /** | 
| 336 | 336 | * Helper function to retrive the default config.xml file. | 
| 337 | 337 | * | 
| 338 | - * @return string | |
| 338 | + * @return null|SimpleXMLElement | |
| 339 | 339 | */ | 
| 340 | 340 |  function bigbluebuttonbn_get_default_config_xml() { | 
| 341 | 341 | $xml = bigbluebuttonbn_wrap_xml_load_file( | 
| @@ -417,7 +417,7 @@ discard block | ||
| 417 | 417 | * @param object $a | 
| 418 | 418 | * @param object $b | 
| 419 | 419 | * | 
| 420 | - * @return array | |
| 420 | + * @return integer | |
| 421 | 421 | */ | 
| 422 | 422 |  function bigbluebuttonbn_recording_build_sorter($a, $b) { | 
| 423 | 423 | global $CFG; | 
| @@ -531,7 +531,7 @@ discard block | ||
| 531 | 531 | * @param string $data | 
| 532 | 532 | * @param string $contenttype | 
| 533 | 533 | * | 
| 534 | - * @return object | |
| 534 | + * @return null|SimpleXMLElement | |
| 535 | 535 | */ | 
| 536 | 536 |  function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') { | 
| 537 | 537 |      if (extension_loaded('curl')) { | 
| @@ -572,7 +572,7 @@ discard block | ||
| 572 | 572 | * @param string $data | 
| 573 | 573 | * @param string $contenttype | 
| 574 | 574 | * | 
| 575 | - * @return object | |
| 575 | + * @return string | |
| 576 | 576 | */ | 
| 577 | 577 |  function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') { | 
| 578 | 578 | $c = new curl(); | 
| @@ -945,7 +945,7 @@ discard block | ||
| 945 | 945 | * @param integer $instance | 
| 946 | 946 | * @param integer $voicebridge | 
| 947 | 947 | * | 
| 948 | - * @return string | |
| 948 | + * @return boolean | |
| 949 | 949 | */ | 
| 950 | 950 |  function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) { | 
| 951 | 951 | global $DB; | 
| @@ -1293,7 +1293,7 @@ discard block | ||
| 1293 | 1293 | * @param string $meetingid | 
| 1294 | 1294 | * @param string $configxml | 
| 1295 | 1295 | * | 
| 1296 | - * @return object | |
| 1296 | + * @return null|SimpleXMLElement | |
| 1297 | 1297 | */ | 
| 1298 | 1298 |  function bigbluebuttonbn_set_config_xml($meetingid, $configxml) { | 
| 1299 | 1299 |      $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?'; | 
| @@ -1347,7 +1347,7 @@ discard block | ||
| 1347 | 1347 | * @param array $recording | 
| 1348 | 1348 | * @param array $tools | 
| 1349 | 1349 | * | 
| 1350 | - * @return array | |
| 1350 | + * @return null|stdClass | |
| 1351 | 1351 | */ | 
| 1352 | 1352 |  function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) { | 
| 1353 | 1353 |      if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) { | 
| @@ -1982,7 +1982,7 @@ discard block | ||
| 1982 | 1982 | * | 
| 1983 | 1983 | * @param array $bbbsession | 
| 1984 | 1984 | * @param array $recording | 
| 1985 | - * @param object $rowdata | |
| 1985 | + * @param stdClass $rowdata | |
| 1986 | 1986 | * | 
| 1987 | 1987 | * @return object | 
| 1988 | 1988 | */ | 
| @@ -2131,6 +2131,11 @@ discard block | ||
| 2131 | 2131 | } | 
| 2132 | 2132 | |
| 2133 | 2133 | |
| 2134 | +/** | |
| 2135 | + * @param boolean $type | |
| 2136 | + * @param string $key | |
| 2137 | + * @param string $subkey | |
| 2138 | + */ | |
| 2134 | 2139 |  function bigbluebuttonbn_validate_completion_state($completioncriteria, $logs, $type, $key, $subkey=null) { | 
| 2135 | 2140 |      if ($criteria) { | 
| 2136 | 2141 |          if (!$logs) { | 
| @@ -2204,7 +2209,7 @@ discard block | ||
| 2204 | 2209 | * | 
| 2205 | 2210 | * @param array $bbbsession | 
| 2206 | 2211 | * @param array $recordings | 
| 2207 | - * @param array $tools | |
| 2212 | + * @param string[] $tools | |
| 2208 | 2213 | * | 
| 2209 | 2214 | * @return array | 
| 2210 | 2215 | */ | 
| @@ -2285,7 +2290,7 @@ discard block | ||
| 2285 | 2290 | * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included | 
| 2286 | 2291 | * in the getRecordings request considering only those that belong to deleted activities. | 
| 2287 | 2292 | * | 
| 2288 | - * @param string $courseid | |
| 2293 | + * @param integer $courseid | |
| 2289 | 2294 | * @param string $bigbluebuttonbnid | 
| 2290 | 2295 | * @param bool $subset | 
| 2291 | 2296 | * | 
| @@ -2309,7 +2314,7 @@ discard block | ||
| 2309 | 2314 | * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included | 
| 2310 | 2315 | * in the getRecordings request considering only those that belong to imported recordings. | 
| 2311 | 2316 | * | 
| 2312 | - * @param string $courseid | |
| 2317 | + * @param integer $courseid | |
| 2313 | 2318 | * @param string $bigbluebuttonbnid | 
| 2314 | 2319 | * @param bool $subset | 
| 2315 | 2320 | * | 
| @@ -2332,7 +2337,7 @@ discard block | ||
| 2332 | 2337 | /** | 
| 2333 | 2338 | * Helper function to get recordings and imported recordings together. | 
| 2334 | 2339 | * | 
| 2335 | - * @param string $courseid | |
| 2340 | + * @param integer $courseid | |
| 2336 | 2341 | * @param string $bigbluebuttonbnid | 
| 2337 | 2342 | * @param bool $subset | 
| 2338 | 2343 | * @param bool $includedeleted | 
| @@ -2350,7 +2355,7 @@ discard block | ||
| 2350 | 2355 | * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events | 
| 2351 | 2356 | * in bigbluebuttonbn_logs. | 
| 2352 | 2357 | * | 
| 2353 | - * @param string $courseid | |
| 2358 | + * @param integer $courseid | |
| 2354 | 2359 | * @param string $bigbluebuttonbnid | 
| 2355 | 2360 | * @param bool $subset | 
| 2356 | 2361 | * @param bool $includedeleted | 
| @@ -32,7 +32,7 @@ discard block | ||
| 32 | 32 | |
| 33 | 33 | global $CFG; | 
| 34 | 34 | |
| 35 | -require_once(__DIR__ . '/lib.php'); | |
| 35 | +require_once(__DIR__.'/lib.php'); | |
| 36 | 36 | |
| 37 | 37 | /** @var BIGBLUEBUTTONBN_UPDATE_CACHE boolean set to true indicates that cache has to be updated */ | 
| 38 | 38 | const BIGBLUEBUTTONBN_UPDATE_CACHE = true; | 
| @@ -145,8 +145,8 @@ discard block | ||
| 145 | 145 | $data = null; | 
| 146 | 146 |      if (!is_null($pname) && !is_null($purl)) { | 
| 147 | 147 | $method = 'POST'; | 
| 148 | - $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" . | |
| 149 | - $purl . "' /></module></modules>"; | |
| 148 | + $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='". | |
| 149 | + $purl."' /></module></modules>"; | |
| 150 | 150 | } | 
| 151 | 151 | $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $data); | 
| 152 | 152 |      if ($xml) { | 
| @@ -406,7 +406,7 @@ discard block | ||
| 406 | 406 |          if (is_object($value)) { | 
| 407 | 407 | $value = ''; | 
| 408 | 408 | } | 
| 409 | - $metadataarray['meta_' . $key] = $value; | |
| 409 | + $metadataarray['meta_'.$key] = $value; | |
| 410 | 410 | } | 
| 411 | 411 | return $metadataarray; | 
| 412 | 412 | } | 
| @@ -546,7 +546,7 @@ discard block | ||
| 546 | 546 | return $xml; | 
| 547 | 547 |          } catch (\Exception $e) { | 
| 548 | 548 | libxml_use_internal_errors($previous); | 
| 549 | - $error = 'Caught exception: ' . $e->getMessage(); | |
| 549 | + $error = 'Caught exception: '.$e->getMessage(); | |
| 550 | 550 | debugging($error, DEBUG_DEVELOPER); | 
| 551 | 551 | return null; | 
| 552 | 552 | } | 
| @@ -557,7 +557,7 @@ discard block | ||
| 557 | 557 | $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS); | 
| 558 | 558 | return $response; | 
| 559 | 559 |      } catch (\Exception $e) { | 
| 560 | - $error = 'Caught exception: ' . $e->getMessage(); | |
| 560 | + $error = 'Caught exception: '.$e->getMessage(); | |
| 561 | 561 | debugging($error, DEBUG_DEVELOPER); | 
| 562 | 562 | libxml_use_internal_errors($previous); | 
| 563 | 563 | return null; | 
| @@ -583,8 +583,8 @@ discard block | ||
| 583 | 583 | } | 
| 584 | 584 | $options = array(); | 
| 585 | 585 | $options['CURLOPT_HTTPHEADER'] = array( | 
| 586 | - 'Content-Type: ' . $contenttype, | |
| 587 | - 'Content-Length: ' . strlen($data), | |
| 586 | + 'Content-Type: '.$contenttype, | |
| 587 | + 'Content-Length: '.strlen($data), | |
| 588 | 588 | 'Content-Language: en-US', | 
| 589 | 589 | ); | 
| 590 | 590 | |
| @@ -605,7 +605,7 @@ discard block | ||
| 605 | 605 | * @return void | 
| 606 | 606 | */ | 
| 607 | 607 |  function bigbluebuttonbn_end_meeting_if_running($bigbluebuttonbn) { | 
| 608 | - $meetingid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id; | |
| 608 | + $meetingid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id; | |
| 609 | 609 |      if (bigbluebuttonbn_is_meeting_running($meetingid)) { | 
| 610 | 610 | bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass); | 
| 611 | 611 | } | 
| @@ -625,9 +625,9 @@ discard block | ||
| 625 | 625 |      if ($userroles) { | 
| 626 | 626 | $where = ''; | 
| 627 | 627 |          foreach ($userroles as $userrole) { | 
| 628 | - $where .= (empty($where) ? ' WHERE' : ' OR') . ' id=' . $userrole->roleid; | |
| 628 | + $where .= (empty($where) ? ' WHERE' : ' OR').' id='.$userrole->roleid; | |
| 629 | 629 | } | 
| 630 | -        $userroles = $DB->get_records_sql('SELECT * FROM {role}' . $where); | |
| 630 | +        $userroles = $DB->get_records_sql('SELECT * FROM {role}'.$where); | |
| 631 | 631 | } | 
| 632 | 632 | return $userroles; | 
| 633 | 633 | } | 
| @@ -952,9 +952,9 @@ discard block | ||
| 952 | 952 |      if ($voicebridge == 0) { | 
| 953 | 953 | return true; | 
| 954 | 954 | } | 
| 955 | - $select = 'voicebridge = ' . $voicebridge; | |
| 955 | + $select = 'voicebridge = '.$voicebridge; | |
| 956 | 956 |      if ($instance != 0) { | 
| 957 | - $select .= ' AND id <>' . $instance; | |
| 957 | + $select .= ' AND id <>'.$instance; | |
| 958 | 958 | } | 
| 959 | 959 |      if (!$DB->get_records_select('bigbluebuttonbn', $select)) { | 
| 960 | 960 | return true; | 
| @@ -1090,7 +1090,7 @@ discard block | ||
| 1090 | 1090 |  function bigbluebuttonbn_generate_nonce() { | 
| 1091 | 1091 | $mt = microtime(); | 
| 1092 | 1092 | $rand = mt_rand(); | 
| 1093 | - return md5($mt . $rand); | |
| 1093 | + return md5($mt.$rand); | |
| 1094 | 1094 | } | 
| 1095 | 1095 | |
| 1096 | 1096 | /** | 
| @@ -1138,7 +1138,7 @@ discard block | ||
| 1138 | 1138 | $params['other'] = $options['other']; | 
| 1139 | 1139 | } | 
| 1140 | 1140 | $event = call_user_func_array( | 
| 1141 | - '\mod_bigbluebuttonbn\event\\' . $type . '::create', | |
| 1141 | + '\mod_bigbluebuttonbn\event\\'.$type.'::create', | |
| 1142 | 1142 | array($params) | 
| 1143 | 1143 | ); | 
| 1144 | 1144 |      $event->add_record_snapshot('course_modules', $cm); | 
| @@ -1296,7 +1296,7 @@ discard block | ||
| 1296 | 1296 | * @return object | 
| 1297 | 1297 | */ | 
| 1298 | 1298 |  function bigbluebuttonbn_set_config_xml($meetingid, $configxml) { | 
| 1299 | -    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?'; | |
| 1299 | +    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url').'api/setConfigXML?'; | |
| 1300 | 1300 | $configxmlparams = bigbluebuttonbn_set_config_xml_params($meetingid, $configxml); | 
| 1301 | 1301 | $xml = bigbluebuttonbn_wrap_xml_load_file( | 
| 1302 | 1302 | $urldefaultconfig, | 
| @@ -1316,9 +1316,9 @@ discard block | ||
| 1316 | 1316 | * @return string | 
| 1317 | 1317 | */ | 
| 1318 | 1318 |  function bigbluebuttonbn_set_config_xml_params($meetingid, $configxml) { | 
| 1319 | - $params = 'configXML=' . urlencode($configxml) . '&meetingID=' . urlencode($meetingid); | |
| 1319 | + $params = 'configXML='.urlencode($configxml).'&meetingID='.urlencode($meetingid); | |
| 1320 | 1320 |      $sharedsecret = \mod_bigbluebuttonbn\locallib\config::get('shared_secret'); | 
| 1321 | -    $configxmlparams = $params . '&checksum=' . sha1('setConfigXML' . $params . $sharedsecret); | |
| 1321 | +    $configxmlparams = $params.'&checksum='.sha1('setConfigXML'.$params.$sharedsecret); | |
| 1322 | 1322 | return $configxmlparams; | 
| 1323 | 1323 | } | 
| 1324 | 1324 | |
| @@ -1426,7 +1426,7 @@ discard block | ||
| 1426 | 1426 | global $USER; | 
| 1427 | 1427 | $starttime = $starttime - ($starttime % 1000); | 
| 1428 | 1428 | // Set formatted date. | 
| 1429 | -    $dateformat = get_string('strftimerecentfull', 'langconfig') . ' %Z'; | |
| 1429 | +    $dateformat = get_string('strftimerecentfull', 'langconfig').' %Z'; | |
| 1430 | 1430 | return userdate($starttime / 1000, $dateformat, usertimezone($USER->timezone)); | 
| 1431 | 1431 | } | 
| 1432 | 1432 | |
| @@ -1474,11 +1474,11 @@ discard block | ||
| 1474 | 1474 | $actionbar .= bigbluebuttonbn_actionbar_render_button($recording, $buttonpayload); | 
| 1475 | 1475 | } | 
| 1476 | 1476 |      $head = html_writer::start_tag('div', array( | 
| 1477 | - 'id' => 'recording-actionbar-' . $recording['recordID'], | |
| 1477 | + 'id' => 'recording-actionbar-'.$recording['recordID'], | |
| 1478 | 1478 | 'data-recordingid' => $recording['recordID'], | 
| 1479 | 1479 | 'data-meetingid' => $recording['meetingID'])); | 
| 1480 | 1480 |      $tail = html_writer::end_tag('div'); | 
| 1481 | - return $head . $actionbar . $tail; | |
| 1481 | + return $head.$actionbar.$tail; | |
| 1482 | 1482 | } | 
| 1483 | 1483 | |
| 1484 | 1484 | /** | 
| @@ -1542,7 +1542,7 @@ discard block | ||
| 1542 | 1542 | * @return string | 
| 1543 | 1543 | */ | 
| 1544 | 1544 |  function bigbluebuttonbn_get_recording_data_row_preview($recording) { | 
| 1545 | -    $options = array('id' => 'preview-' . $recording['recordID']); | |
| 1545 | +    $options = array('id' => 'preview-'.$recording['recordID']); | |
| 1546 | 1546 |      if ($recording['published'] === 'false') { | 
| 1547 | 1547 | $options['hidden'] = 'hidden'; | 
| 1548 | 1548 | } | 
| @@ -1574,7 +1574,7 @@ discard block | ||
| 1574 | 1574 |          $recordingpreview .= html_writer::start_tag('div', array('class' => '')); | 
| 1575 | 1575 | $recordingpreview .= html_writer::empty_tag( | 
| 1576 | 1576 | 'img', | 
| 1577 | -            array('src' => trim($image['url']) . '?' . time(), 'class' => 'recording-thumbnail pull-left') | |
| 1577 | +            array('src' => trim($image['url']).'?'.time(), 'class' => 'recording-thumbnail pull-left') | |
| 1578 | 1578 | ); | 
| 1579 | 1579 |          $recordingpreview .= html_writer::end_tag('div'); | 
| 1580 | 1580 | } | 
| @@ -1609,7 +1609,7 @@ discard block | ||
| 1609 | 1609 |      if ($recording['published'] === 'false') { | 
| 1610 | 1610 | $visibility = 'hidden '; | 
| 1611 | 1611 | } | 
| 1612 | - $id = 'playbacks-' . $recording['recordID']; | |
| 1612 | + $id = 'playbacks-'.$recording['recordID']; | |
| 1613 | 1613 |      $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported, | 
| 1614 | 1614 | 'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'], | 
| 1615 | 1615 | 'title' => $title, $visibility => $visibility)); | 
| @@ -1634,14 +1634,14 @@ discard block | ||
| 1634 | 1634 |      if (!bigbluebuttonbn_include_recording_data_row_type($recording, $bbbsession, $playback)) { | 
| 1635 | 1635 | return ''; | 
| 1636 | 1636 | } | 
| 1637 | -    $text = get_string('view_recording_format_' . $playback['type'], 'bigbluebuttonbn'); | |
| 1638 | - $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id . | |
| 1639 | - '&mid=' . $recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type']; | |
| 1637 | +    $text = get_string('view_recording_format_'.$playback['type'], 'bigbluebuttonbn'); | |
| 1638 | + $href = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=play&bn='.$bbbsession['bigbluebuttonbn']->id. | |
| 1639 | + '&mid='.$recording['meetingID'].'&rid='.$recording['recordID'].'&rtype='.$playback['type']; | |
| 1640 | 1640 |      if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') { | 
| 1641 | - $href .= '&href=' . urlencode(trim($playback['url'])); | |
| 1641 | + $href .= '&href='.urlencode(trim($playback['url'])); | |
| 1642 | 1642 | } | 
| 1643 | 1643 | $linkattributes = array( | 
| 1644 | - 'id' => 'recording-play-' . $playback['type'] . '-' . $recording['recordID'], | |
| 1644 | + 'id' => 'recording-play-'.$playback['type'].'-'.$recording['recordID'], | |
| 1645 | 1645 | 'class' => 'btn btn-sm btn-default', | 
| 1646 | 1646 | 'onclick' => 'M.mod_bigbluebuttonbn.recordings.recordingPlay(this);', | 
| 1647 | 1647 | 'data-action' => 'play', | 
| @@ -1653,7 +1653,7 @@ discard block | ||
| 1653 | 1653 |          $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn'); | 
| 1654 | 1654 | unset($linkattributes['data-href']); | 
| 1655 | 1655 | } | 
| 1656 | -    return $OUTPUT->action_link('#', $text, null, $linkattributes) . ' '; | |
| 1656 | +    return $OUTPUT->action_link('#', $text, null, $linkattributes).' '; | |
| 1657 | 1657 | } | 
| 1658 | 1658 | |
| 1659 | 1659 | /** | 
| @@ -1679,7 +1679,7 @@ discard block | ||
| 1679 | 1679 | $validatedurls[$urlhost] = true; | 
| 1680 | 1680 | $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($url, 'HEAD'); | 
| 1681 | 1681 |      if (!isset($curlinfo['http_code']) || $curlinfo['http_code'] != 200) { | 
| 1682 | - $error = "Resources hosted by " . $urlhost . " are unreachable. Server responded with code " . $curlinfo['http_code']; | |
| 1682 | + $error = "Resources hosted by ".$urlhost." are unreachable. Server responded with code ".$curlinfo['http_code']; | |
| 1683 | 1683 | debugging($error, DEBUG_DEVELOPER); | 
| 1684 | 1684 | $validatedurls[$urlhost] = false; | 
| 1685 | 1685 | } | 
| @@ -1770,12 +1770,12 @@ discard block | ||
| 1770 | 1770 | * @return string | 
| 1771 | 1771 | */ | 
| 1772 | 1772 |  function bigbluebuttonbn_get_recording_data_row_text($recording, $text, $source, $data) { | 
| 1773 | - $htmltext = '<span>' . htmlentities($text) . '</span>'; | |
| 1773 | + $htmltext = '<span>'.htmlentities($text).'</span>'; | |
| 1774 | 1774 |      if (empty($data)) { | 
| 1775 | 1775 | return $htmltext; | 
| 1776 | 1776 | } | 
| 1777 | - $target = $data['action'] . '-' . $data['target']; | |
| 1778 | - $id = 'recording-' . $target . '-' . $data['recordingid']; | |
| 1777 | + $target = $data['action'].'-'.$data['target']; | |
| 1778 | + $id = 'recording-'.$target.'-'.$data['recordingid']; | |
| 1779 | 1779 |      $attributes = array('id' => $id, 'class' => 'quickeditlink col-md-20', | 
| 1780 | 1780 | 'data-recordingid' => $data['recordingid'], 'data-meetingid' => $data['meetingid'], | 
| 1781 | 1781 | 'data-target' => $data['target'], 'data-source' => $source); | 
| @@ -1783,7 +1783,7 @@ discard block | ||
| 1783 | 1783 |      $tail = html_writer::end_tag('div'); | 
| 1784 | 1784 |      $payload = array('action' => $data['action'], 'tag' => $data['tag'], 'target' => $data['target']); | 
| 1785 | 1785 | $htmllink = bigbluebuttonbn_actionbar_render_button($recording, $payload); | 
| 1786 | - return $head . $htmltext . $htmllink . $tail; | |
| 1786 | + return $head.$htmltext.$htmllink.$tail; | |
| 1787 | 1787 | } | 
| 1788 | 1788 | |
| 1789 | 1789 | /** | 
| @@ -1801,10 +1801,10 @@ discard block | ||
| 1801 | 1801 | } | 
| 1802 | 1802 | $target = $data['action']; | 
| 1803 | 1803 |      if (isset($data['target'])) { | 
| 1804 | - $target .= '-' . $data['target']; | |
| 1804 | + $target .= '-'.$data['target']; | |
| 1805 | 1805 | } | 
| 1806 | - $id = 'recording-' . $target . '-' . $recording['recordID']; | |
| 1807 | - $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this);'; | |
| 1806 | + $id = 'recording-'.$target.'-'.$recording['recordID']; | |
| 1807 | + $onclick = 'M.mod_bigbluebuttonbn.recordings.recording'.ucfirst($data['action']).'(this);'; | |
| 1808 | 1808 |      if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) { | 
| 1809 | 1809 | // With icon for $manageaction. | 
| 1810 | 1810 |          $iconattributes = array('id' => $id, 'class' => 'iconsmall'); | 
| @@ -1819,13 +1819,13 @@ discard block | ||
| 1819 | 1819 | ); | 
| 1820 | 1820 | } | 
| 1821 | 1821 |          if (isset($data['disabled'])) { | 
| 1822 | - $iconattributes['class'] .= ' fa-' . $data['disabled']; | |
| 1822 | + $iconattributes['class'] .= ' fa-'.$data['disabled']; | |
| 1823 | 1823 | $linkattributes['class'] = 'disabled'; | 
| 1824 | 1824 | unset($linkattributes['onclick']); | 
| 1825 | 1825 | } | 
| 1826 | 1826 | $icon = new pix_icon( | 
| 1827 | - 'i/' . $data['tag'], | |
| 1828 | -            get_string('view_recording_list_actionbar_' . $data['action'], 'bigbluebuttonbn'), | |
| 1827 | + 'i/'.$data['tag'], | |
| 1828 | +            get_string('view_recording_list_actionbar_'.$data['action'], 'bigbluebuttonbn'), | |
| 1829 | 1829 | 'moodle', | 
| 1830 | 1830 | $iconattributes | 
| 1831 | 1831 | ); | 
| @@ -1923,7 +1923,7 @@ discard block | ||
| 1923 | 1923 |      if ($bbbsession['managerecordings']) { | 
| 1924 | 1924 |          $table->head[] = get_string('view_recording_actionbar', 'bigbluebuttonbn'); | 
| 1925 | 1925 | $table->align[] = 'left'; | 
| 1926 | - $table->size[] = (count($tools) * 40) . 'px'; | |
| 1926 | + $table->size[] = (count($tools) * 40).'px'; | |
| 1927 | 1927 | } | 
| 1928 | 1928 | // Get the groups of the user. | 
| 1929 | 1929 | $usergroups = groups_get_all_groups($bbbsession['course']->id, $bbbsession['userID']); | 
| @@ -1988,7 +1988,7 @@ discard block | ||
| 1988 | 1988 | */ | 
| 1989 | 1989 |  function bigbluebuttonbn_get_recording_table_row($bbbsession, $recording, $rowdata) { | 
| 1990 | 1990 | $row = new html_table_row(); | 
| 1991 | - $row->id = 'recording-tr-' . $recording['recordID']; | |
| 1991 | + $row->id = 'recording-tr-'.$recording['recordID']; | |
| 1992 | 1992 | $row->attributes['data-imported'] = 'false'; | 
| 1993 | 1993 | $texthead = ''; | 
| 1994 | 1994 | $texttail = ''; | 
| @@ -2000,15 +2000,15 @@ discard block | ||
| 2000 | 2000 | } | 
| 2001 | 2001 |      $rowdata->date_formatted = str_replace(' ', ' ', $rowdata->date_formatted); | 
| 2002 | 2002 | $row->cells = array(); | 
| 2003 | - $row->cells[] = $texthead . $rowdata->recording . $texttail; | |
| 2004 | - $row->cells[] = $texthead . $rowdata->meeting . $texttail; | |
| 2003 | + $row->cells[] = $texthead.$rowdata->recording.$texttail; | |
| 2004 | + $row->cells[] = $texthead.$rowdata->meeting.$texttail; | |
| 2005 | 2005 | |
| 2006 | - $row->cells[] = $texthead . $rowdata->activity . $texttail; | |
| 2007 | - $row->cells[] = $texthead . $rowdata->description . $texttail; | |
| 2006 | + $row->cells[] = $texthead.$rowdata->activity.$texttail; | |
| 2007 | + $row->cells[] = $texthead.$rowdata->description.$texttail; | |
| 2008 | 2008 |      if (bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession)) { | 
| 2009 | 2009 | $row->cells[] = $rowdata->preview; | 
| 2010 | 2010 | } | 
| 2011 | - $row->cells[] = $texthead . $rowdata->date_formatted . $texttail; | |
| 2011 | + $row->cells[] = $texthead.$rowdata->date_formatted.$texttail; | |
| 2012 | 2012 | $row->cells[] = $rowdata->duration_formatted; | 
| 2013 | 2013 |      if ($bbbsession['managerecordings']) { | 
| 2014 | 2014 | $row->cells[] = $rowdata->actionbar; | 
| @@ -2099,7 +2099,7 @@ discard block | ||
| 2099 | 2099 | // Enqueue it. | 
| 2100 | 2100 | \core\task\manager::queue_adhoc_task($task); | 
| 2101 | 2101 |      } catch (\Exception $e) { | 
| 2102 | -        mtrace("Error while enqueuing completion_update_state task. " . (string) $e); | |
| 2102 | +        mtrace("Error while enqueuing completion_update_state task. ".(string) $e); | |
| 2103 | 2103 | } | 
| 2104 | 2104 | } | 
| 2105 | 2105 | |
| @@ -2131,7 +2131,7 @@ discard block | ||
| 2131 | 2131 | } | 
| 2132 | 2132 | |
| 2133 | 2133 | |
| 2134 | -function bigbluebuttonbn_validate_completion_state($completioncriteria, $logs, $type, $key, $subkey=null) { | |
| 2134 | +function bigbluebuttonbn_validate_completion_state($completioncriteria, $logs, $type, $key, $subkey = null) { | |
| 2135 | 2135 |      if ($criteria) { | 
| 2136 | 2136 |          if (!$logs) { | 
| 2137 | 2137 | // As completion by some criteria was required, the activity hasn't been completed. | 
| @@ -2292,17 +2292,17 @@ discard block | ||
| 2292 | 2292 | * @return string containing the sql used for getting the target bigbluebuttonbn instances | 
| 2293 | 2293 | */ | 
| 2294 | 2294 |  function bigbluebuttonbn_get_recordings_deleted_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) { | 
| 2295 | - $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_DELETE . "' AND meta like '%has_recordings%' AND meta like '%true%'"; | |
| 2295 | + $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_DELETE."' AND meta like '%has_recordings%' AND meta like '%true%'"; | |
| 2296 | 2296 |      if (empty($courseid)) { | 
| 2297 | 2297 | $courseid = 0; | 
| 2298 | 2298 | } | 
| 2299 | 2299 |      if (empty($bigbluebuttonbnid)) { | 
| 2300 | -        return $sql . " AND courseid = {$courseid}"; | |
| 2300 | +        return $sql." AND courseid = {$courseid}"; | |
| 2301 | 2301 | } | 
| 2302 | 2302 |      if ($subset) { | 
| 2303 | -        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'"; | |
| 2303 | +        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'"; | |
| 2304 | 2304 | } | 
| 2305 | -    return $sql . " AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'"; | |
| 2305 | +    return $sql." AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'"; | |
| 2306 | 2306 | } | 
| 2307 | 2307 | |
| 2308 | 2308 | /** | 
| @@ -2316,17 +2316,17 @@ discard block | ||
| 2316 | 2316 | * @return string containing the sql used for getting the target bigbluebuttonbn instances | 
| 2317 | 2317 | */ | 
| 2318 | 2318 |  function bigbluebuttonbn_get_recordings_imported_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) { | 
| 2319 | - $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_IMPORT . "'"; | |
| 2319 | + $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_IMPORT."'"; | |
| 2320 | 2320 |      if (empty($courseid)) { | 
| 2321 | 2321 | $courseid = 0; | 
| 2322 | 2322 | } | 
| 2323 | 2323 |      if (empty($bigbluebuttonbnid)) { | 
| 2324 | -        return $sql . " AND courseid = '{$courseid}'"; | |
| 2324 | +        return $sql." AND courseid = '{$courseid}'"; | |
| 2325 | 2325 | } | 
| 2326 | 2326 |      if ($subset) { | 
| 2327 | -        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'"; | |
| 2327 | +        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'"; | |
| 2328 | 2328 | } | 
| 2329 | -    return $sql . " AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'"; | |
| 2329 | +    return $sql." AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'"; | |
| 2330 | 2330 | } | 
| 2331 | 2331 | |
| 2332 | 2332 | /** | 
| @@ -2385,7 +2385,7 @@ discard block | ||
| 2385 | 2385 | } | 
| 2386 | 2386 | // Prepare select for loading records based on existent bigbluebuttonbns. | 
| 2387 | 2387 |      $sql = 'SELECT DISTINCT meetingid, bigbluebuttonbnid FROM {bigbluebuttonbn_logs} WHERE '; | 
| 2388 | -    $sql .= '(bigbluebuttonbnid=' . implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)) . ')'; | |
| 2388 | +    $sql .= '(bigbluebuttonbnid='.implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)).')'; | |
| 2389 | 2389 | // Include only Create events and exclude those with record not true. | 
| 2390 | 2390 | $sql .= ' AND log = ? AND meta LIKE ? AND meta LIKE ?'; | 
| 2391 | 2391 | // Execute select for loading records based on existent bigbluebuttonbns. | 
| @@ -2568,8 +2568,8 @@ discard block | ||
| 2568 | 2568 |  function bigbluebuttonbn_format_activity_time($time) { | 
| 2569 | 2569 | $activitytime = ''; | 
| 2570 | 2570 |      if ($time) { | 
| 2571 | - $activitytime = calendar_day_representation($time) . ' ' . | |
| 2572 | -        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn') . ' ' . | |
| 2571 | + $activitytime = calendar_day_representation($time).' '. | |
| 2572 | +        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '. | |
| 2573 | 2573 | calendar_time_representation($time); | 
| 2574 | 2574 | } | 
| 2575 | 2575 | return $activitytime; | 
| @@ -3118,16 +3118,16 @@ discard block | ||
| 3118 | 3118 | return $output; | 
| 3119 | 3119 | } | 
| 3120 | 3120 | $output .= $OUTPUT->box_start( | 
| 3121 | - 'box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in', | |
| 3121 | + 'box boxalignleft adminerror alert alert-'.$type.' alert-block fade in', | |
| 3122 | 3122 | 'bigbluebuttonbn_view_general_warning' | 
| 3123 | - ) . "\n"; | |
| 3124 | - $output .= ' ' . $message . "\n"; | |
| 3125 | - $output .= ' <div class="singlebutton pull-right">' . "\n"; | |
| 3123 | + )."\n"; | |
| 3124 | + $output .= ' '.$message."\n"; | |
| 3125 | + $output .= ' <div class="singlebutton pull-right">'."\n"; | |
| 3126 | 3126 |      if (!empty($href)) { | 
| 3127 | 3127 | $output .= bigbluebuttonbn_render_warning_button($href, $text, $class); | 
| 3128 | 3128 | } | 
| 3129 | - $output .= ' </div>' . "\n"; | |
| 3130 | - $output .= $OUTPUT->box_end() . "\n"; | |
| 3129 | + $output .= ' </div>'."\n"; | |
| 3130 | + $output .= $OUTPUT->box_end()."\n"; | |
| 3131 | 3131 | return $output; | 
| 3132 | 3132 | } | 
| 3133 | 3133 | |
| @@ -3151,11 +3151,11 @@ discard block | ||
| 3151 | 3151 |      if ($class == '') { | 
| 3152 | 3152 | $class = 'btn btn-secondary'; | 
| 3153 | 3153 | } | 
| 3154 | - $output = ' <form method="post" action="' . $href . '" class="form-inline">' . "\n"; | |
| 3155 | - $output .= ' <button type="submit" class="' . $class . '"' . "\n"; | |
| 3156 | - $output .= ' title="' . $title . '"' . "\n"; | |
| 3157 | - $output .= ' >' . $text . '</button>' . "\n"; | |
| 3158 | - $output .= ' </form>' . "\n"; | |
| 3154 | + $output = ' <form method="post" action="'.$href.'" class="form-inline">'."\n"; | |
| 3155 | + $output .= ' <button type="submit" class="'.$class.'"'."\n"; | |
| 3156 | + $output .= ' title="'.$title.'"'."\n"; | |
| 3157 | + $output .= ' >'.$text.'</button>'."\n"; | |
| 3158 | + $output .= ' </form>'."\n"; | |
| 3159 | 3159 | return $output; | 
| 3160 | 3160 | } | 
| 3161 | 3161 | |
| @@ -3219,7 +3219,7 @@ discard block | ||
| 3219 | 3219 |  function bigbluebuttonbn_user_can_join_meeting($bigbluebuttonbn, $mid = null, $userid = null) { | 
| 3220 | 3220 | // By default, use a meetingid without groups. | 
| 3221 | 3221 |      if (empty($mid)) { | 
| 3222 | - $mid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id; | |
| 3222 | + $mid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id; | |
| 3223 | 3223 | } | 
| 3224 | 3224 | // When meeting is running, all authorized users can join right in. | 
| 3225 | 3225 |      if (bigbluebuttonbn_is_meeting_running($mid)) { | 
| @@ -3288,7 +3288,7 @@ discard block | ||
| 3288 | 3288 | * @return boolean | 
| 3289 | 3289 | */ | 
| 3290 | 3290 |  function bigbluebuttonbn_has_html5_client() { | 
| 3291 | - $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root() . "html5client/check"; | |
| 3291 | + $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root()."html5client/check"; | |
| 3292 | 3292 | $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($checkurl, 'HEAD'); | 
| 3293 | 3293 | return (isset($curlinfo['http_code']) && $curlinfo['http_code'] == 200); | 
| 3294 | 3294 | } | 
| @@ -3316,7 +3316,7 @@ discard block | ||
| 3316 | 3316 | $bbbsession['modPW'] = $bbbsession['bigbluebuttonbn']->moderatorpass; | 
| 3317 | 3317 | $bbbsession['viewerPW'] = $bbbsession['bigbluebuttonbn']->viewerpass; | 
| 3318 | 3318 | // Database info related to the activity. | 
| 3319 | - $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid . '-' . $bbbsession['course']->id . '-' . | |
| 3319 | + $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'. | |
| 3320 | 3320 | $bbbsession['bigbluebuttonbn']->id; | 
| 3321 | 3321 | $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name; | 
| 3322 | 3322 | $bbbsession['meetingdescription'] = $bbbsession['bigbluebuttonbn']->intro; | 
| @@ -3348,12 +3348,12 @@ discard block | ||
| 3348 | 3348 |      if ($bbbsession['bigbluebuttonbn']->record) { | 
| 3349 | 3349 | // Check if is enable record all from start. | 
| 3350 | 3350 |          if ($bbbsession['recordallfromstart']) { | 
| 3351 | - $bbbsession['welcome'] .= '<br><br>' . get_string( | |
| 3351 | + $bbbsession['welcome'] .= '<br><br>'.get_string( | |
| 3352 | 3352 | 'bbbrecordallfromstartwarning', | 
| 3353 | 3353 | 'bigbluebuttonbn' | 
| 3354 | 3354 | ); | 
| 3355 | 3355 |          } else { | 
| 3356 | -            $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn'); | |
| 3356 | +            $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn'); | |
| 3357 | 3357 | } | 
| 3358 | 3358 | } | 
| 3359 | 3359 | $bbbsession['openingtime'] = $bbbsession['bigbluebuttonbn']->openingtime; | 
| @@ -3368,7 +3368,7 @@ discard block | ||
| 3368 | 3368 | $bbbsession['originServerName'] = $parsedurl['host']; | 
| 3369 | 3369 | $bbbsession['originServerUrl'] = $CFG->wwwroot; | 
| 3370 | 3370 | $bbbsession['originServerCommonName'] = ''; | 
| 3371 | -    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')'; | |
| 3371 | +    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')'; | |
| 3372 | 3372 | $bbbsession['bnserver'] = bigbluebuttonbn_is_bn_server(); | 
| 3373 | 3373 | // Setting for clienttype, assign flash if not enabled, or default if not editable. | 
| 3374 | 3374 | $bbbsession['clienttype'] = BIGBLUEBUTTON_CLIENTTYPE_FLASH; | 
| @@ -3475,7 +3475,7 @@ discard block | ||
| 3475 | 3475 |      if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) { | 
| 3476 | 3476 | $metadata["bn-recording-status"] = json_encode( | 
| 3477 | 3477 | array( | 
| 3478 | -                'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'), | |
| 3478 | +                'email' => array('"'.fullname($USER).'" <'.$USER->email.'>'), | |
| 3479 | 3479 | 'context' => $bbbsession['bigbluebuttonbnURL'], | 
| 3480 | 3480 | ) | 
| 3481 | 3481 | ); |