jf-guillou / lcds

controllers/DeviceController.php

Doc Comments +5 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * Lists all Device models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -59,7 +59,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return string
      */
     public function actionView($id)
     {
@@ -121,7 +121,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {
@@ -164,9 +164,8 @@ 
      * Remove a Screen from a Device.
      *
      * @param int $id
-     * @param int $flowId
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionUnlink($id, $screenId)
     {
@@ -184,7 +183,7 @@ 
      *
      * @param int $id screen id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionToggle($id)
     {

controllers/ScreenController.php

Doc Comments +4 added lines, -4 removed lines

@@ -42,7 +42,7 @@ 
     /**
      * Lists all Screen models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -65,7 +65,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return string
      */
     public function actionView($id)
     {
@@ -146,7 +146,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {
@@ -191,7 +191,7 @@ 
      * @param int $id
      * @param int $flowId
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionUnlink($id, $flowId)
     {

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
             return $this->redirect(['view', 'id' => $model->id]);
         } else {
             $templates = ScreenTemplate::find()->all();
-            $templatesArray = array_reduce($templates, function ($a, $t) {
+            $templatesArray = array_reduce($templates, function($a, $t) {
                 $a[$t->id] = $t->name;
 
                 return $a;
@@ -127,7 +127,7 @@ 
             return $this->redirect(['view', 'id' => $model->id]);
         } else {
             $templates = ScreenTemplate::find()->all();
-            $templatesArray = array_reduce($templates, function ($a, $t) {
+            $templatesArray = array_reduce($templates, function($a, $t) {
                 $a[$t->id] = $t->name;
 
                 return $a;

controllers/ScreenTemplateController.php

Doc Comments +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
     /**
      * Lists all ScreenTemplate models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -62,7 +62,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return string
      */
     public function actionView($id)
     {
@@ -126,7 +126,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {
@@ -209,7 +209,7 @@ 
      *
      * @param int $id field id
      *
-     * @return mixed
+     * @return null|string
      */
     public function actionEditField($id)
     {
@@ -330,7 +330,7 @@ 
      * @param float $min
      * @param float $max
      *
-     * @return float random float
+     * @return integer random float
      */
     public static function randf($min = 0.0, $max = 1.0)
     {

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use app\models\TemplateBackground;
 use yii\data\ActiveDataProvider;
 use yii\helpers\Url;
-use yii\web\Controller;
 use yii\web\NotFoundHttpException;
 use yii\filters\VerbFilter;
 use yii\filters\AccessControl;

Spacing +1 added lines, -1 removed lines

@@ -223,7 +223,7 @@
             if (!is_array($newTypeIds)) {
                 $newTypeIds = [];
             }
-            $oldTypeIds = array_map(function ($c) {
+            $oldTypeIds = array_map(function($c) {
                 return $c->id;
             }, $field->contentTypes);
 

controllers/TemplateBackgroundController.php

Doc Comments +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
     /**
      * Lists all TemplateBackground models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -78,7 +78,7 @@ 
      *
      * @param int $id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {

controllers/UserController.php

Doc Comments +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
     /**
      * Lists all User models.
      *
-     * @return mixed
+     * @return string
      */
     public function actionIndex()
     {
@@ -64,7 +64,7 @@ 
      *
      * @param string $id
      *
-     * @return mixed
+     * @return string
      */
     public function actionView($id)
     {
@@ -134,7 +134,7 @@ 
      *
      * @param string $id
      *
-     * @return mixed
+     * @return \yii\web\Response
      */
     public function actionDelete($id)
     {

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
                 'only' => ['index', 'view', 'create', 'import', 'delete', 'set-roles'],
                 'rules' => [
                     ['allow' => true, 'actions' => ['index', 'view', 'create', 'delete', 'set-roles'], 'roles' => ['admin']],
-                    ['allow' => true, 'actions' => ['import'], 'matchCallback' => function ($rule, $action) {
+                    ['allow' => true, 'actions' => ['import'], 'matchCallback' => function($rule, $action) {
                         return Yii::$app->params['useLdap'];
                     }],
                 ],

models/types/Agenda.php

Doc Comments +2 added lines, -1 removed lines

@@ -54,6 +54,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $filename
      */
     public function genImage($url, $filename)
     {
@@ -550,7 +551,7 @@ 
     /**
      * Trim and decode array content.
      *
-     * @param array $arr input array
+     * @param string $arr input array
      *
      * @return array trimed array
      */

Spacing +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
         // exit(var_dump($blocks));
 
         // Sort blocks by day and group
-        usort($blocks, function ($a, $b) {
+        usort($blocks, function($a, $b) {
             if ($a['day'] != $b['day']) {
                 return $a['day'] - $b['day'];
             }

models/types/HostedVideo.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace app\models\types;
 
 use Yii;
-use app\models\Content;
 use yii\web\UploadedFile;
 use yii\helpers\FileHelper;
 use YoutubeDl\YoutubeDl;

models/types/Media.php

Doc Comments +4 added lines, -3 removed lines

@@ -286,7 +286,7 @@ 
     /**
      * Try to get media info for this media.
      *
-     * @return \MediaInfo|null media info
+     * @return \Mhor\MediaInfo\Container\MediaInfoContainer|null media info
      */
     protected static function getMediaInfo($realFilepath)
     {
@@ -300,7 +300,8 @@ 
     /**
      * Use mediainfo to parse media duration.
      *
-     * @return int media duration
+     * @param string $realFilepath
+     * @return double|null media duration
      */
     public static function getDuration($realFilepath)
     {
@@ -386,7 +387,7 @@ 
      * After delete event
      * Try to delete file if necessary.
      *
-     * @return bool success
+     * @return boolean|null success
      */
     public function afterDelete()
     {

models/types/Weather.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Yii;
 use app\models\Content;
-use yii\helpers\Url;
 
 /**
  * This is the model class for Weather content type.