Completed
Push — master ( 8f6f9d...d708fb )
by Sinnarasa
02:41
created
src/Routing/Matcher/UriMatcher.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     /**
21 21
      * @var array
22 22
      */
23
-    private $matcher = ['matchController','matchTemplate'];
23
+    private $matcher = ['matchController', 'matchTemplate'];
24 24
 
25 25
     /**
26 26
      * @var array
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     /**
42 42
      * @param string $matcher
43 43
      */
44
-    public function addMatcher($matcher){
44
+    public function addMatcher($matcher) {
45 45
         $this->matcher[] = $matcher;
46 46
     }
47 47
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      * @param $class
67 67
      * @return mixed|void
68 68
      */
69
-    public function addDispatcher($method,$class){
69
+    public function addDispatcher($method, $class) {
70 70
         $this->dispatcher[$method] = $class;
71 71
     }
72 72
 
@@ -75,8 +75,8 @@  discard block
 block discarded – undo
75 75
      */
76 76
     public function match()
77 77
     {
78
-        foreach($this->matcher as $matcher){
79
-            if(call_user_func([$this,$matcher])) {
78
+        foreach ($this->matcher as $matcher) {
79
+            if (call_user_func([$this, $matcher])) {
80 80
                 $this->router->response->setStatusCode(202);
81 81
                 return true;
82 82
             }
@@ -91,14 +91,14 @@  discard block
 block discarded – undo
91 91
     {
92 92
         foreach ($this->router->getConfig()['templateExtension'] as $extension) {
93 93
             for ($i = 0; $i < $this->router->collection->countRoutes; ++$i) {
94
-                $url = explode('/', str_replace($this->router->collection->getRoutes('prefix_' . $i), '',$this->router->route->getUrl()));
94
+                $url = explode('/', str_replace($this->router->collection->getRoutes('prefix_' . $i), '', $this->router->route->getUrl()));
95 95
                 $end = array_pop($url);
96
-                $url = implode('/', array_map('ucwords', $url)).'/'.$end;
96
+                $url = implode('/', array_map('ucwords', $url)) . '/' . $end;
97 97
                 if (is_file(($template = rtrim($this->router->collection->getRoutes('view_dir_' . $i), '/') . $url . $extension))) {
98 98
                     $this->router->route->setTarget([
99 99
                         'dispatcher' => $this->dispatcher['matchTemplate'],
100
-                        'block' => $this->router->collection->getRoutes('block_'.$i),
101
-                        'view_dir' => $this->router->collection->getRoutes('view_dir_'.$i),
100
+                        'block' => $this->router->collection->getRoutes('block_' . $i),
101
+                        'view_dir' => $this->router->collection->getRoutes('view_dir_' . $i),
102 102
                         'template' => $template,
103 103
                         'extension' => str_replace('.', '', $extension),
104 104
                         'callback' => $this->router->getConfig()['templateCallback']
@@ -117,18 +117,18 @@  discard block
 block discarded – undo
117 117
     {
118 118
         $routes = array_slice(explode('/', $this->router->route->getUrl()), 1);
119 119
         $i = 0;
120
-        do{
121
-            $route =  ('/' . $routes[0] == $this->router->collection->getRoutes('prefix_' . $i)) ? array_slice($routes, 1) : $routes;
120
+        do {
121
+            $route = ('/' . $routes[0] == $this->router->collection->getRoutes('prefix_' . $i)) ? array_slice($routes, 1) : $routes;
122 122
             if (isset($route[0])) {
123
-                $class =  (class_exists($this->router->collection->getRoutes('ctrl_namespace_' . $i). ucfirst($route[0]) . 'Controller'))
124
-                    ? $this->router->collection->getRoutes('ctrl_namespace_' . $i). ucfirst($route[0]) . 'Controller'
123
+                $class = (class_exists($this->router->collection->getRoutes('ctrl_namespace_' . $i) . ucfirst($route[0]) . 'Controller'))
124
+                    ? $this->router->collection->getRoutes('ctrl_namespace_' . $i) . ucfirst($route[0]) . 'Controller'
125 125
                     : ucfirst($route[0]) . 'Controller';
126
-                $route[1] = isset($route[1])?$route[1]:'index';
126
+                $route[1] = isset($route[1]) ? $route[1] : 'index';
127 127
                 if (method_exists($class, $route[1])) {
128 128
                     $this->router->route->setTarget([
129 129
                         'dispatcher' => $this->dispatcher['matchController'],
130
-                        'block' => $this->router->collection->getRoutes('block_'.$i),
131
-                        'view_dir' => $this->router->collection->getRoutes('view_dir_'.$i),
130
+                        'block' => $this->router->collection->getRoutes('block_' . $i),
131
+                        'view_dir' => $this->router->collection->getRoutes('view_dir_' . $i),
132 132
                         'di' => $this->router->getConfig()['di'],
133 133
                         'controller' => $class,
134 134
                         'action' => $route[1]
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
                 }
139 139
             }
140 140
             ++$i;
141
-        }while($i < $this->router->collection->countRoutes);
141
+        }while ($i < $this->router->collection->countRoutes);
142 142
         return false;
143 143
     }
144 144
 
Please login to merge, or discard this patch.
src/Routing/Matcher/ArrayMatcher.php 2 patches
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     /**
25 25
      * @var array
26 26
      */
27
-    private $matcher = ['matchClosure','matchController','matchTemplate'];
27
+    private $matcher = ['matchClosure', 'matchController', 'matchTemplate'];
28 28
 
29 29
     /**
30 30
      * @var array
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     /**
47 47
      * @param string $matcher
48 48
      */
49
-    public function addMatcher($matcher){
49
+    public function addMatcher($matcher) {
50 50
         $this->matcher[] = $matcher;
51 51
     }
52 52
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     /**
62 62
      * @param array $dispatcher
63 63
      */
64
-    public function setDispatcher($dispatcher = []){
64
+    public function setDispatcher($dispatcher = []) {
65 65
         $this->dispatcher = $dispatcher;
66 66
     }
67 67
 
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      * @return mixed|void
72 72
      * @internal param array $dispatcher
73 73
      */
74
-    public function addDispatcher($method,$class){
74
+    public function addDispatcher($method, $class) {
75 75
         $this->dispatcher[$method] = $class;
76 76
     }
77 77
 
@@ -133,14 +133,14 @@  discard block
 block discarded – undo
133 133
      */
134 134
     private function generateTarget()
135 135
     {
136
-        if($this->validMethod()) {
137
-            foreach($this->matcher as $match)
138
-                if(call_user_func_array([$this,$match],[$this->router->route->getCallback()])) break;
136
+        if ($this->validMethod()) {
137
+            foreach ($this->matcher as $match)
138
+                if (call_user_func_array([$this, $match], [$this->router->route->getCallback()])) break;
139 139
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
140
-            $this->router->route->addTarget('block',$this->router->collection->getRoutes('block_'.$index));
141
-            $this->router->route->addTarget('view_dir',$this->router->collection->getRoutes('view_dir_'.$index));
140
+            $this->router->route->addTarget('block', $this->router->collection->getRoutes('block_' . $index));
141
+            $this->router->route->addTarget('view_dir', $this->router->collection->getRoutes('view_dir_' . $index));
142 142
             $this->router->response->setStatusCode(202);
143
-        }else
143
+        } else
144 144
             $this->router->response->setStatusCode(405);
145 145
         return $this->router->route->hasTarget();
146 146
     }
@@ -148,9 +148,9 @@  discard block
 block discarded – undo
148 148
     /**
149 149
      *
150 150
      */
151
-    private function setRoute(){
151
+    private function setRoute() {
152 152
         if (isset($this->request['params'])) {
153
-            if(is_callable($this->request['params']))
153
+            if (is_callable($this->request['params']))
154 154
                 $this->router->route->setCallback($this->request['params']);
155 155
             else {
156 156
                 (is_array($this->request['params']) && isset($this->request['params']['use']))
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      */
169 169
     public function validMethod()
170 170
     {
171
-        if(is_callable($this->request['params']))return true;
171
+        if (is_callable($this->request['params']))return true;
172 172
         if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest')
173 173
             return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
174 174
         $method = (isset($this->router->route->getDetail()['params']['method'])) ? $this->router->route->getDetail()['params']['method'] : ['GET'];
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
206 206
             $class = (class_exists($routes[0]))
207 207
                 ? $routes[0]
208
-                : $this->router->collection->getRoutes()['ctrl_namespace_'.$index].$routes[0];
208
+                : $this->router->collection->getRoutes()['ctrl_namespace_' . $index] . $routes[0];
209 209
             if (!class_exists($class))
210 210
                 throw new \Exception('Class "' . $class . '." is not found');
211 211
             if (method_exists($class, $routes[1])) {
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
      */
230 230
     public function matchTemplate($callback)
231 231
     {
232
-        if(is_string($callback)) {
232
+        if (is_string($callback)) {
233 233
             $path = trim($callback, '/');
234 234
             $extension = substr(strrchr($path, "."), 1);
235 235
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                     }
247 247
                 }
248 248
             }
249
-            if(is_null($target))
249
+            if (is_null($target))
250 250
                 throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
251 251
             $this->router->route->setTarget([
252 252
                 'dispatcher' => $this->dispatcher['matchTemplate'],
Please login to merge, or discard this patch.
Braces   +36 added lines, -22 removed lines patch added patch discarded remove patch
@@ -118,8 +118,9 @@  discard block
 block discarded – undo
118 118
     {
119 119
         if (substr($this->request['route'], -1) == '*') {
120 120
             $pos = strpos($this->request['route'], '*');
121
-            if (substr($this->router->route->getUrl(), 0, $pos) == substr($this->request['route'], 0, $pos) && isset($this->request['params']))
122
-                return true;
121
+            if (substr($this->router->route->getUrl(), 0, $pos) == substr($this->request['route'], 0, $pos) && isset($this->request['params'])) {
122
+                            return true;
123
+            }
123 124
         }
124 125
         if (preg_match($regex, $this->router->route->getUrl(), $this->request['parameters'])) {
125 126
             array_shift($this->request['parameters']);
@@ -134,14 +135,16 @@  discard block
 block discarded – undo
134 135
     private function generateTarget()
135 136
     {
136 137
         if($this->validMethod()) {
137
-            foreach($this->matcher as $match)
138
-                if(call_user_func_array([$this,$match],[$this->router->route->getCallback()])) break;
138
+            foreach($this->matcher as $match) {
139
+                            if(call_user_func_array([$this,$match],[$this->router->route->getCallback()])) break;
140
+            }
139 141
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
140 142
             $this->router->route->addTarget('block',$this->router->collection->getRoutes('block_'.$index));
141 143
             $this->router->route->addTarget('view_dir',$this->router->collection->getRoutes('view_dir_'.$index));
142 144
             $this->router->response->setStatusCode(202);
143
-        }else
144
-            $this->router->response->setStatusCode(405);
145
+        } else {
146
+                    $this->router->response->setStatusCode(405);
147
+        }
145 148
         return $this->router->route->hasTarget();
146 149
     }
147 150
 
@@ -150,14 +153,18 @@  discard block
 block discarded – undo
150 153
      */
151 154
     private function setRoute(){
152 155
         if (isset($this->request['params'])) {
153
-            if(is_callable($this->request['params']))
154
-                $this->router->route->setCallback($this->request['params']);
155
-            else {
156
+            if(is_callable($this->request['params'])) {
157
+                            $this->router->route->setCallback($this->request['params']);
158
+            } else {
156 159
                 (is_array($this->request['params']) && isset($this->request['params']['use']))
157 160
                     ? $this->router->route->setCallback($this->request['params']['use'])
158 161
                     : $this->router->route->setCallback($this->request['params']);
159
-                if (isset($this->request['params']['name'])) $this->router->route->setName($this->request['params']['name']);
160
-                if (isset($this->request['params']['method'])) $this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];
162
+                if (isset($this->request['params']['name'])) {
163
+                    $this->router->route->setName($this->request['params']['name']);
164
+                }
165
+                if (isset($this->request['params']['method'])) {
166
+                    $this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];
167
+                }
161 168
             }
162 169
         }
163 170
         $this->router->route->setDetail($this->request);
@@ -168,9 +175,12 @@  discard block
 block discarded – undo
168 175
      */
169 176
     public function validMethod()
170 177
     {
171
-        if(is_callable($this->request['params']))return true;
172
-        if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest')
173
-            return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
178
+        if(is_callable($this->request['params'])) {
179
+            return true;
180
+        }
181
+        if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
182
+                    return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
183
+        }
174 184
         $method = (isset($this->router->route->getDetail()['params']['method'])) ? $this->router->route->getDetail()['params']['method'] : ['GET'];
175 185
         return (in_array($this->router->route->getMethod(), $method)) ? true : false;
176 186
     }
@@ -201,13 +211,16 @@  discard block
 block discarded – undo
201 211
     {
202 212
         if (is_string($callback) && strpos($callback, '@') !== false) {
203 213
             $routes = explode('@', $callback);
204
-            if (!isset($routes[1])) $routes[1] = 'index';
214
+            if (!isset($routes[1])) {
215
+                $routes[1] = 'index';
216
+            }
205 217
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
206 218
             $class = (class_exists($routes[0]))
207 219
                 ? $routes[0]
208 220
                 : $this->router->collection->getRoutes()['ctrl_namespace_'.$index].$routes[0];
209
-            if (!class_exists($class))
210
-                throw new \Exception('Class "' . $class . '." is not found');
221
+            if (!class_exists($class)) {
222
+                            throw new \Exception('Class "' . $class . '." is not found');
223
+            }
211 224
             if (method_exists($class, $routes[1])) {
212 225
                 $this->router->route->setTarget([
213 226
                     'dispatcher' => $this->dispatcher['matchController'],
@@ -235,9 +248,9 @@  discard block
 block discarded – undo
235 248
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
236 249
             $viewDir = $this->router->collection->getRoutes('view_dir_' . $index);
237 250
             $target = null;
238
-            if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) || is_file($fullPath = $path)))
239
-                $target = $fullPath;
240
-            else {
251
+            if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) || is_file($fullPath = $path))) {
252
+                            $target = $fullPath;
253
+            } else {
241 254
                 foreach ($this->router->getConfig()['templateExtension'] as $ext) {
242 255
                     if (is_file($fullPath = $viewDir . $path . $ext) || is_file($fullPath = $path . $ext)) {
243 256
                         $target = $fullPath;
@@ -246,8 +259,9 @@  discard block
 block discarded – undo
246 259
                     }
247 260
                 }
248 261
             }
249
-            if(is_null($target))
250
-                throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
262
+            if(is_null($target)) {
263
+                            throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
264
+            }
251 265
             $this->router->route->setTarget([
252 266
                 'dispatcher' => $this->dispatcher['matchTemplate'],
253 267
                 'template'   => $target,
Please login to merge, or discard this patch.
src/Routing/Router.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -46,13 +46,13 @@  discard block
 block discarded – undo
46 46
      * @param ResponseInterface $response
47 47
      * @param Route $route
48 48
      */
49
-    public function __construct(RouteCollection $collection,ResponseInterface $response = null,Route $route = null)
49
+    public function __construct(RouteCollection $collection, ResponseInterface $response = null, Route $route = null)
50 50
     {
51 51
         $this->collection = $collection;
52
-        $this->response = is_null($response)? new Response() : $response;
52
+        $this->response = is_null($response) ? new Response() : $response;
53 53
         $this->response->setStatusCode(404);
54
-        $this->route = is_null($route)? new Route() : $route;
55
-        $this->config['di'] = function($class){
54
+        $this->route = is_null($route) ? new Route() : $route;
55
+        $this->config['di'] = function($class) {
56 56
             return new $class;
57 57
         };
58 58
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     /**
77 77
      * @param string $matcher
78 78
      */
79
-    public function addMatcher($matcher){
79
+    public function addMatcher($matcher) {
80 80
         $this->config['matcher'][] = $matcher;
81 81
     }
82 82
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     public function callTarget()
124 124
     {
125 125
         $target = $this->route->getTarget('dispatcher');
126
-        if(!empty($target)) {
126
+        if (!empty($target)) {
127 127
             $this->dispatcher = new $target($this->route, $this->response);
128 128
             return call_user_func([$this->dispatcher, 'call']);
129 129
         }
@@ -157,12 +157,12 @@  discard block
 block discarded – undo
157 157
     {
158 158
         if (isset($this->route->getDetail()['response_templates']) && isset($this->route->getDetail()['response_templates'][$code = $this->response->getStatusCode()])) {
159 159
             $this->route->setCallback($this->route->getDetail()['response_templates'][$code]);
160
-            if(!isset($this->config['matcherInstance']))
160
+            if (!isset($this->config['matcherInstance']))
161 161
                 foreach ($this->config['matcher'] as $matcher)
162 162
                     $this->config['matcherInstance'][$matcher] = new $matcher($this);
163
-            foreach($this->config['matcherInstance'] as $instance) {
163
+            foreach ($this->config['matcherInstance'] as $instance) {
164 164
                 foreach (call_user_func([$instance, 'getMatcher']) as $match)
165
-                    if (call_user_func_array([$instance, $match],[$this->route->getCallback()])){ $this->callTarget(); break; }
165
+                    if (call_user_func_array([$instance, $match], [$this->route->getCallback()])) { $this->callTarget(); break; }
166 166
             }
167 167
             $this->response->setStatusCode($code);
168 168
         }
Please login to merge, or discard this patch.
Braces   +17 added lines, -10 removed lines patch added patch discarded remove patch
@@ -86,7 +86,9 @@  discard block
 block discarded – undo
86 86
     public function run()
87 87
     {
88 88
         $this->setUrl();
89
-        if ($this->config['generateRoutesPath']) $this->collection->generateRoutesPath();
89
+        if ($this->config['generateRoutesPath']) {
90
+            $this->collection->generateRoutesPath();
91
+        }
90 92
         if ($this->match()) {
91 93
             $this->handle();
92 94
             $this->callTarget();
@@ -99,8 +101,9 @@  discard block
 block discarded – undo
99 101
      */
100 102
     public function setUrl($url = null)
101 103
     {
102
-        if (is_null($url))
103
-            $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);
104
+        if (is_null($url)) {
105
+                    $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);
106
+        }
104 107
         $this->route->setUrl('/' . trim(explode('?', $url)[0], '/'));
105 108
     }
106 109
 
@@ -111,8 +114,9 @@  discard block
 block discarded – undo
111 114
     {
112 115
         foreach ($this->config['matcher'] as $matcher) {
113 116
             $this->config['matcherInstance'][$matcher] = new $matcher($this);
114
-            if (call_user_func([$this->config['matcherInstance'][$matcher], 'match']))
115
-                return true;
117
+            if (call_user_func([$this->config['matcherInstance'][$matcher], 'match'])) {
118
+                            return true;
119
+            }
116 120
         }
117 121
         return false;
118 122
     }
@@ -157,12 +161,15 @@  discard block
 block discarded – undo
157 161
     {
158 162
         if (isset($this->route->getDetail()['response_templates']) && isset($this->route->getDetail()['response_templates'][$code = $this->response->getStatusCode()])) {
159 163
             $this->route->setCallback($this->route->getDetail()['response_templates'][$code]);
160
-            if(!isset($this->config['matcherInstance']))
161
-                foreach ($this->config['matcher'] as $matcher)
162
-                    $this->config['matcherInstance'][$matcher] = new $matcher($this);
164
+            if(!isset($this->config['matcherInstance'])) {
165
+                            foreach ($this->config['matcher'] as $matcher)
166
+                    $this->config['matcherInstance'][$matcher] = new $matcher($this);
167
+            }
163 168
             foreach($this->config['matcherInstance'] as $instance) {
164
-                foreach (call_user_func([$instance, 'getMatcher']) as $match)
165
-                    if (call_user_func_array([$instance, $match],[$this->route->getCallback()])){ $this->callTarget(); break; }
169
+                foreach (call_user_func([$instance, 'getMatcher']) as $match) {
170
+                                    if (call_user_func_array([$instance, $match],[$this->route->getCallback()])){ $this->callTarget();
171
+                }
172
+                break; }
166 173
             }
167 174
             $this->response->setStatusCode($code);
168 175
         }
Please login to merge, or discard this patch.
src/Routing/RouteCollection.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
      */
43 43
     public function addRoutes($routes = null, $options = [])
44 44
     {
45
-        if(!is_null($routes) && !is_array($routes)) {
45
+        if (!is_null($routes) && !is_array($routes)) {
46 46
             if (strpos($routes, '.php') === false) $routes = trim($routes, '/') . '/';
47 47
             if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) $routes = $routesFile;
48 48
             elseif (is_file($routes) && is_array($routesFile = include $routes)) $routes = $routesFile;
49
-            else throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "'.$routes.'" given');
49
+            else throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "' . $routes . '" given');
50 50
         }
51 51
         $this->routes['routes_' . $this->countRoutes] = is_array($routes) ? $routes : [];
52 52
         $this->routes['view_dir_' . $this->countRoutes] = (isset($options['view_dir']) && !empty($options['view_dir'])) ? rtrim($options['view_dir'], '/') . '/' : '';
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function getRoutes($key = null)
64 64
     {
65
-        if(!is_null($key))
66
-            return isset($this->routes[$key])?$this->routes[$key]:'';
65
+        if (!is_null($key))
66
+            return isset($this->routes[$key]) ? $this->routes[$key] : '';
67 67
         return $this->routes;
68 68
     }
69 69
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         } elseif (is_string($args))
80 80
             for ($i = 0; $i < $this->countRoutes; ++$i)
81 81
                 $this->routes['prefix_' . $i] = '/' . trim($args, '/');
82
-        if($this->countRoutes == 0)$this->countRoutes++;
82
+        if ($this->countRoutes == 0)$this->countRoutes++;
83 83
     }
84 84
 
85 85
     /**
@@ -89,15 +89,15 @@  discard block
 block discarded – undo
89 89
     {
90 90
         $nbrArgs = count($args);
91 91
         for ($i = 0; $i < $nbrArgs; ++$i) {
92
-            if(is_array($args[$i])){
92
+            if (is_array($args[$i])) {
93 93
                 $this->routes['block_' . $i] = (isset($args[$i]['block']) && !empty($args[$i]['block'])) ? rtrim($args[$i]['block'], '/') . '/' : '';
94 94
                 $this->routes['view_dir_' . $i] = (isset($args[$i]['view_dir']) && !empty($args[$i]['view_dir'])) ? rtrim($args[$i]['view_dir'], '/') . '/' : '';
95 95
                 $this->routes['ctrl_namespace_' . $i] = (isset($args[$i]['ctrl_namespace']) && !empty($args[$i]['ctrl_namespace'])) ? trim($args[$i]['ctrl_namespace'], '\\') . '\\' : '';
96
-                $this->routes['prefix_' . $i] = (isset($args[$i]['prefix']) && !empty($args[$i]['prefix'])) ? '/'.trim($args[$i]['prefix'], '/') : '';
97
-                if(!isset($this->routes['routes_' . $i]))$this->routes['routes_' . $i] = [];
96
+                $this->routes['prefix_' . $i] = (isset($args[$i]['prefix']) && !empty($args[$i]['prefix'])) ? '/' . trim($args[$i]['prefix'], '/') : '';
97
+                if (!isset($this->routes['routes_' . $i]))$this->routes['routes_' . $i] = [];
98 98
             }
99 99
         }
100
-        if($this->countRoutes == 0)$this->countRoutes++;
100
+        if ($this->countRoutes == 0)$this->countRoutes++;
101 101
     }
102 102
 
103 103
     /**
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      */
120 120
     public function generateRoutesPath()
121 121
     {
122
-        $root = 'http://' . (isset($_SERVER['HTTP_HOST'])?$_SERVER['HTTP_HOST']:$_SERVER['SERVER_NAME']) . str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']);
122
+        $root = 'http://' . (isset($_SERVER['HTTP_HOST']) ? $_SERVER['HTTP_HOST'] : $_SERVER['SERVER_NAME']) . str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']);
123 123
         $count = 0;
124 124
         for ($i = 0; $i < $this->countRoutes; ++$i) {
125 125
             $prefix = (isset($this->routes['prefix_' . $i])) ? $this->routes['prefix_' . $i] : '';
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
                 foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
128 128
                     if (is_array($dependencies) && isset($dependencies['use']))
129 129
                         $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
130
-                    elseif(!is_array($dependencies))
130
+                    elseif (!is_array($dependencies))
131 131
                         $use = (is_callable($dependencies)) ? 'closure-' . $count : trim($dependencies, '/');
132 132
                     else
133 133
                         $use = $route;
Please login to merge, or discard this patch.
Braces   +60 added lines, -31 removed lines patch added patch discarded remove patch
@@ -33,7 +33,9 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function __construct($routes = null, $options = [])
35 35
     {
36
-        if (!is_null($routes) || !empty($options)) $this->addRoutes($routes, $options);
36
+        if (!is_null($routes) || !empty($options)) {
37
+            $this->addRoutes($routes, $options);
38
+        }
37 39
     }
38 40
 
39 41
     /**
@@ -43,10 +45,16 @@  discard block
 block discarded – undo
43 45
     public function addRoutes($routes = null, $options = [])
44 46
     {
45 47
         if(!is_null($routes) && !is_array($routes)) {
46
-            if (strpos($routes, '.php') === false) $routes = trim($routes, '/') . '/';
47
-            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) $routes = $routesFile;
48
-            elseif (is_file($routes) && is_array($routesFile = include $routes)) $routes = $routesFile;
49
-            else throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "'.$routes.'" given');
48
+            if (strpos($routes, '.php') === false) {
49
+                $routes = trim($routes, '/') . '/';
50
+            }
51
+            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) {
52
+                $routes = $routesFile;
53
+            } elseif (is_file($routes) && is_array($routesFile = include $routes)) {
54
+                $routes = $routesFile;
55
+            } else {
56
+                throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "'.$routes.'" given');
57
+            }
50 58
         }
51 59
         $this->routes['routes_' . $this->countRoutes] = is_array($routes) ? $routes : [];
52 60
         $this->routes['view_dir_' . $this->countRoutes] = (isset($options['view_dir']) && !empty($options['view_dir'])) ? rtrim($options['view_dir'], '/') . '/' : '';
@@ -62,8 +70,9 @@  discard block
 block discarded – undo
62 70
      */
63 71
     public function getRoutes($key = null)
64 72
     {
65
-        if(!is_null($key))
66
-            return isset($this->routes[$key])?$this->routes[$key]:'';
73
+        if(!is_null($key)) {
74
+                    return isset($this->routes[$key])?$this->routes[$key]:'';
75
+        }
67 76
         return $this->routes;
68 77
     }
69 78
 
@@ -74,12 +83,18 @@  discard block
 block discarded – undo
74 83
     {
75 84
         if (is_array($args)) {
76 85
             $nbrArgs = count($args);
77
-            for ($i = 0; $i < $nbrArgs; ++$i)
78
-                $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
79
-        } elseif (is_string($args))
80
-            for ($i = 0; $i < $this->countRoutes; ++$i)
81
-                $this->routes['prefix_' . $i] = '/' . trim($args, '/');
82
-        if($this->countRoutes == 0)$this->countRoutes++;
86
+            for ($i = 0; $i < $nbrArgs; ++$i) {
87
+                            $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
88
+            }
89
+        } elseif (is_string($args)) {
90
+                    for ($i = 0;
91
+        }
92
+        $i < $this->countRoutes; ++$i) {
93
+                            $this->routes['prefix_' . $i] = '/' . trim($args, '/');
94
+            }
95
+        if($this->countRoutes == 0) {
96
+            $this->countRoutes++;
97
+        }
83 98
     }
84 99
 
85 100
     /**
@@ -94,10 +109,14 @@  discard block
 block discarded – undo
94 109
                 $this->routes['view_dir_' . $i] = (isset($args[$i]['view_dir']) && !empty($args[$i]['view_dir'])) ? rtrim($args[$i]['view_dir'], '/') . '/' : '';
95 110
                 $this->routes['ctrl_namespace_' . $i] = (isset($args[$i]['ctrl_namespace']) && !empty($args[$i]['ctrl_namespace'])) ? trim($args[$i]['ctrl_namespace'], '\\') . '\\' : '';
96 111
                 $this->routes['prefix_' . $i] = (isset($args[$i]['prefix']) && !empty($args[$i]['prefix'])) ? '/'.trim($args[$i]['prefix'], '/') : '';
97
-                if(!isset($this->routes['routes_' . $i]))$this->routes['routes_' . $i] = [];
112
+                if(!isset($this->routes['routes_' . $i])) {
113
+                    $this->routes['routes_' . $i] = [];
114
+                }
98 115
             }
99 116
         }
100
-        if($this->countRoutes == 0)$this->countRoutes++;
117
+        if($this->countRoutes == 0) {
118
+            $this->countRoutes++;
119
+        }
101 120
     }
102 121
 
103 122
     /**
@@ -106,12 +125,16 @@  discard block
 block discarded – undo
106 125
      */
107 126
     public function setMiddleware($middleware)
108 127
     {
109
-        if (is_string($middleware)) $middleware = rtrim($middleware, '/');
110
-        if (is_array($middleware))
111
-            $this->middleware = $middleware;
112
-        elseif (is_file($middleware) && is_array($mid = include $middleware))
113
-            $this->middleware = $mid;
114
-        else throw new \InvalidArgumentException('Accepted argument for setMiddleware are array and array file');
128
+        if (is_string($middleware)) {
129
+            $middleware = rtrim($middleware, '/');
130
+        }
131
+        if (is_array($middleware)) {
132
+                    $this->middleware = $middleware;
133
+        } elseif (is_file($middleware) && is_array($mid = include $middleware)) {
134
+                    $this->middleware = $mid;
135
+        } else {
136
+            throw new \InvalidArgumentException('Accepted argument for setMiddleware are array and array file');
137
+        }
115 138
     }
116 139
 
117 140
     /**
@@ -123,14 +146,15 @@  discard block
 block discarded – undo
123 146
         $count = 0;
124 147
         for ($i = 0; $i < $this->countRoutes; ++$i) {
125 148
             $prefix = (isset($this->routes['prefix_' . $i])) ? $this->routes['prefix_' . $i] : '';
126
-            if (isset($this->routes['routes_' . $i]))
127
-                foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
149
+            if (isset($this->routes['routes_' . $i])) {
150
+                            foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
128 151
                     if (is_array($dependencies) && isset($dependencies['use']))
129
-                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
130
-                    elseif(!is_array($dependencies))
131
-                        $use = (is_callable($dependencies)) ? 'closure-' . $count : trim($dependencies, '/');
132
-                    else
133
-                        $use = $route;
152
+                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
153
+            } elseif(!is_array($dependencies)) {
154
+                                            $use = (is_callable($dependencies)) ? 'closure-' . $count : trim($dependencies, '/');
155
+                    } else {
156
+                                            $use = $route;
157
+                    }
134 158
                     (!is_callable($dependencies) && isset($dependencies['name'])) ? $this->routesByName[$use . '#' . $dependencies['name']] = $root . $prefix . $route : $this->routesByName[$use] = $root . $prefix . $route;
135 159
                     $count++;
136 160
                 }
@@ -147,9 +171,14 @@  discard block
 block discarded – undo
147 171
     {
148 172
         foreach ($this->routesByName as $key => $route) {
149 173
             $param = explode('#', $key);
150
-            foreach ($params as $key2 => $value) $route = str_replace(':' . $key2, $value, $route);
151
-            if ($param[0] == trim($name, '/')) return $route;
152
-            else if (isset($param[1]) && $param[1] == $name) return $route;
174
+            foreach ($params as $key2 => $value) {
175
+                $route = str_replace(':' . $key2, $value, $route);
176
+            }
177
+            if ($param[0] == trim($name, '/')) {
178
+                return $route;
179
+            } else if (isset($param[1]) && $param[1] == $name) {
180
+                return $route;
181
+            }
153 182
         }
154 183
         return null;
155 184
     }
Please login to merge, or discard this patch.