View GitHub Repository laravel-roles

Schedule Inspection
Subscribe
Test Setup Failed
Pull Request — master (#206)
by
unknown
05:14
created
Status
Category
Toggle Patches
tests/Feature/NPlusOneQueriesTest.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch 
@@ -20,8 +20,8 @@  discard block
 
 block discarded – undo
20 20 
      * please indicate their number here
21 21 
      */
22 22 
     protected $usersCountCorrection = 0;
23 
-    protected $rolesCount = 3;//correct according to your data
24 
-    protected $permissionsCount = 4;//correct according to your data
23 
+    protected $rolesCount = 3; //correct according to your data
24 
+    protected $permissionsCount = 4; //correct according to your data
25 25
26 26 
     protected $queries = 0;
27 27 
 
@@ -32,7 +32,7 @@  discard block
 
 block discarded – undo
32 32 
         $this->assertEquals($this->rolesCount, config('roles.models.role')::count());
33 33 
         $this->assertEquals($this->permissionsCount, config('roles.models.permission')::count());
34 34
35 
-        DB::listen(function (QueryExecuted $query) {
35 
+        DB::listen(function(QueryExecuted $query) {
36 36 
             $this->queries++;
37 37 
         });
38 38 
     }
 
@@ -43,7 +43,7 @@  discard block
 
 block discarded – undo
43 43 
         $roleIds = config('roles.models.role')::pluck('id');
44 44
45 45 
         User::factory($this->usersCount)->create()
46 
-            ->each(function (User $user) use ($roleIds) {
46 
+            ->each(function(User $user) use ($roleIds) {
47 47 
                 $user->roles()->attach($roleIds);
48 48 
             });
49 49 
         $this->assertEquals($this->usersCount, User::count() - $this->usersCountCorrection);
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
         $users = User::get();
55 55 
         $this->assertQueries(1);
56 56
57 
-        $users->each(function (User $user) {
57 
+        $users->each(function(User $user) {
58 58 
             $user->getRoles();
59 59 
         });
60 60 
         $this->queries = $this->queries - $this->usersCountCorrection;
 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64 
         $users = User::with('roles')->get();
65 65 
         $this->assertQueries(2);
66 66
67 
-        $users->each(function (User $user) {
67 
+        $users->each(function(User $user) {
68 68 
             $user->getRoles();
69 69 
         });
70 70 
         $this->assertQueries(0);
 
@@ -142,7 +142,7 @@  discard block
 
 block discarded – undo
142 142 
         $roleIds = config('roles.models.role')::pluck('id');
143 143
144 144 
         User::factory($this->usersCount)->create()
145 
-            ->each(function (User $user) use ($roleIds) {
145 
+            ->each(function(User $user) use ($roleIds) {
146 146 
                 $user->roles()->attach($roleIds);
147 147 
             });
148 148 
         $this->assertEquals($this->usersCount, User::count() - $this->usersCountCorrection);
 
@@ -153,7 +153,7 @@  discard block
 
 block discarded – undo
153 153 
         $users = User::get();
154 154 
         $this->assertQueries(1);
155 155
156 
-        $users->each(function (User $user) {
156 
+        $users->each(function(User $user) {
157 157 
             $user->getPermissions();
158 158 
         });
159 159 
         // rolePermissions(+getRoles) + userPermissions
 
@@ -164,7 +164,7 @@  discard block
 
 block discarded – undo
164 164 
         $users = User::with('roles', 'userPermissions')->get();
165 165 
         $this->assertQueries(3);
166 166
167 
-        $users->each(function (User $user) {
167 
+        $users->each(function(User $user) {
168 168 
             $user->getPermissions();
169 169 
         });
170 170 
         // TODO: optimize via relations: userPermissions and rolePermissions
Please login to merge, or discard this patch.