Inspection of "Fixed a bug where adding a static bug would happen..." - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 8acba5...dfac37 )

by Jens

created 2016-05-09 09:30 UTC

Status

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -3,7 +3,7 @@  discard block
 block discarded – undo
 <script src="//netdna.bootstrapcdn.com/bootstrap/3.0.1/js/bootstrap.min.js"></script>
 <link href="//netdna.bootstrapcdn.com/font-awesome/4.0.3/css/font-awesome.min.css" rel="stylesheet">
 <script>var smallestImage = '<?=$smallestImage?>';</script>
-<?$copyable=''?>
+<?$copyable = ''?>
 <section class="documents">
 	<h2><i class="fa fa-file-text-o"></i> Documents</h2>
 	<nav class="actions">
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
 				<label for="state">Published</label>
 				<input<?=isset($document) && $document->state == 'published' ? ' checked="checked"' : '' ?> type="checkbox" id="state" name="state" placeholder="State" />
 			</div>
-			<?$fieldPrefix='fields';?>
+			<?$fieldPrefix = 'fields'; ?>
 			<? foreach ($documentType->fields as $field) : ?>
 				<div class="form-element">
 					<label for="<?=$field->slug?>"><?=$field->title?></label>
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
 								<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
 								<div class="form-element">
 					<? endif ?>
-						<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+						<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 					<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
 
 								</div>
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
 							<li class="grid-container">
 								<div class="grid-box-10">
 									<div class="grid-inner form-element">
-										<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+										<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 									</div>
 								</div>
 								<div class="grid-box-2">
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
 									</div>
 								</div>
 							</li>
-							<?$value='';?>
+							<?$value = ''; ?>
 							<? endforeach ?>
 						<? endif ?>
 					</ul>
@@ -111,10 +111,10 @@  discard block
 block discarded – undo
 								<a class="btn error js-deletemultiple"><i class="fa fa-times"></i></a>
 								<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
 								<div class="form-element">
-								<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+								<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 								</div>
 							</li>
-							<?$value='';?>
+							<?$value = ''; ?>
 						<? endforeach ?>
 						<? endif ?>
 						</div>
@@ -123,17 +123,17 @@  discard block
 block discarded – undo
 					<a class="btn js-addrtemultiple">+</a>
 					<? endif ?>
 				</div>
-				<?$value='';?>
+				<?$value = ''; ?>
 			<? endforeach ?>
 			<hr />
-			<? $static_brick_nr = 0;?>
+			<? $static_brick_nr = 0; ?>
 			<? foreach ($documentType->bricks as $brick) : ?>
 			<div class="brick">
 				<label><?=$brick->title?></label>
 				<? if ($brick->multiple == 'true') : ?>
 					<input type="hidden" value="<?=$brick->brickSlug?>"/>
 					<input type="hidden" value="<?=$brick->slug?>"/>
-					<?$myBrickSlug=$brick->slug;?>
+					<?$myBrickSlug = $brick->slug; ?>
 					<ul id="newBrickDropzone_<?=$static_brick_nr?>" class="dynamicBricks sortable">
 						<? if (isset($document)) : ?>
 							<? foreach ($document->bricks as $currentBrickSlug => $brickArray) : ?>
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
 									<li class="brick form-element">
 										<label><?=$brick->title?></label>
 										<?$static = true; ?>
-										<?include(__DIR__ . '/brick.php')?>
+										<?include(__DIR__.'/brick.php')?>
 									</li>
 									<? endif ?>
 								<? endforeach ?>
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
 					<a class="btn" onclick="addDynamicBrick(this, 'true', 'newBrickDropzone_<?=$static_brick_nr?>');">+</a>
 					<?$static_brick_nr += 1?>
 				<? else : ?>
-					<?$fieldPrefix='bricks[' . $brick->slug . '][fields]';?>
+					<?$fieldPrefix = 'bricks['.$brick->slug.'][fields]'; ?>
 					<input type="hidden" name="bricks[<?=$brick->slug?>][type]" value="<?=$brick->brickSlug?>" />
 					<? foreach ($brick->structure->fields as $field) : ?>
 						<div class="form-element">
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
 									<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
 									<div class="form-element">
 						<? endif ?>
-							<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+							<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 						<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
 
 									</div>
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
 								<li class="grid-container">
 									<div class="grid-box-10">
 										<div class="grid-inner form-element">
-											<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+											<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 										</div>
 									</div>
 									<div class="grid-box-2">
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
 										</div>
 									</div>
 								</li>
-								<?$value='';?>
+								<?$value = ''; ?>
 								<? endforeach ?>
 							<? endif ?>
 						</ul>
@@ -234,10 +234,10 @@  discard block
 block discarded – undo
 									<a class="btn error js-deletemultiple"><i class="fa fa-times"></i></a>
 									<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
 									<div class="form-element">
-									<? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
+									<? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
 									</div>
 								</li>
-								<?$value='';?>
+								<?$value = ''; ?>
 							<? endforeach ?>
 							<? endif ?>
 							</div>
@@ -246,12 +246,12 @@  discard block
 block discarded – undo
 						<a class="btn js-addrtemultiple">+</a>
 						<? endif ?>
 					</div>
-					<?$value='';?>
+					<?$value = ''; ?>
 				<? endforeach ?>
 				<? endif ?>
 				</div>
 				<hr />
-			<? endforeach;?>
+			<? endforeach; ?>
 
 
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
 						<li class="brick form-element">
 							<label><?=$brick->title?></label>
 							<?$static = false; ?>
-							<?include(__DIR__ . '/brick.php')?>
+							<?include(__DIR__.'/brick.php')?>
 						</li>
 					<? endforeach ?>
 				<? endif ?>

Please login to merge, or discard this patch.

		@@ -3,7 +3,7 @@ discard block
		block discarded – undo
3	3	<script src="//netdna.bootstrapcdn.com/bootstrap/3.0.1/js/bootstrap.min.js"></script>
4	4	<link href="//netdna.bootstrapcdn.com/font-awesome/4.0.3/css/font-awesome.min.css" rel="stylesheet">
5	5	<script>var smallestImage = '<?=$smallestImage?>';</script>
6		-<?$copyable=''?>
	6	+<?$copyable = ''?>
7	7	<section class="documents">
8	8	<h2><i class="fa fa-file-text-o"></i> Documents</h2>
9	9	<nav class="actions">
		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	<label for="state">Published</label>
39	39	<input<?=isset($document) && $document->state == 'published' ? ' checked="checked"' : '' ?> type="checkbox" id="state" name="state" placeholder="State" />
40	40	</div>
41		- <?$fieldPrefix='fields';?>
	41	+ <?$fieldPrefix = 'fields'; ?>
42	42	<? foreach ($documentType->fields as $field) : ?>
43	43	<div class="form-element">
44	44	<label for="<?=$field->slug?>"><?=$field->title?></label>
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
63	63	<div class="form-element">
64	64	<? endif ?>
65		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	65	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
66	66	<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
67	67
68	68	</div>
		@@ -84,7 +84,7 @@ discard block
		block discarded – undo
84	84	<li class="grid-container">
85	85	<div class="grid-box-10">
86	86	<div class="grid-inner form-element">
87		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	87	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
88	88	</div>
89	89	</div>
90	90	<div class="grid-box-2">
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94	</div>
95	95	</div>
96	96	</li>
97		- <?$value='';?>
	97	+ <?$value = ''; ?>
98	98	<? endforeach ?>
99	99	<? endif ?>
100	100	</ul>
		@@ -111,10 +111,10 @@ discard block
		block discarded – undo
111	111	<a class="btn error js-deletemultiple"><i class="fa fa-times"></i></a>
112	112	<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
113	113	<div class="form-element">
114		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	114	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
115	115	</div>
116	116	</li>
117		- <?$value='';?>
	117	+ <?$value = ''; ?>
118	118	<? endforeach ?>
119	119	<? endif ?>
120	120	</div>
		@@ -123,17 +123,17 @@ discard block
		block discarded – undo
123	123	<a class="btn js-addrtemultiple">+</a>
124	124	<? endif ?>
125	125	</div>
126		- <?$value='';?>
	126	+ <?$value = ''; ?>
127	127	<? endforeach ?>
128	128	<hr />
129		- <? $static_brick_nr = 0;?>
	129	+ <? $static_brick_nr = 0; ?>
130	130	<? foreach ($documentType->bricks as $brick) : ?>
131	131	<div class="brick">
132	132	<label><?=$brick->title?></label>
133	133	<? if ($brick->multiple == 'true') : ?>
134	134	<input type="hidden" value="<?=$brick->brickSlug?>"/>
135	135	<input type="hidden" value="<?=$brick->slug?>"/>
136		- <?$myBrickSlug=$brick->slug;?>
	136	+ <?$myBrickSlug = $brick->slug; ?>
137	137	<ul id="newBrickDropzone_<?=$static_brick_nr?>" class="dynamicBricks sortable">
138	138	<? if (isset($document)) : ?>
139	139	<? foreach ($document->bricks as $currentBrickSlug => $brickArray) : ?>
		@@ -147,7 +147,7 @@ discard block
		block discarded – undo
147	147	<li class="brick form-element">
148	148	<label><?=$brick->title?></label>
149	149	<?$static = true; ?>
150		- <?include(__DIR__ . '/brick.php')?>
	150	+ <?include(__DIR__.'/brick.php')?>
151	151	</li>
152	152	<? endif ?>
153	153	<? endforeach ?>
		@@ -157,7 +157,7 @@ discard block
		block discarded – undo
157	157	<a class="btn" onclick="addDynamicBrick(this, 'true', 'newBrickDropzone_<?=$static_brick_nr?>');">+</a>
158	158	<?$static_brick_nr += 1?>
159	159	<? else : ?>
160		- <?$fieldPrefix='bricks[' . $brick->slug . '][fields]';?>
	160	+ <?$fieldPrefix = 'bricks['.$brick->slug.'][fields]'; ?>
161	161	<input type="hidden" name="bricks[<?=$brick->slug?>][type]" value="<?=$brick->brickSlug?>" />
162	162	<? foreach ($brick->structure->fields as $field) : ?>
163	163	<div class="form-element">
		@@ -183,7 +183,7 @@ discard block
		block discarded – undo
183	183	<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
184	184	<div class="form-element">
185	185	<? endif ?>
186		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	186	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
187	187	<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
188	188
189	189	</div>
		@@ -206,7 +206,7 @@ discard block
		block discarded – undo
206	206	<li class="grid-container">
207	207	<div class="grid-box-10">
208	208	<div class="grid-inner form-element">
209		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	209	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
210	210	</div>
211	211	</div>
212	212	<div class="grid-box-2">
		@@ -216,7 +216,7 @@ discard block
		block discarded – undo
216	216	</div>
217	217	</div>
218	218	</li>
219		- <?$value='';?>
	219	+ <?$value = ''; ?>
220	220	<? endforeach ?>
221	221	<? endif ?>
222	222	</ul>
		@@ -234,10 +234,10 @@ discard block
		block discarded – undo
234	234	<a class="btn error js-deletemultiple"><i class="fa fa-times"></i></a>
235	235	<a class="btn move ui-sortable-handle"><i class="fa fa-arrows-v"></i></a>
236	236	<div class="form-element">
237		- <? include(__DIR__ . '/fieldTypes/' . str_replace(' ', '-', $field->type) . '.php') ?>
	237	+ <? include(__DIR__.'/fieldTypes/'.str_replace(' ', '-', $field->type).'.php') ?>
238	238	</div>
239	239	</li>
240		- <?$value='';?>
	240	+ <?$value = ''; ?>
241	241	<? endforeach ?>
242	242	<? endif ?>
243	243	</div>
		@@ -246,12 +246,12 @@ discard block
		block discarded – undo
246	246	<a class="btn js-addrtemultiple">+</a>
247	247	<? endif ?>
248	248	</div>
249		- <?$value='';?>
	249	+ <?$value = ''; ?>
250	250	<? endforeach ?>
251	251	<? endif ?>
252	252	</div>
253	253	<hr />
254		- <? endforeach;?>
	254	+ <? endforeach; ?>
255	255
256	256
257	257
		@@ -274,7 +274,7 @@ discard block
		block discarded – undo
274	274	<li class="brick form-element">
275	275	<label><?=$brick->title?></label>
276	276	<?$static = false; ?>
277		- <?include(__DIR__ . '/brick.php')?>
	277	+ <?include(__DIR__.'/brick.php')?>
278	278	</li>
279	279	<? endforeach ?>
280	280	<? endif ?>

jenskooij / cloudcontrol

Push — develop ( 8acba5...dfac37 )

Status

Category

Spacing +20 added lines, -20 removed lines patch added patch discarded remove patch