View GitHub Repository cloudcontrol

Schedule Inspection
Subscribe
Passed
Push — develop ( adb2d3...61a548 )
by Jens
04:06
created
Status
Category
Toggle Patches
src/components/cms/DocumentRouting.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -56,7 +56,7 @@  discard block
 
 block discarded – undo
56 56 
     }
57 57
58 58 
     /**
59 
-     * @param $request
59 
+     * @param Request $request
60 60 
      * @param CmsComponent $cmsComponent
61 61 
      *
62 62 
      * @throws \Exception
 
@@ -91,7 +91,7 @@  discard block
 
 block discarded – undo
91 91 
     }
92 92
93 93 
     /**
94 
-     * @param $request
94 
+     * @param Request $request
95 95 
      * @param CmsComponent $cmsComponent
96 96 
      * @throws \Exception
97 97 
      */
 
@@ -126,7 +126,7 @@  discard block
 
 block discarded – undo
126 126 
     }
127 127
128 128 
     /**
129 
-     * @param $request
129 
+     * @param Request $request
130 130 
      * @param CmsComponent $cmsComponent
131 131 
      * @throws \Exception
132 132 
      */
 
@@ -148,7 +148,7 @@  discard block
 
 block discarded – undo
148 148 
     }
149 149
150 150 
     /**
151 
-     * @param $request
151 
+     * @param Request $request
152 152 
      * @param CmsComponent $cmsComponent
153 153 
      */
154 154 
     private function deleteDocumentRoute($request, $cmsComponent)
 
@@ -160,7 +160,7 @@  discard block
 
 block discarded – undo
160 160 
     }
161 161
162 162 
     /**
163 
-     * @param $request
163 
+     * @param Request $request
164 164 
      * @param CmsComponent $cmsComponent
165 165 
      */
166 166 
     private function publishDocumentRoute($request, $cmsComponent)
 
@@ -179,7 +179,7 @@  discard block
 
 block discarded – undo
179 179 
     }
180 180
181 181 
     /**
182 
-     * @param $request
182 
+     * @param Request $request
183 183 
      * @param CmsComponent $cmsComponent
184 184 
      */
185 185 
     private function unpublishDocumentRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -171,7 +171,7 @@  discard block
 
 block discarded – undo
171 171 
         $docLink = $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents/edit-document?slug=' . $path;
172 172 
         $cmsComponent->storage->getActivityLog()->add('published document <a href="' . $docLink . '">' . $request::$get[CmsConstants::GET_PARAMETER_SLUG] . '</a>', 'check-circle-o');
173 173 
         if ($cmsComponent->autoUpdateSearchIndex) {
174 
-            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/search/update-index?returnUrl=' . urlencode($request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?published=' .  urlencode($request::$get[CmsConstants::GET_PARAMETER_SLUG])));
174 
+            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/search/update-index?returnUrl=' . urlencode($request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?published=' . urlencode($request::$get[CmsConstants::GET_PARAMETER_SLUG])));
175 175 
         } else {
176 176 
             header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?published=' . urlencode($request::$get[CmsConstants::GET_PARAMETER_SLUG]));
177 177 
         }
 
@@ -190,7 +190,7 @@  discard block
 
 block discarded – undo
190 190 
         $docLink = $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents/edit-document?slug=' . $path;
191 191 
         $cmsComponent->storage->getActivityLog()->add('unpublished document <a href="' . $docLink . '">' . $request::$get[CmsConstants::GET_PARAMETER_SLUG] . '</a>', 'times-circle-o');
192 192 
         if ($cmsComponent->autoUpdateSearchIndex) {
193 
-            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/search/update-index?returnUrl=' . urlencode($request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?unpublished=' .  urlencode($request::$get[CmsConstants::GET_PARAMETER_SLUG])));
193 
+            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/search/update-index?returnUrl=' . urlencode($request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?unpublished=' . urlencode($request::$get[CmsConstants::GET_PARAMETER_SLUG])));
194 194 
         } else {
195 195 
             header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/documents?unpublished=' . htmlentities($request::$get[CmsConstants::GET_PARAMETER_SLUG]));
196 196 
         }
Please login to merge, or discard this patch.
src/storage/Cache.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -39,7 +39,7 @@  discard block
 
 block discarded – undo
39 39 
     }
40 40
41 41 
     /**
42 
-     * @param $path
42 
+     * @param string $path
43 43 
      * @return \stdClass
44 44 
      */
45 45 
     public function getCacheForPath($path)
 
@@ -114,7 +114,7 @@  discard block
 
 block discarded – undo
114 114 
     }
115 115
116 116 
     /**
117 
-     * @param $requestUri
117 
+     * @param string $requestUri
118 118 
      * @param $renderedContent
119 119 
      */
120 120 
     public function setCacheForPath($requestUri, $renderedContent)
Please login to merge, or discard this patch.