AuthController::create() - Code Metrics - Inspection of "Possibility to run from root directory" - jdrda/olapus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7d04c8...2a4aa6 )

by Jan

created 2020-10-21 14:46 UTC

AuthController::create() A

↳ Parent: AuthController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace App\Http\Controllers\Auth;

use App\User;
use Illuminate\Validation\Validator;
use App\Http\Controllers\Controller;
//use Illuminate\Foundation\Auth\ThrottlesLogins;
//use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
use \Illuminate\Http\Request;

class AuthController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Registration & Login Controller
    |--------------------------------------------------------------------------
    |
    | This controller handles the registration of new users, as well as the
    | authentication of existing users. By default, this controller uses
    | a simple trait to add these behaviors. Why don't you explore it?
    |
    */

    use AuthenticatesAndRegistersUsers, ThrottlesLogins;
    
    /**
     * Redirect after logout URL
     * 
     * @var string 
     */
    protected $redirectAfterLogout = 'admin';

    /**
     * Create a new authentication controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->redirectAfterLogout = env('APP_ADMIN_URL', 'admin');
        $this->middleware('guest', ['except' => 'getLogout']);
    }

    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array  $data
     * @return \Illuminate\Contracts\Validation\Validator
     */
    protected function validator(array $data)
    {
        return Validator::make($data, [

            'name' => 'required|max:255',
            'email' => 'required|email|max:255|unique:users',
            'password' => 'required|confirmed|min:6',
        ]);
    }

    /**
     * Create a new user instance after a valid registration.
     *
     * @param  array  $data
     * @return User
     */
    protected function create(array $data)

    {
        return User::create([
            'name' => $data['name'],
            'email' => $data['email'],
            'password' => bcrypt($data['password']),
        ]);
    }
    
    public function prePostLogin(Request $request) {

        
        /**
         * Add recaptcha
         */
        if(env('RECAPTCHA_ENABLED') == 1){
            $this->validate($request, ['g-recaptcha-response' => 'required|recaptcha']);
        }
        
        return $this->postLogin($request);
    }
    
    
}


1		<?php
2
3		namespace App\Http\Controllers\Auth;
4
5		use App\User;
6		use Illuminate\Validation\Validator;
7		use App\Http\Controllers\Controller;
8		//use Illuminate\Foundation\Auth\ThrottlesLogins;
9		//use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
10		use \Illuminate\Http\Request;
11
12		class AuthController extends Controller
13		{
14		/*
15		\|--------------------------------------------------------------------------
16		\| Registration & Login Controller
17		\|--------------------------------------------------------------------------
18		\|
19		\| This controller handles the registration of new users, as well as the
20		\| authentication of existing users. By default, this controller uses
21		\| a simple trait to add these behaviors. Why don't you explore it?
22		\|
23		*/
24
25		use AuthenticatesAndRegistersUsers, ThrottlesLogins;
26
27		/**
28		* Redirect after logout URL
29		*
30		* @var string
31		*/
32		protected $redirectAfterLogout = 'admin';
33
34		/**
35		* Create a new authentication controller instance.
36		*
37		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-08-22 00:55 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
38		*/
39		public function __construct()
40		{
41		$this->redirectAfterLogout = env('APP_ADMIN_URL', 'admin');
42		$this->middleware('guest', ['except' => 'getLogout']);
43		}
44
45		/**
46		* Get a validator for an incoming registration request.
47		*
48		* @param array $data
49		* @return \Illuminate\Contracts\Validation\Validator
50		*/
51		protected function validator(array $data)
52		{
53		return Validator::make($data, [
		0 ignored issues – show Bug introduced 2020-04-14 16:00 UTC by Report Bug Copy Issue Report The method `make()` does not seem to exist on `object<Illuminate\Validation\Validator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
54		'name' => 'required\|max:255',
55		'email' => 'required\|email\|max:255\|unique:users',
56		'password' => 'required\|confirmed\|min:6',
57		]);
58		}
59
60		/**
61		* Create a new user instance after a valid registration.
62		*
63		* @param array $data
64		* @return User
65		*/
66	View Code Duplication	protected function create(array $data)
		0 ignored issues – show Duplication introduced 2019-04-13 14:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68		return User::create([
69		'name' => $data['name'],
70		'email' => $data['email'],
71		'password' => bcrypt($data['password']),
72		]);
73		}
74
75	View Code Duplication	public function prePostLogin(Request $request) {
		0 ignored issues – show Duplication introduced 2019-04-13 14:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76
77		/**
78		* Add recaptcha
79		*/
80		if(env('RECAPTCHA_ENABLED') == 1){
81		$this->validate($request, ['g-recaptcha-response' => 'required\|recaptcha']);
82		}
83
84		return $this->postLogin($request);
85		}
86
87
88		}
89

jdrda / olapus

Push — master ( 7d04c8...2a4aa6 )

AuthController::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like