App\Http\Controllers\Auth\AuthController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	77
Duplicated Lines	24.68 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	prePostLogin()	11	11	2
A	__construct()	0	5	1
A	validator()	0	8	1
A	create()	8	8	1

<?php

namespace App\Http\Controllers\Auth;

use App\User;
use Illuminate\Validation\Validator;
use App\Http\Controllers\Controller;
//use Illuminate\Foundation\Auth\ThrottlesLogins;
//use Illuminate\Foundation\Auth\AuthenticatesAndRegistersUsers;
use \Illuminate\Http\Request;

class AuthController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Registration & Login Controller
    |--------------------------------------------------------------------------
    |
    | This controller handles the registration of new users, as well as the
    | authentication of existing users. By default, this controller uses
    | a simple trait to add these behaviors. Why don't you explore it?
    |
    */

    use AuthenticatesAndRegistersUsers, ThrottlesLogins;
    
    /**
     * Redirect after logout URL
     * 
     * @var string 
     */
    protected $redirectAfterLogout = 'admin';

    /**
     * Create a new authentication controller instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        $this->redirectAfterLogout = env('APP_ADMIN_URL', 'admin');
        $this->middleware('guest', ['except' => 'getLogout']);
    }

    /**
     * Get a validator for an incoming registration request.
     *
     * @param  array  $data
     * @return \Illuminate\Contracts\Validation\Validator
     */
    protected function validator(array $data)
    {
        return Validator::make($data, [

The method make() does not seem to exist on object<Illuminate\Validation\Validator>.

            'name' => 'required|max:255',
            'email' => 'required|email|max:255|unique:users',
            'password' => 'required|confirmed|min:6',
        ]);
    }

    /**
     * Create a new user instance after a valid registration.
     *
     * @param  array  $data
     * @return User
     */
    protected function create(array $data)

This method seems to be duplicated in your project.

    {
        return User::create([
            'name' => $data['name'],
            'email' => $data['email'],
            'password' => bcrypt($data['password']),
        ]);
    }
    
    public function prePostLogin(Request $request) {

This method seems to be duplicated in your project.

        
        /**
         * Add recaptcha
         */
        if(env('RECAPTCHA_ENABLED') == 1){
            $this->validate($request, ['g-recaptcha-response' => 'required|recaptcha']);
        }
        
        return $this->postLogin($request);
    }
    
    
}