JDesrosiers\Resourceful\ResourcefulServiceProvider\ResourcefulServiceProvider

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

83.33%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	12	1
A	register()	0	9	1

<?php

namespace JDesrosiers\Resourceful\ResourcefulServiceProvider;

use Pimple\Container;
use Pimple\ServiceProviderInterface;
use Silex\Api\BootableProviderInterface;
use Silex\Application;
use Twig_Loader_Filesystem;

class ResourcefulServiceProvider implements ServiceProviderInterface, BootableProviderInterface
{
    const ERROR_HANDLER_PRIORITY = 0;

    public function boot(Application $app)
    {
        // Error Handling
        $schema = $app["url_generator"]->generate("schema", array("type" => "error"));

        $app["twig.loader"]->addLoader(new Twig_Loader_Filesystem(__DIR__ . "/templates"));
        $app->before(new AddSchema($schema, "error"));

        $app->error(function (\Exception $e, $code) use ($app) {

The parameter $e is not used and could be removed.

The parameter $code is not used and could be removed.

            $app["json-schema.describedBy"] = $app["url_generator"]->generate("schema", array("type" => "error"));
        }, self::ERROR_HANDLER_PRIORITY);
    }

    public function register(Container $app)
    {
        $app["resources_factory"] = $app->protect(new ResourcesFactory($app));

$app of type object<Pimple\Container> is not a sub-type of object<Silex\Application>. It seems like you assume a child class of the class Pimple\Container to be always present.

        // CreateResourceController
        $app["uniqid"] = function () {
            return uniqid();
        };
    }
}