ResourcefulServiceProvider::boot() - Code Metrics - Inspection of "Refactoring error handling" - jdesrosiers/resourceful - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 57c6bc...e6f823 )

by Jason

created 2016-09-28 23:44 UTC

ResourcefulServiceProvider::boot() A

↳ Parent: ResourcefulServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
ccs	7
cts	7
cp	1
cc	1
eloc	7
nc	1
nop	1
crap	1

<?php

namespace JDesrosiers\Resourceful\ResourcefulServiceProvider;

use Pimple\Container;
use Pimple\ServiceProviderInterface;
use Silex\Api\BootableProviderInterface;
use Silex\Application;
use Twig_Loader_Filesystem;

class ResourcefulServiceProvider implements ServiceProviderInterface, BootableProviderInterface
{
    const ERROR_HANDLER_PRIORITY = 0;

    public function boot(Application $app)
    {
        // Error Handling
        $schema = $app["url_generator"]->generate("schema", array("type" => "error"));

        $app["twig.loader"]->addLoader(new Twig_Loader_Filesystem(__DIR__ . "/templates"));
        $app->before(new AddSchema($schema, "error"));

        $app->error(function (\Exception $e, $code) use ($app) {

            $app["json-schema.describedBy"] = $app["url_generator"]->generate("schema", array("type" => "error"));
        }, self::ERROR_HANDLER_PRIORITY);
    }

    public function register(Container $app)
    {
        $app["resources_factory"] = $app->protect(new ResourcesFactory($app));


        // CreateResourceController
        $app["uniqid"] = function () {
            return uniqid();
        };
    }
}


1		<?php
2
3		namespace JDesrosiers\Resourceful\ResourcefulServiceProvider;
4
5		use Pimple\Container;
6		use Pimple\ServiceProviderInterface;
7		use Silex\Api\BootableProviderInterface;
8		use Silex\Application;
9		use Twig_Loader_Filesystem;
10
11		class ResourcefulServiceProvider implements ServiceProviderInterface, BootableProviderInterface
12		{
13		const ERROR_HANDLER_PRIORITY = 0;
14
15	8	public function boot(Application $app)
16		{
17		// Error Handling
18	8	$schema = $app["url_generator"]->generate("schema", array("type" => "error"));
19
20	8	$app["twig.loader"]->addLoader(new Twig_Loader_Filesystem(__DIR__ . "/templates"));
21	8	$app->before(new AddSchema($schema, "error"));
22
23		$app->error(function (\Exception $e, $code) use ($app) {
		0 ignored issues – show Unused Code introduced 2016-05-12 07:13 UTC by Report Bug Copy Issue Report The parameter `$e` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-05-12 07:13 UTC by Report Bug Copy Issue Report The parameter `$code` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
24	2	$app["json-schema.describedBy"] = $app["url_generator"]->generate("schema", array("type" => "error"));
25	8	}, self::ERROR_HANDLER_PRIORITY);
26	8	}
27
28	8	public function register(Container $app)
29		{
30	8	$app["resources_factory"] = $app->protect(new ResourcesFactory($app));
		0 ignored issues – show Compatibility introduced 2016-06-07 07:05 UTC by Report Bug Copy Issue Report `$app` of type `object<Pimple\Container>` is not a sub-type of `object<Silex\Application>`. It seems like you assume a child class of the class `Pimple\Container` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
31
32		// CreateResourceController
33		$app["uniqid"] = function () {
34		return uniqid();
35		};
36	8	}
37		}
38

jdesrosiers / resourceful

GitHub Access Token became invalid

Push — master ( 57c6bc...e6f823 )

ResourcefulServiceProvider::boot() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like