jclaveau / php-logical-filter

src/Rule/AbstractOperationRule.php

Spacing +58 added lines, -58 removed lines

@@ -20,7 +20,7 @@ 
     const remove_negations        = 'remove_negations';
     const rootify_disjunctions    = 'rootify_disjunctions';
     const unify_atomic_operands   = 'unify_atomic_operands';
-    const remove_invalid_branches = 'remove_invalid_branches';    // simplified after this step
+    const remove_invalid_branches = 'remove_invalid_branches'; // simplified after this step
 
     const simplified              = self::remove_invalid_branches;
 
@@ -43,9 +43,9 @@ 
 
     /**
      */
-    public function __construct( array $operands=[] )
+    public function __construct(array $operands = [])
     {
-        $this->setOperands( $operands );
+        $this->setOperands($operands);
         $this->flushCache();
     }
 
@@ -64,10 +64,10 @@ 
      *
      * @return $this
      */
-    public function addOperand( AbstractRule $new_operand )
+    public function addOperand(AbstractRule $new_operand)
     {
-        if ( ! isset($this->operands[ $id = $new_operand->getSemanticId() ])) {
-            $this->operands[ $id ] = $new_operand;
+        if (!isset($this->operands[$id = $new_operand->getSemanticId()])) {
+            $this->operands[$id] = $new_operand;
 
             if ($this->current_simplification_step) {
                 $this->current_simplification_step = null;
@@ -84,7 +84,7 @@ 
      */
     public function getOperands()
     {
-        return array_values( $this->operands );
+        return array_values($this->operands);
     }
 
     /**
@@ -128,30 +128,30 @@ 
      * @param array  $simplification_options
      * @param bool   $force
      */
-    public function moveSimplificationStepForward($step_to_go_to, array $simplification_options, $force=false)
+    public function moveSimplificationStepForward($step_to_go_to, array $simplification_options, $force = false)
     {
-        if ( ! in_array($step_to_go_to, self::simplification_steps)) {
+        if (!in_array($step_to_go_to, self::simplification_steps)) {
             throw new \InvalidArgumentException(
                 "Invalid simplification step to go to: ".$step_to_go_to
             );
         }
 
         // if ($this->isNormalizationAllowed($simplification_options) && !$force && $this->current_simplification_step != null) {
-        if ( ! $force && null !== $this->current_simplification_step) {
+        if (!$force && null !== $this->current_simplification_step) {
             $steps_indices = array_flip(self::simplification_steps);
 
-            $current_index = $steps_indices[ $this->current_simplification_step ];
-            $target_index  = $steps_indices[ $step_to_go_to ];
+            $current_index = $steps_indices[$this->current_simplification_step];
+            $target_index  = $steps_indices[$step_to_go_to];
 
-            if ( $current_index >= $target_index ) {
+            if ($current_index >= $target_index) {
                 // allow recall of previous step without going back
                 return;
             }
-            elseif ( $current_index < $target_index - 1 ) {
+            elseif ($current_index < $target_index - 1) {
                 throw new \LogicException(
-                    "$step_to_go_to MUST be fullfilled after " . self::simplification_steps[$target_index - 1]
-                    . " instead of the current step: " . $this->current_simplification_step
-                    ."\nfor: " . $this
+                    "$step_to_go_to MUST be fullfilled after ".self::simplification_steps[$target_index - 1]
+                    . " instead of the current step: ".$this->current_simplification_step
+                    ."\nfor: ".$this
                 );
             }
         }
@@ -168,7 +168,7 @@ 
      */
     public function simplicationStepReached($step)
     {
-        if ( ! in_array($step, self::simplification_steps)) {
+        if (!in_array($step, self::simplification_steps)) {
             throw new \InvalidArgumentException(
                 "Invalid simplification step: ".$step
             );
@@ -180,8 +180,8 @@ 
 
         $steps_indices = array_flip(self::simplification_steps);
 
-        $current_index = $steps_indices[ $this->current_simplification_step ];
-        $step_index    = $steps_indices[ $step ];
+        $current_index = $steps_indices[$this->current_simplification_step];
+        $step_index    = $steps_indices[$step];
 
         return $current_index >= $step_index;
     }
@@ -193,7 +193,7 @@ 
      */
     public function removeNegations(array $contextual_options)
     {
-        if ( ! $this->isNormalizationAllowed($contextual_options)) {
+        if (!$this->isNormalizationAllowed($contextual_options)) {
             return $this;
         }
 
@@ -207,7 +207,7 @@ 
                 }
 
                 if ($operands[$i] instanceof AbstractOperationRule) {
-                    $operands[$i]->removeNegations( $contextual_options );
+                    $operands[$i]->removeNegations($contextual_options);
                 }
             }
 
@@ -230,14 +230,14 @@ 
      *
      * @return AbstractOperationRule
      */
-    public function cleanOperations(array $simplification_options, $recurse=true)
+    public function cleanOperations(array $simplification_options, $recurse = true)
     {
         if ($recurse) {
             foreach ($this->operands as $i => $operand) {
-                if (     $operand instanceof AbstractOperationRule
-                    && ! $operand instanceof InRule
-                    && ! $operand instanceof NotEqualRule
-                    && ! $operand instanceof NotInRule
+                if ($operand instanceof AbstractOperationRule
+                    && !$operand instanceof InRule
+                    && !$operand instanceof NotEqualRule
+                    && !$operand instanceof NotInRule
                 ) {
                     $this->operands[$i] = $operand->cleanOperations($simplification_options);
                 }
@@ -276,11 +276,11 @@ 
     public function removeMonooperandOperationsOperands(array $simplification_options)
     {
         foreach ($this->operands as $i => $operand) {
-            if ( ! $operand instanceof AbstractOperationRule || $operand instanceof NotRule) {
+            if (!$operand instanceof AbstractOperationRule || $operand instanceof NotRule) {
                 continue;
             }
 
-            if ($operand instanceof InRule && ! $operand->isNormalizationAllowed($simplification_options)) {
+            if ($operand instanceof InRule && !$operand->isNormalizationAllowed($simplification_options)) {
                 $count = count($operand->getPossibilities());
             }
             else {
@@ -297,7 +297,7 @@ 
             }
         }
 
-        return ! empty($has_been_changed);
+        return !empty($has_been_changed);
     }
 
     /**
@@ -308,12 +308,12 @@ 
     public function unifyAtomicOperands($simplification_strategy_step = false, array $contextual_options)
     {
         if ($simplification_strategy_step) {
-            $this->moveSimplificationStepForward( self::unify_atomic_operands, $contextual_options );
+            $this->moveSimplificationStepForward(self::unify_atomic_operands, $contextual_options);
         }
 
         // $this->dump(true);
 
-        if ( ! $this->isNormalizationAllowed($contextual_options)) {
+        if (!$this->isNormalizationAllowed($contextual_options)) {
             return $this;
         }
 
@@ -344,7 +344,7 @@ 
                 catch (\Exception $e) {
                     VisibilityViolator::setHiddenProperty(
                         $e, 'message',
-                        $e->getMessage() . "\n" . var_export($operandsByOperator, true)
+                        $e->getMessage()."\n".var_export($operandsByOperator, true)
                     );
 
                     throw $e;
@@ -352,7 +352,7 @@ 
             }
         }
 
-        return $this->setOperandsOrReplaceByOperation( $unifiedOperands, $contextual_options );
+        return $this->setOperandsOrReplaceByOperation($unifiedOperands, $contextual_options);
     }
 
     private static $simplification_cache = [];
@@ -368,13 +368,13 @@ 
      *
      * @return AbstractRule the simplified rule
      */
-    final public function simplify($options=[])
+    final public function simplify($options = [])
     {
-        $step_to_stop_before = ! empty($options['stop_before'])        ? $options['stop_before'] : null;
-        $step_to_stop_after  = ! empty($options['stop_after'])         ? $options['stop_after']  : null;
-        $force_logical_core  = ! empty($options['force_logical_core']) ? $options['force_logical_core'] : false;
+        $step_to_stop_before = !empty($options['stop_before']) ? $options['stop_before'] : null;
+        $step_to_stop_after  = !empty($options['stop_after']) ? $options['stop_after'] : null;
+        $force_logical_core  = !empty($options['force_logical_core']) ? $options['force_logical_core'] : false;
 
-        if ($step_to_stop_before && ! in_array($step_to_stop_before, self::simplification_steps)) {
+        if ($step_to_stop_before && !in_array($step_to_stop_before, self::simplification_steps)) {
             throw new \InvalidArgumentException(
                 "Invalid simplification step to stop at: ".$step_to_stop_before
             );
@@ -409,7 +409,7 @@ 
         // $instance->dump(true);
 
         if (self::remove_negations == $step_to_stop_after ||
-            self::rootify_disjunctions == $step_to_stop_before ) {
+            self::rootify_disjunctions == $step_to_stop_before) {
             return $instance;
         }
 
@@ -421,18 +421,18 @@ 
         // $instance->dump(true);
 
         if (self::rootify_disjunctions == $step_to_stop_after ||
-            self::unify_atomic_operands == $step_to_stop_before ) {
+            self::unify_atomic_operands == $step_to_stop_before) {
             return $instance;
         }
 
-        if ( ! $instance instanceof AbstractAtomicRule) {
+        if (!$instance instanceof AbstractAtomicRule) {
             $instance->cleanOperations($options);
             $instance->unifyAtomicOperands(true, $options);
 
             // $instance->dump(true);
 
             if (self::unify_atomic_operands == $step_to_stop_after ||
-                self::remove_invalid_branches == $step_to_stop_before ) {
+                self::remove_invalid_branches == $step_to_stop_before) {
                 return $instance;
             }
 
@@ -449,8 +449,8 @@ 
         // last non recursive clean
         // TODO kind of monad|become|cese
         //@see https://github.com/jclaveau/php-logical-filter/issues/20
-        if ($instance instanceof AndRule || $instance instanceof OrRule ) {
-            if ( ! $instance->getOperands()) {
+        if ($instance instanceof AndRule || $instance instanceof OrRule) {
+            if (!$instance->getOperands()) {
                 return $instance;
             }
 
@@ -469,7 +469,7 @@ 
             $instance = $instance->forceLogicalCore();
             // for the simplification status at
             foreach ($operands = $instance->getOperands() as $andOperand) {
-                if ( ! $andOperand instanceof AndRule) {
+                if (!$andOperand instanceof AndRule) {
                     throw new \LogicException(
                         "A rule is intended to be an and case: \n"
                         .$andOperand
@@ -489,7 +489,7 @@ 
 
         $cache_keys[] = $instance->getSemanticId().'-'.$options_id;
         foreach ($cache_keys as $cache_key) {
-            self::$simplification_cache[ $cache_key ] = $instance;
+            self::$simplification_cache[$cache_key] = $instance;
         }
 
         return $instance->copy();
@@ -512,15 +512,15 @@ 
             // For FilteredValue and FilteredKey
             $field = (string) $field;
 
-            if ( ! isset($operandsByFields[ $field ])) {
-                $operandsByFields[ $field ] = [];
+            if (!isset($operandsByFields[$field])) {
+                $operandsByFields[$field] = [];
             }
 
-            if ( ! isset($operandsByFields[ $field ][ $operand::operator ])) {
-                $operandsByFields[ $field ][ $operand::operator ] = [];
+            if (!isset($operandsByFields[$field][$operand::operator])) {
+                $operandsByFields[$field][$operand::operator] = [];
             }
 
-            $operandsByFields[ $field ][ $operand::operator ][] = $operand;
+            $operandsByFields[$field][$operand::operator][] = $operand;
         }
 
         return $operandsByFields;
@@ -543,15 +543,15 @@ 
             // For FilteredValue and FilteredKey
             $field = (string) $field;
 
-            if ( ! isset($operandsByFields[ $field ])) {
-                $operandsByFields[ $field ] = [];
+            if (!isset($operandsByFields[$field])) {
+                $operandsByFields[$field] = [];
             }
 
-            if ( ! isset($operandsByFields[ $field ][ $operand::operator ])) {
-                $operandsByFields[ $field ][ $operand::operator ] = [];
+            if (!isset($operandsByFields[$field][$operand::operator])) {
+                $operandsByFields[$field][$operand::operator] = [];
             }
 
-            $operandsByFields[ $field ][ $operand::operator ][] = $operand;
+            $operandsByFields[$field][$operand::operator][] = $operand;
         }
 
         return $operandsByFields;
@@ -589,7 +589,7 @@ 
      *
      * @return AbstractRule|null The operand if it exists or null
      */
-    protected function getOperandAt($index=0)
+    protected function getOperandAt($index = 0)
     {
         $operands = array_values($this->operands);
         if (isset($operands[$index])) {