Passed
Push — master ( 76213e...2a417c )
by Jean
02:49
created
src/Filterer/FiltererInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
      * @param LogicalFilter $filter
17 17
      * @param Iterable      $data_to_filter
18 18
      */
19
-    public function apply( LogicalFilter $filter, $tree_to_filter, $options=[] );
19
+    public function apply(LogicalFilter $filter, $tree_to_filter, $options = []);
20 20
 
21 21
     public function validateRule($field, $operator, $value, $row, array $path, $all_operands, $options);
22 22
 
Please login to merge, or discard this patch.
src/Filterer/CustomizableFilterer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
     /**
18 18
      */
19
-    public function __construct( callable $rule_validator )
19
+    public function __construct(callable $rule_validator)
20 20
     {
21 21
         $this->rule_validator = $rule_validator;
22 22
     }
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      */
26 26
     public function validateRule($field, $operator, $value, $row, array $path, $all_operands, $options)
27 27
     {
28
-        return call_user_func_array( $this->rule_validator, get_defined_vars() );
28
+        return call_user_func_array($this->rule_validator, get_defined_vars());
29 29
     }
30 30
 
31 31
     /**/
Please login to merge, or discard this patch.
src/Converter/ConverterInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     /**
35 35
      * @param LogicalFilter $filter
36 36
      */
37
-    public function convert( LogicalFilter $filter );
37
+    public function convert(LogicalFilter $filter);
38 38
 
39 39
     /**/
40 40
 }
Please login to merge, or discard this patch.
src/Converter/CustomizableMinimalConverter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,14 +30,14 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function onOpenOr()
32 32
     {
33
-        call_user_func( $this->callbacks[ __FUNCTION__ ] );
33
+        call_user_func($this->callbacks[__FUNCTION__]);
34 34
     }
35 35
 
36 36
     /**
37 37
      */
38 38
     public function onCloseOr()
39 39
     {
40
-        call_user_func( $this->callbacks[ __FUNCTION__ ] );
40
+        call_user_func($this->callbacks[__FUNCTION__]);
41 41
     }
42 42
 
43 43
     /**
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     public function onAndPossibility($field, $operator, $operand, array $allOperandsByField)
48 48
     {
49 49
         call_user_func(
50
-            $this->callbacks[ __FUNCTION__ ],
50
+            $this->callbacks[__FUNCTION__],
51 51
             $field,
52 52
             $operator,
53 53
             $operand,
Please login to merge, or discard this patch.
src/Rule/BetweenOrEqualBothRule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -14,10 +14,10 @@
 block discarded – undo
14 14
 
15 15
     /**
16 16
      */
17
-    public function __construct( $field, array $limits )
17
+    public function __construct($field, array $limits)
18 18
     {
19
-        $this->addOperand( new AboveOrEqualRule($field, $limits[0]) );
20
-        $this->addOperand( new BelowOrEqualRule($field, $limits[1]) );
19
+        $this->addOperand(new AboveOrEqualRule($field, $limits[0]));
20
+        $this->addOperand(new BelowOrEqualRule($field, $limits[1]));
21 21
     }
22 22
 
23 23
     /**
Please login to merge, or discard this patch.
src/Rule/Trait_RuleWithOptions.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     /**
31 31
      */
32
-    public function getOption($name, array $contextual_options=[])
32
+    public function getOption($name, array $contextual_options = [])
33 33
     {
34 34
         $options = $this->getOptions($contextual_options);
35 35
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     /**
40 40
      * @param $contextual_options
41 41
      */
42
-    public function getOptions(array $contextual_options=[])
42
+    public function getOptions(array $contextual_options = [])
43 43
     {
44 44
         $default_options = LogicalFilter::getDefaultOptions();
45 45
 
Please login to merge, or discard this patch.
src/Rule/EqualRule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
      * @param string $field The field to apply the rule on.
17 17
      * @param array  $value The value the field can equal to.
18 18
      */
19
-    public function __construct( $field, $value )
19
+    public function __construct($field, $value)
20 20
     {
21 21
         $this->field = $field;
22 22
         $this->value = $value;
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      *
43 43
      * @return bool
44 44
      */
45
-    public function hasSolution(array $contextual_options=[])
45
+    public function hasSolution(array $contextual_options = [])
46 46
     {
47 47
         return true;
48 48
     }
Please login to merge, or discard this patch.
src/Rule/AbstractRule.php 3 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
         }
171 171
         else {
172 172
             throw new \InvalidArgumentException(
173
-                 "'mode' option must belong to ['string', 'export', 'dump'] "
173
+                    "'mode' option must belong to ['string', 'export', 'dump'] "
174 174
                 ."instead of " . var_export($mode, true)
175 175
             );
176 176
         }
@@ -251,9 +251,9 @@  discard block
 block discarded – undo
251 251
 
252 252
         // return hash('crc32b', serialize( $this->toArray() ));
253 253
         return hash('md4', serialize( $this->toArray(['semantic' => true]) ))  // faster but longer
254
-              .'-'
255
-              .hash('md4', serialize( $this->options ))
256
-              ;
254
+                .'-'
255
+                .hash('md4', serialize( $this->options ))
256
+                ;
257 257
     }
258 258
 
259 259
     /**
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public static function findSymbolicOperator($english_operator)
35 35
     {
36
-        $association = array_flip( self::$ruleAliases );
37
-        if (isset($association[ $english_operator ])) {
38
-            return $association[ $english_operator ];
36
+        $association = array_flip(self::$ruleAliases);
37
+        if (isset($association[$english_operator])) {
38
+            return $association[$english_operator];
39 39
         }
40 40
 
41 41
         return $english_operator;
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
     public static function findEnglishOperator($symbolic_operator)
47 47
     {
48 48
         $association = self::$ruleAliases;
49
-        if (isset($association[ $symbolic_operator ])) {
50
-            return $association[ $symbolic_operator ];
49
+        if (isset($association[$symbolic_operator])) {
50
+            return $association[$symbolic_operator];
51 51
         }
52 52
 
53 53
         return $symbolic_operator;
@@ -65,16 +65,16 @@  discard block
 block discarded – undo
65 65
      *
66 66
      * @return $this
67 67
      */
68
-    public static function generateSimpleRule($field, $type, $values, array $options=[])
68
+    public static function generateSimpleRule($field, $type, $values, array $options = [])
69 69
     {
70
-        $cache_key = hash('md4', serialize( func_get_args()) );
70
+        $cache_key = hash('md4', serialize(func_get_args()));
71 71
         if (isset(self::$static_cache['rules_generation'][$cache_key])) {
72 72
             return self::$static_cache['rules_generation'][$cache_key]->copy();
73 73
         }
74 74
 
75 75
         $ruleClass = self::getRuleClass($type);
76 76
 
77
-        return self::$static_cache['rules_generation'][$cache_key] = new $ruleClass( $field, $values, $options );
77
+        return self::$static_cache['rules_generation'][$cache_key] = new $ruleClass($field, $values, $options);
78 78
     }
79 79
 
80 80
     /**
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
             . str_replace('_', '', ucwords($english_rule_operator, '_'))
92 92
             . 'Rule';
93 93
 
94
-        if ( ! class_exists( $rule_class)) {
94
+        if (!class_exists($rule_class)) {
95 95
             throw new \InvalidArgumentException(
96 96
                 "The class '$rule_class' corresponding to the  operator "
97 97
                 ."'$rule_operator' / '$english_rule_operator' cannot be found."
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
      *
121 121
      * @return $this
122 122
      */
123
-    final public function dump($exit=false, array $options=[])
123
+    final public function dump($exit = false, array $options = [])
124 124
     {
125 125
         $default_options = [
126 126
             'callstack_depth' => 2,
@@ -128,18 +128,18 @@  discard block
 block discarded – undo
128 128
             // 'show_instance'   => false,
129 129
         ];
130 130
         foreach ($default_options as $default_option => &$default_value) {
131
-            if ( ! isset($options[ $default_option ])) {
132
-                $options[ $default_option ] = $default_value;
131
+            if (!isset($options[$default_option])) {
132
+                $options[$default_option] = $default_value;
133 133
             }
134 134
         }
135 135
         extract($options);
136 136
 
137 137
         $bt     = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, $callstack_depth);
138
-        $caller = $bt[ $callstack_depth - 2 ];
138
+        $caller = $bt[$callstack_depth - 2];
139 139
 
140
-        echo "\n" . $caller['file'] . ':' . $caller['line'] . "\n";
140
+        echo "\n".$caller['file'].':'.$caller['line']."\n";
141 141
         if ('string' == $mode) {
142
-            if ( ! isset($options['indent_unit'])) {
142
+            if (!isset($options['indent_unit'])) {
143 143
                 $options['indent_unit'] = "    ";
144 144
             }
145 145
 
@@ -157,10 +157,10 @@  discard block
 block discarded – undo
157 157
             }
158 158
         }
159 159
         elseif ('xdebug' == $mode) {
160
-            if ( ! function_exists('xdebug_is_enabled')) {
160
+            if (!function_exists('xdebug_is_enabled')) {
161 161
                 throw new \RuntimeException("Xdebug is not installed");
162 162
             }
163
-            if ( ! xdebug_is_enabled()) {
163
+            if (!xdebug_is_enabled()) {
164 164
                 throw new \RuntimeException("Xdebug is disabled");
165 165
             }
166 166
 
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
         else {
181 181
             throw new \InvalidArgumentException(
182 182
                  "'mode' option must belong to ['string', 'export', 'dump'] "
183
-                ."instead of " . var_export($mode, true)
183
+                ."instead of ".var_export($mode, true)
184 184
             );
185 185
         }
186 186
         echo "\n\n";
@@ -262,9 +262,9 @@  discard block
 block discarded – undo
262 262
         }
263 263
 
264 264
         // return hash('crc32b', serialize( $this->toArray() ));
265
-        return hash('md4', serialize( $this->toArray(['semantic' => true]) ))  // faster but longer
265
+        return hash('md4', serialize($this->toArray(['semantic' => true])))  // faster but longer
266 266
               .'-'
267
-              .hash('md4', serialize( $this->options ))
267
+              .hash('md4', serialize($this->options))
268 268
               ;
269 269
     }
270 270
 
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
         }
297 297
         elseif ($this instanceof OrRule) {
298 298
             foreach ($this->operands as $i => $operand) {
299
-                if ( ! $operand instanceof AndRule) {
299
+                if (!$operand instanceof AndRule) {
300 300
                     $this->operands[$i] = new AndRule([$operand]);
301 301
                 }
302 302
             }
Please login to merge, or discard this patch.
Braces   +7 added lines, -14 removed lines patch added patch discarded remove patch
@@ -144,8 +144,7 @@  discard block
 block discarded – undo
144 144
             }
145 145
 
146 146
             echo ($this->toString($options));
147
-        }
148
-        elseif ('dump' == $mode) {
147
+        } elseif ('dump' == $mode) {
149 148
             if ($xdebug_enabled = ini_get('xdebug.overload_var_dump')) {
150 149
                 ini_set('xdebug.overload_var_dump', 0);
151 150
             }
@@ -155,8 +154,7 @@  discard block
 block discarded – undo
155 154
             if ($xdebug_enabled) {
156 155
                 ini_set('xdebug.overload_var_dump', 1);
157 156
             }
158
-        }
159
-        elseif ('xdebug' == $mode) {
157
+        } elseif ('xdebug' == $mode) {
160 158
             if ( ! function_exists('xdebug_is_enabled')) {
161 159
                 throw new \RuntimeException("Xdebug is not installed");
162 160
             }
@@ -173,11 +171,9 @@  discard block
 block discarded – undo
173 171
             if ($xdebug_enabled) {
174 172
                 ini_set('xdebug.overload_var_dump', 0);
175 173
             }
176
-        }
177
-        elseif ('export' == $mode) {
174
+        } elseif ('export' == $mode) {
178 175
             var_export($this->toArray($options));
179
-        }
180
-        else {
176
+        } else {
181 177
             throw new \InvalidArgumentException(
182 178
                  "'mode' option must belong to ['string', 'export', 'dump'] "
183 179
                 ."instead of " . var_export($mode, true)
@@ -288,21 +284,18 @@  discard block
 block discarded – undo
288 284
                     $this,
289 285
                 ]),
290 286
             ]);
291
-        }
292
-        elseif ($this instanceof AndRule) {
287
+        } elseif ($this instanceof AndRule) {
293 288
             $ruleTree = new OrRule([
294 289
                 $this,
295 290
             ]);
296
-        }
297
-        elseif ($this instanceof OrRule) {
291
+        } elseif ($this instanceof OrRule) {
298 292
             foreach ($this->operands as $i => $operand) {
299 293
                 if ( ! $operand instanceof AndRule) {
300 294
                     $this->operands[$i] = new AndRule([$operand]);
301 295
                 }
302 296
             }
303 297
             $ruleTree = $this;
304
-        }
305
-        else {
298
+        } else {
306 299
             throw new \LogicException(
307 300
                 "Unhandled type of simplified rules provided for conversion: "
308 301
                 .$this
Please login to merge, or discard this patch.
src/Rule/Trait_RuleWithField.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -50,13 +50,11 @@
 block discarded – undo
50 50
     {
51 51
         if (is_callable($renamings)) {
52 52
             $this->setField( call_user_func($renamings, $this->field) );
53
-        }
54
-        elseif (is_array($renamings)) {
53
+        } elseif (is_array($renamings)) {
55 54
             if (isset($renamings[$this->field])) {
56 55
                 $this->setField( $renamings[$this->field] );
57 56
             }
58
-        }
59
-        else {
57
+        } else {
60 58
             throw new \InvalidArgumentException(
61 59
                 "\$renamings MUST be a callable or an associative array "
62 60
                 ."instead of: " . var_export($renamings, true)
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -23,9 +23,9 @@  discard block
 block discarded – undo
23 23
     /**
24 24
      * @return string $field
25 25
      */
26
-    final public function setField( $field )
26
+    final public function setField($field)
27 27
     {
28
-        if ( ! is_scalar($field)) {
28
+        if (!is_scalar($field)) {
29 29
             throw new \InvalidArgumentEXception(
30 30
                 "\$field property of a logical rule must be a scalar contrary to: "
31 31
                 .var_export($field, true)
@@ -49,17 +49,17 @@  discard block
 block discarded – undo
49 49
     final public function renameField($renamings)
50 50
     {
51 51
         if (is_callable($renamings)) {
52
-            $this->setField( call_user_func($renamings, $this->field) );
52
+            $this->setField(call_user_func($renamings, $this->field));
53 53
         }
54 54
         elseif (is_array($renamings)) {
55 55
             if (isset($renamings[$this->field])) {
56
-                $this->setField( $renamings[$this->field] );
56
+                $this->setField($renamings[$this->field]);
57 57
             }
58 58
         }
59 59
         else {
60 60
             throw new \InvalidArgumentException(
61 61
                 "\$renamings MUST be a callable or an associative array "
62
-                ."instead of: " . var_export($renamings, true)
62
+                ."instead of: ".var_export($renamings, true)
63 63
             );
64 64
         }
65 65
 
Please login to merge, or discard this patch.