jclaveau / php-logical-filter

src/Converter/InlineSqlMinimalConverter.php

Spacing +8 added lines, -8 removed lines

@@ -51,12 +51,12 @@ 
     /**
      * @param LogicalFilter $filter
      */
-    public function convert( LogicalFilter $filter )
+    public function convert(LogicalFilter $filter)
     {
         $this->output = [];
         parent::convert($filter);
         return [
-            'sql' => ! $this->output
+            'sql' => !$this->output
                    ? '1' // True
                    : '('.implode(') OR (', $this->output).')',
             'parameters' => $this->parameters,
@@ -75,7 +75,7 @@ 
     public function onCloseOr()
     {
         $last_key                  = $this->getLastOrOperandKey();
-        $this->output[ $last_key ] = implode(' AND ', $this->output[ $last_key ]);
+        $this->output[$last_key] = implode(' AND ', $this->output[$last_key]);
     }
 
     /**
@@ -116,7 +116,7 @@ 
             $value = $rule->getValue();
         }
         elseif ($rule instanceof RegexpRule) {
-            $value = RegexpRule::php2mariadbPCRE( $rule->getPattern() );
+            $value = RegexpRule::php2mariadbPCRE($rule->getPattern());
         }
         else {
             throw new \InvalidArgumentException(
@@ -130,7 +130,7 @@ 
             // TODO disable locale to handle separators
         }
         elseif ($value instanceof \DateTime) {
-            $value = "'" . $value->format('Y-m-d H:i:s') . "'";
+            $value = "'".$value->format('Y-m-d H:i:s')."'";
         }
         elseif (gettype($value) == 'string') {
             $value = $this->addParameter($value);
@@ -140,7 +140,7 @@ 
             foreach ($value as $possibility) {
                 $sql_part[] = $this->addParameter($possibility);
             }
-            $value = '(' . implode(', ', $sql_part) . ')';
+            $value = '('.implode(', ', $sql_part).')';
         }
         elseif ($value === null) {
             $value = "NULL";
@@ -158,7 +158,7 @@ 
         }
         else {
             throw new \InvalidArgumentException(
-                "Unhandled type of value: ".gettype($value). ' | ' .var_export($value, true)
+                "Unhandled type of value: ".gettype($value).' | '.var_export($value, true)
             );
         }
 
@@ -183,7 +183,7 @@ 
     protected function appendToLastOrOperandKey($rule)
     {
         $last_key                    = $this->getLastOrOperandKey();
-        $this->output[ $last_key ][] = $rule;
+        $this->output[$last_key][] = $rule;
     }
 
     /**/

Braces +17 added lines, -34 removed lines

@@ -86,77 +86,60 @@
     {
         if ($rule instanceof EqualRule) {
             $value = $rule->getValue();
-        }
-        elseif ($rule instanceof InRule) {
+        } elseif ($rule instanceof InRule) {
             $value = $rule->getPossibilities();
             if (is_object($value) && method_exists('toArray', $value)) {
                 $value = $value->toArray();
             }
-        }
-        elseif ($rule instanceof NotInRule) {
+        } elseif ($rule instanceof NotInRule) {
             $operator = 'NOT IN';
             $value    = $rule->getPossibilities();
             if (is_object($value) && method_exists('toArray', $value)) {
                 $value = $value->toArray();
             }
-        }
-        elseif ($rule instanceof AboveRule) {
+        } elseif ($rule instanceof AboveRule) {
             $value = $rule->getLowerLimit();
-        }
-        elseif ($rule instanceof BelowRule) {
+        } elseif ($rule instanceof BelowRule) {
             $value = $rule->getUpperLimit();
-        }
-        elseif ($rule instanceof AboveOrEqualRule) {
+        } elseif ($rule instanceof AboveOrEqualRule) {
             $value = $rule->getMinimum();
-        }
-        elseif ($rule instanceof BelowOrEqualRule) {
+        } elseif ($rule instanceof BelowOrEqualRule) {
             $value = $rule->getMaximum();
-        }
-        elseif ($rule instanceof NotEqualRule) {
+        } elseif ($rule instanceof NotEqualRule) {
             $value = $rule->getValue();
-        }
-        elseif ($rule instanceof RegexpRule) {
+        } elseif ($rule instanceof RegexpRule) {
             $value = RegexpRule::php2mariadbPCRE( $rule->getPattern() );
-        }
-        else {
+        } else {
             throw new \InvalidArgumentException(
                 "Unhandled operator '$operator' during SQL query generation"
             );
         }
 
         if (gettype($value) == 'integer') {
-        }
-        elseif (gettype($value) == 'double') {
+        } elseif (gettype($value) == 'double') {
             // TODO disable locale to handle separators
-        }
-        elseif ($value instanceof \DateTime) {
+        } elseif ($value instanceof \DateTime) {
             $value = "'" . $value->format('Y-m-d H:i:s') . "'";
-        }
-        elseif (gettype($value) == 'string') {
+        } elseif (gettype($value) == 'string') {
             $value = $this->addParameter($value);
-        }
-        elseif (gettype($value) == 'array') {
+        } elseif (gettype($value) == 'array') {
             $sql_part = [];
             foreach ($value as $possibility) {
                 $sql_part[] = $this->addParameter($possibility);
             }
             $value = '(' . implode(', ', $sql_part) . ')';
-        }
-        elseif ($value === null) {
+        } elseif ($value === null) {
             $value = "NULL";
             if ($rule instanceof EqualRule) {
                 $operator = 'IS';
-            }
-            elseif ($rule instanceof NotEqualRule) {
+            } elseif ($rule instanceof NotEqualRule) {
                 $operator = 'IS NOT';
-            }
-            else {
+            } else {
                 throw new \InvalidArgumentException(
                     "NULL is only handled for equality / difference"
                 );
             }
-        }
-        else {
+        } else {
             throw new \InvalidArgumentException(
                 "Unhandled type of value: ".gettype($value). ' | ' .var_export($value, true)
             );

src/Converter/ElasticSearchMinimalConverter.php

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
     /**
      * @param LogicalFilter $filter
      */
-    public function convert( LogicalFilter $filter )
+    public function convert(LogicalFilter $filter)
     {
         $this->output = [
         ];
@@ -162,7 +162,7 @@ 
     protected function appendToLastOrOperandKey($rule)
     {
         $last_key                                    = $this->getLastOrOperandKey();
-        $this->output[ $last_key ]['bool']['must'][] = $rule;
+        $this->output[$last_key]['bool']['must'][] = $rule;
     }
 
     /**/

src/Rule/AboveRule.php

Spacing +6 added lines, -6 removed lines

@@ -16,9 +16,9 @@ 
      * @param string $field The field to apply the rule on.
      * @param array  $value The value the field can above to.
      */
-    public function __construct( $field, $minimum )
+    public function __construct($field, $minimum)
     {
-        if (    !is_scalar($minimum)
+        if (!is_scalar($minimum)
             && !$minimum instanceof \DateTimeInterface
             && null !== $minimum
         ) {
@@ -61,15 +61,15 @@ 
      *
      * @return bool
      */
-    public function hasSolution(array $simplification_options=[])
+    public function hasSolution(array $simplification_options = [])
     {
         // if minimum is null, the rule is equivalent to true
-        if (is_numeric( $this->minimum )) {
-            if (is_nan( $this->minimum )) {
+        if (is_numeric($this->minimum)) {
+            if (is_nan($this->minimum)) {
                 return false;
             }
 
-            if (is_infinite( $this->minimum ) && $this->minimum > 0) {
+            if (is_infinite($this->minimum) && $this->minimum > 0) {
                 return false;
             }
         }

src/Rule/RegexpRule.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
      *
      * @todo  Support Posix?
      */
-    public function __construct( $field, $pattern )
+    public function __construct($field, $pattern)
     {
         $this->field   = $field;
         $this->pattern = $pattern;
@@ -49,7 +49,7 @@ 
      *
      * @return bool
      */
-    public function hasSolution(array $simplification_options=[])
+    public function hasSolution(array $simplification_options = [])
     {
         return true;
     }
@@ -78,7 +78,7 @@ 
         $pattern = $matches[1];
         $options = $matches[2];
 
-        return ($options ? "(?$options)" : '') . $pattern;
+        return ($options ? "(?$options)" : '').$pattern;
     }
 
     /**/

src/Rule/NotInRule.php

Spacing +11 added lines, -11 removed lines

@@ -13,17 +13,17 @@ 
      * @param string $field The field to apply the rule on.
      * @param array  $value The value the field can equal to.
      */
-    public function __construct( $field, $possibilities )
+    public function __construct($field, $possibilities)
     {
         $this->addOperand(new InRule($field, $possibilities));
     }
 
     /**
      */
-    public function isNormalizationAllowed(array $contextual_options=[])
+    public function isNormalizationAllowed(array $contextual_options = [])
     {
         $operand = $this->getOperandAt(0);
-        if ( ! $operand->getPossibilities()) {
+        if (!$operand->getPossibilities()) {
             return false;
         }
 
@@ -78,7 +78,7 @@ 
      */
     public function setPossibilities($possibilities)
     {
-        if (    is_object($possibilities)
+        if (is_object($possibilities)
             && $possibilities instanceof \IteratorAggregate
             && method_exists($possibilities, 'toArray')
         ) {
@@ -113,7 +113,7 @@ 
 
     /**
      */
-    public function hasSolution(array $contextual_options=[])
+    public function hasSolution(array $contextual_options = [])
     {
         return true;
     }
@@ -123,14 +123,14 @@ 
      *
      * @return array
      */
-    public function toArray(array $options=[])
+    public function toArray(array $options = [])
     {
         $default_options = [
             'show_instance' => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if (!isset($options[ $default_option ])) {
-                $options[ $default_option ] = $default_value;
+            if (!isset($options[$default_option])) {
+                $options[$default_option] = $default_value;
             }
         }
 
@@ -149,14 +149,14 @@ 
     /**
      * @todo cache support
      */
-    public function toString(array $options=[])
+    public function toString(array $options = [])
     {
         try {
             $operator = self::operator;
 
-            $stringified_possibilities = '[' . implode(', ', array_map(function($possibility) {
+            $stringified_possibilities = '['.implode(', ', array_map(function($possibility) {
                 return var_export($possibility, true);
-            }, $this->getPossibilities()) ) .']';
+            }, $this->getPossibilities())).']';
 
             return "['{$this->getField()}', '$operator', $stringified_possibilities]";
         }

src/Rule/BelowRule.php

Indentation +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
             && null !== $maximum
         ) {
             throw new \InvalidArgumentException(
-                 "Maximum parameter must be a scalar or null "
+                    "Maximum parameter must be a scalar or null "
                 ."or implements DateTimeInterface instead of: "
                 .var_export($maximum, true)
             );

Spacing +6 added lines, -6 removed lines

@@ -16,9 +16,9 @@ 
      * @param string $field The field to apply the rule on.
      * @param array  $value The value the field can below to.
      */
-    public function __construct( $field, $maximum )
+    public function __construct($field, $maximum)
     {
-        if (    !is_scalar($maximum)
+        if (!is_scalar($maximum)
             && !$maximum instanceof \DateTimeInterface
             && null !== $maximum
         ) {
@@ -38,15 +38,15 @@ 
      *
      * @return bool
      */
-    public function hasSolution(array $contextual_options=[])
+    public function hasSolution(array $contextual_options = [])
     {
         // if minimum is null, the rule is equivalent to true
-        if (is_numeric( $this->maximum )) {
-            if (is_nan( $this->maximum )) {
+        if (is_numeric($this->maximum)) {
+            if (is_nan($this->maximum)) {
                 return false;
             }
 
-            if (is_infinite( $this->maximum ) && $this->maximum < 0) {
+            if (is_infinite($this->maximum) && $this->maximum < 0) {
                 return false;
             }
         }

src/Rule/AbstractOperationRule.php

Spacing +42 added lines, -42 removed lines

@@ -20,7 +20,7 @@ 
     const remove_negations        = 'remove_negations';
     const rootify_disjunctions    = 'rootify_disjunctions';
     const unify_atomic_operands   = 'unify_atomic_operands';
-    const remove_invalid_branches = 'remove_invalid_branches';    // simplified after this step
+    const remove_invalid_branches = 'remove_invalid_branches'; // simplified after this step
 
     const simplified              = self::remove_invalid_branches;
 
@@ -43,9 +43,9 @@ 
 
     /**
      */
-    public function __construct( array $operands=[] )
+    public function __construct(array $operands = [])
     {
-        $this->setOperands( $operands );
+        $this->setOperands($operands);
         $this->flushCache();
     }
 
@@ -64,10 +64,10 @@ 
      *
      * @return $this
      */
-    public function addOperand( AbstractRule $new_operand )
+    public function addOperand(AbstractRule $new_operand)
     {
-        if (!isset($this->operands[ $id = $new_operand->getSemanticId() ])) {
-            $this->operands[ $id ] = $new_operand;
+        if (!isset($this->operands[$id = $new_operand->getSemanticId()])) {
+            $this->operands[$id] = $new_operand;
 
             if ($this->current_simplification_step) {
                 $this->current_simplification_step = null;
@@ -84,7 +84,7 @@ 
      */
     public function getOperands()
     {
-        return array_values( $this->operands );
+        return array_values($this->operands);
     }
 
     /**
@@ -128,7 +128,7 @@ 
      * @param array  $simplification_options
      * @param bool   $force
      */
-    public function moveSimplificationStepForward($step_to_go_to, array $simplification_options, $force=false)
+    public function moveSimplificationStepForward($step_to_go_to, array $simplification_options, $force = false)
     {
         if (!in_array($step_to_go_to, self::simplification_steps)) {
             throw new \InvalidArgumentException(
@@ -140,18 +140,18 @@ 
         if (!$force && $this->current_simplification_step !== null) {
             $steps_indices = array_flip(self::simplification_steps);
 
-            $current_index = $steps_indices[ $this->current_simplification_step ];
-            $target_index  = $steps_indices[ $step_to_go_to ];
+            $current_index = $steps_indices[$this->current_simplification_step];
+            $target_index  = $steps_indices[$step_to_go_to];
 
-            if ( $current_index >= $target_index ) {
+            if ($current_index >= $target_index) {
                 // allow recall of previous step without going back
                 return;
             }
-            elseif ( $current_index < $target_index - 1 ) {
+            elseif ($current_index < $target_index - 1) {
                 throw new \LogicException(
-                    "$step_to_go_to MUST be fullfilled after " . self::simplification_steps[$target_index - 1]
-                    . " instead of the current step: " . $this->current_simplification_step
-                    ."\nfor: " . $this
+                    "$step_to_go_to MUST be fullfilled after ".self::simplification_steps[$target_index - 1]
+                    . " instead of the current step: ".$this->current_simplification_step
+                    ."\nfor: ".$this
                 );
             }
         }
@@ -180,8 +180,8 @@ 
 
         $steps_indices = array_flip(self::simplification_steps);
 
-        $current_index = $steps_indices[ $this->current_simplification_step ];
-        $step_index    = $steps_indices[ $step ];
+        $current_index = $steps_indices[$this->current_simplification_step];
+        $step_index    = $steps_indices[$step];
 
         return $current_index >= $step_index;
     }
@@ -207,7 +207,7 @@ 
                 }
 
                 if ($operands[$i] instanceof AbstractOperationRule) {
-                    $operands[$i]->removeNegations( $contextual_options );
+                    $operands[$i]->removeNegations($contextual_options);
                 }
             }
 
@@ -227,11 +227,11 @@ 
      *
      * @return $this;
      */
-    public function cleanOperations($simplification_options, $recurse=true)
+    public function cleanOperations($simplification_options, $recurse = true)
     {
         if ($recurse) {
             foreach ($this->operands as $i => $operand) {
-                if (    $operand instanceof AbstractOperationRule
+                if ($operand instanceof AbstractOperationRule
                 && !$operand instanceof InRule
                 && !$operand instanceof NotEqualRule
                 && !$operand instanceof NotInRule
@@ -305,7 +305,7 @@ 
     public function unifyAtomicOperands($simplification_strategy_step = false, array $contextual_options)
     {
         if ($simplification_strategy_step) {
-            $this->moveSimplificationStepForward( self::unify_atomic_operands, $contextual_options );
+            $this->moveSimplificationStepForward(self::unify_atomic_operands, $contextual_options);
         }
 
         // $this->dump(true);
@@ -341,7 +341,7 @@ 
                 catch (\Exception $e) {
                     VisibilityViolator::setHiddenProperty(
                         $e, 'message',
-                        $e->getMessage() . "\n" . var_export($operandsByOperator, true)
+                        $e->getMessage()."\n".var_export($operandsByOperator, true)
                     );
 
                     throw $e;
@@ -349,7 +349,7 @@ 
             }
         }
 
-        return $this->setOperandsOrReplaceByOperation( $unifiedOperands, $contextual_options );
+        return $this->setOperandsOrReplaceByOperation($unifiedOperands, $contextual_options);
     }
 
     private static $simplification_cache = [];
@@ -365,10 +365,10 @@ 
      *
      * @return AbstractRule the simplified rule
      */
-    final public function simplify($options=[])
+    final public function simplify($options = [])
     {
-        $step_to_stop_before = !empty($options['stop_before'])        ? $options['stop_before'] : null;
-        $step_to_stop_after  = !empty($options['stop_after'])         ? $options['stop_after']  : null;
+        $step_to_stop_before = !empty($options['stop_before']) ? $options['stop_before'] : null;
+        $step_to_stop_after  = !empty($options['stop_after']) ? $options['stop_after'] : null;
         $force_logical_core  = !empty($options['force_logical_core']) ? $options['force_logical_core'] : false;
 
         if ($step_to_stop_before && !in_array($step_to_stop_before, self::simplification_steps)) {
@@ -406,7 +406,7 @@ 
         // $instance->dump(true);
 
         if ($step_to_stop_after == self::remove_negations ||
-            $step_to_stop_before == self::rootify_disjunctions ) {
+            $step_to_stop_before == self::rootify_disjunctions) {
             return $instance;
         }
 
@@ -418,7 +418,7 @@ 
         // $instance->dump(true);
 
         if ($step_to_stop_after == self::rootify_disjunctions ||
-            $step_to_stop_before == self::unify_atomic_operands ) {
+            $step_to_stop_before == self::unify_atomic_operands) {
             return $instance;
         }
 
@@ -429,7 +429,7 @@ 
             // $instance->dump(true);
 
             if ($step_to_stop_after == self::unify_atomic_operands ||
-                $step_to_stop_before == self::remove_invalid_branches ) {
+                $step_to_stop_before == self::remove_invalid_branches) {
                 return $instance;
             }
 
@@ -446,7 +446,7 @@ 
         // last non recursive clean
         // TODO kind of monad|become|cese
         //@see https://github.com/jclaveau/php-logical-filter/issues/20
-        if ($instance instanceof AndRule || $instance instanceof OrRule ) {
+        if ($instance instanceof AndRule || $instance instanceof OrRule) {
             if (!$instance->getOperands()) {
                 return $instance;
             }
@@ -486,7 +486,7 @@ 
 
         $cache_keys[] = $instance->getSemanticId().'-'.$options_id;
         foreach ($cache_keys as $cache_key) {
-            self::$simplification_cache[ $cache_key ] = $instance;
+            self::$simplification_cache[$cache_key] = $instance;
         }
 
         return $instance->copy();
@@ -509,15 +509,15 @@ 
             // For FilteredValue and FilteredKey
             $field = (string) $field;
 
-            if (!isset($operandsByFields[ $field ])) {
-                $operandsByFields[ $field ] = [];
+            if (!isset($operandsByFields[$field])) {
+                $operandsByFields[$field] = [];
             }
 
-            if (!isset($operandsByFields[ $field ][ $operand::operator ])) {
-                $operandsByFields[ $field ][ $operand::operator ] = [];
+            if (!isset($operandsByFields[$field][$operand::operator])) {
+                $operandsByFields[$field][$operand::operator] = [];
             }
 
-            $operandsByFields[ $field ][ $operand::operator ][] = $operand;
+            $operandsByFields[$field][$operand::operator][] = $operand;
         }
 
         return $operandsByFields;
@@ -540,15 +540,15 @@ 
             // For FilteredValue and FilteredKey
             $field = (string) $field;
 
-            if (!isset($operandsByFields[ $field ])) {
-                $operandsByFields[ $field ] = [];
+            if (!isset($operandsByFields[$field])) {
+                $operandsByFields[$field] = [];
             }
 
-            if (!isset($operandsByFields[ $field ][ $operand::operator ])) {
-                $operandsByFields[ $field ][ $operand::operator ] = [];
+            if (!isset($operandsByFields[$field][$operand::operator])) {
+                $operandsByFields[$field][$operand::operator] = [];
             }
 
-            $operandsByFields[ $field ][ $operand::operator ][] = $operand;
+            $operandsByFields[$field][$operand::operator][] = $operand;
         }
 
         return $operandsByFields;
@@ -586,7 +586,7 @@ 
      *
      * @return AbstractRule|null The operand if it exists or null
      */
-    protected function getOperandAt($index=0)
+    protected function getOperandAt($index = 0)
     {
         $operands = array_values($this->operands);
         if (isset($operands[$index])) {

src/Rule/InRule.php

Spacing +17 added lines, -17 removed lines

@@ -32,14 +32,14 @@ 
      * @param string $field         The field to apply the rule on.
      * @param mixed  $possibilities The values the field can belong to.
      */
-    public function __construct( $field, $possibilities, array $options=[] )
+    public function __construct($field, $possibilities, array $options = [])
     {
         if (!empty($options)) {
             $this->setOptions($options);
         }
 
         $this->field = $field;
-        $this->addPossibilities( $possibilities );
+        $this->addPossibilities($possibilities);
     }
 
     /**
@@ -84,7 +84,7 @@ 
         else {
             throw new \InvalidArgumentException(
                 "\$renamings MUST be a callable or an associative array "
-                ."instead of: " . var_export($renamings, true)
+                ."instead of: ".var_export($renamings, true)
             );
         }
 
@@ -100,7 +100,7 @@ 
      */
     public function getPossibilities()
     {
-        return array_values( $this->native_possibilities );
+        return array_values($this->native_possibilities);
     }
 
     /**
@@ -110,7 +110,7 @@ 
      */
     public function addPossibilities($possibilities)
     {
-        if (    is_object($possibilities)
+        if (is_object($possibilities)
             && $possibilities instanceof \IteratorAggregate
             && method_exists($possibilities, 'toArray')
         ) {
@@ -132,8 +132,8 @@ 
                 $id = hash('crc32b', serialize($possibility));
             }
 
-            if (!isset($this->native_possibilities[ $id ])) {
-                $this->native_possibilities[ $id ] = $possibility;
+            if (!isset($this->native_possibilities[$id])) {
+                $this->native_possibilities[$id] = $possibility;
                 $require_cache_flush               = true;
             }
         }
@@ -150,7 +150,7 @@ 
      *
      * @return InRule $this
      */
-    public function addOperand( AbstractRule $operand )
+    public function addOperand(AbstractRule $operand)
     {
         $this->addPossibilities([$operand->getValue()]);
 
@@ -188,11 +188,11 @@ 
      */
     protected function checkOperandAndExtractValue($operand)
     {
-        if (! $operand instanceof AbstractAtomicRule) {
+        if (!$operand instanceof AbstractAtomicRule) {
             return $operand;
         }
 
-        if ( ! ($operand instanceof EqualRule && $operand->getField() == $this->field) ) {
+        if (!($operand instanceof EqualRule && $operand->getField() == $this->field)) {
             throw new \InvalidArgumentException(
                 "Trying to set an invalid operand of an InRule: "
                 .var_export($operand, true)
@@ -232,14 +232,14 @@ 
      *
      * @return array
      */
-    public function toArray(array $options=[])
+    public function toArray(array $options = [])
     {
         $default_options = [
             'show_instance' => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if (!isset($options[ $default_option ])) {
-                $options[ $default_option ] = $default_value;
+            if (!isset($options[$default_option])) {
+                $options[$default_option] = $default_value;
             }
         }
 
@@ -265,7 +265,7 @@ 
 
     /**
      */
-    public function toString(array $options=[])
+    public function toString(array $options = [])
     {
         if (isset($this->cache['string'])) {
             return $this->cache['string'];
@@ -273,9 +273,9 @@ 
 
         $operator = self::operator;
 
-        $stringified_possibilities = '[' . implode(', ', array_map(function($possibility) {
+        $stringified_possibilities = '['.implode(', ', array_map(function($possibility) {
             return var_export($possibility, true);
-        }, $this->getPossibilities()) ) .']';
+        }, $this->getPossibilities())).']';
 
         return $this->cache['string'] = "['{$this->getField()}', '$operator', $stringified_possibilities]";
     }
@@ -294,7 +294,7 @@ 
     /**
      * @return bool If the InRule can have a solution or not
      */
-    public function hasSolution(array $contextual_options=[])
+    public function hasSolution(array $contextual_options = [])
     {
         return !empty($this->getPossibilities());
     }

src/Rule/AbstractRule.php

Spacing +20 added lines, -20 removed lines

@@ -33,9 +33,9 @@ 
      */
     public static function findSymbolicOperator($english_operator)
     {
-        $association = array_flip( self::$ruleAliases );
-        if (isset($association[ $english_operator ])) {
-            return $association[ $english_operator ];
+        $association = array_flip(self::$ruleAliases);
+        if (isset($association[$english_operator])) {
+            return $association[$english_operator];
         }
 
         return $english_operator;
@@ -46,8 +46,8 @@ 
     public static function findEnglishOperator($symbolic_operator)
     {
         $association = self::$ruleAliases;
-        if (isset($association[ $symbolic_operator ])) {
-            return $association[ $symbolic_operator ];
+        if (isset($association[$symbolic_operator])) {
+            return $association[$symbolic_operator];
         }
 
         return $symbolic_operator;
@@ -65,16 +65,16 @@ 
      *
      * @return $this
      */
-    public static function generateSimpleRule($field, $type, $values, array $options=[])
+    public static function generateSimpleRule($field, $type, $values, array $options = [])
     {
-        $cache_key = hash('md4', serialize( func_get_args()) );
+        $cache_key = hash('md4', serialize(func_get_args()));
         if (isset(self::$static_cache['rules_generation'][$cache_key])) {
             return self::$static_cache['rules_generation'][$cache_key]->copy();
         }
 
         $ruleClass = self::getRuleClass($type);
 
-        return self::$static_cache['rules_generation'][$cache_key] = new $ruleClass( $field, $values, $options );
+        return self::$static_cache['rules_generation'][$cache_key] = new $ruleClass($field, $values, $options);
     }
 
     /**
@@ -91,7 +91,7 @@ 
             . str_replace('_', '', ucwords($english_rule_operator, '_'))
             . 'Rule';
 
-        if (!class_exists( $rule_class)) {
+        if (!class_exists($rule_class)) {
             throw new \InvalidArgumentException(
                 "The class '$rule_class' corresponding to the  operator "
                 ."'$rule_operator' / '$english_rule_operator' cannot be found."
@@ -120,7 +120,7 @@ 
      *
      * @return $this
      */
-    final public function dump($exit=false, array $options=[])
+    final public function dump($exit = false, array $options = [])
     {
         $default_options = [
             'callstack_depth' => 2,
@@ -128,18 +128,18 @@ 
             // 'show_instance'   => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if (!isset($options[ $default_option ])) {
-                $options[ $default_option ] = $default_value;
+            if (!isset($options[$default_option])) {
+                $options[$default_option] = $default_value;
             }
         }
         extract($options);
 
         $bt     = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, $callstack_depth);
-        $caller = $bt[ $callstack_depth - 2 ];
+        $caller = $bt[$callstack_depth - 2];
 
-        echo "\n" . $caller['file'] . ':' . $caller['line'] . "\n";
+        echo "\n".$caller['file'].':'.$caller['line']."\n";
         if ($mode == 'string') {
-            if ( ! isset($options['indent_unit'])) {
+            if (!isset($options['indent_unit'])) {
                 $options['indent_unit'] = "    ";
             }
 
@@ -157,10 +157,10 @@ 
             }
         }
         elseif ($mode == 'xdebug') {
-            if ( ! function_exists('xdebug_is_enabled')) {
+            if (!function_exists('xdebug_is_enabled')) {
                 throw new \RuntimeException("Xdebug is not installed");
             }
-            if ( ! xdebug_is_enabled()) {
+            if (!xdebug_is_enabled()) {
                 throw new \RuntimeException("Xdebug is disabled");
             }
 
@@ -180,7 +180,7 @@ 
         else {
             throw new \InvalidArgumentException(
                  "'mode' option must belong to ['string', 'export', 'dump'] "
-                ."instead of " . var_export($mode, true)
+                ."instead of ".var_export($mode, true)
             );
         }
         echo "\n\n";
@@ -262,9 +262,9 @@ 
         }
 
         // return hash('crc32b', serialize( $this->toArray() ));
-        return hash('md4', serialize( $this->toArray(['semantic' => true]) ))  // faster but longer
+        return hash('md4', serialize($this->toArray(['semantic' => true])))  // faster but longer
               .'-'
-              .hash('md4', serialize( $this->options ))
+              .hash('md4', serialize($this->options))
               ;
     }