jclaveau / php-logical-filter

src/Rule/InRule.php

Spacing +17 added lines, -17 removed lines

@@ -32,14 +32,14 @@ 
      * @param string $field         The field to apply the rule on.
      * @param mixed  $possibilities The values the field can belong to.
      */
-    public function __construct( $field, $possibilities, array $options=[] )
+    public function __construct($field, $possibilities, array $options = [])
     {
         if (!empty($options)) {
             $this->setOptions($options);
         }
 
         $this->field = $field;
-        $this->addPossibilities( $possibilities );
+        $this->addPossibilities($possibilities);
     }
 
     /**
@@ -83,7 +83,7 @@ 
         else {
             throw new \InvalidArgumentException(
                 "\$renamings MUST be a callable or an associative array "
-                ."instead of: " . var_export($renamings, true)
+                ."instead of: ".var_export($renamings, true)
             );
         }
 
@@ -98,7 +98,7 @@ 
      */
     public function getPossibilities()
     {
-        return array_values( $this->native_possibilities );
+        return array_values($this->native_possibilities);
     }
 
     /**
@@ -108,7 +108,7 @@ 
      */
     public function addPossibilities($possibilities)
     {
-        if (    is_object($possibilities)
+        if (is_object($possibilities)
             &&  $possibilities instanceof \IteratorAggregate
             &&  method_exists($possibilities, 'toArray')
         ) {
@@ -128,8 +128,8 @@ 
             else
                 $id = hash('crc32b', serialize($possibility));
 
-            if (!isset($this->native_possibilities[ $id ])) {
-                $this->native_possibilities[ $id ] = $possibility;
+            if (!isset($this->native_possibilities[$id])) {
+                $this->native_possibilities[$id] = $possibility;
                 $require_cache_flush = true;
             }
         }
@@ -145,7 +145,7 @@ 
      *
      * @return InRule $this
      */
-    public function addOperand( AbstractRule $operand )
+    public function addOperand(AbstractRule $operand)
     {
         $this->addPossibilities([$operand->getValue()]);
 
@@ -183,10 +183,10 @@ 
      */
     protected function checkOperandAndExtractValue($operand)
     {
-        if (! $operand instanceof AbstractAtomicRule)
+        if (!$operand instanceof AbstractAtomicRule)
             return $operand;
 
-        if ( ! ($operand instanceof EqualRule && $operand->getField() == $this->field) ) {
+        if (!($operand instanceof EqualRule && $operand->getField() == $this->field)) {
             throw new \InvalidArgumentException(
                 "Trying to set an invalid operand of an InRule: "
                 .var_export($operand, true)
@@ -225,14 +225,14 @@ 
      *
      * @return array
      */
-    public function toArray(array $options=[])
+    public function toArray(array $options = [])
     {
         $default_options = [
             'show_instance' => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if (!isset($options[ $default_option ]))
-                $options[ $default_option ] = $default_value;
+            if (!isset($options[$default_option]))
+                $options[$default_option] = $default_value;
         }
 
         $class = get_class($this);
@@ -254,16 +254,16 @@ 
 
     /**
      */
-    public function toString(array $options=[])
+    public function toString(array $options = [])
     {
         if (isset($this->cache['string']))
             return $this->cache['string'];
 
         $operator = self::operator;
 
-        $stringified_possibilities = '[' . implode(', ', array_map(function($possibility) {
+        $stringified_possibilities = '['.implode(', ', array_map(function($possibility) {
             return var_export($possibility, true);
-        }, $this->getPossibilities()) ) .']';
+        }, $this->getPossibilities())).']';
 
         return $this->cache['string'] = "['{$this->getField()}', '$operator', $stringified_possibilities]";
     }
@@ -282,7 +282,7 @@ 
     /**
      * @return bool If the InRule can have a solution or not
      */
-    public function hasSolution(array $contextual_options=[])
+    public function hasSolution(array $contextual_options = [])
     {
         return !empty($this->getPossibilities());
     }

Braces +39 added lines, -30 removed lines

@@ -75,20 +75,20 @@ 
 
         if (is_callable($renamings)) {
             $this->field = call_user_func($renamings, $this->field);
-        }
-        elseif (is_array($renamings)) {
-            if (isset($renamings[$this->field]))
-                $this->field = $renamings[$this->field];
-        }
-        else {
+        } elseif (is_array($renamings)) {
+            if (isset($renamings[$this->field])) {
+                            $this->field = $renamings[$this->field];
+            }
+        } else {
             throw new \InvalidArgumentException(
                 "\$renamings MUST be a callable or an associative array "
                 ."instead of: " . var_export($renamings, true)
             );
         }
 
-        if ($old_field != $this->field)
-            $this->flushCache();
+        if ($old_field != $this->field) {
+                    $this->flushCache();
+        }
 
         return $this;
     }
@@ -115,18 +115,20 @@ 
             $possibilities = $possibilities->toArray();
         }
 
-        if (!is_array($possibilities))
-            $possibilities = [$possibilities];
+        if (!is_array($possibilities)) {
+                    $possibilities = [$possibilities];
+        }
 
         $possibilities = array_map([$this, 'checkOperandAndExtractValue'], $possibilities);
 
         // unique possibilities
         foreach ($possibilities as &$possibility) {
 
-            if (is_scalar($possibility))
-                $id = hash('crc32b', $possibility);
-            else
-                $id = hash('crc32b', serialize($possibility));
+            if (is_scalar($possibility)) {
+                            $id = hash('crc32b', $possibility);
+            } else {
+                            $id = hash('crc32b', serialize($possibility));
+            }
 
             if (!isset($this->native_possibilities[ $id ])) {
                 $this->native_possibilities[ $id ] = $possibility;
@@ -134,8 +136,9 @@ 
             }
         }
 
-        if (isset($require_cache_flush))
-            $this->flushCache();
+        if (isset($require_cache_flush)) {
+                    $this->flushCache();
+        }
 
         return $this;
     }
@@ -183,8 +186,9 @@ 
      */
     protected function checkOperandAndExtractValue($operand)
     {
-        if (! $operand instanceof AbstractAtomicRule)
-            return $operand;
+        if (! $operand instanceof AbstractAtomicRule) {
+                    return $operand;
+        }
 
         if ( ! ($operand instanceof EqualRule && $operand->getField() == $this->field) ) {
             throw new \InvalidArgumentException(
@@ -206,8 +210,9 @@ 
         }
 
         $operands = [];
-        foreach ($this->native_possibilities as $value)
-            $operands[] = new EqualRule($this->field, $value);
+        foreach ($this->native_possibilities as $value) {
+                    $operands[] = new EqualRule($this->field, $value);
+        }
 
         return $this->cache['operands'] = $operands;
     }
@@ -231,14 +236,16 @@ 
             'show_instance' => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if (!isset($options[ $default_option ]))
-                $options[ $default_option ] = $default_value;
+            if (!isset($options[ $default_option ])) {
+                            $options[ $default_option ] = $default_value;
+            }
         }
 
         $class = get_class($this);
 
-        if (!$options['show_instance'] && isset($this->cache['array']))
-            return $this->cache['array'];
+        if (!$options['show_instance'] && isset($this->cache['array'])) {
+                    return $this->cache['array'];
+        }
 
         $array = [
             $this->getField(),
@@ -246,18 +253,20 @@ 
             $this->getValues(),
         ];
 
-        if (!$options['show_instance'])
-            return $this->cache['array'] = $array;
-        else
-            return $array;
+        if (!$options['show_instance']) {
+                    return $this->cache['array'] = $array;
+        } else {
+                    return $array;
+        }
     }
 
     /**
      */
     public function toString(array $options=[])
     {
-        if (isset($this->cache['string']))
-            return $this->cache['string'];
+        if (isset($this->cache['string'])) {
+                    return $this->cache['string'];
+        }
 
         $operator = self::operator;