jclaveau / php-logical-filter

src/Rule/AbstractOperationRule.php

Doc Comments +2 added lines, -2 removed lines

@@ -81,7 +81,7 @@ 
     }
 
     /**
-     * @return array
+     * @return AbstractRule[]
      */
     public function getOperands()
     {
@@ -117,7 +117,7 @@ 
      * @param  array|callable $renamings Associative array of renamings or callable
      *                                   that would rename the fields.
      *
-     * @return boolean Whether or not the operation changed semantically
+     * @return AbstractOperationRule Whether or not the operation changed semantically
      */
     public function renameFields_andReturnIsChanged($renamings)
     {

src/Rule/InRule.php

Spacing +15 added lines, -15 removed lines

@@ -24,14 +24,14 @@ 
      * @param string $field         The field to apply the rule on.
      * @param mixed  $possibilities The values the field can belong to.
      */
-    public function __construct($field, $possibilities, array $options=[])
+    public function __construct($field, $possibilities, array $options = [])
     {
-        if (! empty($options)) {
+        if ( ! empty($options)) {
             $this->setOptions($options);
         }
 
         $this->field = $field;
-        $this->addPossibilities( $possibilities );
+        $this->addPossibilities($possibilities);
     }
 
     /**
@@ -49,7 +49,7 @@ 
      */
     public function addPossibilities($possibilities)
     {
-        if (    is_object($possibilities)
+        if (is_object($possibilities)
             && $possibilities instanceof \IteratorAggregate
             && method_exists($possibilities, 'toArray')
         ) {
@@ -71,8 +71,8 @@ 
                 $id = hash('crc32b', serialize($possibility));
             }
 
-            if ( ! isset($this->native_possibilities[ $id ])) {
-                $this->native_possibilities[ $id ] = $possibility;
+            if ( ! isset($this->native_possibilities[$id])) {
+                $this->native_possibilities[$id] = $possibility;
                 $require_cache_flush               = true;
             }
         }
@@ -89,7 +89,7 @@ 
      *
      * @return InRule $this
      */
-    public function addOperand( AbstractRule $operand )
+    public function addOperand(AbstractRule $operand)
     {
         $this->addPossibilities([$operand->getValue()]);
 
@@ -131,7 +131,7 @@ 
             return $operand;
         }
 
-        if ( ! ($operand instanceof EqualRule && $operand->getField() == $this->field) ) {
+        if ( ! ($operand instanceof EqualRule && $operand->getField() == $this->field)) {
             throw new \InvalidArgumentException(
                 "Trying to set an invalid operand of an InRule: "
                 .var_export($operand, true)
@@ -171,14 +171,14 @@ 
      *
      * @return array
      */
-    public function toArray(array $options=[])
+    public function toArray(array $options = [])
     {
         $default_options = [
             'show_instance' => false,
         ];
         foreach ($default_options as $default_option => &$default_value) {
-            if ( ! isset($options[ $default_option ])) {
-                $options[ $default_option ] = $default_value;
+            if ( ! isset($options[$default_option])) {
+                $options[$default_option] = $default_value;
             }
         }
 
@@ -204,7 +204,7 @@ 
 
     /**
      */
-    public function toString(array $options=[])
+    public function toString(array $options = [])
     {
         if (isset($this->cache['string'])) {
             return $this->cache['string'];
@@ -212,9 +212,9 @@ 
 
         $operator = self::operator;
 
-        $stringified_possibilities = '[' . implode(', ', array_map(function($possibility) {
+        $stringified_possibilities = '['.implode(', ', array_map(function($possibility) {
             return var_export($possibility, true);
-        }, $this->getPossibilities()) ) .']';
+        }, $this->getPossibilities())).']';
 
         return $this->cache['string'] = "['{$this->getField()}', '$operator', $stringified_possibilities]";
     }
@@ -233,7 +233,7 @@ 
     /**
      * @return bool If the InRule can have a solution or not
      */
-    public function hasSolution(array $contextual_options=[])
+    public function hasSolution(array $contextual_options = [])
     {
         return ! empty($this->getPossibilities());
     }

src/Rule/Trait_RuleWithField.php

Spacing +4 added lines, -4 removed lines

@@ -23,7 +23,7 @@ 
     /**
      * @return string $field
      */
-    final public function setField( $field )
+    final public function setField($field)
     {
         if ( ! is_scalar($field)) {
             throw new \InvalidArgumentEXception(
@@ -67,17 +67,17 @@ 
         $old_field = $this->field;
 
         if (is_callable($renamings)) {
-            $this->setField( call_user_func($renamings, $this->field) );
+            $this->setField(call_user_func($renamings, $this->field));
         }
         elseif (is_array($renamings)) {
             if (isset($renamings[$this->field])) {
-                $this->setField( $renamings[$this->field] );
+                $this->setField($renamings[$this->field]);
             }
         }
         else {
             throw new \InvalidArgumentException(
                 "\$renamings MUST be a callable or an associative array "
-                ."instead of: " . var_export($renamings, true)
+                ."instead of: ".var_export($renamings, true)
             );
         }