jclaveau / php-chainable-array

src/Arrays/MergeBucket.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     public function reduceIfUnique()
     {
         if ($this->unique()->count() == 1)
-            return reset( $this->data );
+            return reset($this->data);
     }
     /**/
 }

Braces +3 added lines, -2 removed lines

@@ -11,8 +11,9 @@
      */
     public function reduceIfUnique()
     {
-        if ($this->unique()->count() == 1)
-            return reset( $this->data );
+        if ($this->unique()->count() == 1) {
+                    return reset( $this->data );
+        }
     }
     /**/
 }

src/Arrays/ChainableArray_Utils_Trait.php

Spacing +48 added lines, -48 removed lines

@@ -18,7 +18,7 @@ 
      *
      * @return array The array containing the grouped rows.
      */
-    public function groupBy( callable $indexGenerator, callable $conflictResolver=null )
+    public function groupBy(callable $indexGenerator, callable $conflictResolver = null)
     {
         // todo : this doesn't work
         // return $this->groupByTransformed($indexGenerator, null, $conflictResolver);
@@ -26,15 +26,15 @@ 
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
+            if ( ! $row)
                 continue;
 
             $newIndexes     = call_user_func($indexGenerator, $key, $row);
-            if (!is_array($newIndexes))
+            if ( ! is_array($newIndexes))
                 $newIndexes = [$newIndexes];
 
             foreach ($newIndexes as $newIndex) {
-                if (!isset($out[$newIndex])) {
+                if ( ! isset($out[$newIndex])) {
                     $out[$newIndex] = $row;
                 }
                 else {
@@ -69,26 +69,26 @@ 
      *
      * @return array The array containing the grouped rows.
      */
-    public function groupInArrays( callable $indexGenerator )
+    public function groupInArrays(callable $indexGenerator)
     {
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
+            if ( ! $row)
                 continue;
 
             $new_keys = call_user_func($indexGenerator, $row, $key);
-            if (!is_array($new_keys))
+            if ( ! is_array($new_keys))
                 $new_keys = [$new_keys];
 
             foreach ($new_keys as $new_key) {
-                if (!isset($out[ $new_key ])) {
-                    $out[ $new_key ] = [
+                if ( ! isset($out[$new_key])) {
+                    $out[$new_key] = [
                         $key => $row
                     ];
                 }
                 else {
-                    $out[ $new_key ][ $key ] = $row;
+                    $out[$new_key][$key] = $row;
                 }
             }
         }
@@ -112,7 +112,7 @@ 
      */
     public function groupByTransformed(
         callable $indexGenerator,
-        callable $rowTransformer,      // todo check this behavior
+        callable $rowTransformer, // todo check this behavior
         callable $conflictResolver )
     {
         // The goal here is to remove the second parameter has it makes the
@@ -125,7 +125,7 @@ 
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
+            if ( ! $row)
                 continue;
 
             $newIndex       = call_user_func($indexGenerator, $key, $row);
@@ -134,7 +134,7 @@ 
                             ? call_user_func($rowTransformer, $row)
                             : $row;
 
-            if (!isset($out[$newIndex])) {
+            if ( ! isset($out[$newIndex])) {
                 $out[$newIndex] = $transformedRow;
             }
             else {
@@ -159,12 +159,12 @@ 
      *                                       rows have the same index.
      * @return static
      */
-    public function mergeWith( $otherTable, callable $conflictResolver=null )
+    public function mergeWith($otherTable, callable $conflictResolver = null)
     {
         if (is_array($otherTable))
             $otherTable = new static($otherTable);
 
-        if (!$otherTable instanceof static) {
+        if ( ! $otherTable instanceof static) {
             self::throwUsageException(
                 '$otherTable must be an array or an instance of '.static::class.' instead of: '
                 .var_export($otherTable, true)
@@ -174,14 +174,14 @@ 
         $out = $this->data;
         foreach ($otherTable->getArray() as $key => $row) {
 
-            if (!isset($out[$key])) {
+            if ( ! isset($out[$key])) {
                 $out[$key] = $row;
             }
             else {
                 if ($conflictResolver === null) {
                     self::throwUsageException(
                         "No conflict resolver for a merge provoking one: $key \n\n"
-                        .var_export($row, true) . "\n\n"
+                        .var_export($row, true)."\n\n"
                         .var_export($out[$key], true)
                     );
                 }
@@ -207,7 +207,7 @@ 
      * (same as self::mergeWith with the other table as $this)
      * @return static
      */
-    public function mergeIn( $otherTable, callable $conflictResolver=null )
+    public function mergeIn($otherTable, callable $conflictResolver = null)
     {
         $otherTable->mergeWith($this, $conflictResolver);
         return $this;
@@ -233,7 +233,7 @@ 
      */
     public function each(callable $rowTransformer)
     {
-        $out  = [];
+        $out = [];
         foreach ($this->data as $key => $row) {
             $out[$key] = call_user_func_array(
                 $rowTransformer,
@@ -263,7 +263,7 @@ 
      */
     public function renameColumns(array $old_to_new_names)
     {
-        $out  = [];
+        $out = [];
         foreach ($this->data as $key => $row) {
             try {
                 foreach ($old_to_new_names as $old_name => $new_name) {
@@ -272,7 +272,7 @@ 
                 }
             }
             catch (\Exception $e) {
-                self::throwUsageException( $e->getMessage() );
+                self::throwUsageException($e->getMessage());
             }
 
             $out[$key] = $row;
@@ -324,20 +324,20 @@ 
      *                            nor a static.
      * @return static       $this
      */
-    public function append($new_rows, callable $conflict_resolver=null)
+    public function append($new_rows, callable $conflict_resolver = null)
     {
         if ($new_rows instanceof static)
             $new_rows = $new_rows->getArray();
 
-        if (!is_array($new_rows)) {
+        if ( ! is_array($new_rows)) {
             $this->throwUsageException(
-                "\$new_rows parameter must be an array or an instance of " . __CLASS__
+                "\$new_rows parameter must be an array or an instance of ".__CLASS__
             );
         }
 
-        if (!$conflict_resolver) {
+        if ( ! $conflict_resolver) {
             // default conflict resolver: append with numeric key
-            $conflict_resolver = function (&$data, $existing_row, $confliuct_row, $key) {
+            $conflict_resolver = function(&$data, $existing_row, $confliuct_row, $key) {
                 $data[] = $confliuct_row;
             };
         }
@@ -369,7 +369,7 @@ 
      *
      * @return static
      */
-    public function dimensionsAsColumns(array $columnNames, array $options=null)
+    public function dimensionsAsColumns(array $columnNames, array $options = null)
     {
         $out = $this->dimensionsAsColumns_recurser($this->data, $columnNames);
         return $this->returnConstant($out);
@@ -406,12 +406,12 @@ 
      *      ],
      * ]
      */
-    protected function dimensionsAsColumns_recurser(array $data, $columnNames, $rowIdParts=[])
+    protected function dimensionsAsColumns_recurser(array $data, $columnNames, $rowIdParts = [])
     {
         $out = [];
         // if (!$columnNames)
             // return $data;
-        $no_more_column = !(bool) $columnNames;
+        $no_more_column = ! (bool) $columnNames;
 
         // If all the names have been given to the dimensions
         // we compile the index key of the row at the current level
@@ -435,7 +435,7 @@ 
                     self::throwUsageException(
                          "Trying to populate a column '$name' that "
                         ."already exists with a different value "
-                        .var_export($data[$name], true). " => '$value'"
+                        .var_export($data[$name], true)." => '$value'"
                     );
                 }
                 $data[$name] = $value;
@@ -466,7 +466,7 @@ 
             }
             else {
 
-                if (!isset($rows)) {
+                if ( ! isset($rows)) {
                     echo json_encode([
                         '$rowIdParts' => $rowIdParts,
                         '$row' => $row,
@@ -494,9 +494,9 @@ 
     /**
      * Returns the first element of the array
      */
-    public function first($strict=false)
+    public function first($strict = false)
     {
-        if (!$this->count()) {
+        if ( ! $this->count()) {
             if ($strict)
                 throw new \ErrorException("No first element found in this array");
             else
@@ -516,9 +516,9 @@ 
      *
      * @todo Preserve the offset
      */
-    public function last($strict=false)
+    public function last($strict = false)
     {
-        if (!$this->count()) {
+        if ( ! $this->count()) {
             if ($strict)
                 throw new \ErrorException("No last element found in this array");
             else
@@ -536,9 +536,9 @@ 
     /**
      *
      */
-    public function firstKey($strict=false)
+    public function firstKey($strict = false)
     {
-        if (!$this->count()) {
+        if ( ! $this->count()) {
             if ($strict)
                 throw new \ErrorException("No last element found in this array");
             else
@@ -557,16 +557,16 @@ 
     /**
      *
      */
-    public function lastKey($strict=false)
+    public function lastKey($strict = false)
     {
-        if (!$this->count()) {
+        if ( ! $this->count()) {
             if ($strict)
                 throw new \ErrorException("No last element found in this array");
             else
                 $lastKey = null;
         }
         else {
-            $key  = key($this->data);
+            $key = key($this->data);
             end($this->data);
             $lastKey = key($this->data);
             $this->move($key);
@@ -578,7 +578,7 @@ 
     /**
      * Move the internal pointer of the array to the key given as parameter
      */
-    public function move($key, $strict=true)
+    public function move($key, $strict = true)
     {
         if (array_key_exists($key, $this->data)) {
             foreach ($this->data as $i => &$value) {
@@ -645,13 +645,13 @@ 
      * @see http://php.net/manual/fr/function.var-dump.php
      * @todo Handle xdebug dump formatting
      */
-    public function dump($exit=false)
+    public function dump($exit = false)
     {
         $bt = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2);
         $caller = $bt[0];
 
         var_export([
-            'location' => $caller['file'] . ':' . $caller['line'],
+            'location' => $caller['file'].':'.$caller['line'],
             'data'     => $this->data,
         ]);
 
@@ -668,7 +668,7 @@ 
      * @todo move it to an Arrays class storing static methods
      */
     public static function replaceEntries(
-        array $array, callable $replacer, $max_depth=null
+        array $array, callable $replacer, $max_depth = null
     ) {
         foreach ($array as $key => &$row) {
             $arguments = [&$row, $key];
@@ -676,7 +676,7 @@ 
 
             if (is_array($row) && $max_depth !== 0) { // allowing null to have no depth limit
                 $row = self::replaceEntries(
-                    $row, $replacer, $max_depth ? $max_depth-1 : $max_depth
+                    $row, $replacer, $max_depth ? $max_depth - 1 : $max_depth
                 );
             }
         }
@@ -692,7 +692,7 @@ 
      *
      * @return static $this or a new static.
      */
-    public function extract($callback=null)
+    public function extract($callback = null)
     {
         if ($callback) {
 
@@ -700,7 +700,7 @@ 
                 $callback = new \JClaveau\LogicalFilter\LogicalFilter($callback);
             }
 
-            if (!is_callable($callback)) {
+            if ( ! is_callable($callback)) {
                 $this->throwUsageException(
                     "\$callback must be a logical filter description array or a callable"
                     ." instead of "
@@ -712,7 +712,7 @@ 
             foreach ($this->data as $key => $value) {
                 if ($callback($value, $key)) {
                     $out[$key] = $value;
-                    unset( $this->data[$key] );
+                    unset($this->data[$key]);
                 }
             }
         }

Braces +67 added lines, -64 removed lines

@@ -26,18 +26,19 @@ 
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
-                continue;
+            if (!$row) {
+                            continue;
+            }
 
             $newIndexes     = call_user_func($indexGenerator, $key, $row);
-            if (!is_array($newIndexes))
-                $newIndexes = [$newIndexes];
+            if (!is_array($newIndexes)) {
+                            $newIndexes = [$newIndexes];
+            }
 
             foreach ($newIndexes as $newIndex) {
                 if (!isset($out[$newIndex])) {
                     $out[$newIndex] = $row;
-                }
-                else {
+                } else {
                     if ($conflictResolver === null) {
                         self::throwUsageException(
                             "A 'group by' provoking a conflict"
@@ -74,20 +75,21 @@ 
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
-                continue;
+            if (!$row) {
+                            continue;
+            }
 
             $new_keys = call_user_func($indexGenerator, $row, $key);
-            if (!is_array($new_keys))
-                $new_keys = [$new_keys];
+            if (!is_array($new_keys)) {
+                            $new_keys = [$new_keys];
+            }
 
             foreach ($new_keys as $new_key) {
                 if (!isset($out[ $new_key ])) {
                     $out[ $new_key ] = [
                         $key => $row
                     ];
-                }
-                else {
+                } else {
                     $out[ $new_key ][ $key ] = $row;
                 }
             }
@@ -125,8 +127,9 @@ 
         $out = [];
         foreach ($this->data as $key => $row) {
 
-            if (!$row)
-                continue;
+            if (!$row) {
+                            continue;
+            }
 
             $newIndex       = call_user_func($indexGenerator, $key, $row);
 
@@ -136,8 +139,7 @@ 
 
             if (!isset($out[$newIndex])) {
                 $out[$newIndex] = $transformedRow;
-            }
-            else {
+            } else {
                 $out[$newIndex] = call_user_func(
                     $conflictResolver,
                     $newIndex,
@@ -161,8 +163,9 @@ 
      */
     public function mergeWith( $otherTable, callable $conflictResolver=null )
     {
-        if (is_array($otherTable))
-            $otherTable = new static($otherTable);
+        if (is_array($otherTable)) {
+                    $otherTable = new static($otherTable);
+        }
 
         if (!$otherTable instanceof static) {
             self::throwUsageException(
@@ -176,8 +179,7 @@ 
 
             if (!isset($out[$key])) {
                 $out[$key] = $row;
-            }
-            else {
+            } else {
                 if ($conflictResolver === null) {
                     self::throwUsageException(
                         "No conflict resolver for a merge provoking one: $key \n\n"
@@ -270,8 +272,7 @@ 
                     $row[$new_name] = $row[$old_name];
                     unset($row[$old_name]);
                 }
-            }
-            catch (\Exception $e) {
+            } catch (\Exception $e) {
                 self::throwUsageException( $e->getMessage() );
             }
 
@@ -292,17 +293,19 @@ 
     public function limit()
     {
         $arguments = func_get_args();
-        if (count($arguments) == 1 && is_numeric($arguments[0]))
-            $max = $arguments[0];
-        else
-            self::throwUsageException("Bad arguments type and count for limit()");
+        if (count($arguments) == 1 && is_numeric($arguments[0])) {
+                    $max = $arguments[0];
+        } else {
+                    self::throwUsageException("Bad arguments type and count for limit()");
+        }
 
         $out   = [];
         $count = 0;
         foreach ($this->data as $key => $row) {
 
-            if ($max <= $count)
-                break;
+            if ($max <= $count) {
+                            break;
+            }
 
             $out[$key] = $row;
 
@@ -326,8 +329,9 @@ 
      */
     public function append($new_rows, callable $conflict_resolver=null)
     {
-        if ($new_rows instanceof static)
-            $new_rows = $new_rows->getArray();
+        if ($new_rows instanceof static) {
+                    $new_rows = $new_rows->getArray();
+        }
 
         if (!is_array($new_rows)) {
             $this->throwUsageException(
@@ -352,8 +356,7 @@ 
                 ];
 
                 call_user_func_array($conflict_resolver, $arguments);
-            }
-            else {
+            } else {
                 $this->data[$key] = $new_row;
             }
         }
@@ -463,8 +466,7 @@ 
                 foreach ($rows as $row_id => $joined_row) {
                     $out[$row_id] = $joined_row;
                 }
-            }
-            else {
+            } else {
 
                 if (!isset($rows)) {
                     echo json_encode([
@@ -474,8 +476,9 @@ 
                     exit;
                 }
 
-                foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue)
-                    $row[$rowIdPartName] = $rowIdPartValue;
+                foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue) {
+                                    $row[$rowIdPartName] = $rowIdPartValue;
+                }
 
                 $indexParts = [];
                 foreach ($rowIdParts as $name => $value) {
@@ -497,12 +500,12 @@ 
     public function first($strict=false)
     {
         if (!$this->count()) {
-            if ($strict)
-                throw new \ErrorException("No first element found in this array");
-            else
-                $first = null;
-        }
-        else {
+            if ($strict) {
+                            throw new \ErrorException("No first element found in this array");
+            } else {
+                            $first = null;
+            }
+        } else {
             $key   = key($this->data);
             $first = reset($this->data);
             $this->move($key);
@@ -519,12 +522,12 @@ 
     public function last($strict=false)
     {
         if (!$this->count()) {
-            if ($strict)
-                throw new \ErrorException("No last element found in this array");
-            else
-                $last = null;
-        }
-        else {
+            if ($strict) {
+                            throw new \ErrorException("No last element found in this array");
+            } else {
+                            $last = null;
+            }
+        } else {
             $key  = key($this->data);
             $last = end($this->data);
             $this->move($key);
@@ -539,12 +542,12 @@ 
     public function firstKey($strict=false)
     {
         if (!$this->count()) {
-            if ($strict)
-                throw new \ErrorException("No last element found in this array");
-            else
-                $firstKey = null;
-        }
-        else {
+            if ($strict) {
+                            throw new \ErrorException("No last element found in this array");
+            } else {
+                            $firstKey = null;
+            }
+        } else {
             $key      = key($this->data);
             reset($this->data);
             $firstKey = key($this->data);
@@ -560,12 +563,12 @@ 
     public function lastKey($strict=false)
     {
         if (!$this->count()) {
-            if ($strict)
-                throw new \ErrorException("No last element found in this array");
-            else
-                $lastKey = null;
-        }
-        else {
+            if ($strict) {
+                            throw new \ErrorException("No last element found in this array");
+            } else {
+                            $lastKey = null;
+            }
+        } else {
             $key  = key($this->data);
             end($this->data);
             $lastKey = key($this->data);
@@ -587,8 +590,7 @@ 
                     break;
                 }
             }
-        }
-        elseif ($strict) {
+        } elseif ($strict) {
             throw new \ErrorException("Unable to move the internal pointer to a key that doesn't exist.");
         }
 
@@ -655,8 +657,9 @@ 
             'data'     => $this->data,
         ]);
 
-        if ($exit)
-            exit;
+        if ($exit) {
+                    exit;
+        }
 
         return $this;
     }