@@ -18,7 +18,7 @@ discard block |
||
18 | 18 | * |
19 | 19 | * @return array The array containing the grouped rows. |
20 | 20 | */ |
21 | - public function groupBy( callable $indexGenerator, callable $conflictResolver=null ) |
|
21 | + public function groupBy(callable $indexGenerator, callable $conflictResolver = null) |
|
22 | 22 | { |
23 | 23 | // todo : this doesn't work |
24 | 24 | // return $this->groupByTransformed($indexGenerator, null, $conflictResolver); |
@@ -26,15 +26,15 @@ discard block |
||
26 | 26 | $out = []; |
27 | 27 | foreach ($this->data as $key => $row) { |
28 | 28 | |
29 | - if (!$row) |
|
29 | + if ( ! $row) |
|
30 | 30 | continue; |
31 | 31 | |
32 | 32 | $newIndexes = call_user_func($indexGenerator, $key, $row); |
33 | - if (!is_array($newIndexes)) |
|
33 | + if ( ! is_array($newIndexes)) |
|
34 | 34 | $newIndexes = [$newIndexes]; |
35 | 35 | |
36 | 36 | foreach ($newIndexes as $newIndex) { |
37 | - if (!isset($out[$newIndex])) { |
|
37 | + if ( ! isset($out[$newIndex])) { |
|
38 | 38 | $out[$newIndex] = $row; |
39 | 39 | } |
40 | 40 | else { |
@@ -69,26 +69,26 @@ discard block |
||
69 | 69 | * |
70 | 70 | * @return array The array containing the grouped rows. |
71 | 71 | */ |
72 | - public function groupInArrays( callable $indexGenerator ) |
|
72 | + public function groupInArrays(callable $indexGenerator) |
|
73 | 73 | { |
74 | 74 | $out = []; |
75 | 75 | foreach ($this->data as $key => $row) { |
76 | 76 | |
77 | - if (!$row) |
|
77 | + if ( ! $row) |
|
78 | 78 | continue; |
79 | 79 | |
80 | 80 | $new_keys = call_user_func($indexGenerator, $row, $key); |
81 | - if (!is_array($new_keys)) |
|
81 | + if ( ! is_array($new_keys)) |
|
82 | 82 | $new_keys = [$new_keys]; |
83 | 83 | |
84 | 84 | foreach ($new_keys as $new_key) { |
85 | - if (!isset($out[ $new_key ])) { |
|
86 | - $out[ $new_key ] = [ |
|
85 | + if ( ! isset($out[$new_key])) { |
|
86 | + $out[$new_key] = [ |
|
87 | 87 | $key => $row |
88 | 88 | ]; |
89 | 89 | } |
90 | 90 | else { |
91 | - $out[ $new_key ][ $key ] = $row; |
|
91 | + $out[$new_key][$key] = $row; |
|
92 | 92 | } |
93 | 93 | } |
94 | 94 | } |
@@ -112,7 +112,7 @@ discard block |
||
112 | 112 | */ |
113 | 113 | public function groupByTransformed( |
114 | 114 | callable $indexGenerator, |
115 | - callable $rowTransformer, // todo check this behavior |
|
115 | + callable $rowTransformer, // todo check this behavior |
|
116 | 116 | callable $conflictResolver ) |
117 | 117 | { |
118 | 118 | // The goal here is to remove the second parameter has it makes the |
@@ -125,7 +125,7 @@ discard block |
||
125 | 125 | $out = []; |
126 | 126 | foreach ($this->data as $key => $row) { |
127 | 127 | |
128 | - if (!$row) |
|
128 | + if ( ! $row) |
|
129 | 129 | continue; |
130 | 130 | |
131 | 131 | $newIndex = call_user_func($indexGenerator, $key, $row); |
@@ -134,7 +134,7 @@ discard block |
||
134 | 134 | ? call_user_func($rowTransformer, $row) |
135 | 135 | : $row; |
136 | 136 | |
137 | - if (!isset($out[$newIndex])) { |
|
137 | + if ( ! isset($out[$newIndex])) { |
|
138 | 138 | $out[$newIndex] = $transformedRow; |
139 | 139 | } |
140 | 140 | else { |
@@ -159,12 +159,12 @@ discard block |
||
159 | 159 | * rows have the same index. |
160 | 160 | * @return static |
161 | 161 | */ |
162 | - public function mergeWith( $otherTable, callable $conflictResolver=null ) |
|
162 | + public function mergeWith($otherTable, callable $conflictResolver = null) |
|
163 | 163 | { |
164 | 164 | if (is_array($otherTable)) |
165 | 165 | $otherTable = new static($otherTable); |
166 | 166 | |
167 | - if (!$otherTable instanceof static) { |
|
167 | + if ( ! $otherTable instanceof static) { |
|
168 | 168 | self::throwUsageException( |
169 | 169 | '$otherTable must be an array or an instance of '.static::class.' instead of: ' |
170 | 170 | .var_export($otherTable, true) |
@@ -174,7 +174,7 @@ discard block |
||
174 | 174 | $out = $this->data; |
175 | 175 | foreach ($otherTable->getArray() as $key => $row) { |
176 | 176 | |
177 | - if (!isset($out[$key])) { |
|
177 | + if ( ! isset($out[$key])) { |
|
178 | 178 | $out[$key] = $row; |
179 | 179 | } |
180 | 180 | else { |
@@ -202,7 +202,7 @@ discard block |
||
202 | 202 | * (same as self::mergeWith with the other table as $this) |
203 | 203 | * @return static |
204 | 204 | */ |
205 | - public function mergeIn( $otherTable, callable $conflictResolver=null ) |
|
205 | + public function mergeIn($otherTable, callable $conflictResolver = null) |
|
206 | 206 | { |
207 | 207 | $otherTable->mergeWith($this, $conflictResolver); |
208 | 208 | return $this; |
@@ -228,7 +228,7 @@ discard block |
||
228 | 228 | */ |
229 | 229 | public function each(callable $rowTransformer) |
230 | 230 | { |
231 | - $out = []; |
|
231 | + $out = []; |
|
232 | 232 | foreach ($this->data as $key => $row) { |
233 | 233 | $out[$key] = call_user_func_array( |
234 | 234 | $rowTransformer, |
@@ -258,7 +258,7 @@ discard block |
||
258 | 258 | */ |
259 | 259 | public function renameColumns(array $old_to_new_names) |
260 | 260 | { |
261 | - $out = []; |
|
261 | + $out = []; |
|
262 | 262 | foreach ($this->data as $key => $row) { |
263 | 263 | try { |
264 | 264 | foreach ($old_to_new_names as $old_name => $new_name) { |
@@ -267,7 +267,7 @@ discard block |
||
267 | 267 | } |
268 | 268 | } |
269 | 269 | catch (\Exception $e) { |
270 | - self::throwUsageException( $e->getMessage() ); |
|
270 | + self::throwUsageException($e->getMessage()); |
|
271 | 271 | } |
272 | 272 | |
273 | 273 | $out[$key] = $row; |
@@ -319,20 +319,20 @@ discard block |
||
319 | 319 | * nor a static. |
320 | 320 | * @return static $this |
321 | 321 | */ |
322 | - public function append($new_rows, callable $conflict_resolver=null) |
|
322 | + public function append($new_rows, callable $conflict_resolver = null) |
|
323 | 323 | { |
324 | 324 | if ($new_rows instanceof static) |
325 | 325 | $new_rows = $new_rows->getArray(); |
326 | 326 | |
327 | - if (!is_array($new_rows)) { |
|
327 | + if ( ! is_array($new_rows)) { |
|
328 | 328 | $this->throwUsageException( |
329 | - "\$new_rows parameter must be an array or an instance of " . __CLASS__ |
|
329 | + "\$new_rows parameter must be an array or an instance of ".__CLASS__ |
|
330 | 330 | ); |
331 | 331 | } |
332 | 332 | |
333 | - if (!$conflict_resolver) { |
|
333 | + if ( ! $conflict_resolver) { |
|
334 | 334 | // default conflict resolver: append with numeric key |
335 | - $conflict_resolver = function (&$data, $existing_row, $confliuct_row, $key) { |
|
335 | + $conflict_resolver = function(&$data, $existing_row, $confliuct_row, $key) { |
|
336 | 336 | $data[] = $confliuct_row; |
337 | 337 | }; |
338 | 338 | } |
@@ -364,7 +364,7 @@ discard block |
||
364 | 364 | * |
365 | 365 | * @return static |
366 | 366 | */ |
367 | - public function dimensionsAsColumns(array $columnNames, array $options=null) |
|
367 | + public function dimensionsAsColumns(array $columnNames, array $options = null) |
|
368 | 368 | { |
369 | 369 | $out = $this->dimensionsAsColumns_recurser($this->data, $columnNames); |
370 | 370 | return $this->returnConstant($out); |
@@ -401,12 +401,12 @@ discard block |
||
401 | 401 | * ], |
402 | 402 | * ] |
403 | 403 | */ |
404 | - protected function dimensionsAsColumns_recurser(array $data, $columnNames, $rowIdParts=[]) |
|
404 | + protected function dimensionsAsColumns_recurser(array $data, $columnNames, $rowIdParts = []) |
|
405 | 405 | { |
406 | 406 | $out = []; |
407 | 407 | // if (!$columnNames) |
408 | 408 | // return $data; |
409 | - $no_more_column = !(bool) $columnNames; |
|
409 | + $no_more_column = ! (bool) $columnNames; |
|
410 | 410 | |
411 | 411 | // If all the names have been given to the dimensions |
412 | 412 | // we compile the index key of the row at the current level |
@@ -430,7 +430,7 @@ discard block |
||
430 | 430 | self::throwUsageException( |
431 | 431 | "Trying to populate a column '$name' that " |
432 | 432 | ."already exists with a different value " |
433 | - .var_export($data[$name], true). " => '$value'" |
|
433 | + .var_export($data[$name], true)." => '$value'" |
|
434 | 434 | ); |
435 | 435 | } |
436 | 436 | $data[$name] = $value; |
@@ -461,7 +461,7 @@ discard block |
||
461 | 461 | } |
462 | 462 | else { |
463 | 463 | |
464 | - if (!isset($rows)) { |
|
464 | + if ( ! isset($rows)) { |
|
465 | 465 | echo json_encode([ |
466 | 466 | '$rowIdParts' => $rowIdParts, |
467 | 467 | '$row' => $row, |
@@ -522,12 +522,12 @@ discard block |
||
522 | 522 | |
523 | 523 | if (is_string($value) && array_key_exists($value, $row)) { |
524 | 524 | $part_name .= $value; |
525 | - $group_value = $row[ $value ]; |
|
525 | + $group_value = $row[$value]; |
|
526 | 526 | } |
527 | 527 | elseif (is_callable($value)) { |
528 | 528 | |
529 | 529 | if (is_string($value)) { |
530 | - $part_name .= $value; |
|
530 | + $part_name .= $value; |
|
531 | 531 | } |
532 | 532 | // elseif (is_function($value)) { |
533 | 533 | elseif (is_object($value) && ($value instanceof \Closure)) { |
@@ -543,19 +543,19 @@ discard block |
||
543 | 543 | ]); |
544 | 544 | } |
545 | 545 | elseif (is_int($value)) { |
546 | - $part_name .= $value ? : '0'; |
|
547 | - $group_value = $row[ $value ]; |
|
546 | + $part_name .= $value ?: '0'; |
|
547 | + $group_value = $row[$value]; |
|
548 | 548 | } |
549 | 549 | else { |
550 | 550 | self::throwUsageException( |
551 | 551 | 'Bad value provided for groupBy id generation: ' |
552 | 552 | .var_export($value, true) |
553 | - ."\n" . var_export($row, true) |
|
553 | + ."\n".var_export($row, true) |
|
554 | 554 | ); |
555 | 555 | } |
556 | 556 | |
557 | - if (!is_null($part_name)) |
|
558 | - $group_parts[ $part_name ] = $group_value; |
|
557 | + if ( ! is_null($part_name)) |
|
558 | + $group_parts[$part_name] = $group_value; |
|
559 | 559 | } |
560 | 560 | |
561 | 561 | // sort the groups by names (without it the same group could have multiple ids) |
@@ -573,9 +573,9 @@ discard block |
||
573 | 573 | /** |
574 | 574 | * Returns the first element of the array |
575 | 575 | */ |
576 | - public function first($strict=false) |
|
576 | + public function first($strict = false) |
|
577 | 577 | { |
578 | - if (!$this->count()) { |
|
578 | + if ( ! $this->count()) { |
|
579 | 579 | if ($strict) |
580 | 580 | throw new \ErrorException("No first element found in this array"); |
581 | 581 | else |
@@ -595,9 +595,9 @@ discard block |
||
595 | 595 | * |
596 | 596 | * @todo Preserve the offset |
597 | 597 | */ |
598 | - public function last($strict=false) |
|
598 | + public function last($strict = false) |
|
599 | 599 | { |
600 | - if (!$this->count()) { |
|
600 | + if ( ! $this->count()) { |
|
601 | 601 | if ($strict) |
602 | 602 | throw new \ErrorException("No last element found in this array"); |
603 | 603 | else |
@@ -615,9 +615,9 @@ discard block |
||
615 | 615 | /** |
616 | 616 | * |
617 | 617 | */ |
618 | - public function firstKey($strict=false) |
|
618 | + public function firstKey($strict = false) |
|
619 | 619 | { |
620 | - if (!$this->count()) { |
|
620 | + if ( ! $this->count()) { |
|
621 | 621 | if ($strict) |
622 | 622 | throw new \ErrorException("No last element found in this array"); |
623 | 623 | else |
@@ -636,16 +636,16 @@ discard block |
||
636 | 636 | /** |
637 | 637 | * |
638 | 638 | */ |
639 | - public function lastKey($strict=false) |
|
639 | + public function lastKey($strict = false) |
|
640 | 640 | { |
641 | - if (!$this->count()) { |
|
641 | + if ( ! $this->count()) { |
|
642 | 642 | if ($strict) |
643 | 643 | throw new \ErrorException("No last element found in this array"); |
644 | 644 | else |
645 | 645 | $lastKey = null; |
646 | 646 | } |
647 | 647 | else { |
648 | - $key = key($this->data); |
|
648 | + $key = key($this->data); |
|
649 | 649 | end($this->data); |
650 | 650 | $lastKey = key($this->data); |
651 | 651 | $this->move($key); |
@@ -657,7 +657,7 @@ discard block |
||
657 | 657 | /** |
658 | 658 | * Move the internal pointer of the array to the key given as parameter |
659 | 659 | */ |
660 | - public function move($key, $strict=true) |
|
660 | + public function move($key, $strict = true) |
|
661 | 661 | { |
662 | 662 | if (array_key_exists($key, $this->data)) { |
663 | 663 | foreach ($this->data as $i => &$value) { |
@@ -724,13 +724,13 @@ discard block |
||
724 | 724 | * @see http://php.net/manual/fr/function.var-dump.php |
725 | 725 | * @todo Handle xdebug dump formatting |
726 | 726 | */ |
727 | - public function dump($exit=false) |
|
727 | + public function dump($exit = false) |
|
728 | 728 | { |
729 | 729 | $bt = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2); |
730 | 730 | $caller = $bt[0]; |
731 | 731 | |
732 | 732 | var_export([ |
733 | - 'location' => $caller['file'] . ':' . $caller['line'], |
|
733 | + 'location' => $caller['file'].':'.$caller['line'], |
|
734 | 734 | 'data' => $this->data, |
735 | 735 | ]); |
736 | 736 | |
@@ -747,7 +747,7 @@ discard block |
||
747 | 747 | * @todo move it to an Arrays class storing static methods |
748 | 748 | */ |
749 | 749 | public static function replaceEntries( |
750 | - array $array, callable $replacer, $max_depth=null |
|
750 | + array $array, callable $replacer, $max_depth = null |
|
751 | 751 | ) { |
752 | 752 | foreach ($array as $key => &$row) { |
753 | 753 | $arguments = [&$row, $key]; |
@@ -755,7 +755,7 @@ discard block |
||
755 | 755 | |
756 | 756 | if (is_array($row) && $max_depth !== 0) { // allowing null to have no depth limit |
757 | 757 | $row = self::replaceEntries( |
758 | - $row, $replacer, $max_depth ? $max_depth-1 : $max_depth |
|
758 | + $row, $replacer, $max_depth ? $max_depth - 1 : $max_depth |
|
759 | 759 | ); |
760 | 760 | } |
761 | 761 | } |
@@ -771,7 +771,7 @@ discard block |
||
771 | 771 | * |
772 | 772 | * @return static $this or a new static. |
773 | 773 | */ |
774 | - public function extract($callback=null) |
|
774 | + public function extract($callback = null) |
|
775 | 775 | { |
776 | 776 | if ($callback) { |
777 | 777 | |
@@ -779,7 +779,7 @@ discard block |
||
779 | 779 | $callback = new \JClaveau\LogicalFilter\LogicalFilter($callback); |
780 | 780 | } |
781 | 781 | |
782 | - if (!is_callable($callback)) { |
|
782 | + if ( ! is_callable($callback)) { |
|
783 | 783 | $this->throwUsageException( |
784 | 784 | "\$callback must be a logical filter description array or a callable" |
785 | 785 | ." instead of " |
@@ -791,7 +791,7 @@ discard block |
||
791 | 791 | foreach ($this->data as $key => $value) { |
792 | 792 | if ($callback($value, $key)) { |
793 | 793 | $out[$key] = $value; |
794 | - unset( $this->data[$key] ); |
|
794 | + unset($this->data[$key]); |
|
795 | 795 | } |
796 | 796 | } |
797 | 797 | } |
@@ -26,18 +26,19 @@ discard block |
||
26 | 26 | $out = []; |
27 | 27 | foreach ($this->data as $key => $row) { |
28 | 28 | |
29 | - if (!$row) |
|
30 | - continue; |
|
29 | + if (!$row) { |
|
30 | + continue; |
|
31 | + } |
|
31 | 32 | |
32 | 33 | $newIndexes = call_user_func($indexGenerator, $key, $row); |
33 | - if (!is_array($newIndexes)) |
|
34 | - $newIndexes = [$newIndexes]; |
|
34 | + if (!is_array($newIndexes)) { |
|
35 | + $newIndexes = [$newIndexes]; |
|
36 | + } |
|
35 | 37 | |
36 | 38 | foreach ($newIndexes as $newIndex) { |
37 | 39 | if (!isset($out[$newIndex])) { |
38 | 40 | $out[$newIndex] = $row; |
39 | - } |
|
40 | - else { |
|
41 | + } else { |
|
41 | 42 | if ($conflictResolver === null) { |
42 | 43 | self::throwUsageException( |
43 | 44 | "A 'group by' provoking a conflict" |
@@ -74,20 +75,21 @@ discard block |
||
74 | 75 | $out = []; |
75 | 76 | foreach ($this->data as $key => $row) { |
76 | 77 | |
77 | - if (!$row) |
|
78 | - continue; |
|
78 | + if (!$row) { |
|
79 | + continue; |
|
80 | + } |
|
79 | 81 | |
80 | 82 | $new_keys = call_user_func($indexGenerator, $row, $key); |
81 | - if (!is_array($new_keys)) |
|
82 | - $new_keys = [$new_keys]; |
|
83 | + if (!is_array($new_keys)) { |
|
84 | + $new_keys = [$new_keys]; |
|
85 | + } |
|
83 | 86 | |
84 | 87 | foreach ($new_keys as $new_key) { |
85 | 88 | if (!isset($out[ $new_key ])) { |
86 | 89 | $out[ $new_key ] = [ |
87 | 90 | $key => $row |
88 | 91 | ]; |
89 | - } |
|
90 | - else { |
|
92 | + } else { |
|
91 | 93 | $out[ $new_key ][ $key ] = $row; |
92 | 94 | } |
93 | 95 | } |
@@ -125,8 +127,9 @@ discard block |
||
125 | 127 | $out = []; |
126 | 128 | foreach ($this->data as $key => $row) { |
127 | 129 | |
128 | - if (!$row) |
|
129 | - continue; |
|
130 | + if (!$row) { |
|
131 | + continue; |
|
132 | + } |
|
130 | 133 | |
131 | 134 | $newIndex = call_user_func($indexGenerator, $key, $row); |
132 | 135 | |
@@ -136,8 +139,7 @@ discard block |
||
136 | 139 | |
137 | 140 | if (!isset($out[$newIndex])) { |
138 | 141 | $out[$newIndex] = $transformedRow; |
139 | - } |
|
140 | - else { |
|
142 | + } else { |
|
141 | 143 | $out[$newIndex] = call_user_func( |
142 | 144 | $conflictResolver, |
143 | 145 | $newIndex, |
@@ -161,8 +163,9 @@ discard block |
||
161 | 163 | */ |
162 | 164 | public function mergeWith( $otherTable, callable $conflictResolver=null ) |
163 | 165 | { |
164 | - if (is_array($otherTable)) |
|
165 | - $otherTable = new static($otherTable); |
|
166 | + if (is_array($otherTable)) { |
|
167 | + $otherTable = new static($otherTable); |
|
168 | + } |
|
166 | 169 | |
167 | 170 | if (!$otherTable instanceof static) { |
168 | 171 | self::throwUsageException( |
@@ -176,10 +179,10 @@ discard block |
||
176 | 179 | |
177 | 180 | if (!isset($out[$key])) { |
178 | 181 | $out[$key] = $row; |
179 | - } |
|
180 | - else { |
|
181 | - if ($conflictResolver === null) |
|
182 | - self::throwUsageException('No conflict resolver for a merge provoking one'); |
|
182 | + } else { |
|
183 | + if ($conflictResolver === null) { |
|
184 | + self::throwUsageException('No conflict resolver for a merge provoking one'); |
|
185 | + } |
|
183 | 186 | |
184 | 187 | $arguments = [ |
185 | 188 | &$key, |
@@ -265,8 +268,7 @@ discard block |
||
265 | 268 | $row[$new_name] = $row[$old_name]; |
266 | 269 | unset($row[$old_name]); |
267 | 270 | } |
268 | - } |
|
269 | - catch (\Exception $e) { |
|
271 | + } catch (\Exception $e) { |
|
270 | 272 | self::throwUsageException( $e->getMessage() ); |
271 | 273 | } |
272 | 274 | |
@@ -287,17 +289,19 @@ discard block |
||
287 | 289 | public function limit() |
288 | 290 | { |
289 | 291 | $arguments = func_get_args(); |
290 | - if (count($arguments) == 1 && is_numeric($arguments[0])) |
|
291 | - $max = $arguments[0]; |
|
292 | - else |
|
293 | - self::throwUsageException("Bad arguments type and count for limit()"); |
|
292 | + if (count($arguments) == 1 && is_numeric($arguments[0])) { |
|
293 | + $max = $arguments[0]; |
|
294 | + } else { |
|
295 | + self::throwUsageException("Bad arguments type and count for limit()"); |
|
296 | + } |
|
294 | 297 | |
295 | 298 | $out = []; |
296 | 299 | $count = 0; |
297 | 300 | foreach ($this->data as $key => $row) { |
298 | 301 | |
299 | - if ($max <= $count) |
|
300 | - break; |
|
302 | + if ($max <= $count) { |
|
303 | + break; |
|
304 | + } |
|
301 | 305 | |
302 | 306 | $out[$key] = $row; |
303 | 307 | |
@@ -321,8 +325,9 @@ discard block |
||
321 | 325 | */ |
322 | 326 | public function append($new_rows, callable $conflict_resolver=null) |
323 | 327 | { |
324 | - if ($new_rows instanceof static) |
|
325 | - $new_rows = $new_rows->getArray(); |
|
328 | + if ($new_rows instanceof static) { |
|
329 | + $new_rows = $new_rows->getArray(); |
|
330 | + } |
|
326 | 331 | |
327 | 332 | if (!is_array($new_rows)) { |
328 | 333 | $this->throwUsageException( |
@@ -347,8 +352,7 @@ discard block |
||
347 | 352 | ]; |
348 | 353 | |
349 | 354 | call_user_func_array($conflict_resolver, $arguments); |
350 | - } |
|
351 | - else { |
|
355 | + } else { |
|
352 | 356 | $this->data[$key] = $new_row; |
353 | 357 | } |
354 | 358 | } |
@@ -458,8 +462,7 @@ discard block |
||
458 | 462 | foreach ($rows as $row_id => $joined_row) { |
459 | 463 | $out[$row_id] = $joined_row; |
460 | 464 | } |
461 | - } |
|
462 | - else { |
|
465 | + } else { |
|
463 | 466 | |
464 | 467 | if (!isset($rows)) { |
465 | 468 | echo json_encode([ |
@@ -469,8 +472,9 @@ discard block |
||
469 | 472 | exit; |
470 | 473 | } |
471 | 474 | |
472 | - foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue) |
|
473 | - $row[$rowIdPartName] = $rowIdPartValue; |
|
475 | + foreach ($rowIdParts as $rowIdPartName => $rowIdPartValue) { |
|
476 | + $row[$rowIdPartName] = $rowIdPartValue; |
|
477 | + } |
|
474 | 478 | |
475 | 479 | $indexParts = []; |
476 | 480 | foreach ($rowIdParts as $name => $value) { |
@@ -523,8 +527,7 @@ discard block |
||
523 | 527 | if (is_string($value) && array_key_exists($value, $row)) { |
524 | 528 | $part_name .= $value; |
525 | 529 | $group_value = $row[ $value ]; |
526 | - } |
|
527 | - elseif (is_callable($value)) { |
|
530 | + } elseif (is_callable($value)) { |
|
528 | 531 | |
529 | 532 | if (is_string($value)) { |
530 | 533 | $part_name .= $value; |
@@ -533,20 +536,17 @@ discard block |
||
533 | 536 | elseif (is_object($value) && ($value instanceof \Closure)) { |
534 | 537 | $part_name .= 'unnamed-closure-' |
535 | 538 | . hash('crc32b', var_export($value, true)); |
536 | - } |
|
537 | - elseif (is_array($value)) { |
|
539 | + } elseif (is_array($value)) { |
|
538 | 540 | $part_name .= implode('::', $value); |
539 | 541 | } |
540 | 542 | |
541 | 543 | $group_value = call_user_func_array($value, [ |
542 | 544 | $row, &$part_name |
543 | 545 | ]); |
544 | - } |
|
545 | - elseif (is_int($value)) { |
|
546 | + } elseif (is_int($value)) { |
|
546 | 547 | $part_name .= $value ? : '0'; |
547 | 548 | $group_value = $row[ $value ]; |
548 | - } |
|
549 | - else { |
|
549 | + } else { |
|
550 | 550 | self::throwUsageException( |
551 | 551 | 'Bad value provided for groupBy id generation: ' |
552 | 552 | .var_export($value, true) |
@@ -554,8 +554,9 @@ discard block |
||
554 | 554 | ); |
555 | 555 | } |
556 | 556 | |
557 | - if (!is_null($part_name)) |
|
558 | - $group_parts[ $part_name ] = $group_value; |
|
557 | + if (!is_null($part_name)) { |
|
558 | + $group_parts[ $part_name ] = $group_value; |
|
559 | + } |
|
559 | 560 | } |
560 | 561 | |
561 | 562 | // sort the groups by names (without it the same group could have multiple ids) |
@@ -576,12 +577,12 @@ discard block |
||
576 | 577 | public function first($strict=false) |
577 | 578 | { |
578 | 579 | if (!$this->count()) { |
579 | - if ($strict) |
|
580 | - throw new \ErrorException("No first element found in this array"); |
|
581 | - else |
|
582 | - $first = null; |
|
583 | - } |
|
584 | - else { |
|
580 | + if ($strict) { |
|
581 | + throw new \ErrorException("No first element found in this array"); |
|
582 | + } else { |
|
583 | + $first = null; |
|
584 | + } |
|
585 | + } else { |
|
585 | 586 | $key = key($this->data); |
586 | 587 | $first = reset($this->data); |
587 | 588 | $this->move($key); |
@@ -598,12 +599,12 @@ discard block |
||
598 | 599 | public function last($strict=false) |
599 | 600 | { |
600 | 601 | if (!$this->count()) { |
601 | - if ($strict) |
|
602 | - throw new \ErrorException("No last element found in this array"); |
|
603 | - else |
|
604 | - $last = null; |
|
605 | - } |
|
606 | - else { |
|
602 | + if ($strict) { |
|
603 | + throw new \ErrorException("No last element found in this array"); |
|
604 | + } else { |
|
605 | + $last = null; |
|
606 | + } |
|
607 | + } else { |
|
607 | 608 | $key = key($this->data); |
608 | 609 | $last = end($this->data); |
609 | 610 | $this->move($key); |
@@ -618,12 +619,12 @@ discard block |
||
618 | 619 | public function firstKey($strict=false) |
619 | 620 | { |
620 | 621 | if (!$this->count()) { |
621 | - if ($strict) |
|
622 | - throw new \ErrorException("No last element found in this array"); |
|
623 | - else |
|
624 | - $firstKey = null; |
|
625 | - } |
|
626 | - else { |
|
622 | + if ($strict) { |
|
623 | + throw new \ErrorException("No last element found in this array"); |
|
624 | + } else { |
|
625 | + $firstKey = null; |
|
626 | + } |
|
627 | + } else { |
|
627 | 628 | $key = key($this->data); |
628 | 629 | reset($this->data); |
629 | 630 | $firstKey = key($this->data); |
@@ -639,12 +640,12 @@ discard block |
||
639 | 640 | public function lastKey($strict=false) |
640 | 641 | { |
641 | 642 | if (!$this->count()) { |
642 | - if ($strict) |
|
643 | - throw new \ErrorException("No last element found in this array"); |
|
644 | - else |
|
645 | - $lastKey = null; |
|
646 | - } |
|
647 | - else { |
|
643 | + if ($strict) { |
|
644 | + throw new \ErrorException("No last element found in this array"); |
|
645 | + } else { |
|
646 | + $lastKey = null; |
|
647 | + } |
|
648 | + } else { |
|
648 | 649 | $key = key($this->data); |
649 | 650 | end($this->data); |
650 | 651 | $lastKey = key($this->data); |
@@ -666,8 +667,7 @@ discard block |
||
666 | 667 | break; |
667 | 668 | } |
668 | 669 | } |
669 | - } |
|
670 | - elseif ($strict) { |
|
670 | + } elseif ($strict) { |
|
671 | 671 | throw new \ErrorException("Unable to move the internal pointer to a key that doesn't exist."); |
672 | 672 | } |
673 | 673 | |
@@ -734,8 +734,9 @@ discard block |
||
734 | 734 | 'data' => $this->data, |
735 | 735 | ]); |
736 | 736 | |
737 | - if ($exit) |
|
738 | - exit; |
|
737 | + if ($exit) { |
|
738 | + exit; |
|
739 | + } |
|
739 | 740 | |
740 | 741 | return $this; |
741 | 742 | } |
@@ -134,16 +134,16 @@ discard block |
||
134 | 134 | public static function mergeRecursiveCustom( |
135 | 135 | $existing_row, |
136 | 136 | $conflict_row, |
137 | - callable $merge_resolver=null, |
|
138 | - $max_depth=null |
|
139 | - ){ |
|
137 | + callable $merge_resolver = null, |
|
138 | + $max_depth = null |
|
139 | + ) { |
|
140 | 140 | static::mustBeCountable($existing_row); |
141 | 141 | static::mustBeCountable($conflict_row); |
142 | 142 | |
143 | 143 | foreach ($conflict_row as $column => $conflict_value) { |
144 | 144 | |
145 | 145 | // not existing in first array |
146 | - if (!isset($existing_row[$column])) { |
|
146 | + if ( ! isset($existing_row[$column])) { |
|
147 | 147 | $existing_row[$column] = $conflict_value; |
148 | 148 | continue; |
149 | 149 | } |
@@ -176,7 +176,7 @@ discard block |
||
176 | 176 | } |
177 | 177 | else { |
178 | 178 | // same resolution as array_merge_recursive |
179 | - if (!is_array($existing_value)) { |
|
179 | + if ( ! is_array($existing_value)) { |
|
180 | 180 | $existing_row[$column] = [$existing_value]; |
181 | 181 | } |
182 | 182 | |
@@ -199,14 +199,14 @@ discard block |
||
199 | 199 | public static function mergePreservingDistincts( |
200 | 200 | $existing_row, |
201 | 201 | $conflict_row |
202 | - ){ |
|
202 | + ) { |
|
203 | 203 | static::mustBeCountable($existing_row); |
204 | 204 | static::mustBeCountable($conflict_row); |
205 | 205 | |
206 | 206 | $merge = static::mergeRecursiveCustom( |
207 | 207 | $existing_row, |
208 | 208 | $conflict_row, |
209 | - function ($existing_value, $conflict_value, $column) { |
|
209 | + function($existing_value, $conflict_value, $column) { |
|
210 | 210 | |
211 | 211 | if ( ! $existing_value instanceof MergeBucket) { |
212 | 212 | $existing_value = MergeBucket::from()->push($existing_value); |
@@ -235,7 +235,7 @@ discard block |
||
235 | 235 | * @param array|Countable $row |
236 | 236 | * @param array $options : 'excluded_columns' |
237 | 237 | */ |
238 | - public static function cleanMergeDuplicates($row, array $options=[]) |
|
238 | + public static function cleanMergeDuplicates($row, array $options = []) |
|
239 | 239 | { |
240 | 240 | static::mustBeCountable($row); |
241 | 241 | |
@@ -268,7 +268,7 @@ discard block |
||
268 | 268 | * @see mergePreservingDistincts() |
269 | 269 | * @see cleanMergeDuplicates() |
270 | 270 | */ |
271 | - public static function cleanMergeBuckets($row, array $options=[]) |
|
271 | + public static function cleanMergeBuckets($row, array $options = []) |
|
272 | 272 | { |
273 | 273 | static::mustBeCountable($row); |
274 | 274 | |
@@ -309,13 +309,13 @@ discard block |
||
309 | 309 | $id = serialize($value); |
310 | 310 | } |
311 | 311 | |
312 | - if (isset($ids[ $id ])) { |
|
313 | - unset($array[ $key ]); |
|
314 | - $ids[ $id ][] = $key; |
|
312 | + if (isset($ids[$id])) { |
|
313 | + unset($array[$key]); |
|
314 | + $ids[$id][] = $key; |
|
315 | 315 | continue; |
316 | 316 | } |
317 | 317 | |
318 | - $ids[ $id ] = [$key]; |
|
318 | + $ids[$id] = [$key]; |
|
319 | 319 | } |
320 | 320 | |
321 | 321 | return $array; |
@@ -335,7 +335,7 @@ discard block |
||
335 | 335 | } |
336 | 336 | else { |
337 | 337 | throw new \InvalidArgumentException( |
338 | - "keyExists() method missing on :\n". var_export($array, true) |
|
338 | + "keyExists() method missing on :\n".var_export($array, true) |
|
339 | 339 | ); |
340 | 340 | } |
341 | 341 | |
@@ -411,16 +411,16 @@ discard block |
||
411 | 411 | throw new \InvalidArgumentException( |
412 | 412 | "Different number of " |
413 | 413 | ." values and weights for weight mean calculation: \n" |
414 | - .var_export($values, true)."\n\n" |
|
414 | + .var_export($values, true)."\n\n" |
|
415 | 415 | .var_export($weights, true) |
416 | 416 | ); |
417 | 417 | } |
418 | 418 | |
419 | - if (!$values) |
|
419 | + if ( ! $values) |
|
420 | 420 | return null; |
421 | 421 | |
422 | - $weights_sum = array_sum($weights); |
|
423 | - if (!$weights_sum) |
|
422 | + $weights_sum = array_sum($weights); |
|
423 | + if ( ! $weights_sum) |
|
424 | 424 | return 0; |
425 | 425 | |
426 | 426 | $weighted_sum = 0; |
@@ -455,15 +455,15 @@ discard block |
||
455 | 455 | */ |
456 | 456 | public static function mustBeCountable($value) |
457 | 457 | { |
458 | - if ( ! static::isCountable($value) ) { |
|
458 | + if ( ! static::isCountable($value)) { |
|
459 | 459 | $exception = new \InvalidArgumentException( |
460 | 460 | "A value must be Countable instead of: \n" |
461 | 461 | .var_export($value, true) |
462 | 462 | ); |
463 | 463 | |
464 | 464 | // The true location of the throw is still available through the backtrace |
465 | - $trace_location = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0]; |
|
466 | - $reflectionClass = new \ReflectionClass( get_class($exception) ); |
|
465 | + $trace_location = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0]; |
|
466 | + $reflectionClass = new \ReflectionClass(get_class($exception)); |
|
467 | 467 | |
468 | 468 | // file |
469 | 469 | if (isset($trace_location['file'])) { |
@@ -487,15 +487,15 @@ discard block |
||
487 | 487 | */ |
488 | 488 | public static function mustBeTraversable($value) |
489 | 489 | { |
490 | - if ( ! static::isTraversable($value) ) { |
|
490 | + if ( ! static::isTraversable($value)) { |
|
491 | 491 | $exception = new \InvalidArgumentException( |
492 | 492 | "A value must be Traversable instead of: \n" |
493 | 493 | .var_export($value, true) |
494 | 494 | ); |
495 | 495 | |
496 | 496 | // The true location of the throw is still available through the backtrace |
497 | - $trace_location = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0]; |
|
498 | - $reflectionClass = new \ReflectionClass( get_class($exception) ); |
|
497 | + $trace_location = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0]; |
|
498 | + $reflectionClass = new \ReflectionClass(get_class($exception)); |
|
499 | 499 | |
500 | 500 | // file |
501 | 501 | if (isset($trace_location['file'])) { |
@@ -64,14 +64,12 @@ discard block |
||
64 | 64 | ) |
65 | 65 | { |
66 | 66 | $array1[$key] = self::merge($array1[$key], $value); |
67 | - } |
|
68 | - else |
|
67 | + } else |
|
69 | 68 | { |
70 | 69 | $array1[$key] = $value; |
71 | 70 | } |
72 | 71 | } |
73 | - } |
|
74 | - else |
|
72 | + } else |
|
75 | 73 | { |
76 | 74 | foreach ($array2 as $value) |
77 | 75 | { |
@@ -96,14 +94,12 @@ discard block |
||
96 | 94 | ) |
97 | 95 | { |
98 | 96 | $array1[$key] = self::merge($array1[$key], $value); |
99 | - } |
|
100 | - else |
|
97 | + } else |
|
101 | 98 | { |
102 | 99 | $array1[$key] = $value; |
103 | 100 | } |
104 | 101 | } |
105 | - } |
|
106 | - else |
|
102 | + } else |
|
107 | 103 | { |
108 | 104 | foreach ($array2 as $value) |
109 | 105 | { |
@@ -173,8 +169,7 @@ discard block |
||
173 | 169 | $column, |
174 | 170 | ] |
175 | 171 | ); |
176 | - } |
|
177 | - else { |
|
172 | + } else { |
|
178 | 173 | // same resolution as array_merge_recursive |
179 | 174 | if (!is_array($existing_value)) { |
180 | 175 | $existing_row[$column] = [$existing_value]; |
@@ -245,15 +240,18 @@ discard block |
||
245 | 240 | ; |
246 | 241 | |
247 | 242 | foreach ($row as $column => &$values) { |
248 | - if ( ! $values instanceof MergeBucket) |
|
249 | - continue; |
|
243 | + if ( ! $values instanceof MergeBucket) { |
|
244 | + continue; |
|
245 | + } |
|
250 | 246 | |
251 | - if (in_array($column, $excluded_columns)) |
|
252 | - continue; |
|
247 | + if (in_array($column, $excluded_columns)) { |
|
248 | + continue; |
|
249 | + } |
|
253 | 250 | |
254 | 251 | $values = Arrays::unique($values); |
255 | - if (count($values) == 1) |
|
256 | - $values = $values[0]; |
|
252 | + if (count($values) == 1) { |
|
253 | + $values = $values[0]; |
|
254 | + } |
|
257 | 255 | } |
258 | 256 | |
259 | 257 | return $row; |
@@ -278,11 +276,13 @@ discard block |
||
278 | 276 | ; |
279 | 277 | |
280 | 278 | foreach ($row as $column => &$values) { |
281 | - if (in_array($column, $excluded_columns)) |
|
282 | - continue; |
|
279 | + if (in_array($column, $excluded_columns)) { |
|
280 | + continue; |
|
281 | + } |
|
283 | 282 | |
284 | - if ($values instanceof MergeBucket) |
|
285 | - $values = $values->toArray(); |
|
283 | + if ($values instanceof MergeBucket) { |
|
284 | + $values = $values->toArray(); |
|
285 | + } |
|
286 | 286 | } |
287 | 287 | |
288 | 288 | return $row; |
@@ -304,8 +304,7 @@ discard block |
||
304 | 304 | foreach ($array as $key => $value) { |
305 | 305 | if (is_scalar($value)) { |
306 | 306 | $id = $value; |
307 | - } |
|
308 | - else { |
|
307 | + } else { |
|
309 | 308 | $id = serialize($value); |
310 | 309 | } |
311 | 310 | |
@@ -329,11 +328,9 @@ discard block |
||
329 | 328 | |
330 | 329 | if (is_array($array)) { |
331 | 330 | return array_key_exists($key, $array); |
332 | - } |
|
333 | - elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) { |
|
331 | + } elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) { |
|
334 | 332 | return $array->keyExists($key); |
335 | - } |
|
336 | - else { |
|
333 | + } else { |
|
337 | 334 | throw new \InvalidArgumentException( |
338 | 335 | "keyExists() method missing on :\n". var_export($array, true) |
339 | 336 | ); |
@@ -359,16 +356,13 @@ discard block |
||
359 | 356 | foreach ($array as $key => &$value) { // &for optimization |
360 | 357 | if (is_scalar($value)) { |
361 | 358 | $sum += $value; |
362 | - } |
|
363 | - elseif (is_null($value)) { |
|
359 | + } elseif (is_null($value)) { |
|
364 | 360 | continue; |
365 | - } |
|
366 | - elseif (is_array($value)) { |
|
361 | + } elseif (is_array($value)) { |
|
367 | 362 | throw new \InvalidArgumentException( |
368 | 363 | "Trying to sum an array with '$sum': ".var_export($value, true) |
369 | 364 | ); |
370 | - } |
|
371 | - elseif (is_object($value)) { |
|
365 | + } elseif (is_object($value)) { |
|
372 | 366 | if ( ! method_exists($value, 'toNumber')) { |
373 | 367 | throw new \InvalidArgumentEXception( |
374 | 368 | "Trying to sum a ".get_class($value)." object which cannot be casted as a number. " |
@@ -395,17 +389,21 @@ discard block |
||
395 | 389 | */ |
396 | 390 | public static function weightedMean($values, $weights) |
397 | 391 | { |
398 | - if ($values instanceof ChainableArray) |
|
399 | - $values = $values->toArray(); |
|
392 | + if ($values instanceof ChainableArray) { |
|
393 | + $values = $values->toArray(); |
|
394 | + } |
|
400 | 395 | |
401 | - if ($weights instanceof ChainableArray) |
|
402 | - $weights = $weights->toArray(); |
|
396 | + if ($weights instanceof ChainableArray) { |
|
397 | + $weights = $weights->toArray(); |
|
398 | + } |
|
403 | 399 | |
404 | - if ( ! is_array($values)) |
|
405 | - $values = [$values]; |
|
400 | + if ( ! is_array($values)) { |
|
401 | + $values = [$values]; |
|
402 | + } |
|
406 | 403 | |
407 | - if ( ! is_array($weights)) |
|
408 | - $weights = [$weights]; |
|
404 | + if ( ! is_array($weights)) { |
|
405 | + $weights = [$weights]; |
|
406 | + } |
|
409 | 407 | |
410 | 408 | if (count($values) != count($weights)) { |
411 | 409 | throw new \InvalidArgumentException( |
@@ -416,12 +414,14 @@ discard block |
||
416 | 414 | ); |
417 | 415 | } |
418 | 416 | |
419 | - if (!$values) |
|
420 | - return null; |
|
417 | + if (!$values) { |
|
418 | + return null; |
|
419 | + } |
|
421 | 420 | |
422 | 421 | $weights_sum = array_sum($weights); |
423 | - if (!$weights_sum) |
|
424 | - return 0; |
|
422 | + if (!$weights_sum) { |
|
423 | + return 0; |
|
424 | + } |
|
425 | 425 | |
426 | 426 | $weighted_sum = 0; |
427 | 427 | foreach ($values as $i => $value) { |
@@ -34,7 +34,7 @@ |
||
34 | 34 | foreach ($column_names as $column_name) { |
35 | 35 | if (!array_key_exists($column_name, $row)) { |
36 | 36 | self::throwUsageException( |
37 | - "Trying to extract a column from a row which" |
|
37 | + "Trying to extract a column from a row which" |
|
38 | 38 | ." doesn't contain it : '$column_name' \n" |
39 | 39 | .var_export($row, true) |
40 | 40 | ); |