jclaveau / php-chainable-array

src/Arrays/Arrays.php

Spacing +47 added lines, -47 removed lines

@@ -135,16 +135,16 @@ 
     public static function mergeRecursiveCustom(
         $existing_row,
         $conflict_row,
-        callable $merge_resolver=null,
-        $max_depth=null
-    ){
+        callable $merge_resolver = null,
+        $max_depth = null
+    ) {
         static::mustBeCountable($existing_row);
         static::mustBeCountable($conflict_row);
 
         foreach ($conflict_row as $column => $conflict_value) {
 
             // not existing in first array
-            if (!isset($existing_row[$column])) {
+            if ( ! isset($existing_row[$column])) {
                 $existing_row[$column] = $conflict_value;
                 continue;
             }
@@ -177,7 +177,7 @@ 
             }
             else {
                 // same resolution as array_merge_recursive
-                if (!is_array($existing_value)) {
+                if ( ! is_array($existing_value)) {
                     $existing_row[$column] = [$existing_value];
                 }
 
@@ -202,7 +202,7 @@ 
     public static function mergePreservingDistincts(
         $existing_row,
         $conflict_row
-    ){
+    ) {
         return self::mergeInColumnBuckets($existing_row, $conflict_row);
     }
 
@@ -219,8 +219,8 @@ 
     public static function mergeInColumnBuckets(
         $existing_row,
         $conflict_row,
-        $existing_key=null,
-        $conflict_key=null
+        $existing_key = null,
+        $conflict_key = null
     ) {
         static::mustBeCountable($existing_row);
         static::mustBeCountable($conflict_row);
@@ -228,16 +228,16 @@ 
         $merged_row = [];
         foreach ($existing_row as $existing_column => $existing_value) {
             if ($existing_value instanceof MergeBucket) {
-                $merged_row[ $existing_column ] = $existing_value;
+                $merged_row[$existing_column] = $existing_value;
             }
             else {
                 if (isset($existing_key)) {
-                    $merged_row[ $existing_column ] = MergeBucket::from([
+                    $merged_row[$existing_column] = MergeBucket::from([
                         $existing_key => $existing_value
                     ]);
                 }
                 else {
-                    $merged_row[ $existing_column ] = MergeBucket::from([
+                    $merged_row[$existing_column] = MergeBucket::from([
                         $existing_value
                     ]);
                 }
@@ -245,26 +245,26 @@ 
         }
         
         foreach ($conflict_row as $conflict_column => $conflict_value) {
-            if (! isset($merged_row[ $conflict_column ])) {
-                $merged_row[ $conflict_column ] = new MergeBucket;
+            if ( ! isset($merged_row[$conflict_column])) {
+                $merged_row[$conflict_column] = new MergeBucket;
             }
             
             if ($conflict_value instanceof MergeBucket) {
                 foreach ($conflict_value as $conflict_bucket_value) {
                     if (isset($conflict_key)) {
-                        $merged_row[ $conflict_column ][$conflict_key] = $conflict_bucket_value;
+                        $merged_row[$conflict_column][$conflict_key] = $conflict_bucket_value;
                     }
                     else {
-                        $merged_row[ $conflict_column ][] = $conflict_bucket_value;
+                        $merged_row[$conflict_column][] = $conflict_bucket_value;
                     }
                 }
             }
             else {
                 if (isset($conflict_key)) {
-                    $merged_row[ $conflict_column ][$conflict_key] = $conflict_value;
+                    $merged_row[$conflict_column][$conflict_key] = $conflict_value;
                 }
                 else {
-                    $merged_row[ $conflict_column ][] = $conflict_value;
+                    $merged_row[$conflict_column][] = $conflict_value;
                 }
             }
         }
@@ -278,7 +278,7 @@ 
      * @param  array|Countable   $row
      * @param  array             $options : 'excluded_columns'
      */
-    public static function cleanMergeDuplicates($row, array $options=[])
+    public static function cleanMergeDuplicates($row, array $options = [])
     {
         static::mustBeCountable($row);
 
@@ -311,7 +311,7 @@ 
      * @see mergePreservingDistincts()
      * @see cleanMergeDuplicates()
      */
-    public static function cleanMergeBuckets($row, array $options=[])
+    public static function cleanMergeBuckets($row, array $options = [])
     {
         static::mustBeCountable($row);
 
@@ -354,13 +354,13 @@ 
                 $id = serialize($value);
             }
 
-            if (isset($ids[ $id ])) {
-                unset($array[ $key ]);
-                $ids[ $id ][] = $key;
+            if (isset($ids[$id])) {
+                unset($array[$key]);
+                $ids[$id][] = $key;
                 continue;
             }
 
-            $ids[ $id ] = [$key];
+            $ids[$id] = [$key];
         }
 
         return $array;
@@ -380,7 +380,7 @@ 
         }
         else {
             throw new \InvalidArgumentException(
-                "keyExists() method missing on :\n". var_export($array, true)
+                "keyExists() method missing on :\n".var_export($array, true)
             );
         }
 
@@ -456,16 +456,16 @@ 
             throw new \InvalidArgumentException(
                 "Different number of "
                 ." values and weights for weight mean calculation: \n"
-                .var_export($values,  true)."\n\n"
+                .var_export($values, true)."\n\n"
                 .var_export($weights, true)
             );
         }
 
-        if (!$values)
+        if ( ! $values)
             return null;
 
-        $weights_sum  = array_sum($weights);
-        if (!$weights_sum)
+        $weights_sum = array_sum($weights);
+        if ( ! $weights_sum)
             return 0;
 
         $weighted_sum = 0;
@@ -514,8 +514,8 @@ 
         );
 
         // The true location of the throw is still available through the backtrace
-        $trace_location  = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0];
-        $reflectionClass = new \ReflectionClass( get_class($exception) );
+        $trace_location  = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0];
+        $reflectionClass = new \ReflectionClass(get_class($exception));
 
         // file
         if (isset($trace_location['file'])) {
@@ -552,8 +552,8 @@ 
         );
 
         // The true location of the throw is still available through the backtrace
-        $trace_location  = debug_backtrace( DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0];
-        $reflectionClass = new \ReflectionClass( get_class($exception) );
+        $trace_location  = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1)[0];
+        $reflectionClass = new \ReflectionClass(get_class($exception));
 
         // file
         if (isset($trace_location['file'])) {
@@ -593,7 +593,7 @@ 
      *
      * @return string       The unique identifier of the group
      */
-    public static function generateGroupId($row, array $groups_definitions, array $options=[])
+    public static function generateGroupId($row, array $groups_definitions, array $options = [])
     {
         Arrays::mustBeCountable($row);
 
@@ -602,7 +602,7 @@ 
                              : ':'
                              ;
 
-        $groups_separator    = ! empty($options['groups_separator'])
+        $groups_separator = ! empty($options['groups_separator'])
                              ? $options['groups_separator']
                              : '-'
                              ;
@@ -616,32 +616,32 @@ 
             }
 
             if (is_string($group_definition_value)) {
-                if (    (is_array($row)              && ! array_key_exists($group_definition_value, $row))
+                if ((is_array($row) && ! array_key_exists($group_definition_value, $row))
                     ||  ($row instanceof \ArrayAcces && ! $row->offsetExists($group_definition_value))
                 ) {
                     throw new UsageException(
                         'Unset column for group id generation: '
                         .var_export($group_definition_value, true)
-                        ."\n" . var_export($row, true)
+                        ."\n".var_export($row, true)
                     );
                 }
 
                 $part_name         .= $group_definition_value;
-                $group_result_value = $row[ $group_definition_value ];
+                $group_result_value = $row[$group_definition_value];
             }
             elseif (is_int($group_definition_value)) {
-                if (    (is_array($row)              && ! array_key_exists($group_definition_value, $row))
+                if ((is_array($row) && ! array_key_exists($group_definition_value, $row))
                     ||  ($row instanceof \ArrayAcces && ! $row->offsetExists($group_definition_value))
                 ) {
                     throw new UsageException(
                         'Unset column for group id generation: '
                         .var_export($group_definition_value, true)
-                        ."\n" . var_export($row, true)
+                        ."\n".var_export($row, true)
                     );
                 }
 
-                $part_name         .= $group_definition_value ? : '0';
-                $group_result_value = $row[ $group_definition_value ];
+                $part_name         .= $group_definition_value ?: '0';
+                $group_result_value = $row[$group_definition_value];
             }
             elseif (is_callable($group_definition_value)) {
 
@@ -665,12 +665,12 @@ 
                 throw new UsageException(
                     'Bad value provided for group id generation: '
                     .var_export($group_definition_value, true)
-                    ."\n" . var_export($row, true)
+                    ."\n".var_export($row, true)
                 );
             }
 
-            if (!is_null($part_name))
-                $group_parts[ $part_name ] = $group_result_value;
+            if ( ! is_null($part_name))
+                $group_parts[$part_name] = $group_result_value;
         }
 
         // sort the groups by names (without it the same group could have multiple ids)
@@ -682,13 +682,13 @@ 
             if (is_object($group_value)) {
                 $group_value = get_class($group_value)
                              . '_'
-                             . hash( 'crc32b', var_export($group_value, true) );
+                             . hash('crc32b', var_export($group_value, true));
             }
             elseif (is_array($group_value)) {
-                $group_value = 'array_' . hash( 'crc32b', var_export($group_value, true) );
+                $group_value = 'array_'.hash('crc32b', var_export($group_value, true));
             }
 
-            $out[] = $group_name . $key_value_separator . $group_value;
+            $out[] = $group_name.$key_value_separator.$group_value;
         }
 
         return implode($groups_separator, $out);

Braces +57 added lines, -66 removed lines

@@ -65,14 +65,12 @@ 
                 )
                 {
                     $array1[$key] = self::merge($array1[$key], $value);
-                }
-                else
+                } else
                 {
                     $array1[$key] = $value;
                 }
             }
-        }
-        else
+        } else
         {
             foreach ($array2 as $value)
             {
@@ -97,14 +95,12 @@ 
                         )
                         {
                             $array1[$key] = self::merge($array1[$key], $value);
-                        }
-                        else
+                        } else
                         {
                             $array1[$key] = $value;
                         }
                     }
-                }
-                else
+                } else
                 {
                     foreach ($array2 as $value)
                     {
@@ -174,8 +170,7 @@ 
                         $column,
                     ]
                 );
-            }
-            else {
+            } else {
                 // same resolution as array_merge_recursive
                 if (!is_array($existing_value)) {
                     $existing_row[$column] = [$existing_value];
@@ -229,14 +224,12 @@ 
         foreach ($existing_row as $existing_column => $existing_value) {
             if ($existing_value instanceof MergeBucket) {
                 $merged_row[ $existing_column ] = $existing_value;
-            }
-            else {
+            } else {
                 if (isset($existing_key)) {
                     $merged_row[ $existing_column ] = MergeBucket::from([
                         $existing_key => $existing_value
                     ]);
-                }
-                else {
+                } else {
                     $merged_row[ $existing_column ] = MergeBucket::from([
                         $existing_value
                     ]);
@@ -253,17 +246,14 @@ 
                 foreach ($conflict_value as $conflict_bucket_value) {
                     if (isset($conflict_key)) {
                         $merged_row[ $conflict_column ][$conflict_key] = $conflict_bucket_value;
-                    }
-                    else {
+                    } else {
                         $merged_row[ $conflict_column ][] = $conflict_bucket_value;
                     }
                 }
-            }
-            else {
+            } else {
                 if (isset($conflict_key)) {
                     $merged_row[ $conflict_column ][$conflict_key] = $conflict_value;
-                }
-                else {
+                } else {
                     $merged_row[ $conflict_column ][] = $conflict_value;
                 }
             }
@@ -288,15 +278,18 @@ 
                           ;
 
         foreach ($row as $column => &$values) {
-            if ( ! $values instanceof MergeBucket)
-                continue;
+            if ( ! $values instanceof MergeBucket) {
+                            continue;
+            }
 
-            if (in_array($column, $excluded_columns))
-                continue;
+            if (in_array($column, $excluded_columns)) {
+                            continue;
+            }
 
             $values = Arrays::unique($values);
-            if (count($values) == 1)
-                $values = $values[0];
+            if (count($values) == 1) {
+                            $values = $values[0];
+            }
         }
 
         return $row;
@@ -349,8 +342,7 @@ 
         foreach ($array as $key => $value) {
             if (is_scalar($value)) {
                 $id = $value;
-            }
-            else {
+            } else {
                 $id = serialize($value);
             }
 
@@ -374,11 +366,9 @@ 
 
         if (is_array($array)) {
             return array_key_exists($key, $array);
-        }
-        elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) {
+        } elseif ($array instanceof ChainableArray || method_exists($array, 'keyExists')) {
             return $array->keyExists($key);
-        }
-        else {
+        } else {
             throw new \InvalidArgumentException(
                 "keyExists() method missing on :\n". var_export($array, true)
             );
@@ -404,16 +394,13 @@ 
         foreach ($array as $key => &$value) { // &for optimization
             if (is_scalar($value)) {
                 $sum += $value;
-            }
-            elseif (is_null($value)) {
+            } elseif (is_null($value)) {
                 continue;
-            }
-            elseif (is_array($value)) {
+            } elseif (is_array($value)) {
                 throw new \InvalidArgumentException(
                     "Trying to sum an array with '$sum': ".var_export($value, true)
                 );
-            }
-            elseif (is_object($value)) {
+            } elseif (is_object($value)) {
                 if ( ! method_exists($value, 'toNumber')) {
                     throw new \InvalidArgumentEXception(
                          "Trying to sum a ".get_class($value)." object which cannot be casted as a number. "
@@ -440,17 +427,21 @@ 
      */
     public static function weightedMean($values, $weights)
     {
-        if ($values instanceof ChainableArray)
-            $values = $values->toArray();
+        if ($values instanceof ChainableArray) {
+                    $values = $values->toArray();
+        }
 
-        if ($weights instanceof ChainableArray)
-            $weights = $weights->toArray();
+        if ($weights instanceof ChainableArray) {
+                    $weights = $weights->toArray();
+        }
 
-        if ( ! is_array($values))
-            $values = [$values];
+        if ( ! is_array($values)) {
+                    $values = [$values];
+        }
 
-        if ( ! is_array($weights))
-            $weights = [$weights];
+        if ( ! is_array($weights)) {
+                    $weights = [$weights];
+        }
 
         if (count($values) != count($weights)) {
             throw new \InvalidArgumentException(
@@ -461,12 +452,14 @@ 
             );
         }
 
-        if (!$values)
-            return null;
+        if (!$values) {
+                    return null;
+        }
 
         $weights_sum  = array_sum($weights);
-        if (!$weights_sum)
-            return 0;
+        if (!$weights_sum) {
+                    return 0;
+        }
 
         $weighted_sum = 0;
         foreach ($values as $i => $value) {
@@ -505,8 +498,9 @@ 
      */
     public static function mustBeCountable($value)
     {
-        if (static::isCountable($value))
-            return true;
+        if (static::isCountable($value)) {
+                    return true;
+        }
 
         $exception = new \InvalidArgumentException(
             "A value must be Countable instead of: \n"
@@ -543,8 +537,9 @@ 
      */
     public static function mustBeTraversable($value)
     {
-        if (static::isTraversable($value))
-            return true;
+        if (static::isTraversable($value)) {
+                    return true;
+        }
 
         $exception = new \InvalidArgumentException(
             "A value must be Traversable instead of: \n"
@@ -628,8 +623,7 @@ 
 
                 $part_name         .= $group_definition_value;
                 $group_result_value = $row[ $group_definition_value ];
-            }
-            elseif (is_int($group_definition_value)) {
+            } elseif (is_int($group_definition_value)) {
                 if (    (is_array($row)              && ! array_key_exists($group_definition_value, $row))
                     ||  ($row instanceof \ArrayAcces && ! $row->offsetExists($group_definition_value))
                 ) {
@@ -642,8 +636,7 @@ 
 
                 $part_name         .= $group_definition_value ? : '0';
                 $group_result_value = $row[ $group_definition_value ];
-            }
-            elseif (is_callable($group_definition_value)) {
+            } elseif (is_callable($group_definition_value)) {
 
                 if (is_string($group_definition_value)) {
                     $part_name .= $group_definition_value;
@@ -652,16 +645,14 @@ 
                 elseif (is_object($group_definition_value) && ($group_definition_value instanceof \Closure)) {
                     $part_name .= 'unnamed-closure-'
                                 . hash('crc32b', var_export($group_definition_value, true));
-                }
-                elseif (is_array($group_definition_value)) {
+                } elseif (is_array($group_definition_value)) {
                     $part_name .= implode('::', $group_definition_value);
                 }
 
                 $group_result_value = call_user_func_array($group_definition_value, [
                     $row, &$part_name
                 ]);
-            }
-            else {
+            } else {
                 throw new UsageException(
                     'Bad value provided for group id generation: '
                     .var_export($group_definition_value, true)
@@ -669,8 +660,9 @@ 
                 );
             }
 
-            if (!is_null($part_name))
-                $group_parts[ $part_name ] = $group_result_value;
+            if (!is_null($part_name)) {
+                            $group_parts[ $part_name ] = $group_result_value;
+            }
         }
 
         // sort the groups by names (without it the same group could have multiple ids)
@@ -683,8 +675,7 @@ 
                 $group_value = get_class($group_value)
                              . '_'
                              . hash( 'crc32b', var_export($group_value, true) );
-            }
-            elseif (is_array($group_value)) {
+            } elseif (is_array($group_value)) {
                 $group_value = 'array_' . hash( 'crc32b', var_export($group_value, true) );
             }