jazzsequence / games-collector

inc/game/namespace.php

Spacing +22 added lines, -22 removed lines

@@ -50,7 +50,7 @@ 
 			],
 		],
 		// Dropdown filters.
-		'admin_filters'       => [],
+		'admin_filters'       => [ ],
 		], [
 			'singular'      => __( 'Game', 'games-collector' ),
 			'plural'        => __( 'Games', 'games-collector' ),
@@ -71,9 +71,9 @@ 
 		'id'            => $prefix . 'metabox',
 		'title'         => __( 'Game Details', 'games-collector' ),
 		'object_types'  => [ 'gc_game' ],
-	]);
+	] );
 
-	$cmb->add_field([
+	$cmb->add_field( [
 		'name'       => __( 'Minimum Number of Players', 'games-collector' ),
 		'id'         => $prefix . 'min_players',
 		'type'       => 'text_small',
@@ -81,9 +81,9 @@ 
 			'type'        => 'number',
 			'placeholder' => '1',
 		],
-	]);
+	] );
 
-	$cmb->add_field([
+	$cmb->add_field( [
 		'name'       => __( 'Maximum Number of Players', 'games-collector' ),
 		'id'         => $prefix . 'max_players',
 		'type'       => 'text_small',
@@ -91,9 +91,9 @@ 
 			'type'        => 'number',
 			'placeholder' => '4',
 		],
-	]);
+	] );
 
-	$cmb->add_field([
+	$cmb->add_field( [
 		'name'       => __( 'Playing Time', 'games-collector' ),
 		'id'         => $prefix . 'time',
 		'type'       => 'text_small',
@@ -101,9 +101,9 @@ 
 		'attributes' => [
 			'placeholder' => '20-30',
 		],
-	]);
+	] );
 
-	$cmb->add_field([
+	$cmb->add_field( [
 		'name'       => __( 'Ages', 'games-collector' ),
 		'id'         => $prefix . 'age',
 		'type'       => 'text_small',
@@ -112,16 +112,16 @@ 
 			'type'        => 'number',
 			'placeholder' => '10',
 		],
-	]);
+	] );
 
-	$cmb->add_field([
+	$cmb->add_field( [
 		'name'       => __( 'Difficulty Level', 'games-collector' ),
 		'id'         => $prefix . 'difficulty',
 		'type'       => 'radio',
 		'desc'       => __( 'How difficult or complex is this game?', 'games-collector' ),
 		'options'    => get_difficulties(),
 		'default'    => 'easy',
-	]);
+	] );
 
 	$cmb->add_field( array(
 		'name'       => __( 'More Info Link', 'games-collector' ),
@@ -149,8 +149,8 @@ 
 
 	$players_min_max = get_players_min_max( $post_id );
 
-	if ( isset( $players_min_max['min'] ) && isset( $players_min_max['max'] ) ) {
-		return sprintf( '%1$s - %2$s', $players_min_max['min'], $players_min_max['max'] );
+	if ( isset( $players_min_max[ 'min' ] ) && isset( $players_min_max[ 'max' ] ) ) {
+		return sprintf( '%1$s - %2$s', $players_min_max[ 'min' ], $players_min_max[ 'max' ] );
 	}
 
 	return;
@@ -292,20 +292,20 @@ 
 	$difficulty = get_post_meta( $post_id, '_gc_difficulty', true );
 	$length     = get_game_length( $post_id );
 
-	if ( isset( $players['min'] ) ) {
-		$classes .= ' min-' . $players['min'] . '-players';
+	if ( isset( $players[ 'min' ] ) ) {
+		$classes .= ' min-' . $players[ 'min' ] . '-players';
 	}
 
-	if ( isset( $players['max'] ) ) {
-		if ( absint( $players['max'] ) >= 8 ) {
+	if ( isset( $players[ 'max' ] ) ) {
+		if ( absint( $players[ 'max' ] ) >= 8 ) {
 			$classes .= ' 8-or-more-players';
 		} else {
-			$classes .= ' max-' . $players['max'] . '-players';
+			$classes .= ' max-' . $players[ 'max' ] . '-players';
 		}
 	}
 
-	if ( isset( $players['min'] ) && ! isset( $players['max'] ) ) {
-		$classes .= ' ' . $players['min'] . '-players';
+	if ( isset( $players[ 'min' ] ) && ! isset( $players[ 'max' ] ) ) {
+		$classes .= ' ' . $players[ 'min' ] . '-players';
 	}
 
 	if ( $age ) {
@@ -341,7 +341,7 @@ 
 
 	$game_time = str_replace( ' ', '', get_post_meta( $post_id, '_gc_time', true ) );
 	$time      = explode( '-', $game_time );
-	$time      = isset( $time[1] ) ? $time[1] : $time[0];
+	$time      = isset( $time[ 1 ] ) ? $time[ 1 ] : $time[ 0 ];
 
 	if ( $game_time ) {
 		switch ( $time ) {

inc/namespace.php

Spacing +6 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
  */
 function activate() {
 	if ( ! get_page_by_title( esc_html__( 'Games', 'games-collector' ) ) ) {
-		wp_insert_post([
+		wp_insert_post( [
 			'post_type'    => 'page',
 			'post_title'   => esc_html__( 'Games', 'games-collector' ),
 			'post_content' => '[games-collector]',
@@ -63,20 +63,20 @@ 
 function numbers_of_players( $game_id, $players_min_max, $output ) {
 
 	// Deal with max number of players matching min number of players.
-	if ( absint( $players_min_max['min'] ) === absint( $players_min_max['max'] ) ) {
+	if ( absint( $players_min_max[ 'min' ] ) === absint( $players_min_max[ 'max' ] ) ) {
 		return esc_attr( sprintf(
 			// Translators: %d is the number of players.
-			_n( '%d player', '%d players', absint( $players_min_max['min'] ), 'games-collector' ),
-			absint( $players_min_max['min'] )
+			_n( '%d player', '%d players', absint( $players_min_max[ 'min' ] ), 'games-collector' ),
+			absint( $players_min_max[ 'min' ] )
 		) );
 	}
 
 	// Deal with indeterminate or large number of max players.
-	if ( 0 === absint( $players_min_max['max'] ) || 20 <= absint( $players_min_max['max'] ) ) {
+	if ( 0 === absint( $players_min_max[ 'max' ] ) || 20 <= absint( $players_min_max[ 'max' ] ) ) {
 		return esc_attr( sprintf(
 			// Translators: %d is the minimum number players.
 			__( '%d+ players', 'games-collector' ),
-			absint( $players_min_max['min'] )
+			absint( $players_min_max[ 'min' ] )
 		) );
 	}
 

inc/bgg/namespace.php

Spacing +69 added lines, -69 removed lines

@@ -70,19 +70,19 @@ 
  */
 function get_bgg_search_results( $query ) {
 	$response = wp_remote_get( bgg_search( $query ) );
-	$results  = [];
+	$results  = [ ];
 
-	if ( isset( $response['response'] ) && 200 === $response['response']['code'] ) {
-		$xml  = simplexml_load_string( wp_remote_retrieve_body( $response ) );
+	if ( isset( $response[ 'response' ] ) && 200 === $response[ 'response' ][ 'code' ] ) {
+		$xml = simplexml_load_string( wp_remote_retrieve_body( $response ) );
 
 		if ( isset( $xml->boardgame ) ) {
 			foreach ( $xml->boardgame as $game ) {
 				$game = (array) $game;
 
-				$results[] = [
-					'id'   => ( isset( $game['@attributes']['objectid'] ) ) ? (int) $game['@attributes']['objectid'] : '',
-					'name' => ( isset( $game['name'] ) ) ? $game['name'] : '',
-					'year' => ( isset( $game['yearpublished'] ) ) ? $game['yearpublished'] : '',
+				$results[ ] = [
+					'id'   => ( isset( $game[ '@attributes' ][ 'objectid' ] ) ) ? (int) $game[ '@attributes' ][ 'objectid' ] : '',
+					'name' => ( isset( $game[ 'name' ] ) ) ? $game[ 'name' ] : '',
+					'year' => ( isset( $game[ 'yearpublished' ] ) ) ? $game[ 'yearpublished' ] : '',
 				];
 			}
 		}
@@ -100,31 +100,31 @@ 
  */
 function get_bgg_game( $id ) {
 	$response = wp_remote_get( bgg_game( $id ) );
-	$data     = [];
+	$data     = [ ];
 
-	if ( isset( $response['response'] ) && 200 === $response['response']['code'] ) {
+	if ( isset( $response[ 'response' ] ) && 200 === $response[ 'response' ][ 'code' ] ) {
 		$xml = simplexml_load_string( wp_remote_retrieve_body( $response ) );
 		$game = $xml->item;
 		$data = [
-			'title'       => (string) $game->name->attributes()['value'],
+			'title'       => (string) $game->name->attributes()[ 'value' ],
 			'image'       => (string) $game->image,
-			'minplayers'  => (int) $game->minplayers->attributes()['value'],
-			'maxplayers'  => (int) $game->maxplayers->attributes()['value'],
-			'minplaytime' => (int) $game->minplaytime->attributes()['value'],
-			'maxplaytime' => (int) $game->maxplaytime->attributes()['value'],
-			'minage'      => (int) $game->minage->attributes()['value'],
-			'categories'  => [],
+			'minplayers'  => (int) $game->minplayers->attributes()[ 'value' ],
+			'maxplayers'  => (int) $game->maxplayers->attributes()[ 'value' ],
+			'minplaytime' => (int) $game->minplaytime->attributes()[ 'value' ],
+			'maxplaytime' => (int) $game->maxplaytime->attributes()[ 'value' ],
+			'minage'      => (int) $game->minage->attributes()[ 'value' ],
+			'categories'  => [ ],
 		];
 
-		$categories = [];
+		$categories = [ ];
 
 		foreach ( $game->link as $metadata ) {
-			if ( 'boardgamecategory' === (string) $metadata->attributes()['type'] ) {
-				$categories[] = (string) $metadata->attributes()['value'];
+			if ( 'boardgamecategory' === (string) $metadata->attributes()[ 'type' ] ) {
+				$categories[ ] = (string) $metadata->attributes()[ 'value' ];
 			}
 		}
 
-		$data['categories'] = ! empty( $categories ) ? $categories : [];
+		$data[ 'categories' ] = ! empty( $categories ) ? $categories : [ ];
 	}
 
 	return $data;
@@ -139,11 +139,11 @@ 
 	$search_results = get_transient( 'gc_last_bgg_search' );
 
 	// First run.
-	if ( ! $search_results || isset( $_GET['reset_search'] ) ) {
+	if ( ! $search_results || isset( $_GET[ 'reset_search' ] ) ) {
 
 		// If we're clearing the search, delete the transient and start over.
-		if ( isset( $_GET['bgg_search_reset_nonce'] ) &&
-			wp_verify_nonce( sanitize_text_field( wp_unslash( $_GET['bgg_search_reset_nonce'] ) ), 'bgg_search_reset_nonce' ) ) {
+		if ( isset( $_GET[ 'bgg_search_reset_nonce' ] ) &&
+			wp_verify_nonce( sanitize_text_field( wp_unslash( $_GET[ 'bgg_search_reset_nonce' ] ) ), 'bgg_search_reset_nonce' ) ) {
 			delete_transient( 'gc_last_bgg_search' );
 			add_action( 'admin_notices', __NAMESPACE__ . '\\search_cleared_notice' );
 		}
@@ -212,10 +212,10 @@ 
  * @param  object $field_type_object The CMB2 field type object.
  */
 function render_cmb2_bgg_search( $field, $escaped_value, $object_id, $object_type, $field_type_object ) {
-	$description = '<p class="description">' . esc_html( $field_type_object->field->args()['desc'] ) . '</p>';
+	$description = '<p class="description">' . esc_html( $field_type_object->field->args()[ 'desc' ] ) . '</p>';
 	$form = sprintf( '<input id="%1$s" class="regular-text" name="%2$s" value="" placeholder="%3$s" type="text">',
-		esc_attr( $field_type_object->field->args()['id'] ),
-		esc_attr( $field_type_object->field->args()['id'] ),
+		esc_attr( $field_type_object->field->args()[ 'id' ] ),
+		esc_attr( $field_type_object->field->args()[ 'id' ] ),
 		__( 'A game title or search, e.g. &ldquo;betrayal house hill&rdquo;', 'usat' )
 	);
 	$hidden = '<input type="hidden" name="action" value="bgg_search_response">';
@@ -223,15 +223,15 @@ 
 
 	echo wp_kses( $output, [
 		'p'     => [
-			'class'       => [],
+			'class'       => [ ],
 		],
 		'input' => [
-			'id'          => [],
-			'class'       => [],
-			'name'        => [],
-			'value'       => [],
-			'type'        => [],
-			'placeholder' => [],
+			'id'          => [ ],
+			'class'       => [ ],
+			'name'        => [ ],
+			'value'       => [ ],
+			'type'        => [ ],
+			'placeholder' => [ ],
 		],
 	] );
 }
@@ -262,7 +262,7 @@ 
 	?>
 	<a href="<?php echo esc_url_raw( $url ); ?>">
 		<div class="button alignright" name="bgg_search_reset">
-			<?php echo esc_html( $field_type_object->field->args['button_name'] ); ?>
+			<?php echo esc_html( $field_type_object->field->args[ 'button_name' ] ); ?>
 		</div>
 	</a>
 	<input type="hidden" name="action" value="bgg_search_reset" />
@@ -270,17 +270,17 @@ 
 
 	echo wp_kses( ob_get_clean(), [
 		'a' => [
-			'href' => [],
+			'href' => [ ],
 		],
 		'div' => [
-			'class' => [],
+			'class' => [ ],
 		],
 		'input' => [
-			'type'  => [],
-			'name'  => [],
-			'value' => [],
+			'type'  => [ ],
+			'name'  => [ ],
+			'value' => [ ],
 		],
-	]);
+	] );
 }
 
 /**
@@ -290,9 +290,9 @@ 
  * @return void|wp_die
  */
 function search_response() {
-	if ( isset( $_POST['nonce_CMB2phpbgg-search'] ) && wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['nonce_CMB2phpbgg-search'] ) ), 'nonce_CMB2phpbgg-search' ) ) {
+	if ( isset( $_POST[ 'nonce_CMB2phpbgg-search' ] ) && wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST[ 'nonce_CMB2phpbgg-search' ] ) ), 'nonce_CMB2phpbgg-search' ) ) {
 
-		$search_query = isset( $_POST['bgg_searchform'] ) ? sanitize_text_field( wp_unslash( $_POST['bgg_searchform'] ) ) : '';
+		$search_query = isset( $_POST[ 'bgg_searchform' ] ) ? sanitize_text_field( wp_unslash( $_POST[ 'bgg_searchform' ] ) ) : '';
 		$results      = get_bgg_search_results( $search_query );
 		set_transient( 'gc_last_bgg_search', $results, HOUR_IN_SECONDS );
 		wp_safe_redirect( admin_url( 'edit.php?post_type=gc_game&page=add_from_bgg&step=2' ) );
@@ -330,14 +330,14 @@ 
 	global $submenu;
 
 	// Store the Games Collector menu to a variable.
-	$items = $submenu['edit.php?post_type=gc_game'];
+	$items = $submenu[ 'edit.php?post_type=gc_game' ];
 
 	// Item 11 is right after Add New. Item 16 is the link for Add New from BGG.
-	$submenu['edit.php?post_type=gc_game'][11] = $items[16]; // WPCS: override ok.
+	$submenu[ 'edit.php?post_type=gc_game' ][ 11 ] = $items[ 16 ]; // WPCS: override ok.
 	// Remove item 16, the old Add New from BGG link.
-	unset( $submenu['edit.php?post_type=gc_game'][16] );
+	unset( $submenu[ 'edit.php?post_type=gc_game' ][ 16 ] );
 	// Re-sort the menu by index.
-	ksort( $submenu['edit.php?post_type=gc_game'] );
+	ksort( $submenu[ 'edit.php?post_type=gc_game' ] );
 
 	return $menu_order;
 }
@@ -350,12 +350,12 @@ 
  * @return array          An array of options for CMB2.
  */
 function bgg_search_results_options( $results ) {
-	$options = [];
+	$options = [ ];
 	foreach ( $results as $game ) {
-		$options[ absint( $game['id'] ) ] = sprintf( '%1$s [%2$s] (%3$s)',
-			'<strong>' . esc_html( $game['name'] ) . '</strong>',
-			esc_html( $game['year'] ),
-			esc_html( $game['id'] )
+		$options[ absint( $game[ 'id' ] ) ] = sprintf( '%1$s [%2$s] (%3$s)',
+			'<strong>' . esc_html( $game[ 'name' ] ) . '</strong>',
+			esc_html( $game[ 'year' ] ),
+			esc_html( $game[ 'id' ] )
 		);
 	}
 
@@ -369,16 +369,16 @@ 
  * @return void|wp_die
  */
 function insert_game() {
-	if ( isset( $_POST['nonce_CMB2phpbgg-search-2'] ) && wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST['nonce_CMB2phpbgg-search-2'] ) ), 'nonce_CMB2phpbgg-search-2' ) ) {
+	if ( isset( $_POST[ 'nonce_CMB2phpbgg-search-2' ] ) && wp_verify_nonce( sanitize_text_field( wp_unslash( $_POST[ 'nonce_CMB2phpbgg-search-2' ] ) ), 'nonce_CMB2phpbgg-search-2' ) ) {
 
-		$game_id      = isset( $_POST['bgg_search_results'] ) ? absint( wp_unslash( $_POST['bgg_search_results'] ) ) : false;
+		$game_id      = isset( $_POST[ 'bgg_search_results' ] ) ? absint( wp_unslash( $_POST[ 'bgg_search_results' ] ) ) : false;
 		$redirect_url = admin_url( 'edit.php?post_type=gc_game&page=add_from_bgg' );
 
 		if ( $game_id ) {
 			$game = get_bgg_game( $game_id );
 
 			// Check if game already exists.
-			if ( get_page_by_title( $game['title'], OBJECT, 'gc_game' ) ) {
+			if ( get_page_by_title( $game[ 'title' ], OBJECT, 'gc_game' ) ) {
 				return wp_die(
 					esc_html__( 'A game with that title already exists. Please try again.', 'games-collector' ),
 					esc_html__( 'Duplicate game found', 'games-collector' ),
@@ -388,7 +388,7 @@ 
 
 			$post_id = wp_insert_post( [
 				'post_type'   => 'gc_game',
-				'post_title'  => esc_html( $game['title'] ),
+				'post_title'  => esc_html( $game[ 'title' ] ),
 				'post_status' => 'draft',
 			] );
 
@@ -396,20 +396,20 @@ 
 				$redirect_url = admin_url( sprintf( 'post.php?post=%d&action=edit', $post_id ) );
 
 				// Add game meta.
-				add_post_meta( $post_id, '_gc_min_players', absint( $game['minplayers'] ) );
-				add_post_meta( $post_id, '_gc_max_players', absint( $game['maxplayers'] ) );
-				add_post_meta( $post_id, '_gc_age', absint( $game['minage'] ) );
+				add_post_meta( $post_id, '_gc_min_players', absint( $game[ 'minplayers' ] ) );
+				add_post_meta( $post_id, '_gc_max_players', absint( $game[ 'maxplayers' ] ) );
+				add_post_meta( $post_id, '_gc_age', absint( $game[ 'minage' ] ) );
 				add_post_meta( $post_id, '_gc_link', sprintf( 'https://www.boardgamegeek.com/boardgame/%d/', $game_id ) );
 				add_post_meta( $post_id, '_gc_bgg_id', $game_id );
 
-				if ( absint( $game['minplaytime'] ) === absint( $game['maxplaytime'] ) ) {
-					add_post_meta( $post_id, '_gc_time', esc_html( $game['minplaytime'] ) );
+				if ( absint( $game[ 'minplaytime' ] ) === absint( $game[ 'maxplaytime' ] ) ) {
+					add_post_meta( $post_id, '_gc_time', esc_html( $game[ 'minplaytime' ] ) );
 				} else {
-					add_post_meta( $post_id, '_gc_time', esc_html( $game['minplaytime'] . '-' . $game['maxplaytime'] ) );
+					add_post_meta( $post_id, '_gc_time', esc_html( $game[ 'minplaytime' ] . '-' . $game[ 'maxplaytime' ] ) );
 				}
 
-				if ( isset( $game['categories'] ) ) {
-					foreach ( $game['categories'] as $game_attribute ) {
+				if ( isset( $game[ 'categories' ] ) ) {
+					foreach ( $game[ 'categories' ] as $game_attribute ) {
 						$similar_attribute = get_attribute_like( $game_attribute );
 
 						// If there's an existing attribute that matches the BGG category, use that.
@@ -455,7 +455,7 @@ 
 		return $cached_term_search[ $search ];
 	}
 
-	$terms     = [];
+	$terms     = [ ];
 	$all_terms = get_terms( [
 		'taxonomy' => 'gc_attribute',
 		'hide_empty' => false,
@@ -464,7 +464,7 @@ 
 	foreach ( $all_terms as $term ) {
 		similar_text( $term->name, $search, $similarity );
 		if ( $similarity > 75 ) {
-			$terms[] = $term->term_id;
+			$terms[ ] = $term->term_id;
 		}
 	}
 
@@ -473,14 +473,14 @@ 
 		// Cache this term combination so we can access it faster later.
 		if ( ! $cached_term_search ) {
 			set_transient( 'gc_frequently_used_attributes', [
-				$search => $terms[0],
+				$search => $terms[ 0 ],
 			], 999 * YEAR_IN_SECONDS );
 		} else {
-			$cached_term_search = array_merge( $cached_term_search, [ $search => $terms[0] ] );
+			$cached_term_search = array_merge( $cached_term_search, [ $search => $terms[ 0 ] ] );
 			set_transient( 'gc_frequently_used_attributes', $cached_term_search, 999 * YEAR_IN_SECONDS );
 		}
 
-		return $terms[0];
+		return $terms[ 0 ];
 	}
 
 	return false;
@@ -494,6 +494,6 @@ 
  * @param  array $game    The array of game data from BGG.
  */
 function attach_bgg_image( $post_id, $game ) {
-	$image_id = media_sideload_image( esc_url_raw( $game['image'] ), $post_id, esc_html( $game['title'] ), 'id' );
+	$image_id = media_sideload_image( esc_url_raw( $game[ 'image' ] ), $post_id, esc_html( $game[ 'title' ] ), 'id' );
 	set_post_thumbnail( $post_id, $image_id );
 }