Passed
Push — main ( 37879d...ff361e )
by Thierry
01:56
created
src/UploadHandler.php 2 patches
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -135,12 +135,12 @@  discard block
 block discarded – undo
135 135
      */
136 136
     public function canProcessRequest(ServerRequestInterface $xRequest): bool
137 137
     {
138
-        if(count($xRequest->getUploadedFiles()) > 0)
138
+        if (count($xRequest->getUploadedFiles()) > 0)
139 139
         {
140 140
             return true;
141 141
         }
142 142
         $aBody = $xRequest->getParsedBody();
143
-        if(is_array($aBody))
143
+        if (is_array($aBody))
144 144
         {
145 145
             return isset($aBody['jxnupl']);
146 146
         }
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
     private function setTempFile(ServerRequestInterface $xRequest): bool
159 159
     {
160 160
         $aBody = $xRequest->getParsedBody();
161
-        if(is_array($aBody))
161
+        if (is_array($aBody))
162 162
         {
163 163
             $this->sTempFile = trim($aBody['jxnupl'] ?? '');
164 164
             return $this->sTempFile !== '';
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
      */
179 179
     public function processRequest(ServerRequestInterface $xRequest): bool
180 180
     {
181
-        if($this->setTempFile($xRequest))
181
+        if ($this->setTempFile($xRequest))
182 182
         {
183 183
             // Ajax request following a normal HTTP upload.
184 184
             // Copy the previously uploaded files' location from the temp file.
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
             return true;
187 187
         }
188 188
 
189
-        if($this->bIsAjaxRequest)
189
+        if ($this->bIsAjaxRequest)
190 190
         {
191 191
             // Ajax request with upload.
192 192
             // Copy the uploaded files from the HTTP request.
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
             $sTempFile = $this->xUploadManager->saveToTempFile($this->aUserFiles);
204 204
             $this->xResponseManager->append(new UploadResponse($this->xPsr17Factory, $sTempFile));
205 205
         }
206
-        catch(Exception $e)
206
+        catch (Exception $e)
207 207
         {
208 208
             $this->xResponseManager->append(new UploadResponse($this->xPsr17Factory, '', $e->getMessage()));
209 209
         }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -202,8 +202,7 @@
 block discarded – undo
202 202
             $this->aUserFiles = $this->xUploadManager->readFromHttpData($xRequest);
203 203
             $sTempFile = $this->xUploadManager->saveToTempFile($this->aUserFiles);
204 204
             $this->xResponseManager->append(new UploadResponse($this->xPsr17Factory, $sTempFile));
205
-        }
206
-        catch(Exception $e)
205
+        } catch(Exception $e)
207 206
         {
208 207
             $this->xResponseManager->append(new UploadResponse($this->xPsr17Factory, '', $e->getMessage()));
209 208
         }
Please login to merge, or discard this patch.
src/UploadResponse.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -99,8 +99,7 @@
 block discarded – undo
99 99
     public function getOutput(): string
100 100
     {
101 101
         $sResult = json_encode(($this->sUploadedFile) ?
102
-            ['code' => 'success', 'upl' => $this->sUploadedFile] :
103
-            ['code' => 'error', 'msg' => $this->sErrorMessage]) . ';';
102
+            ['code' => 'success', 'upl' => $this->sUploadedFile] : ['code' => 'error', 'msg' => $this->sErrorMessage]) . ';';
104 103
         $sConsoleLog = array_reduce($this->aDebugMessages, function($sJsLog, $sMessage) {
105 104
             return "$sJsLog\n\t" . 'console.log("' . addslashes($sMessage) . '");';
106 105
         }, '');
Please login to merge, or discard this patch.
src/start.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
  */
28 28
 function register(Container $di, bool $bForce = false)
29 29
 {
30
-    if(!$bForce && $di->h(UploadHandler::class))
30
+    if (!$bForce && $di->h(UploadHandler::class))
31 31
     {
32 32
         return;
33 33
     }
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 {
74 74
     $di = jaxon()->di();
75 75
     $sEventListenerKey = UploadHandler::class . '\\ConfigListener';
76
-    if($di->h($sEventListenerKey))
76
+    if ($di->h($sEventListenerKey))
77 77
     {
78 78
         return;
79 79
     }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
             public function onChange(Config $xConfig, string $sName)
87 87
             {
88 88
                 $sConfigKey = 'core.upload.enabled';
89
-                if(($sName === $sConfigKey || $sName === '') && $xConfig->getOption($sConfigKey))
89
+                if (($sName === $sConfigKey || $sName === '') && $xConfig->getOption($sConfigKey))
90 90
                 {
91 91
                     register(jaxon()->di());
92 92
                 }
Please login to merge, or discard this patch.
src/Manager/Validator.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     {
98 98
         $xDefault = $this->xConfigManager->getOption('upload.default.' . $sProperty);
99 99
         $aAllowed = $this->xConfigManager->getOption('upload.files.' . $sVarName . '.' . $sProperty, $xDefault);
100
-        if(is_array($aAllowed) && !in_array($sValue, $aAllowed))
100
+        if (is_array($aAllowed) && !in_array($sValue, $aAllowed))
101 101
         {
102 102
             $this->sErrorMessage = $this->xTranslator->trans('errors.upload.' . $sField, [$sField => $sValue]);
103 103
             return false;
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     {
119 119
         $xDefault = $this->xConfigManager->getOption('upload.default.' . $sProperty, 0);
120 120
         $nSize = $this->xConfigManager->getOption('upload.files.' . $sVarName . '.' . $sProperty, $xDefault);
121
-        if($nSize > 0 && (
121
+        if ($nSize > 0 && (
122 122
             ($sProperty == 'max-size' && $nFileSize > $nSize) ||
123 123
             ($sProperty == 'min-size' && $nFileSize < $nSize)))
124 124
         {
@@ -140,25 +140,25 @@  discard block
 block discarded – undo
140 140
     {
141 141
         $this->sErrorMessage = '';
142 142
         // Verify the file extension
143
-        if(!$this->validateFileProperty($sVarName, $xFile->type(), 'types', 'type'))
143
+        if (!$this->validateFileProperty($sVarName, $xFile->type(), 'types', 'type'))
144 144
         {
145 145
             return false;
146 146
         }
147 147
 
148 148
         // Verify the file extension
149
-        if(!$this->validateFileProperty($sVarName, $xFile->extension(), 'extensions', 'extension'))
149
+        if (!$this->validateFileProperty($sVarName, $xFile->extension(), 'extensions', 'extension'))
150 150
         {
151 151
             return false;
152 152
         }
153 153
 
154 154
         // Verify the max size
155
-        if(!$this->validateFileSize($sVarName, $xFile->size(), 'max-size'))
155
+        if (!$this->validateFileSize($sVarName, $xFile->size(), 'max-size'))
156 156
         {
157 157
             return false;
158 158
         }
159 159
 
160 160
         // Verify the min size
161
-        if(!$this->validateFileSize($sVarName, $xFile->size(), 'min-size'))
161
+        if (!$this->validateFileSize($sVarName, $xFile->size(), 'min-size'))
162 162
         {
163 163
             return false;
164 164
         }
Please login to merge, or discard this patch.
src/Manager/FileStorage.php 1 patch
Spacing   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -80,8 +80,7 @@  discard block
 block discarded – undo
80 80
     {
81 81
         // Local file system adapter
82 82
         $this->registerAdapter('local', function(string $sRootDir, $xOptions) {
83
-            return empty($xOptions) ? new LocalFilesystemAdapter($sRootDir) :
84
-                new LocalFilesystemAdapter($sRootDir, $xOptions);
83
+            return empty($xOptions) ? new LocalFilesystemAdapter($sRootDir) : new LocalFilesystemAdapter($sRootDir, $xOptions);
85 84
         });
86 85
 
87 86
         // In memory file system adapter
@@ -144,7 +143,7 @@  discard block
 block discarded – undo
144 143
     public function filesystem(string $sField = ''): Filesystem
145 144
     {
146 145
         $sField = trim($sField);
147
-        if(isset($this->aFilesystems[$sField]))
146
+        if (isset($this->aFilesystems[$sField]))
148 147
         {
149 148
             return $this->aFilesystems[$sField];
150 149
         }
@@ -154,18 +153,18 @@  discard block
 block discarded – undo
154 153
         $sRootDir = $this->xConfigManager->getOption('upload.default.dir', '');
155 154
         $aOptions = $this->xConfigManager->getOption('upload.default.options');
156 155
         $sConfigKey = "upload.files.$sField";
157
-        if($sField !== '' && $this->xConfigManager->hasOption($sConfigKey))
156
+        if ($sField !== '' && $this->xConfigManager->hasOption($sConfigKey))
158 157
         {
159 158
             $sStorage = $this->xConfigManager->getOption("$sConfigKey.storage", $sStorage);
160 159
             $sRootDir = $this->xConfigManager->getOption("$sConfigKey.dir", $sRootDir);
161 160
             $aOptions = $this->xConfigManager->getOption("$sConfigKey.options", $aOptions);
162 161
         }
163 162
 
164
-        if(!is_string($sRootDir))
163
+        if (!is_string($sRootDir))
165 164
         {
166 165
             throw new RequestException($this->xTranslator->trans('errors.upload.dir'));
167 166
         }
168
-        if(!isset($this->aAdapters[$sStorage]))
167
+        if (!isset($this->aAdapters[$sStorage]))
169 168
         {
170 169
             throw new RequestException($this->xTranslator->trans('errors.upload.adapter'));
171 170
         }
Please login to merge, or discard this patch.
src/Manager/UploadManager.php 2 patches
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -154,13 +154,13 @@  discard block
 block discarded – undo
154 154
         try
155 155
         {
156 156
             $xFilesystem->createDirectory($sUploadDir);
157
-            if($xFilesystem->visibility($sUploadDir) !== Visibility::PUBLIC)
157
+            if ($xFilesystem->visibility($sUploadDir) !== Visibility::PUBLIC)
158 158
             {
159 159
                 throw new RequestException($this->xTranslator->trans('errors.upload.access'));
160 160
             }
161 161
             return $sUploadDir;
162 162
         }
163
-        catch(FilesystemException $e)
163
+        catch (FilesystemException $e)
164 164
         {
165 165
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
166 166
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -204,20 +204,20 @@  discard block
 block discarded – undo
204 204
     private function makeUploadedFile(string $sUploadDir, string $sField, UploadedFile $xHttpFile): File
205 205
     {
206 206
         // Check the uploaded file validity
207
-        if($xHttpFile->getError())
207
+        if ($xHttpFile->getError())
208 208
         {
209 209
             throw new RequestException($this->xTranslator->trans('errors.upload.failed', ['name' => $sField]));
210 210
         }
211 211
         // Set the user file data
212 212
         $xFile = File::fromHttpFile($this->xFileStorage->filesystem($sField), $sUploadDir, $xHttpFile);
213 213
         // Verify file validity (format, size)
214
-        if(!$this->xValidator->validateUploadedFile($sField, $xFile))
214
+        if (!$this->xValidator->validateUploadedFile($sField, $xFile))
215 215
         {
216 216
             throw new RequestException($this->xValidator->getErrorMessage());
217 217
         }
218 218
         // Filename without the extension. Needs to be sanitized.
219 219
         $sName = pathinfo($xHttpFile->getClientFilename(), PATHINFO_FILENAME);
220
-        if($this->cNameSanitizer !== null)
220
+        if ($this->cNameSanitizer !== null)
221 221
         {
222 222
             $sName = (string)call_user_func($this->cNameSanitizer, $sName, $sField, $this->sUploadFieldId);
223 223
         }
@@ -242,16 +242,16 @@  discard block
 block discarded – undo
242 242
 
243 243
         $aUserFiles = [];
244 244
         $this->aAllFiles = []; // A flat list of all uploaded files
245
-        foreach($aTempFiles as $sField => $aFiles)
245
+        foreach ($aTempFiles as $sField => $aFiles)
246 246
         {
247 247
             $aUserFiles[$sField] = [];
248 248
             // Get the path to the upload dir
249 249
             $sUploadDir = $this->getUploadDir($sField);
250
-            if(!is_array($aFiles))
250
+            if (!is_array($aFiles))
251 251
             {
252 252
                 $aFiles = [$aFiles];
253 253
             }
254
-            foreach($aFiles as $xHttpFile)
254
+            foreach ($aFiles as $xHttpFile)
255 255
             {
256 256
                 $aUserFiles[$sField][] = $this->makeUploadedFile($sUploadDir, $sField, $xHttpFile);
257 257
             }
@@ -259,12 +259,12 @@  discard block
 block discarded – undo
259 259
         // Copy the uploaded files from the temp dir to the user dir
260 260
         try
261 261
         {
262
-            foreach($this->aAllFiles as $aFiles)
262
+            foreach ($this->aAllFiles as $aFiles)
263 263
             {
264 264
                 $aFiles['user']->filesystem()->write($aFiles['user']->path(), $aFiles['temp']->getStream());
265 265
             }
266 266
         }
267
-        catch(FilesystemException $e)
267
+        catch (FilesystemException $e)
268 268
         {
269 269
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
270 270
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -284,10 +284,10 @@  discard block
 block discarded – undo
284 284
     {
285 285
         // Convert uploaded file to an array
286 286
         $aFiles = [];
287
-        foreach($aUserFiles as $sField => $aFieldFiles)
287
+        foreach ($aUserFiles as $sField => $aFieldFiles)
288 288
         {
289 289
             $aFiles[$sField] = [];
290
-            foreach($aFieldFiles as $aFieldFile)
290
+            foreach ($aFieldFiles as $aFieldFile)
291 291
             {
292 292
                 $aFiles[$sField][] = $aFieldFile->toTempData();
293 293
             }
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         {
300 300
             $this->xFileStorage->filesystem()->write($sUploadDir . $sTempFile . '.json', json_encode($aFiles));
301 301
         }
302
-        catch(FilesystemException $e)
302
+        catch (FilesystemException $e)
303 303
         {
304 304
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
305 305
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     private function getUploadTempFile(string $sTempFile): string
319 319
     {
320 320
         // Verify file name validity
321
-        if(!$this->xValidator->validateTempFileName($sTempFile))
321
+        if (!$this->xValidator->validateTempFileName($sTempFile))
322 322
         {
323 323
             throw new RequestException($this->xTranslator->trans('errors.upload.invalid'));
324 324
         }
@@ -326,13 +326,13 @@  discard block
 block discarded – undo
326 326
         $sUploadTempFile = $sUploadDir . $sTempFile . '.json';
327 327
         try
328 328
         {
329
-            if($this->xFileStorage->filesystem()->visibility($sUploadTempFile) !== Visibility::PUBLIC)
329
+            if ($this->xFileStorage->filesystem()->visibility($sUploadTempFile) !== Visibility::PUBLIC)
330 330
             {
331 331
                 throw new RequestException($this->xTranslator->trans('errors.upload.access'));
332 332
             }
333 333
             return $sUploadTempFile;
334 334
         }
335
-        catch(FilesystemException $e)
335
+        catch (FilesystemException $e)
336 336
         {
337 337
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
338 338
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -356,15 +356,15 @@  discard block
 block discarded – undo
356 356
         {
357 357
             $aFiles = json_decode($xFileSystem->read($sUploadTempFile), true);
358 358
         }
359
-        catch(FilesystemException $e)
359
+        catch (FilesystemException $e)
360 360
         {
361 361
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
362 362
         }
363 363
         $aUserFiles = [];
364
-        foreach($aFiles as $sField => $aFieldFiles)
364
+        foreach ($aFiles as $sField => $aFieldFiles)
365 365
         {
366 366
             $aUserFiles[$sField] = [];
367
-            foreach($aFieldFiles as $aFieldFile)
367
+            foreach ($aFieldFiles as $aFieldFile)
368 368
             {
369 369
                 $aUserFiles[$sField][] = File::fromTempFile($this->xFileStorage->filesystem($sField), $aFieldFile);
370 370
             }
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
         {
374 374
             $xFileSystem->delete($sUploadTempFile);
375 375
         }
376
-        catch(FilesystemException $e)
376
+        catch (FilesystemException $e)
377 377
         {
378 378
             jaxon()->logger()->warning('Filesystem error', ['message' => $e->getMessage()]);
379 379
         }
Please login to merge, or discard this patch.
Braces   +6 added lines, -12 removed lines patch added patch discarded remove patch
@@ -159,8 +159,7 @@  discard block
 block discarded – undo
159 159
                 throw new RequestException($this->xTranslator->trans('errors.upload.access'));
160 160
             }
161 161
             return $sUploadDir;
162
-        }
163
-        catch(FilesystemException $e)
162
+        } catch(FilesystemException $e)
164 163
         {
165 164
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
166 165
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -263,8 +262,7 @@  discard block
 block discarded – undo
263 262
             {
264 263
                 $aFiles['user']->filesystem()->write($aFiles['user']->path(), $aFiles['temp']->getStream());
265 264
             }
266
-        }
267
-        catch(FilesystemException $e)
265
+        } catch(FilesystemException $e)
268 266
         {
269 267
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
270 268
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -298,8 +296,7 @@  discard block
 block discarded – undo
298 296
         try
299 297
         {
300 298
             $this->xFileStorage->filesystem()->write($sUploadDir . $sTempFile . '.json', json_encode($aFiles));
301
-        }
302
-        catch(FilesystemException $e)
299
+        } catch(FilesystemException $e)
303 300
         {
304 301
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
305 302
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -331,8 +328,7 @@  discard block
 block discarded – undo
331 328
                 throw new RequestException($this->xTranslator->trans('errors.upload.access'));
332 329
             }
333 330
             return $sUploadTempFile;
334
-        }
335
-        catch(FilesystemException $e)
331
+        } catch(FilesystemException $e)
336 332
         {
337 333
             jaxon()->logger()->error('Filesystem error', ['message' => $e->getMessage()]);
338 334
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
@@ -355,8 +351,7 @@  discard block
 block discarded – undo
355 351
         try
356 352
         {
357 353
             $aFiles = json_decode($xFileSystem->read($sUploadTempFile), true);
358
-        }
359
-        catch(FilesystemException $e)
354
+        } catch(FilesystemException $e)
360 355
         {
361 356
             throw new RequestException($this->xTranslator->trans('errors.upload.access'));
362 357
         }
@@ -372,8 +367,7 @@  discard block
 block discarded – undo
372 367
         try
373 368
         {
374 369
             $xFileSystem->delete($sUploadTempFile);
375
-        }
376
-        catch(FilesystemException $e)
370
+        } catch(FilesystemException $e)
377 371
         {
378 372
             jaxon()->logger()->warning('Filesystem error', ['message' => $e->getMessage()]);
379 373
         }
Please login to merge, or discard this patch.