jaxon-php / jaxon-core

src/Jaxon.php

Doc Comments +5 added lines, -14 removed lines

@@ -189,15 +189,6 @@ 
      *        - Jaxon::CALLABLE_OBJECT: an object who's methods are to be registered
      *        - Jaxon::BROWSER_EVENT: an event which will cause zero or more event handlers to be called
      *        - Jaxon::EVENT_HANDLER: register an event handler function.
-     * @param mixed        $sFunction | $objObject | $sEvent
-     *        When registering a function, this is the name of the function
-     *        When registering a callable object, this is the object being registered
-     *        When registering an event or event handler, this is the name of the event
-     * @param mixed        $sIncludeFile | $aCallOptions | $sEventHandler
-     *        When registering a function, this is the (optional) include file
-     *        When registering a callable object, this is an (optional) array
-     *             of call options for the functions being registered
-     *        When registering an event handler, this is the name of the function
      *
      * @return mixed
      */
@@ -473,7 +464,7 @@ 
      * @param string        $sLibKey            The key of the library options in the file
      * @param string|null   $sAppKey            The key of the application options in the file
      *
-     * @return array
+     * @return null|Utils\Config\Config
      */
     public function readPhpConfigFile($sConfigFile, $sLibKey = '', $sAppKey = null)
     {
@@ -487,7 +478,7 @@ 
      * @param string        $sLibKey            The key of the library options in the file
      * @param string|null   $sAppKey            The key of the application options in the file
      *
-     * @return array
+     * @return null|Utils\Config\Config
      */
     public function readYamlConfigFile($sConfigFile, $sLibKey = '', $sAppKey = null)
     {
@@ -501,7 +492,7 @@ 
      * @param string        $sLibKey            The key of the library options in the file
      * @param string|null   $sAppKey            The key of the application options in the file
      *
-     * @return array
+     * @return Utils\Config\Config|null
      */
     public function readJsonConfigFile($sConfigFile, $sLibKey = '', $sAppKey = null)
     {
@@ -515,7 +506,7 @@ 
      * @param string        $sLibKey            The key of the library options in the file
      * @param string|null   $sAppKey            The key of the application options in the file
      *
-     * @return array
+     * @return null|Utils\Config\Config
      */
     public function readConfigFile($sConfigFile, $sLibKey = '', $sAppKey = null)
     {
@@ -547,7 +538,7 @@ 
      * - 1000 thru 8999: User created plugins, typically, these plugins don't care about order
      * - 9000 thru 9999: Plugins that generally need to be last or near the end of the plugin list
      *
-     * @param Plugin         $xPlugin               An instance of a plugin
+     * @param Plugin\Plugin         $xPlugin               An instance of a plugin
      * @param integer        $nPriority             The plugin priority, used to order the plugins
      *
      * @return void

Unused Use Statements -4 removed lines

@@ -25,10 +25,6 @@
 
 namespace Jaxon;
 
-use Jaxon\Plugin\Manager as PluginManager;
-use Jaxon\Request\Manager as RequestManager;
-use Jaxon\Response\Manager as ResponseManager;
-
 use Jaxon\Utils\URI;
 use Exception;
 

Spacing +19 added lines, -19 removed lines

@@ -129,7 +129,7 @@ 
             'core.prefix.event'                 => 'jaxon_event_',
             // 'core.request.uri'               => '',
             'core.request.mode'                 => 'asynchronous',
-            'core.request.method'               => 'POST',    // W3C: Method is case sensitive
+            'core.request.method'               => 'POST', // W3C: Method is case sensitive
             'core.debug.on'                     => false,
             'core.debug.verbose'                => false,
             'core.process.exit_after'           => true,
@@ -206,13 +206,13 @@ 
         $aArgs = func_get_args();
         $nArgs = func_num_args();
 
-        if(self::PROCESSING_EVENT == $aArgs[0])
+        if (self::PROCESSING_EVENT == $aArgs[0])
         {
-            if($nArgs > 2)
+            if ($nArgs > 2)
             {
                 $sEvent = $aArgs[1];
                 $xUserFunction = $aArgs[2];
-                if(!is_a($xUserFunction, 'Request\\Support\\UserFunction'))
+                if (!is_a($xUserFunction, 'Request\\Support\\UserFunction'))
                     $xUserFunction = new Request\Support\UserFunction($xUserFunction);
                 $this->aProcessingEvents[$sEvent] = $xUserFunction;
                 return true;
@@ -296,7 +296,7 @@ 
     public function processRequest()
     {
         // Check to see if headers have already been sent out, in which case we can't do our job
-        if(headers_sent($filename, $linenumber))
+        if (headers_sent($filename, $linenumber))
         {
             echo $this->trans('errors.output.already-sent', array(
                 'location' => $filename . ':' . $linenumber
@@ -305,7 +305,7 @@ 
         }
 
         // Check if there is a plugin to process this request
-        if(!$this->canProcessRequest())
+        if (!$this->canProcessRequest())
         {
             return;
         }
@@ -314,18 +314,18 @@ 
         $mResult = true;
 
         // Handle before processing event
-        if(isset($this->aProcessingEvents[self::PROCESSING_EVENT_BEFORE]))
+        if (isset($this->aProcessingEvents[self::PROCESSING_EVENT_BEFORE]))
         {
             $this->aProcessingEvents[self::PROCESSING_EVENT_BEFORE]->call(array(&$bEndRequest));
         }
 
-        if(!$bEndRequest)
+        if (!$bEndRequest)
         {
             try
             {
                 $mResult = $this->getPluginManager()->processRequest();
             }
-            catch(Exception $e)
+            catch (Exception $e)
             {
                 // An exception was thrown while processing the request.
                 // The request missed the corresponding handler function,
@@ -338,7 +338,7 @@ 
                 $xResponseManager->debug($e->getMessage());
                 $mResult = false;
 
-                if($e instanceof \Jaxon\Exception\Error)
+                if ($e instanceof \Jaxon\Exception\Error)
                 {
                     $sEvent = self::PROCESSING_EVENT_INVALID;
                     $aParams = array($e->getMessage());
@@ -349,7 +349,7 @@ 
                     $aParams = array($e);
                 }
 
-                if(isset($this->aProcessingEvents[$sEvent]))
+                if (isset($this->aProcessingEvents[$sEvent]))
                 {
                     // Call the processing event
                     $this->aProcessingEvents[$sEvent]->call($aParams);
@@ -362,7 +362,7 @@ 
             }
         }
         // Clean the processing buffer
-        if(($this->getOption('core.process.clean_buffer')))
+        if (($this->getOption('core.process.clean_buffer')))
         {
             $er = error_reporting(0);
             while (ob_get_level() > 0)
@@ -372,10 +372,10 @@ 
             error_reporting($er);
         }
 
-        if($mResult === true)
+        if ($mResult === true)
         {
             // Handle after processing event
-            if(isset($this->aProcessingEvents[self::PROCESSING_EVENT_AFTER]))
+            if (isset($this->aProcessingEvents[self::PROCESSING_EVENT_AFTER]))
             {
                 $bEndRequest = false;
                 $this->aProcessingEvents[self::PROCESSING_EVENT_AFTER]->call(array($bEndRequest));
@@ -384,7 +384,7 @@ 
 
         $this->getResponseManager()->send();
 
-        if(($this->getOption('core.process.exit_after')))
+        if (($this->getOption('core.process.exit_after')))
         {
             exit();
         }
@@ -413,16 +413,16 @@ 
      */
     public function getScript($bIncludeJs = false, $bIncludeCss = false)
     {
-        if(!$this->getOption('core.request.uri'))
+        if (!$this->getOption('core.request.uri'))
         {
             $this->setOption('core.request.uri', URI::detect());
         }
         $sCode = '';
-        if(($bIncludeCss))
+        if (($bIncludeCss))
         {
             $sCode .= $this->getPluginManager()->getCss() . "\n";
         }
-        if(($bIncludeJs))
+        if (($bIncludeJs))
         {
             $sCode .= $this->getPluginManager()->getJs() . "\n";
         }
@@ -520,7 +520,7 @@ 
     public function readConfigFile($sConfigFile, $sLibKey = '', $sAppKey = null)
     {
         $sExt = pathinfo($sConfigFile, PATHINFO_EXTENSION);
-        switch($sExt)
+        switch ($sExt)
         {
         case 'php':
             return $this->readPhpConfigFile($sConfigFile, $sLibKey, $sAppKey);

Braces +6 added lines, -8 removed lines

@@ -212,8 +212,9 @@ 
             {
                 $sEvent = $aArgs[1];
                 $xUserFunction = $aArgs[2];
-                if(!is_a($xUserFunction, 'Request\\Support\\UserFunction'))
-                    $xUserFunction = new Request\Support\UserFunction($xUserFunction);
+                if(!is_a($xUserFunction, 'Request\\Support\\UserFunction')) {
+                                    $xUserFunction = new Request\Support\UserFunction($xUserFunction);
+                }
                 $this->aProcessingEvents[$sEvent] = $xUserFunction;
                 return true;
             }
@@ -324,8 +325,7 @@ 
             try
             {
                 $mResult = $this->getPluginManager()->processRequest();
-            }
-            catch(Exception $e)
+            } catch(Exception $e)
             {
                 // An exception was thrown while processing the request.
                 // The request missed the corresponding handler function,
@@ -342,8 +342,7 @@ 
                 {
                     $sEvent = self::PROCESSING_EVENT_INVALID;
                     $aParams = array($e->getMessage());
-                }
-                else
+                } else
                 {
                     $sEvent = self::PROCESSING_EVENT_ERROR;
                     $aParams = array($e);
@@ -353,8 +352,7 @@ 
                 {
                     // Call the processing event
                     $this->aProcessingEvents[$sEvent]->call($aParams);
-                }
-                else
+                } else
                 {
                     // The exception is not to be processed here.
                     throw $e;

src/Plugin/Manager.php

Unused Use Statements -2 removed lines

@@ -24,8 +24,6 @@
 use Jaxon\Jaxon;
 use RecursiveDirectoryIterator;
 use RecursiveIteratorIterator;
-use RegexIterator;
-use RecursiveRegexIterator;
 
 class Manager
 {

Spacing +55 added lines, -55 removed lines

@@ -258,32 +258,32 @@ 
     {
         $bIsAlert = ($xPlugin instanceof \Jaxon\Request\Interfaces\Alert);
         $bIsConfirm = ($xPlugin instanceof \Jaxon\Request\Interfaces\Confirm);
-        if($xPlugin instanceof Request)
+        if ($xPlugin instanceof Request)
         {
             // The name of a request plugin is used as key in the plugin table
             $this->aRequestPlugins[$xPlugin->getName()] = $xPlugin;
         }
-        else if( $xPlugin instanceof Response)
+        else if ($xPlugin instanceof Response)
         {
             // The name of a response plugin is used as key in the plugin table
             $this->aResponsePlugins[$xPlugin->getName()] = $xPlugin;
         }
-        else if(!$bIsConfirm && !$bIsAlert)
+        else if (!$bIsConfirm && !$bIsAlert)
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.register.invalid', array('name' => get_class($xPlugin))));
         }
         // This plugin implements the Alert interface
-        if($bIsAlert)
+        if ($bIsAlert)
         {
             $this->setAlert($xPlugin);
         }
         // This plugin implements the Confirm interface
-        if($bIsConfirm)
+        if ($bIsConfirm)
         {
             $this->setConfirm($xPlugin);
         }
         // Register the plugin as an event listener
-        if($xPlugin instanceof \Jaxon\Utils\Interfaces\EventListener)
+        if ($xPlugin instanceof \Jaxon\Utils\Interfaces\EventListener)
         {
             $this->addEventListener($xPlugin);
         }
@@ -299,7 +299,7 @@ 
     private function generateHash()
     {
         $sHash = $this->getVersion();
-        foreach($this->aPlugins as $xPlugin)
+        foreach ($this->aPlugins as $xPlugin)
         {
             $sHash .= $xPlugin->generateHash();
         }
@@ -316,9 +316,9 @@ 
      */
     public function canProcessRequest()
     {
-        foreach($this->aRequestPlugins as $xPlugin)
+        foreach ($this->aRequestPlugins as $xPlugin)
         {
-            if($xPlugin->canProcessRequest())
+            if ($xPlugin->canProcessRequest())
             {
                 return true;
             }
@@ -336,9 +336,9 @@ 
      */
     public function processRequest()
     {
-        foreach($this->aRequestPlugins as $xPlugin)
+        foreach ($this->aRequestPlugins as $xPlugin)
         {
-            if($xPlugin->canProcessRequest())
+            if ($xPlugin->canProcessRequest())
             {
                 return $xPlugin->processRequest();
             }
@@ -359,10 +359,10 @@ 
      */
     public function register($aArgs)
     {
-        foreach($this->aRequestPlugins as $xPlugin)
+        foreach ($this->aRequestPlugins as $xPlugin)
         {
             $mResult = $xPlugin->register($aArgs);
-            if($mResult instanceof \Jaxon\Request\Request || is_array($mResult) || $mResult === true)
+            if ($mResult instanceof \Jaxon\Request\Request || is_array($mResult) || $mResult === true)
             {
                 return $mResult;
             }
@@ -382,38 +382,38 @@ 
      */
     public function addClassDir($sDirectory, $sNamespace = null, $sSeparator = '.', array $aProtected = array())
     {
-        if(!is_dir(($sDirectory = trim($sDirectory))))
+        if (!is_dir(($sDirectory = trim($sDirectory))))
         {
             return false;
         }
         // Only '.' and '_' are allowed to be used as separator. Any other value is ignored and '.' is used instead.
-        if(($sSeparator = trim($sSeparator)) != '_')
+        if (($sSeparator = trim($sSeparator)) != '_')
         {
             $sSeparator = '.';
         }
-        if(!($sNamespace = trim($sNamespace)))
+        if (!($sNamespace = trim($sNamespace)))
         {
             $sNamespace = null;
         }
-        if(($sNamespace))
+        if (($sNamespace))
         {
             $sNamespace = trim($sNamespace, '\\');
             // If there is an autoloader, register the dir with PSR4 autoloading
-            if(($this->xAutoloader))
+            if (($this->xAutoloader))
             {
                 $this->xAutoloader->setPsr4($sNamespace . '\\', $sDirectory);
             }
         }
-        else if(($this->xAutoloader))
+        else if (($this->xAutoloader))
         {
             // If there is an autoloader, register the dir with classmap autoloading
             $itDir = new RecursiveDirectoryIterator($sDirectory);
             $itFile = new RecursiveIteratorIterator($itDir);
             // Iterate on dir content
-            foreach($itFile as $xFile)
+            foreach ($itFile as $xFile)
             {
                 // skip everything except PHP files
-                if(!$xFile->isFile() || $xFile->getExtension() != 'php')
+                if (!$xFile->isFile() || $xFile->getExtension() != 'php')
                 {
                     continue;
                 }
@@ -444,7 +444,7 @@ 
         $sClassPath = trim(substr($xFile->getPath(), strlen($sDirectory)), DIRECTORY_SEPARATOR);
         $sClassPath = str_replace(array(DIRECTORY_SEPARATOR), array($sSeparator), $sClassPath);
         $sClassName = $xFile->getBasename('.php');
-        if(($sNamespace))
+        if (($sNamespace))
         {
             $sNamespace = trim($sNamespace, '\\');
             $sClassPath = str_replace(array('\\'), array($sSeparator), $sNamespace) . $sSeparator . $sClassPath;
@@ -452,27 +452,27 @@ 
             $sClassName = '\\' . str_replace(array($sSeparator), array('\\'), $sClassPath) . '\\' . $sClassName;
         }
         // Require the file only if autoload is enabled but there is no autoloader
-        if(($this->bAutoloadEnabled) && !($this->xAutoloader))
+        if (($this->bAutoloadEnabled) && !($this->xAutoloader))
         {
             require_once($xFile->getPathname());
         }
         // Create and register an instance of the class
-        if(!array_key_exists('*', $aOptions) || !is_array($aOptions['*']))
+        if (!array_key_exists('*', $aOptions) || !is_array($aOptions['*']))
         {
             $aOptions['*'] = array();
         }
         $aOptions['*']['separator'] = $sSeparator;
-        if(($sNamespace))
+        if (($sNamespace))
         {
             $aOptions['*']['namespace'] = $sNamespace;
         }
-        if(($sClassPath))
+        if (($sClassPath))
         {
             $aOptions['*']['classpath'] = $sClassPath;
         }
         // Filter excluded methods
-        $aProtected = array_filter($aProtected, function($sName){return is_string($sName);});
-        if(count($aProtected) > 0)
+        $aProtected = array_filter($aProtected, function($sName) {return is_string($sName); });
+        if (count($aProtected) > 0)
         {
             $aOptions['*']['protected'] = $aProtected;
         }
@@ -486,15 +486,15 @@ 
      */
     public function registerClasses()
     {
-        foreach($this->aClassDirs as $sClassDir)
+        foreach ($this->aClassDirs as $sClassDir)
         {
             $itDir = new RecursiveDirectoryIterator($sClassDir['directory']);
             $itFile = new RecursiveIteratorIterator($itDir);
             // Iterate on dir content
-            foreach($itFile as $xFile)
+            foreach ($itFile as $xFile)
             {
                 // skip everything except PHP files
-                if(!$xFile->isFile() || $xFile->getExtension() != 'php')
+                if (!$xFile->isFile() || $xFile->getExtension() != 'php')
                 {
                     continue;
                 }
@@ -514,18 +514,18 @@ 
      */
     public function registerClass($sClassName, array $aOptions = array())
     {
-        if(!($sInitialClassName = trim($sClassName)))
+        if (!($sInitialClassName = trim($sClassName)))
         {
             return false;
         }
-        foreach($this->aClassDirs as $aClassDir)
+        foreach ($this->aClassDirs as $aClassDir)
         {
             // Get the separator
             $sSeparator = $aClassDir['separator'];
             // Replace / and \ with dots, and trim the string
             $sClassName = trim(str_replace(array('\\', '/'), array($sSeparator, $sSeparator), $sInitialClassName), $sSeparator);
             $sClassPath = '';
-            if(($nLastDotPosition = strrpos($sClassName, $sSeparator)) !== false)
+            if (($nLastDotPosition = strrpos($sClassName, $sSeparator)) !== false)
             {
                 $sClassPath = substr($sClassName, 0, $nLastDotPosition);
                 $sClassName = substr($sClassName, $nLastDotPosition + 1);
@@ -537,17 +537,17 @@ 
             $nLen = strlen($sNamespace);
             $bRegister = false;
             // Check if the class belongs to the namespace
-            if(($sNamespace) && substr($sClassPath, 0, $nLen) == str_replace(array('\\'), array($sSeparator), $sNamespace))
+            if (($sNamespace) && substr($sClassPath, 0, $nLen) == str_replace(array('\\'), array($sSeparator), $sNamespace))
             {
                 $sClassFile = $aClassDir['directory'] . DIRECTORY_SEPARATOR . substr($sClassFile, $nLen);
                 $bRegister = true;
             }
-            else if(!($sNamespace))
+            else if (!($sNamespace))
             {
                 $sClassFile = $aClassDir['directory'] . DIRECTORY_SEPARATOR . $sClassFile;
                 $bRegister = true;
             }
-            if($bRegister && is_file($sClassFile))
+            if ($bRegister && is_file($sClassFile))
             {
                 // Found the file in this directory
                 $xFileInfo = new \SplFileInfo($sClassFile);
@@ -571,7 +571,7 @@ 
     {
         $xObject = null; // The user registered object
         $xPlugin = $this->getRequestPlugin('CallableObject'); // The CallableObject plugin
-        if(($xPlugin))
+        if (($xPlugin))
         {
             $xObject = $xPlugin->getRegisteredObject($sClassName);
         }
@@ -585,7 +585,7 @@ 
      */
     private function getJsLibUri()
     {
-        if(!$this->hasOption('js.lib.uri'))
+        if (!$this->hasOption('js.lib.uri'))
         {
             return 'https://cdn.jsdelivr.net/jaxon/1.2.0/';
         }
@@ -605,7 +605,7 @@ 
         $jsDelivrUri = 'https://cdn.jsdelivr.net';
         $nLen = strlen($jsDelivrUri);
         // The jsDelivr CDN only hosts minified files
-        if(($this->getOption('js.app.minify')) || substr($this->getJsLibUri(), 0, $nLen) == $jsDelivrUri)
+        if (($this->getOption('js.app.minify')) || substr($this->getJsLibUri(), 0, $nLen) == $jsDelivrUri)
         {
             return '.min.js';
         }
@@ -622,7 +622,7 @@ 
         // Check config options
         // - The js.app.extern option must be set to true
         // - The js.app.uri and js.app.dir options must be set to non null values
-        if(!$this->getOption('js.app.extern') ||
+        if (!$this->getOption('js.app.extern') ||
             !$this->getOption('js.app.uri') ||
             !$this->getOption('js.app.dir'))
         {
@@ -631,7 +631,7 @@ 
         // Check dir access
         // - The js.app.dir must be writable
         $sJsAppDir = $this->getOption('js.app.dir');
-        if(!is_dir($sJsAppDir) || !is_writable($sJsAppDir))
+        if (!is_dir($sJsAppDir) || !is_writable($sJsAppDir))
         {
             return false;
         }
@@ -645,7 +645,7 @@ 
      */
     private function setTemplateCacheDir()
     {
-        if($this->hasOption('core.template.cache_dir'))
+        if ($this->hasOption('core.template.cache_dir'))
         {
             $this->setCacheDir($this->getOption('core.template.cache_dir'));
         }
@@ -667,11 +667,11 @@ 
 
         // Add component files to the javascript file array;
         $aJsFiles = array($sJsCoreUrl);
-        if($this->getOption('core.debug.on'))
+        if ($this->getOption('core.debug.on'))
         {
             $aJsFiles[] = $sJsDebugUrl;
             $aJsFiles[] = $sJsLanguageUrl;
-            if($this->getOption('core.debug.verbose'))
+            if ($this->getOption('core.debug.verbose'))
             {
                 $aJsFiles[] = $sJsVerboseUrl;
             }
@@ -683,7 +683,7 @@ 
             'sJsOptions' => $this->getOption('js.app.options'),
             'aUrls' => $aJsFiles,
         ));
-        foreach($this->aResponsePlugins as $xPlugin)
+        foreach ($this->aResponsePlugins as $xPlugin)
         {
             $sCode .= rtrim($xPlugin->getJs(), " \n") . "\n";
         }
@@ -701,7 +701,7 @@ 
         $this->setTemplateCacheDir();
 
         $sCode = '';
-        foreach($this->aResponsePlugins as $xPlugin)
+        foreach ($this->aResponsePlugins as $xPlugin)
         {
             $sCode .= rtrim($xPlugin->getCss(), " \n") . "\n";
         }
@@ -789,7 +789,7 @@ 
         ));
 
         $sPluginScript = '';
-        foreach($this->aResponsePlugins as $xPlugin)
+        foreach ($this->aResponsePlugins as $xPlugin)
         {
             $sPluginScript .= "\n" . trim($xPlugin->getScript(), " \n");
         }
@@ -821,11 +821,11 @@ 
 
         // Get the config and plugins scripts
         $sScript = $this->getConfigScript() . "\n" . $this->getReadyScript() . "\n";
-        foreach($this->aRequestPlugins as $xPlugin)
+        foreach ($this->aRequestPlugins as $xPlugin)
         {
             $sScript .= "\n" . trim($xPlugin->getScript(), " \n");
         }
-        if($this->canExportJavascript())
+        if ($this->canExportJavascript())
         {
             $sJsAppURI = rtrim($this->getOption('js.app.uri'), '/') . '/';
             $sJsAppDir = rtrim($this->getOption('js.app.dir'), '/') . '/';
@@ -834,13 +834,13 @@ 
             $sHash = $this->generateHash();
             $sOutFile = $sHash . '.js';
             $sMinFile = $sHash . '.min.js';
-            if(!is_file($sJsAppDir . $sOutFile))
+            if (!is_file($sJsAppDir . $sOutFile))
             {
                 file_put_contents($sJsAppDir . $sOutFile, $sScript);
             }
-            if(($this->getOption('js.app.minify')))
+            if (($this->getOption('js.app.minify')))
             {
-                if(($this->minify($sJsAppDir . $sOutFile, $sJsAppDir . $sMinFile)))
+                if (($this->minify($sJsAppDir . $sOutFile, $sJsAppDir . $sMinFile)))
                 {
                     $sOutFile = $sMinFile;
                 }
@@ -873,7 +873,7 @@ 
      */
     public function getResponsePlugin($sName)
     {
-        if(array_key_exists($sName, $this->aResponsePlugins))
+        if (array_key_exists($sName, $this->aResponsePlugins))
         {
             return $this->aResponsePlugins[$sName];
         }
@@ -889,7 +889,7 @@ 
      */
     public function getRequestPlugin($sName)
     {
-        if(array_key_exists($sName, $this->aRequestPlugins))
+        if (array_key_exists($sName, $this->aRequestPlugins))
         {
             return $this->aRequestPlugins[$sName];
         }

Braces +5 added lines, -10 removed lines

@@ -262,13 +262,11 @@ 
         {
             // The name of a request plugin is used as key in the plugin table
             $this->aRequestPlugins[$xPlugin->getName()] = $xPlugin;
-        }
-        else if( $xPlugin instanceof Response)
+        } else if( $xPlugin instanceof Response)
         {
             // The name of a response plugin is used as key in the plugin table
             $this->aResponsePlugins[$xPlugin->getName()] = $xPlugin;
-        }
-        else if(!$bIsConfirm && !$bIsAlert)
+        } else if(!$bIsConfirm && !$bIsAlert)
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.register.invalid', array('name' => get_class($xPlugin))));
         }
@@ -403,8 +401,7 @@ 
             {
                 $this->xAutoloader->setPsr4($sNamespace . '\\', $sDirectory);
             }
-        }
-        else if(($this->xAutoloader))
+        } else if(($this->xAutoloader))
         {
             // If there is an autoloader, register the dir with classmap autoloading
             $itDir = new RecursiveDirectoryIterator($sDirectory);
@@ -541,8 +538,7 @@ 
             {
                 $sClassFile = $aClassDir['directory'] . DIRECTORY_SEPARATOR . substr($sClassFile, $nLen);
                 $bRegister = true;
-            }
-            else if(!($sNamespace))
+            } else if(!($sNamespace))
             {
                 $sClassFile = $aClassDir['directory'] . DIRECTORY_SEPARATOR . $sClassFile;
                 $bRegister = true;
@@ -851,8 +847,7 @@ 
                 'sJsOptions' => $this->getOption('js.app.options'),
                 'sUrl' => $sJsAppURI . $sOutFile,
             ));
-        }
-        else
+        } else
         {
             // The plugins scripts are wrapped with javascript tags
             $sScript = $this->render('jaxon::plugins/wrapper.js', array(

src/Request/Manager.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
      *
      * @param string        $sArg                The Jaxon request argument
      *
-     * @return mixed
+     * @return string|null
      */
     private function __argumentDecode(&$sArg)
     {

Spacing +26 added lines, -26 removed lines

@@ -55,17 +55,17 @@ 
         $this->aArgs = array();
         $this->nMethod = Jaxon::METHOD_UNKNOWN;
         
-        if(isset($_POST['jxnargs']))
+        if (isset($_POST['jxnargs']))
         {
             $this->nMethod = Jaxon::METHOD_POST;
             $this->aArgs = $_POST['jxnargs'];
         }
-        else if(isset($_GET['jxnargs']))
+        else if (isset($_GET['jxnargs']))
         {
             $this->nMethod = Jaxon::METHOD_GET;
             $this->aArgs = $_GET['jxnargs'];
         }
-        if(get_magic_quotes_gpc() == 1)
+        if (get_magic_quotes_gpc() == 1)
         {
             array_walk($this->aArgs, array(&$this, '__argumentStripSlashes'));
         }
@@ -81,17 +81,17 @@ 
      */
     private function __convertStringToBool($sValue)
     {
-        if(strcasecmp($sValue, 'true') == 0)
+        if (strcasecmp($sValue, 'true') == 0)
         {
             return true;
         }
-        if(strcasecmp($sValue, 'false') == 0)
+        if (strcasecmp($sValue, 'false') == 0)
         {
             return false;
         }
-        if(is_numeric($sValue))
+        if (is_numeric($sValue))
         {
-            if($sValue == 0)
+            if ($sValue == 0)
             {
                 return false;
             }
@@ -109,7 +109,7 @@ 
      */
     private function __argumentStripSlashes(&$sArg)
     {
-        if(!is_string($sArg))
+        if (!is_string($sArg))
         {
             return '';
         }
@@ -156,14 +156,14 @@ 
      */
     private function __argumentDecode(&$sArg)
     {
-        if($sArg == '')
+        if ($sArg == '')
         {
             return '';
         }
 
         $data = json_decode($sArg, true);
 
-        if($data !== null && $sArg != $data)
+        if ($data !== null && $sArg != $data)
         {
             $sArg = $data;
         }
@@ -182,13 +182,13 @@ 
      */
     private function __argumentDecodeUTF8_iconv(&$mArg)
     {
-        if(is_array($mArg))
+        if (is_array($mArg))
         {
-            foreach($mArg as $sKey => $xArg)
+            foreach ($mArg as $sKey => $xArg)
             {
                 $sNewKey = $sKey;
                 $this->__argumentDecodeUTF8_iconv($sNewKey);
-                if($sNewKey != $sKey)
+                if ($sNewKey != $sKey)
                 {
                     $mArg[$sNewKey] = $xArg;
                     unset($mArg[$sKey]);
@@ -197,7 +197,7 @@ 
                 $this->__argumentDecodeUTF8_iconv($xArg);
             }
         }
-        else if(is_string($mArg))
+        else if (is_string($mArg))
         {
             $mArg = iconv("UTF-8", $this->getOption('core.encoding') . '//TRANSLIT', $mArg);
         }
@@ -212,13 +212,13 @@ 
      */
     private function __argumentDecodeUTF8_mb_convert_encoding(&$mArg)
     {
-        if(is_array($mArg))
+        if (is_array($mArg))
         {
-            foreach($mArg as $sKey => $xArg)
+            foreach ($mArg as $sKey => $xArg)
             {
                 $sNewKey = $sKey;
                 $this->__argumentDecodeUTF8_mb_convert_encoding($sNewKey);
-                if($sNewKey != $sKey)
+                if ($sNewKey != $sKey)
                 {
                     $mArg[$sNewKey] = $xArg;
                     unset($mArg[$sKey]);
@@ -227,7 +227,7 @@ 
                 $this->__argumentDecodeUTF8_mb_convert_encoding($xArg);
             }
         }
-        else if(is_string($mArg))
+        else if (is_string($mArg))
         {
             $mArg = mb_convert_encoding($mArg, $this->getOption('core.encoding'), "UTF-8");
         }
@@ -242,14 +242,14 @@ 
      */
     private function __argumentDecodeUTF8_utf8_decode(&$mArg)
     {
-        if(is_array($mArg))
+        if (is_array($mArg))
         {
-            foreach($mArg as $sKey => $xArg)
+            foreach ($mArg as $sKey => $xArg)
             {
                 $sNewKey = $sKey;
                 $this->__argumentDecodeUTF8_utf8_decode($sNewKey);
                 
-                if($sNewKey != $sKey)
+                if ($sNewKey != $sKey)
                 {
                     $mArg[$sNewKey] = $xArg;
                     unset($mArg[$sKey]);
@@ -259,7 +259,7 @@ 
                 $this->__argumentDecodeUTF8_utf8_decode($xArg);
             }
         }
-        else if(is_string($mArg))
+        else if (is_string($mArg))
         {
             $mArg = utf8_decode($mArg);
         }
@@ -284,19 +284,19 @@ 
      */
     public function process()
     {
-        if(($this->getOption('core.decode_utf8')))
+        if (($this->getOption('core.decode_utf8')))
         {
             $sFunction = '';
             
-            if(function_exists('iconv'))
+            if (function_exists('iconv'))
             {
                 $sFunction = "iconv";
             }
-            else if(function_exists('mb_convert_encoding'))
+            else if (function_exists('mb_convert_encoding'))
             {
                 $sFunction = "mb_convert_encoding";
             }
-            else if($this->getOption('core.encoding') == "ISO-8859-1")
+            else if ($this->getOption('core.encoding') == "ISO-8859-1")
             {
                 $sFunction = "utf8_decode";
             }

Braces +8 added lines, -16 removed lines

@@ -59,8 +59,7 @@ 
         {
             $this->nMethod = Jaxon::METHOD_POST;
             $this->aArgs = $_POST['jxnargs'];
-        }
-        else if(isset($_GET['jxnargs']))
+        } else if(isset($_GET['jxnargs']))
         {
             $this->nMethod = Jaxon::METHOD_GET;
             $this->aArgs = $_GET['jxnargs'];
@@ -166,8 +165,7 @@ 
         if($data !== null && $sArg != $data)
         {
             $sArg = $data;
-        }
-        else
+        } else
         {
             $sArg = $this->__convertValue($sArg);
         }
@@ -196,8 +194,7 @@ 
                 }
                 $this->__argumentDecodeUTF8_iconv($xArg);
             }
-        }
-        else if(is_string($mArg))
+        } else if(is_string($mArg))
         {
             $mArg = iconv("UTF-8", $this->getOption('core.encoding') . '//TRANSLIT', $mArg);
         }
@@ -226,8 +223,7 @@ 
                 }
                 $this->__argumentDecodeUTF8_mb_convert_encoding($xArg);
             }
-        }
-        else if(is_string($mArg))
+        } else if(is_string($mArg))
         {
             $mArg = mb_convert_encoding($mArg, $this->getOption('core.encoding'), "UTF-8");
         }
@@ -258,8 +254,7 @@ 
                 
                 $this->__argumentDecodeUTF8_utf8_decode($xArg);
             }
-        }
-        else if(is_string($mArg))
+        } else if(is_string($mArg))
         {
             $mArg = utf8_decode($mArg);
         }
@@ -291,16 +286,13 @@ 
             if(function_exists('iconv'))
             {
                 $sFunction = "iconv";
-            }
-            else if(function_exists('mb_convert_encoding'))
+            } else if(function_exists('mb_convert_encoding'))
             {
                 $sFunction = "mb_convert_encoding";
-            }
-            else if($this->getOption('core.encoding') == "ISO-8859-1")
+            } else if($this->getOption('core.encoding') == "ISO-8859-1")
             {
                 $sFunction = "utf8_decode";
-            }
-            else
+            } else
             {
                 throw new \Jaxon\Exception\Error($this->trans('errors.request.conversion'));
             }

Switch Indentation +13 added lines, -13 removed lines

@@ -131,19 +131,19 @@
         $sValue = substr($sValue, 1);
         switch ($cType)
         {
-            case 'S':
-                $value = ($sValue === false ? '' : $sValue);
-                break;
-            case 'B':
-                $value = $this->__convertStringToBool($sValue);
-                break;
-            case 'N':
-                $value = ($sValue == floor($sValue) ? (int)$sValue : (float)$sValue);
-                break;
-            case '*':
-            default:
-                $value = null;
-                break;
+        case 'S':
+            $value = ($sValue === false ? '' : $sValue);
+            break;
+        case 'B':
+            $value = $this->__convertStringToBool($sValue);
+            break;
+        case 'N':
+            $value = ($sValue == floor($sValue) ? (int)$sValue : (float)$sValue);
+            break;
+        case '*':
+        default:
+            $value = null;
+            break;
         }
         return $value;
     }

src/Request/Plugin/BrowserEvent.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 

 namespace Jaxon\Request\Plugin;

 

-use Jaxon\Jaxon;

+use Jaxon\Jaxon;
 use Jaxon\Plugin\Request as RequestPlugin;

 

 class BrowserEvent extends RequestPlugin

Braces +4 added lines, -4 removed lines

@@ -100,8 +100,7 @@ 
                     $this->aEvents[$sEvent] = $xBrowserEvent;

                     return $xBrowserEvent->generateRequest();

                 }

-            }

-            else if($sType == Jaxon::EVENT_HANDLER)

+            } else if($sType == Jaxon::EVENT_HANDLER)

             {

                 $sEvent = $aArgs[1];

                 if(isset($this->aEvents[$sEvent]) && isset($aArgs[2]))

@@ -173,8 +172,9 @@ 
      */

     public function processRequest()

     {

-        if(!$this->canProcessRequest())

-            return false;

+        if(!$this->canProcessRequest()) {
+                    return false;
+        }
 

         $aArgs = $this->getRequestManager()->process();

 

Spacing +15 added lines, -15 removed lines

@@ -51,11 +51,11 @@ 
 

         $this->sRequestedEvent = NULL;

 

-        if(isset($_GET['jxnevt']))

+        if (isset($_GET['jxnevt']))

         {

             $this->sRequestedEvent = $_GET['jxnevt'];

         }

-        if(isset($_POST['jxnevt']))

+        if (isset($_POST['jxnevt']))

         {

             $this->sRequestedEvent = $_POST['jxnevt'];

         }

@@ -80,19 +80,19 @@ 
      */

     public function register($aArgs)

     {

-        if(count($aArgs) > 1)

+        if (count($aArgs) > 1)

         {

             $sType = $aArgs[0];

 

-            if($sType == Jaxon::BROWSER_EVENT)

+            if ($sType == Jaxon::BROWSER_EVENT)

             {

                 $sEvent = $aArgs[1];

-                if(!isset($this->aEvents[$sEvent]))

+                if (!isset($this->aEvents[$sEvent]))

                 {

                     $xBrowserEvent = new \Jaxon\Support\BrowserEvent($sEvent);

-                    if(count($aArgs) > 2 && is_array($aArgs[2]))

+                    if (count($aArgs) > 2 && is_array($aArgs[2]))

                     {

-                        foreach($aArgs[2] as $sKey => $sValue)

+                        foreach ($aArgs[2] as $sKey => $sValue)

                         {

                             $xBrowserEvent->configure($sKey, $sValue);

                         }

@@ -101,13 +101,13 @@ 
                     return $xBrowserEvent->generateRequest();

                 }

             }

-            else if($sType == Jaxon::EVENT_HANDLER)

+            else if ($sType == Jaxon::EVENT_HANDLER)

             {

                 $sEvent = $aArgs[1];

-                if(isset($this->aEvents[$sEvent]) && isset($aArgs[2]))

+                if (isset($this->aEvents[$sEvent]) && isset($aArgs[2]))

                 {

                     $xUserFunction = $aArgs[2];

-                    if(!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction))

+                    if (!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction))

                     {

                         $xUserFunction = new \Jaxon\Request\Support\UserFunction($xUserFunction);

                     }

@@ -129,7 +129,7 @@ 
     public function generateHash()

     {

         $sHash = '';

-        foreach($this->aEvents as $xEvent)

+        foreach ($this->aEvents as $xEvent)

         {

             $sHash .= $xEvent->getName();

         }

@@ -144,7 +144,7 @@ 
     public function getScript()

     {

         $sCode = '';

-        foreach($this->aEvents as $xEvent)

+        foreach ($this->aEvents as $xEvent)

         {

             $sCode .= $xEvent->getScript();

         }

@@ -159,7 +159,7 @@ 
     public function canProcessRequest()

     {

         // Check the validity of the event name

-        if(($this->sRequestedEvent) && !$this->validateEvent($this->sRequestedEvent))

+        if (($this->sRequestedEvent) && !$this->validateEvent($this->sRequestedEvent))

         {

             $this->sRequestedEvent = null;

         }

@@ -173,12 +173,12 @@ 
      */

     public function processRequest()

     {

-        if(!$this->canProcessRequest())

+        if (!$this->canProcessRequest())

             return false;

 

         $aArgs = $this->getRequestManager()->process();

 

-        if(array_key_exists($this->sRequestedEvent, $this->aEvents))

+        if (array_key_exists($this->sRequestedEvent, $this->aEvents))

         {

             $this->aEvents[$this->sRequestedEvent]->fire($aArgs);

             return true;

src/Request/Plugin/CallableObject.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
      *

      * @param array         $aArgs                An array containing the callable object specification

      *

-     * @return array

+     * @return boolean

      */

     public function register($aArgs)

     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 

 namespace Jaxon\Request\Plugin;

 

-use Jaxon\Jaxon;

+use Jaxon\Jaxon;
 use Jaxon\Plugin\Request as RequestPlugin;

 

 class CallableObject extends RequestPlugin

Braces +6 added lines, -4 removed lines

@@ -130,8 +130,9 @@ 
                     {

                         foreach($aValue as $sName => $sValue)

                         {

-                            if($sName == 'classpath' && $sValue != '')

-                                $this->aClassPaths[] = $sValue;

+                            if($sName == 'classpath' && $sValue != '') {
+                                                            $this->aClassPaths[] = $sValue;
+                            }
                             $xCallableObject->configure($sKey, $sName, $sValue);

                         }

                     }

@@ -226,8 +227,9 @@ 
      */

     public function processRequest()

     {

-        if(!$this->canProcessRequest())

-            return false;

+        if(!$this->canProcessRequest()) {
+                    return false;
+        }
 

         $aArgs = $this->getRequestManager()->process();

 

Spacing +26 added lines, -26 removed lines

@@ -67,19 +67,19 @@ 
         $this->sRequestedClass = null;

         $this->sRequestedMethod = null;

 

-        if(!empty($_GET['jxncls']))

+        if (!empty($_GET['jxncls']))

         {

             $this->sRequestedClass = $_GET['jxncls'];

         }

-        if(!empty($_GET['jxnmthd']))

+        if (!empty($_GET['jxnmthd']))

         {

             $this->sRequestedMethod = $_GET['jxnmthd'];

         }

-        if(!empty($_POST['jxncls']))

+        if (!empty($_POST['jxncls']))

         {

             $this->sRequestedClass = $_POST['jxncls'];

         }

-        if(!empty($_POST['jxnmthd']))

+        if (!empty($_POST['jxnmthd']))

         {

             $this->sRequestedMethod = $_POST['jxnmthd'];

         }

@@ -104,33 +104,33 @@ 
      */

     public function register($aArgs)

     {

-        if(count($aArgs) > 1)

+        if (count($aArgs) > 1)

         {

             $sType = $aArgs[0];

 

-            if($sType == Jaxon::CALLABLE_OBJECT)

+            if ($sType == Jaxon::CALLABLE_OBJECT)

             {

                 $xCallableObject = $aArgs[1];

 

-                if(!is_object($xCallableObject) && !is_string($xCallableObject))

+                if (!is_object($xCallableObject) && !is_string($xCallableObject))

                 {

                     throw new \Jaxon\Exception\Error($this->trans('errors.objects.instance'));

                 }

-                if(is_string($xCallableObject) && !class_exists($xCallableObject))

+                if (is_string($xCallableObject) && !class_exists($xCallableObject))

                 {

                     throw new \Jaxon\Exception\Error($this->trans('errors.objects.instance'));

                 }

-                if(!($xCallableObject instanceof \Jaxon\Request\Support\CallableObject))

+                if (!($xCallableObject instanceof \Jaxon\Request\Support\CallableObject))

                 {

                     $xCallableObject = new \Jaxon\Request\Support\CallableObject($xCallableObject);

                 }

-                if(count($aArgs) > 2 && is_array($aArgs[2]))

+                if (count($aArgs) > 2 && is_array($aArgs[2]))

                 {

-                    foreach($aArgs[2] as $sKey => $aValue)

+                    foreach ($aArgs[2] as $sKey => $aValue)

                     {

-                        foreach($aValue as $sName => $sValue)

+                        foreach ($aValue as $sName => $sValue)

                         {

-                            if($sName == 'classpath' && $sValue != '')

+                            if ($sName == 'classpath' && $sValue != '')

                                 $this->aClassPaths[] = $sValue;

                             $xCallableObject->configure($sKey, $sName, $sValue);

                         }

@@ -153,7 +153,7 @@ 
     public function generateHash()

     {

         $sHash = '';

-        foreach($this->aCallableObjects as $xCallableObject)

+        foreach ($this->aCallableObjects as $xCallableObject)

         {

             $sHash .= $xCallableObject->getName();

             $sHash .= implode('|', $xCallableObject->getMethods());

@@ -172,15 +172,15 @@ 
         // Generate code for javascript classes declaration

         $code = '';

         $classes = array();

-        foreach($this->aClassPaths as $sClassPath)

+        foreach ($this->aClassPaths as $sClassPath)

         {

             $offset = 0;

             $sClassPath .= '.Null'; // This is a sentinel. The last token is not processed in the while loop.

-            while(($dotPosition = strpos($sClassPath, '.', $offset)) !== false)

+            while (($dotPosition = strpos($sClassPath, '.', $offset)) !== false)

             {

                 $class = substr($sClassPath, 0, $dotPosition);

                 // Generate code for this class

-                if(!array_key_exists($class, $classes))

+                if (!array_key_exists($class, $classes))

                 {

                     $code .= "$sJaxonPrefix$class = {};\n";

                     $classes[$class] = $class;

@@ -189,7 +189,7 @@ 
             }

         }

 

-        foreach($this->aCallableObjects as $xCallableObject)

+        foreach ($this->aCallableObjects as $xCallableObject)

         {

             $code .= $xCallableObject->getScript();

         }

@@ -204,13 +204,13 @@ 
     public function canProcessRequest()

     {

         // Check the validity of the class name

-        if(($this->sRequestedClass) && !$this->validateClass($this->sRequestedClass))

+        if (($this->sRequestedClass) && !$this->validateClass($this->sRequestedClass))

         {

             $this->sRequestedClass = null;

             $this->sRequestedMethod = null;

         }

         // Check the validity of the method name

-        if(($this->sRequestedMethod) && !$this->validateMethod($this->sRequestedMethod))

+        if (($this->sRequestedMethod) && !$this->validateMethod($this->sRequestedMethod))

         {

             $this->sRequestedClass = null;

             $this->sRequestedMethod = null;

@@ -225,21 +225,21 @@ 
      */

     public function processRequest()

     {

-        if(!$this->canProcessRequest())

+        if (!$this->canProcessRequest())

             return false;

 

         $aArgs = $this->getRequestManager()->process();

 

         // Try to register an instance of the requested class, if it isn't yet

-        if(!array_key_exists($this->sRequestedClass, $this->aCallableObjects))

+        if (!array_key_exists($this->sRequestedClass, $this->aCallableObjects))

         {

             $this->getPluginManager()->registerClass($this->sRequestedClass);

         }

 

-        if(array_key_exists($this->sRequestedClass, $this->aCallableObjects))

+        if (array_key_exists($this->sRequestedClass, $this->aCallableObjects))

         {

             $xCallableObject = $this->aCallableObjects[$this->sRequestedClass];

-            if($xCallableObject->hasMethod($this->sRequestedMethod))

+            if ($xCallableObject->hasMethod($this->sRequestedMethod))

             {

                 $xCallableObject->call($this->sRequestedMethod, $aArgs);

                 return true;

@@ -260,11 +260,11 @@ 
     public function getRegisteredObject($sClassName = null)

     {

         $sClassName = (string)$sClassName;

-        if(!$sClassName)

+        if (!$sClassName)

         {

             $sClassName = $this->sRequestedClass;

         }

-        if(!array_key_exists($sClassName, $this->aCallableObjects))

+        if (!array_key_exists($sClassName, $this->aCallableObjects))

         {

             return null;

         }

src/Request/Plugin/UserFunction.php

Unused Use Statements -1 removed lines

@@ -23,7 +23,6 @@
 
 use Jaxon\Jaxon;
 use Jaxon\Plugin\Request as RequestPlugin;
-use Jaxon\Request\Manager as RequestManager;
 
 class UserFunction extends RequestPlugin
 {

Spacing +13 added lines, -13 removed lines

@@ -51,11 +51,11 @@ 
 
         $this->sRequestedFunction = null;
         
-        if(isset($_GET['jxnfun']))
+        if (isset($_GET['jxnfun']))
         {
             $this->sRequestedFunction = $_GET['jxnfun'];
         }
-        if(isset($_POST['jxnfun']))
+        if (isset($_POST['jxnfun']))
         {
             $this->sRequestedFunction = $_POST['jxnfun'];
         }
@@ -80,22 +80,22 @@ 
      */
     public function register($aArgs)
     {
-        if(count($aArgs) > 1)
+        if (count($aArgs) > 1)
         {
             $sType = $aArgs[0];
 
-            if($sType == Jaxon::USER_FUNCTION)
+            if ($sType == Jaxon::USER_FUNCTION)
             {
                 $xUserFunction = $aArgs[1];
 
-                if(!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction))
+                if (!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction))
                     $xUserFunction = new \Jaxon\Request\Support\UserFunction($xUserFunction);
 
-                if(count($aArgs) > 2)
+                if (count($aArgs) > 2)
                 {
-                    if(is_array($aArgs[2]))
+                    if (is_array($aArgs[2]))
                     {
-                        foreach($aArgs[2] as $sName => $sValue)
+                        foreach ($aArgs[2] as $sName => $sValue)
                         {
                             $xUserFunction->configure($sName, $sValue);
                         }
@@ -122,7 +122,7 @@ 
     public function generateHash()
     {
         $sHash = '';
-        foreach($this->aFunctions as $xFunction)
+        foreach ($this->aFunctions as $xFunction)
         {
             $sHash .= $xFunction->getName();
         }
@@ -137,7 +137,7 @@ 
     public function getScript()
     {
         $code = '';
-        foreach($this->aFunctions as $xFunction)
+        foreach ($this->aFunctions as $xFunction)
         {
             $code .= $xFunction->getScript();
         }
@@ -152,7 +152,7 @@ 
     public function canProcessRequest()
     {
         // Check the validity of the function name
-        if(($this->sRequestedFunction) && !$this->validateFunction($this->sRequestedFunction))
+        if (($this->sRequestedFunction) && !$this->validateFunction($this->sRequestedFunction))
         {
             $this->sRequestedFunction = null;
         }
@@ -166,12 +166,12 @@ 
      */
     public function processRequest()
     {
-        if(!$this->canProcessRequest())
+        if (!$this->canProcessRequest())
             return false;
 
         $aArgs = $this->getRequestManager()->process();
 
-        if(array_key_exists($this->sRequestedFunction, $this->aFunctions))
+        if (array_key_exists($this->sRequestedFunction, $this->aFunctions))
         {
             $this->aFunctions[$this->sRequestedFunction]->call($aArgs);
             return true;

Braces +7 added lines, -6 removed lines

@@ -88,8 +88,9 @@ 
             {
                 $xUserFunction = $aArgs[1];
 
-                if(!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction))
-                    $xUserFunction = new \Jaxon\Request\Support\UserFunction($xUserFunction);
+                if(!($xUserFunction instanceof \Jaxon\Request\Support\UserFunction)) {
+                                    $xUserFunction = new \Jaxon\Request\Support\UserFunction($xUserFunction);
+                }
 
                 if(count($aArgs) > 2)
                 {
@@ -99,8 +100,7 @@ 
                         {
                             $xUserFunction->configure($sName, $sValue);
                         }
-                    }
-                    else
+                    } else
                     {
                         $xUserFunction->configure('include', $aArgs[2]);
                     }
@@ -166,8 +166,9 @@ 
      */
     public function processRequest()
     {
-        if(!$this->canProcessRequest())
-            return false;
+        if(!$this->canProcessRequest()) {
+                    return false;
+        }
 
         $aArgs = $this->getRequestManager()->process();
 

src/Request/Request.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 
 namespace Jaxon\Request;
 
-use JsonSerializable;
 use Jaxon\Jaxon;
 
 class Request extends JsCall

Spacing +18 added lines, -18 removed lines

@@ -69,9 +69,9 @@ 
      */
     public function hasPageNumber()
     {
-        foreach($this->aParameters as $xParameter)
+        foreach ($this->aParameters as $xParameter)
         {
-            if($xParameter->getType() == Jaxon::PAGE_NUMBER)
+            if ($xParameter->getType() == Jaxon::PAGE_NUMBER)
             {
                 return true;
             }
@@ -89,9 +89,9 @@ 
     public function setPageNumber($nPageNumber)
     {
         // Set the value of the Jaxon::PAGE_NUMBER parameter
-        foreach($this->aParameters as $xParameter)
+        foreach ($this->aParameters as $xParameter)
         {
-            if($xParameter->getType() == Jaxon::PAGE_NUMBER)
+            if ($xParameter->getType() == Jaxon::PAGE_NUMBER)
             {
                 $xParameter->setValue(intval($nPageNumber));
                 break;
@@ -111,7 +111,7 @@ 
     {
         $this->sCondition = '__confirm__';
         $this->aMessageArgs = func_get_args();
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -132,7 +132,7 @@ 
         $this->sCondition = Parameter::make($sCondition)->getScript();
         $this->aMessageArgs = func_get_args();
         array_shift($this->aMessageArgs); // Remove the first entry (the condition) from the array
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -153,7 +153,7 @@ 
         $this->sCondition = '!(' . Parameter::make($sCondition)->getScript() . ')';
         $this->aMessageArgs = func_get_args();
         array_shift($this->aMessageArgs); // Remove the first entry (the condition) from the array
-        array_walk($this->aMessageArgs, function(&$xParameter){
+        array_walk($this->aMessageArgs, function(&$xParameter) {
             $xParameter = Parameter::make($xParameter);
         });
         return $this;
@@ -178,12 +178,12 @@ 
         // This array will avoid declaring many variables with the same value.
         // The array key is the variable value, while the array value is the variable name.
         $aVariables = array(); // Array of local variables.
-        foreach($this->aParameters as &$xParameter)
+        foreach ($this->aParameters as &$xParameter)
         {
             $sParameterStr = $xParameter->getScript();
-            if($xParameter instanceof \Jaxon\JQuery\Dom\Element)
+            if ($xParameter instanceof \Jaxon\JQuery\Dom\Element)
             {
-                if(!array_key_exists($sParameterStr, $aVariables))
+                if (!array_key_exists($sParameterStr, $aVariables))
                 {
                     // The value is not yet defined. A new variable is created.
                     $sVarName = "jxnVar$nVarId";
@@ -201,19 +201,19 @@ 
         }
 
         $sPhrase = '';
-        if(count($this->aMessageArgs) > 0)
+        if (count($this->aMessageArgs) > 0)
         {
             $sPhrase = array_shift($this->aMessageArgs); // The first array entry is the question.
             // $sPhrase = "'" . addslashes($sPhrase) . "'"; // Wrap the phrase with single quotes
-            if(count($this->aMessageArgs) > 0)
+            if (count($this->aMessageArgs) > 0)
             {
                 $nParamId = 1;
-                foreach($this->aMessageArgs as &$xParameter)
+                foreach ($this->aMessageArgs as &$xParameter)
                 {
                     $sParameterStr = $xParameter->getScript();
-                    if($xParameter instanceof \Jaxon\JQuery\Dom\Element)
+                    if ($xParameter instanceof \Jaxon\JQuery\Dom\Element)
                     {
-                        if(!array_key_exists($sParameterStr, $aVariables))
+                        if (!array_key_exists($sParameterStr, $aVariables))
                         {
                             // The value is not yet defined. A new variable is created.
                             $sVarName = "jxnVar$nVarId";
@@ -236,17 +236,17 @@ 
         }
 
         $sScript = $this->getOption('core.prefix.' . $this->sType) . parent::getScript();
-        if($this->sCondition == '__confirm__')
+        if ($this->sCondition == '__confirm__')
         {
             $xConfirm = $this->getPluginManager()->getConfirm();
             $sScript = $xConfirm->confirm($sPhrase, $sScript, '');
         }
-        else if($this->sCondition !== null)
+        else if ($this->sCondition !== null)
         {
             $xAlert = $this->getPluginManager()->getAlert();
             $xAlert->setReturn(true);
             $sScript = 'if(' . $this->sCondition . '){' . $sScript . ';}';
-            if(($sPhrase))
+            if (($sPhrase))
             {
                 $sScript .= 'else{' . $xAlert->warning($sPhrase) . ';}';
             }

Braces +3 added lines, -6 removed lines

@@ -190,8 +190,7 @@ 
                     $aVariables[$sParameterStr] = $sVarName;
                     $sVars .= "$sVarName=$xParameter;";
                     $nVarId++;
-                }
-                else
+                } else
                 {
                     // The value is already defined. The corresponding variable is assigned.
                     $sVarName = $aVariables[$sParameterStr];
@@ -220,8 +219,7 @@ 
                             $aVariables[$sParameterStr] = $sVarName;
                             $sVars .= "$sVarName=$xParameter;";
                             $nVarId++;
-                        }
-                        else
+                        } else
                         {
                             // The value is already defined. The corresponding variable is assigned.
                             $sVarName = $aVariables[$sParameterStr];
@@ -240,8 +238,7 @@ 
         {
             $xConfirm = $this->getPluginManager()->getConfirm();
             $sScript = $xConfirm->confirm($sPhrase, $sScript, '');
-        }
-        else if($this->sCondition !== null)
+        } else if($this->sCondition !== null)
         {
             $xAlert = $this->getPluginManager()->getAlert();
             $xAlert->setReturn(true);

src/Request/Support/UserFunction.php

Doc Comments +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
     /**
      * Constructs and returns a <Jaxon\Request\Request> object which is capable of generating the javascript call to invoke this jaxon enabled function
      *
-     * @return Jaxon\Request\Request
+     * @return Request
      */
     public function generateRequest()
     {

Spacing +8 added lines, -8 removed lines

@@ -90,13 +90,13 @@ 
     {
         $this->aConfiguration = array();
         $this->sAlias = '';
-        if(is_array($sUserFunction))
+        if (is_array($sUserFunction))
         {
-            if(count($sUserFunction) != 2 && count($sUserFunction) != 3)
+            if (count($sUserFunction) != 2 && count($sUserFunction) != 3)
             {
                 throw new \Jaxon\Exception\Error($this->trans('errors.functions.invalid-declaration'));
             }
-            if(count($sUserFunction) == 3)
+            if (count($sUserFunction) == 3)
             {
                 $this->sAlias = $sUserFunction[0];
                 $this->sUserFunction = array_slice($sUserFunction, 1);
@@ -106,7 +106,7 @@ 
                 $this->sUserFunction = $sUserFunction;
             }
         }
-        else if(is_string($sUserFunction))
+        else if (is_string($sUserFunction))
         {
             $this->sUserFunction = $sUserFunction;
         }
@@ -124,7 +124,7 @@ 
     public function getName()
     {
         // Do not use sAlias here!
-        if(is_array($this->sUserFunction))
+        if (is_array($this->sUserFunction))
         {
             return $this->sUserFunction[1];
         }
@@ -141,7 +141,7 @@ 
      */
     public function configure($sName, $sValue)
     {
-        switch($sName)
+        switch ($sName)
         {
         case 'alias':
             $this->sAlias = $sValue;
@@ -195,12 +195,12 @@ 
      */
     public function call($aArgs = array())
     {
-        if(($this->sInclude))
+        if (($this->sInclude))
         {
             ob_start();
             require_once $this->sInclude;
             $sOutput = ob_get_clean();
-            if(($sOutput))
+            if (($sOutput))
             {
                 $sOutput = $this->trans('debug.function.include', array(
                     'file' => $this->sInclude,

Braces +3 added lines, -6 removed lines

@@ -100,17 +100,14 @@
             {
                 $this->sAlias = $sUserFunction[0];
                 $this->sUserFunction = array_slice($sUserFunction, 1);
-            }
-            else
+            } else
             {
                 $this->sUserFunction = $sUserFunction;
             }
-        }
-        else if(is_string($sUserFunction))
+        } else if(is_string($sUserFunction))
         {
             $this->sUserFunction = $sUserFunction;
-        }
-        else
+        } else
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.functions.invalid-declaration'));
         }

src/Request/Traits/Factory.php

Doc Comments -2 removed lines

@@ -89,7 +89,6 @@ 
      * Return the javascript call to an Jaxon object method
      *
      * @param string         $sMethod           The method (without class) name
-     * @param ...            $xParams           The parameters of the method
      *
      * @return object
      */
@@ -110,7 +109,6 @@ 
      * @param integer $nItemsPerPage the number of items per page
      * @param integer $nCurrentPage the current page
      * @param string  $sMethod the name of the method
-     * @param ... $parameters the parameters of the method
      *
      * @return string the pagination links
      */

Spacing +3 added lines, -3 removed lines

@@ -44,7 +44,7 @@ 
      */
     public function getJaxonClassName()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Make the Jaxon class name for a class without an associated callable
             // !! Warning !! This can happen only if this object is not registered with the Jaxon libary
@@ -62,7 +62,7 @@ 
      */
     public function getJaxonNamespace()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Return an empty string.
             return '';
@@ -77,7 +77,7 @@ 
      */
     public function getJaxonClassPath()
     {
-        if(!$this->xJaxonCallable)
+        if (!$this->xJaxonCallable)
         {
             // Return an empty string.
             return '';