jaxon-php / jaxon-core

src/DI/Container.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 
 use Lemon\Event\EventDispatcher;
 use Jaxon\Sentry\View\Renderer;
-
 use Jaxon\Request\Support\CallableRepository;
 
 class Container

Spacing +23 added lines, -23 removed lines

@@ -32,7 +32,7 @@ 
 
     public static function getInstance()
     {
-        if(!self::$xInstance)
+        if (!self::$xInstance)
         {
             self::$xInstance = new Container();
         }
@@ -92,27 +92,27 @@ 
          * Managers
          */
         // Callable objects repository
-        $this->coreContainer[CallableRepository::class] = function ($c) {
+        $this->coreContainer[CallableRepository::class] = function($c) {
             return new CallableRepository();
         };
         // Plugin Manager
-        $this->coreContainer['jaxon.core.plugin_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.plugin_manager'] = function($c) {
             return new \Jaxon\Plugin\Manager();
         };
         // Request Manager
-        $this->coreContainer['jaxon.core.request_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.request_manager'] = function($c) {
             return new \Jaxon\Request\Manager();
         };
         // Request Factory
-        $this->coreContainer['jaxon.core.request_factory'] = function ($c) {
+        $this->coreContainer['jaxon.core.request_factory'] = function($c) {
             return new \Jaxon\Factory\Request($c[CallableRepository::class]);
         };
         // Parameter Factory
-        $this->coreContainer['jaxon.core.parameter_factory'] = function ($c) {
+        $this->coreContainer['jaxon.core.parameter_factory'] = function($c) {
             return new \Jaxon\Factory\Parameter();
         };
         // Response Manager
-        $this->coreContainer['jaxon.core.response_manager'] = function ($c) {
+        $this->coreContainer['jaxon.core.response_manager'] = function($c) {
             return new \Jaxon\Response\Manager();
         };
 
@@ -120,35 +120,35 @@ 
          * Services
          */
         // Config manager
-        $this->coreContainer['jaxon.core.config'] = function ($c) {
+        $this->coreContainer['jaxon.core.config'] = function($c) {
             return new \Jaxon\Utils\Config\Config();
         };
         // Minifier
-        $this->coreContainer['jaxon.core.minifier'] = function ($c) {
+        $this->coreContainer['jaxon.core.minifier'] = function($c) {
             return new \Jaxon\Utils\Template\Minifier();
         };
         // Translator
-        $this->coreContainer['jaxon.core.translator'] = function ($c) {
+        $this->coreContainer['jaxon.core.translator'] = function($c) {
             return new \Jaxon\Utils\Translation\Translator($c['jaxon.core.translation_dir'], $c['jaxon.core.config']);
         };
         // Template engine
-        $this->coreContainer['jaxon.core.template'] = function ($c) {
+        $this->coreContainer['jaxon.core.template'] = function($c) {
             return new \Jaxon\Utils\Template\Template($c['jaxon.core.template_dir']);
         };
         // Validator
-        $this->coreContainer['jaxon.core.validator'] = function ($c) {
+        $this->coreContainer['jaxon.core.validator'] = function($c) {
             return new \Jaxon\Utils\Validation\Validator($c['jaxon.core.translator'], $c['jaxon.core.config']);
         };
         // Pagination Renderer
-        $this->coreContainer['jaxon.pagination.renderer'] = function ($c) {
+        $this->coreContainer['jaxon.pagination.renderer'] = function($c) {
             return new \Jaxon\Utils\Pagination\Renderer();
         };
         // Pagination Paginator
-        $this->coreContainer['jaxon.pagination.paginator'] = function ($c) {
+        $this->coreContainer['jaxon.pagination.paginator'] = function($c) {
             return new \Jaxon\Utils\Pagination\Paginator($c['jaxon.pagination.renderer']);
         };
         // Event Dispatcher
-        $this->coreContainer['jaxon.core.events'] = function ($c) {
+        $this->coreContainer['jaxon.core.events'] = function($c) {
             return new EventDispatcher();
         };
 
@@ -156,15 +156,15 @@ 
          * Core library objects
          */
         // Global Response
-        $this->coreContainer['jaxon.core.response'] = function ($c) {
+        $this->coreContainer['jaxon.core.response'] = function($c) {
             return new \Jaxon\Response\Response();
         };
         // Jaxon Core
-        $this->coreContainer['jaxon.core.jaxon'] = function ($c) {
+        $this->coreContainer['jaxon.core.jaxon'] = function($c) {
             return new \Jaxon\Jaxon();
         };
         // View Renderer Facade
-        $this->coreContainer['jaxon.sentry.view.renderer'] = function ($c) {
+        $this->coreContainer['jaxon.sentry.view.renderer'] = function($c) {
             $aRenderers = $c['jaxon.view.data.renderers'];
             $sDefaultNamespace = $c['jaxon.view.data.namespace.default'];
             return new \Jaxon\Sentry\View\Facade($aRenderers, $sDefaultNamespace);
@@ -178,7 +178,7 @@ 
      */
     public function get($sClass)
     {
-        if($this->sentryContainer != null && $this->sentryContainer->has($sClass))
+        if ($this->sentryContainer != null && $this->sentryContainer->has($sClass))
         {
             return $this->sentryContainer->get($sClass);
         }
@@ -463,14 +463,14 @@ 
         $this->coreContainer['jaxon.sentry.view.base.' . $sId] = $xClosure;
 
         // Return the initialized view renderer
-        $this->coreContainer['jaxon.sentry.view.' . $sId] = function ($c) use ($sId) {
+        $this->coreContainer['jaxon.sentry.view.' . $sId] = function($c) use ($sId) {
             // Get the defined renderer
             $renderer = $c['jaxon.sentry.view.base.' . $sId];
             // Init the renderer with the template namespaces
             $aNamespaces = $this->coreContainer['jaxon.view.data.namespaces'];
-            if(key_exists($sId, $aNamespaces))
+            if (key_exists($sId, $aNamespaces))
             {
-                foreach($aNamespaces[$sId] as $ns)
+                foreach ($aNamespaces[$sId] as $ns)
                 {
                     $renderer->addNamespace($ns['namespace'], $ns['directory'], $ns['extension']);
                 }
@@ -488,7 +488,7 @@ 
      */
     public function getViewRenderer($sId = '')
     {
-        if(!$sId)
+        if (!$sId)
         {
             // Return the view renderer facade
             return $this->coreContainer['jaxon.sentry.view.renderer'];

src/Factory/Request.php

Doc Comments +3 added lines, -6 removed lines

@@ -42,7 +42,7 @@ 
     /**
      * The class constructor
      *
-     * @param CallableRepository        $repository
+     * @param CallableRepository        $xRepository
      */
     public function __construct(CallableRepository $xRepository)
     {
@@ -54,7 +54,7 @@ 
      *
      * @param string|null            $sClass              The callable class
      *
-     * @return Factory
+     * @return Request
      */
     public function setClassName($sClass)
     {
@@ -82,7 +82,7 @@ 
      *
      * @param CallableObject          $xCallable              The callable object
      *
-     * @return Factory
+     * @return Request
      */
     public function setCallable(CallableObject $xCallable)
     {
@@ -95,7 +95,6 @@ 
      * Return the javascript call to a Jaxon function or object method
      *
      * @param string            $sFunction          The function or method (without class) name
-     * @param ...               $xParams            The parameters of the function or method
      *
      * @return \Jaxon\Request\Request
      */
@@ -124,7 +123,6 @@ 
      * Return the javascript call to a generic function
      *
      * @param string            $sFunction          The function or method (with class) name
-     * @param ...               $xParams            The parameters of the function or method
      *
      * @return \Jaxon\Request\Request
      */
@@ -148,7 +146,6 @@ 
      * @param integer       $nItemsPerPage          The number of items per page page
      * @param integer       $nCurrentPage           The current page
      * @param string        $sMethod                The name of function or a method prepended with its class name
-     * @param ...           $xParams                The parameters of the function or method
      *
      * @return string the pagination links
      */

Spacing +3 added lines, -3 removed lines

@@ -61,12 +61,12 @@ 
         $this->sPrefix = $this->getOption('core.prefix.function');
 
         $sClass = trim($sClass, '.\\ ');
-        if(!$sClass)
+        if (!$sClass)
         {
             return $this;
         }
 
-        if(!($xCallable = $this->xRepository->getCallableObject($sClass)))
+        if (!($xCallable = $this->xRepository->getCallableObject($sClass)))
         {
             // Todo: decide which of these values to return
             // return null;
@@ -107,7 +107,7 @@ 
         array_shift($aArguments);
 
         // Makes legacy code works
-        if(strpos($sFunction, '.') !== false)
+        if (strpos($sFunction, '.') !== false)
         {
             // If there is a dot in the name, then it is a call to a class
             $this->sPrefix = $this->getOption('core.prefix.class');

src/Request/Plugin/CallableClass.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
     /**
      * The class constructor
      *
-     * @param CallableRepository        $repository
+     * @param CallableRepository        $xRepository
      */
     public function __construct(CallableRepository $xRepository)
     {

Spacing +12 added lines, -12 removed lines

@@ -61,19 +61,19 @@ 
     {
         $this->xRepository = $xRepository;
 
-        if(!empty($_GET['jxncls']))
+        if (!empty($_GET['jxncls']))
         {
             $this->sRequestedClass = $_GET['jxncls'];
         }
-        if(!empty($_GET['jxnmthd']))
+        if (!empty($_GET['jxnmthd']))
         {
             $this->sRequestedMethod = $_GET['jxnmthd'];
         }
-        if(!empty($_POST['jxncls']))
+        if (!empty($_POST['jxncls']))
         {
             $this->sRequestedClass = $_POST['jxncls'];
         }
-        if(!empty($_POST['jxnmthd']))
+        if (!empty($_POST['jxnmthd']))
         {
             $this->sRequestedMethod = $_POST['jxnmthd'];
         }
@@ -100,20 +100,20 @@ 
      */
     public function register($sType, $sClassName, $aOptions)
     {
-        if($sType != $this->getName())
+        if ($sType != $this->getName())
         {
             return false;
         }
 
-        if(!is_string($sClassName))
+        if (!is_string($sClassName))
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.objects.invalid-declaration'));
         }
-        if(is_string($aOptions))
+        if (is_string($aOptions))
         {
             $aOptions = ['include' => $aOptions];
         }
-        if(!is_array($aOptions))
+        if (!is_array($aOptions))
         {
             throw new \Jaxon\Exception\Error($this->trans('errors.objects.invalid-declaration'));
         }
@@ -151,13 +151,13 @@ 
     public function canProcessRequest()
     {
         // Check the validity of the class name
-        if($this->sRequestedClass !== null && !$this->validateClass($this->sRequestedClass))
+        if ($this->sRequestedClass !== null && !$this->validateClass($this->sRequestedClass))
         {
             $this->sRequestedClass = null;
             $this->sRequestedMethod = null;
         }
         // Check the validity of the method name
-        if($this->sRequestedMethod !== null && !$this->validateMethod($this->sRequestedMethod))
+        if ($this->sRequestedMethod !== null && !$this->validateMethod($this->sRequestedMethod))
         {
             $this->sRequestedClass = null;
             $this->sRequestedMethod = null;
@@ -172,7 +172,7 @@ 
      */
     public function processRequest()
     {
-        if(!$this->canProcessRequest())
+        if (!$this->canProcessRequest())
         {
             return false;
         }
@@ -181,7 +181,7 @@ 
 
         // Find the requested method
         $xCallableObject = $this->xRepository->getCallableObject($this->sRequestedClass);
-        if(!$xCallableObject || !$xCallableObject->hasMethod($this->sRequestedMethod))
+        if (!$xCallableObject || !$xCallableObject->hasMethod($this->sRequestedMethod))
         {
             // Unable to find the requested object or method
             throw new \Jaxon\Exception\Error($this->trans('errors.objects.invalid',

src/Request/Plugin/CallableDir.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     /**
      * The class constructor
      *
-     * @param CallableRepository        $repository
+     * @param CallableRepository        $xRepository
      */
     public function __construct(CallableRepository $xRepository)
     {

Braces +1 added lines, -2 removed lines

@@ -161,8 +161,7 @@
             }
 
             $this->xRepository->addNamespace($sNamespace, $aOptions);
-        }
-        else
+        } else
         {
              // Use underscore as separator, so there's no need to deal with namespace
             // when generating javascript code.