TaskEventManager::__construct() - Code Metrics - Inspection of "set up compiler passes, and fix typos" - jarobe42/task-runner - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#7)

by Jim

created 2017-11-05 10:59 UTC

TaskEventManager::__construct() A

↳ Parent: TaskEventManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	3
cts	3
cp	1
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Jarobe\TaskRunnerBundle\Manager;

use Doctrine\ORM\EntityManager;
use Jarobe\TaskRunnerBundle\Entity\TaskEvent;
use Jarobe\TaskRunnerBundle\Exception\TaskException;
use Jarobe\TaskRunnerBundle\Hydrator\Reflector;
use Jarobe\TaskRunnerBundle\Model\TaskResult;
use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;

class TaskEventManager
{
    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @var Reflector
     */
    private $reflector;


    public function __construct(EntityManager $entityManager)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
    }

    /**
     * @param TaskTypeInterface $task
     * @return TaskEvent
     * @throws TaskException
     */
    public function createTaskEvent(TaskTypeInterface $task)
    {
        $taskEvent = new TaskEvent();
        $taskEvent->setTaskName($task::getName())
            ->setTargetTime($task->getTargetTime())
            ->setPayload($task->getPayload())
        ;

        $this->entityManager->persist($taskEvent);
        $this->entityManager->flush($taskEvent);
        return $taskEvent;
    }

    /**
     * @param TaskEvent $taskEvent
     * @return TaskEvent
     */
    public function initiateTaskEvent(TaskEvent $taskEvent)
    {
        $now = new \DateTime('now');
        $taskEvent->setInitiatedAt($now);

        $this->entityManager->flush($taskEvent);

        return $taskEvent;
    }

    /**
     * @param TaskEvent $taskEvent
     * @param TaskResult $result
     * @return TaskEvent
     */
    public function updateTaskEventWithResult(TaskEvent $taskEvent, TaskResult $result)
    {
        $now = new \DateTime('now');
        if ($result->isSuccess()) {
            $taskEvent->setCompletedAt($now)
                ->setErrors(null)
            ;
        } else {
            $taskEvent->setFailedAt($now)
                ->setErrors($result->getErrors())
            ;
        }
        $this->entityManager->flush($taskEvent);
        return $taskEvent;
    }
}


1		<?php
2
3		namespace Jarobe\TaskRunnerBundle\Manager;
4
5		use Doctrine\ORM\EntityManager;
6		use Jarobe\TaskRunnerBundle\Entity\TaskEvent;
7		use Jarobe\TaskRunnerBundle\Exception\TaskException;
8		use Jarobe\TaskRunnerBundle\Hydrator\Reflector;
9		use Jarobe\TaskRunnerBundle\Model\TaskResult;
10		use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;
11
12		class TaskEventManager
13		{
14		/**
15		* @var EntityManager
16		*/
17		private $entityManager;
18
19		/**
20		* @var Reflector
21		*/
22		private $reflector;
		0 ignored issues – show Unused Code introduced 2017-11-05 11:03 UTC by Report Bug Copy Issue Report The property `$reflector` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23
24	6	public function __construct(EntityManager $entityManager)
		0 ignored issues – show Bug introduced 2017-11-05 11:03 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
25		{
26	6	$this->entityManager = $entityManager;
27	6	}
28
29		/**
30		* @param TaskTypeInterface $task
31		* @return TaskEvent
32		* @throws TaskException
33		*/
34		public function createTaskEvent(TaskTypeInterface $task)
35		{
36		$taskEvent = new TaskEvent();
37		$taskEvent->setTaskName($task::getName())
38		->setTargetTime($task->getTargetTime())
39		->setPayload($task->getPayload())
40		;
41
42		$this->entityManager->persist($taskEvent);
43		$this->entityManager->flush($taskEvent);
44		return $taskEvent;
45		}
46
47		/**
48		* @param TaskEvent $taskEvent
49		* @return TaskEvent
50		*/
51	1	public function initiateTaskEvent(TaskEvent $taskEvent)
52		{
53	1	$now = new \DateTime('now');
54	1	$taskEvent->setInitiatedAt($now);
55
56	1	$this->entityManager->flush($taskEvent);
57
58	1	return $taskEvent;
59		}
60
61		/**
62		* @param TaskEvent $taskEvent
63		* @param TaskResult $result
64		* @return TaskEvent
65		*/
66	4	public function updateTaskEventWithResult(TaskEvent $taskEvent, TaskResult $result)
67		{
68	4	$now = new \DateTime('now');
69	4	if ($result->isSuccess()) {
70	2	$taskEvent->setCompletedAt($now)
71	2	->setErrors(null)
72		;
73		} else {
74	2	$taskEvent->setFailedAt($now)
75	2	->setErrors($result->getErrors())
76		;
77		}
78	4	$this->entityManager->flush($taskEvent);
79	4	return $taskEvent;
80		}
81		}
82

jarobe42 / task-runner

Pull Request — master (#7)

TaskEventManager::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like