Jarobe\TaskRunnerBundle\Manager\TaskEventManager

Complexity

Total Complexity

5

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

68%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	createTaskEvent()	0	12	1
A	initiateTaskEvent()	0	9	1
A	updateTaskEventWithResult()	0	15	2

<?php

namespace Jarobe\TaskRunnerBundle\Manager;

use Doctrine\ORM\EntityManager;
use Jarobe\TaskRunnerBundle\Entity\TaskEvent;
use Jarobe\TaskRunnerBundle\Exception\TaskException;
use Jarobe\TaskRunnerBundle\Hydrator\Reflector;
use Jarobe\TaskRunnerBundle\Model\TaskResult;
use Jarobe\TaskRunnerBundle\TaskType\TaskTypeInterface;

class TaskEventManager
{
    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @var Reflector
     */
    private $reflector;

The property $reflector is not used and could be removed.

    public function __construct(EntityManager $entityManager)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
    }

    /**
     * @param TaskTypeInterface $task
     * @return TaskEvent
     * @throws TaskException
     */
    public function createTaskEvent(TaskTypeInterface $task)
    {
        $taskEvent = new TaskEvent();
        $taskEvent->setTaskName($task::getName())
            ->setTargetTime($task->getTargetTime())
            ->setPayload($task->getPayload())
        ;

        $this->entityManager->persist($taskEvent);
        $this->entityManager->flush($taskEvent);
        return $taskEvent;
    }

    /**
     * @param TaskEvent $taskEvent
     * @return TaskEvent
     */
    public function initiateTaskEvent(TaskEvent $taskEvent)
    {
        $now = new \DateTime('now');
        $taskEvent->setInitiatedAt($now);

        $this->entityManager->flush($taskEvent);

        return $taskEvent;
    }

    /**
     * @param TaskEvent $taskEvent
     * @param TaskResult $result
     * @return TaskEvent
     */
    public function updateTaskEventWithResult(TaskEvent $taskEvent, TaskResult $result)
    {
        $now = new \DateTime('now');
        if ($result->isSuccess()) {
            $taskEvent->setCompletedAt($now)
                ->setErrors(null)
            ;
        } else {
            $taskEvent->setFailedAt($now)
                ->setErrors($result->getErrors())
            ;
        }
        $this->entityManager->flush($taskEvent);
        return $taskEvent;
    }
}